Merge pull request #55548 from k0ste/wip-64397-reef

reef: mon: fix health store size growing infinitely

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>

Merge pull request #54258 from YiteGu/backport-bluestore-fragmentation-to-metrics

reef: os/bluestore: add bluestore fragmentation micros to prometheus

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #56654 from aaSharma14/wip-65142-reef

reef: mgr/dashboard: replace piechart plugin charts with native pie chart panel

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56424 from batrick/wip-65092-reef

reef: qa/suites/fs/workload: enable snap_schedule early

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56398 from batrick/wip-64922-reef

reef: mds: ensure snapclient is synced before corruption check

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56396 from batrick/wip-65065-reef

reef: qa: change log-whitelist to log-ignorelist

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56392 from batrick/wip-65058-reef

reef: qa/suites/fs/nfs: use standard health ignorelist

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56211 from joscollin/wip-64919-reef

reef: qa: enhance labeled perf counters test for cephfs-mirror

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55803 from anoopcs9/wip-64565-reef

reef: client: Fix return in removexattr for xattrs from `system.` namespace

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56660 from zdover23/wip-doc-2024-04-03-backport-56635-to-reef

reef: doc/dev: refine "Concepts"

Merge pull request #56652 from aaSharma14/wip-65283-reef

reef: mgr/dashboard: upgrade from old 'graph' type panels to the new 'timeseries' panel

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/dev: refine "Concepts"

Refine the text in the first third of the entries in the section
"Concepts" in doc/dev/peering.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 530b11be24c6e702d4d9b9227649db8ca34591e4)

mgr/dashboard: replace piechart plugin charts with native pie chart
panel

Fixes: https://tracker.ceph.com/issues/64579
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 6e5efb626f4b3503a12371a8f609fdb5175a3ebe)

mgr/dashboard: upgrade from old 'graph' type panels to the new
'timeseries' panel

The graph panel type is deprecated, and disappears after Grafana v9.1 (current version is 10.0) to prevent more old type panels being created. These should be migrated to the timeseries panel type, to avoid potential problems with future Grafana versions.

Fixes: https://tracker.ceph.com/issues/61720
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 2573426f54aab237ed855a4e88d5b89ddbd76acd)

Merge PR #56567 into reef

* refs/pull/56567/head:
doc: add releases links to toc
doc: remove releases docs

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge PR #56479 into reef

* refs/pull/56479/head:
pybind/mgr/devicehealth: skip legacy objects that cannot be loaded
qa: test devicehealth legacy load of deleted snap obj
qa: allow failing whatever the active mgr is
qa: add unit tests for MgrMap down flag
mon/MgrMonitor: add "down" setting to simplify testing

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #56631 from zdover23/wip-doc-2024-04-02-backport-56614-to-reef

reef: doc/mgr: update zabbix information

Merge pull request #56361 from Svelar/wip-65032-reef

reef: ceph.spec.in: add support for openEuler OS

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #56359 from Svelar/wip-65028-reef

reef: mgr/dashboard/frontend:Ceph dashboard supports multiple languages

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/mgr: update zabbix information

Include information from John Jasen about how to install Zabbix.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ebe7651dd85ae1f1570d8c34479b9bdd1249d83c)

Merge pull request #54729 from rishabh-d-dave/wip-63688-reef

reef: qa/cephfs: improvements for name generators in test_volumes.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56122 from xhernandez/wip-64737-reef

reef: client: fix leak of file handles

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #56031 from vshankar/wip-64618-reef

reef: mds: check file layout in mknod

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #56603 from zdover23/wip-doc-2024-04-01-backport-56600-to-reef

reef: doc/dev: update leads list

doc/dev: update leads list

Remove Joao Luis from the list of component leads.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 158b0403bd66cdf6c4b456146705f42d69f56730)

Merge pull request #56594 from zdover23/wip-doc-2024-03-31-backport-56592-to-reef

reef: doc/rados/operations: Improve crush_location docs

doc/rados/operations: Improve crush_location docs

* Fix incorrect syntax
* Use underscores for config options, like other ceph docs did
* Fix incorrect statement that crush_location_hook adds fiels; it replaces
* Explain `root=default host=HOSTNAME` is not set if `crush_location` is given
* Remove duplication across sections
* Point out that `root=default` is important

Signed-off-by: Niklas Hambüchen <mail@nh2.me>
(cherry picked from commit d91e75e1e92b73bf967740575b3c27a86ef844d5)

Merge pull request #56589 from zdover23/wip-doc-2024-03-30-backport-56581-to-reef

reef: doc/dev: update leads list

doc/dev: update leads list

Update the list of component leads in
doc/dev/developer_guide/essentials.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 57e9427eac08b4057999f5afc44cf0fc77a3068f)

Merge pull request #56560 from afreen23/wip-64830-reef

reef: mgr/dashboard: Locking improvements in bucket create form

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56548 from rhcs-dashboard/wip-65194-reef

reef: mgr/dashboard: fix rgw display name validation

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #56435 from zdover23/wip-doc-2024-03-25-backport-56287-to-reef

reef: mon, doc: overriding ec profile requires --yes-i-really-mean-it

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #56523 from zdover23/wip-doc-2024-03-27-backport-56173-to-reef

reef: doc/dev: osd_internals/snaps.rst: add clone_overlap doc

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #56472 from aaSharma14/wip-64790-reef

reef: mgr/dashboard: Allow the user to add the access/secret key on zone edit and not on zone creation

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56546 from rhcs-dashboard/wip-65192-reef

reef: mgr/dashboard: s/active_mds/active_nfs in fs attach form

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #56550 from rhcs-dashboard/wip-65196-reef

reef: mgr/dashboard: fix clone unique validator for name validation

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

doc: add releases links to toc

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc: remove releases docs

So that redirects to the version in the main branch work again.

This should have been part of the release checklist.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #56140 from yuvalif/wip-64792-reef

reef: rgw/notification: Kafka persistent notifications not retried and removed even when the broker is down

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: Locking improvements in bucket create form

Fixes https://tracker.ceph.com/issues/64658
- Addition of help texts
- Addition of info/warnings related to modes and versioning
- change of Locking section layout
- renaming locking to 'Object Locking'
- changes default retention period to 10
- edit bucket only shows lock when its enabled

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 014d4468fce5aadfbc63bd9651c0c66db0bf7f49)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/components/components.module.ts

mgr/dashboard: fix clone unique validator for name validation

Fixes: https://tracker.ceph.com/issues/65145
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8070dfd80be9de15d2234fafa78a25569fde30a7)

mgr/dashboard: fix rgw display name validation

the dot(.) character is allowed in full name

Fixes: https://tracker.ceph.com/issues/65146
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8118a32ec578455b6c2cb4000f2bbee234ae9117)

mgr/dashboard: s/active_mds/active_nfs in fs attach form

Fixes: https://tracker.ceph.com/issues/65173
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 5f97e4eaed3ff25cc01fdaed39f73542e8196677)

Merge pull request #56501 from rhcs-dashboard/wip-65165-reef

reef: mgr/dashboard: fix cephfs name validation

Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #56120 from mkogan1/wip-64766-reef

reef: rgw/beast: Enable SSL session-id reuse speedup mechanism

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #56453 from yuvalif/wip-63856-reef

reef: RGW: pubsub publish commit with etag populated

Reviewed-by: Ali Masarwa <ali.saed.masarwa@gmail.com>

doc/dev: osd_internals/snaps.rst: add clone_overlap doc

snapdir concept was removed in: https://github.com/ceph/ceph/pull/17579

Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 6a7f2b0fda74aedb213067abe5c0a64b68fbbdc7)

Merge pull request #56495 from zdover23/wip-doc-2024-03-27-backport-56450-to-reef

reef: docs/rados: remove incorrect ceph command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge PR #54468 into reef

* refs/pull/54468/head:
mds,client: update the oldest_client_tid via the renew caps
mds: add trim_completed_request_list() helper
client: return false if cannot link all the way to mountpoint
client: use the fs' full path instead of from mountpoint's root
qa/tasks/cephfs/test_admin: run root_squash tests only for FUSE client
qa/tasks/cephfs: Add reproducer for https://tracker.ceph.com/issues/56067
qa: add test for checking access in client side of root_squash
qa: add sudo paramter for read_file()
test/libcephfs: remove reduntant test for acccess
mds/Server: disallow clients that have root_squash
mds/Locker: remove session check access when doing cap updates
client: check the cephx mds auth access for open
client: always set the caller_uid/gid to -1
mds: add CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK feature bit
client: check the cephx mds auth access for setattr
client: save the cap_auths in client when session being opened
client: add make_path_string() helpers support
client: add _get_root_ino() helper support
test/libcephfs: add a tag for each test unique directory
client: rename MAY_* to CLIENT_MAY_* to avoid conflicts
mds: send the cap_auths to clients when openning the sessions
mds: add cap_auths in MClientSession
mds: add MDSCapAuth support
mds: encode/decode the MDSCapMatch
mds: add assign operator support for MDSCapMatch

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mgr/dashboard: fix cephfs name validation

allow volume name to start with dot (.)

Fixes: https://tracker.ceph.com/issues/65143
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 242318452c8111717e49b896c7f9cf0ec5f5b262)

mds,client: update the oldest_client_tid via the renew caps

Update the oldest_client_tid via the session renew caps msg to
make sure that the MDSs won't pile up the completed request list
in a very large size.

Fixes: https://tracker.ceph.com/issues/63364
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 0cff6d5d487972a850e7c64b1e3b8ca283bf3c03)

mds: add trim_completed_request_list() helper

Fixes: https://tracker.ceph.com/issues/63364
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 188aed9d779a168d999be9f652bcceecbfd64f05)

client: return false if cannot link all the way to mountpoint

Just in case we cannot link all the way to our mount point we will
force to do sync requests instead and let the MDS do the auth access
check.

Introduced-by: fd7aaab2907 client: add make_path_string() helpers support
Fixes: https://github.com/ceph/ceph/pull/48027#issuecomment-1752324457
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit c7bc4523ffec65d132eef217ce87eaf344144e35)

client: use the fs' full path instead of from mountpoint's root

The mountpoint's root ino# possibly not be the full CephFS
filesystem root, it's just the mountpoint of this particular client.
Just prepend the mountpoint path to the full path.

Introduced-by: c1bf8d88e9d client: check the cephx mds auth access for setattr
Introduced-by: ce216595c03 client: check the cephx mds auth access for open
Fixes: https://github.com/ceph/ceph/pull/48027#issuecomment-1741019086
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit e46dc20cdfb157f94781032451057d1e138535cc)

qa/tasks/cephfs/test_admin: run root_squash tests only for FUSE client

kclient doesn't have CEPHFS_FEATURE_MDS_AUTH_CAPS required to
enforce root_squash. Run root_squash tests only for FUSE client.

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit a04044670c615b67d633185d50eda12d53e5766b)

qa/tasks/cephfs: Add reproducer for https://tracker.ceph.com/issues/56067

A kernel CephFS client with MDS root_squash caps is able to write to a
file as non-root user. However, the data written is lost after clearing
the kernel client cache, or re-mounting the client. This issue is not
observed with a FUSE CephFS client.

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit c8bae07f70453577d36e83e0bb02c3410ef9cade)

qa: add test for checking access in client side of root_squash

Test the 'chown' and 'truncate', which will call the setattr and
'cat' will open the files. Before each testing will open the file
by non-root user and keep it to make sure the Fxw caps are issued,
and then user the 'sudo' do to the tests, which will set the uid/gid
to 0/0.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 28023f84d714488a5dfd17b2191790ed15909fb3)

Conflicts:
qa/tasks/cephfs/caps_helper.py: missed dependency commit
f0ffade0525("qa/cephfs/cap_tester: simplify CapTester and its
instantiation")

qa: add sudo paramter for read_file()

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 4af6a3f7441345766fddcf2a9086d3b777c9717a)

test/libcephfs: remove reduntant test for acccess

The test.cc will be included in ceph_test_libcephfs, no need to
include it to access.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 77ac1009793016c9f4904eef6bf699105caa0b16)

mds/Server: disallow clients that have root_squash

... MDS auth caps but don't have CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK
feature bit (i.e., can't check the auth caps sent back to it by the
MDS) from establishing a session. Do this in
Server::handle_client_session(), and Server::handle_client_reconnect(),
where old clients try to reconnect to MDS servers after an upgrade.

If the client doesn't have the ability to authorize session access
based on the MDS auth caps send back to it by the MDS, then the
client may buffer changes locally during open and setattr operations
when it's not supposed to, e.g., when enforcing root_squash MDS auth
caps.

Fixes: https://tracker.ceph.com/issues/56067
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit e64931b6a80d0f3e365ed0fe305b73562cbca502)

mds/Locker: remove session check access when doing cap updates

as it's too late. Session access authorization already happens
before new caps are issued.

Fixes: https://tracker.ceph.com/issues/56067
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 96305b5eef06e2b379ed95a086edf9e4809a7e70)

client: check the cephx mds auth access for open

Before opening the file locally we need to check the cephx access.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit ce216595c0391fc4b7e3c0f5b3be88aa4f67d245)

client: always set the caller_uid/gid to -1

Since the setattr will check the cephx mds auth access before
buffering the changes, so it makes no sense any more to let the
cap update to check the access in MDS again.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit f474203aee2ff183d6812a62f43d85b3f25eae0d)

Conflicts:
src/client/Client.cc: missed dependency commit a8d0158d0df
("Client/Inode: wait_for_caps fixups")

mds: add CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK feature bit

This feature bit could be used to distinguish old and new clients.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b2046fc7ca30a988094a473c654a0d1cef8ea945)

client: check the cephx mds auth access for setattr

If couldn't get the absolute path string we need to force it to
do the sync setattr.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit c1bf8d88e9d41c275fbae824c799d41d39d3ab4a)

client: save the cap_auths in client when session being opened

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 01a93986bff4340b1e8fecfd4e83ad92afc79b5d)

Conflicts:
src/client/Client.cc: conflict with commit 997b917c84e
("client: always refresh mds feature bits on session open")

client: add make_path_string() helpers support

Will use this to get the path string to do the mds auth check. It
may fail when the there is no any dentry in local cache, which could
be caused by just unlinking the last dentry while the inode keeps
opening and then try to change the mode.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit fd7aaab290728e47ff699063fa26ad63f848bbf1)

client: add _get_root_ino() helper support

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 429aafbb18d147646e6f52e1a8af4de7a0fd68bd)

test/libcephfs: add a tag for each test unique directory

Make it to be easier to debug when searching the debug logs.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit fa687be805898e8da86056153e34acf1386a6daa)

client: rename MAY_* to CLIENT_MAY_* to avoid conflicts

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 27f73a9b9e4c7efb11adb7dbb17035d8ca978727)

mds: send the cap_auths to clients when openning the sessions

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit c1cbb9acadc311f155b176d6108975835a616a5f)

Conflicts:
src/mds/MDSAuthCaps.h: missed dependency commit 23f1fdbcb3d
("AuthMonitor: allow "fs authorize" to update caps")

mds: add cap_auths in MClientSession

It will include the uid/gids and path in each cap_auth.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 213a27aab0455c83284bdb2187540e4895b18e6d)

mds: add MDSCapAuth support

Need to add writeable/readable members and send them back to clients.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 6e4a6448022051ba9a33f4cb4b0af2298f2622aa)

mds: encode/decode the MDSCapMatch

Will send this to clients.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 53caf313957b414ab7fcc77ff23bd1470cca1724)

mds: add assign operator support for MDSCapMatch

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 5b6634c23d4e21b06064fddd49998ee949c34e5c)

docs/rados: remove incorrect ceph command

The removed line was (incorrectly changed) output of the previous command.

Signed-off-by: Taha Jahangir <mtjahangir@gmail.com>
(cherry picked from commit 3cd39e3582ed830f86c55d2203ece72fa0f9426b)

Merge pull request #55394 from dparmar18/wip-64220-reef

reef: mgr/nfs: include pseudo in JSON output when nfs export apply -i fails

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #54185 from rishabh-d-dave/wip-62332-reef

reef: MDSAuthCaps: minor improvements

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #56471 from rhcs-dashboard/wip-65137-reef

reef: mgr/dashboard: add system users to rgw user form

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #56466 from zdover23/wip-doc-2024-03-26-backport-56436-to-reef

reef: doc/start: improve MDS explanation

pybind/mgr/devicehealth: skip legacy objects that cannot be loaded

Log looks like after test:

    2023-12-21T16:09:28.804+0000 7fbe7fd86700  0 [devicehealth DEBUG root] loading object ABC_DEADB33F_FA
    2023-12-21T16:09:28.805+0000 7fbe7fd86700  0 [devicehealth DEBUG root] object rados.Object(ioctx=<rados.Ioctx object at 0x7fbeee0c4668>,key=ABC_DEADB33F_FA,nspace=--default--,locator=None) does not exist because it is deleted in HEAD
    2023-12-21T16:09:28.805+0000 7fbe7fd86700  0 [devicehealth DEBUG root] finished reading legacy pool, complete = True

Credit to Greg Farnum for postulating the cause.

Fixes: https://tracker.ceph.com/issues/63882
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 5e6fc0bf5f52732966d5cf2987e679abee8a384d)

qa: test devicehealth legacy load of deleted snap obj

Failure without fix looks like:

    2023-12-21T16:05:55.737+0000 7fbe585b0700  0 [devicehealth DEBUG root] loading object ABC_DEADB33F_FA
    2023-12-21T16:05:55.737+0000 7fbe585b0700 -1 log_channel(cluster) log [ERR] : Unhandled exception from module 'devicehealth' while running on mgr.x: [errno 2] RADOS object not found (Failed to operate read op for oid ABC_DEADB33F_FA)
    2023-12-21T16:05:55.737+0000 7fbe585b0700 -1 devicehealth.serve:
    2023-12-21T16:05:55.737+0000 7fbe585b0700 -1 Traceback (most recent call last):
    File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 394, in serve
        self._do_serve()
    File "/home/pdonnell/ceph/src/pybind/mgr/mgr_module.py", line 524, in check
        return func(self, *args, **kwargs)
    File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 354, in _do_serve
        finished_loading_legacy = self.check_legacy_pool()
    File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 326, in check_legacy_pool
        if self._load_legacy_object(ioctx, obj.key):
    File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 300, in _load_legacy_object
        ioctx.operate_read_op(op, oid)
    File "rados.pyx", line 3723, in rados.Ioctx.operate_read_op
    rados.ObjectNotFound: [errno 2] RADOS object not found (Failed to operate read op for oid ABC_DEADB33F_FA)

Credit to Greg Farnum for postulating the cause.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit aa30adbaa7616c8e24b3ccaad9dbcda7c0c663fc)

qa: allow failing whatever the active mgr is

Vanilla `mgr fail` will just fail the active.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit a066467c9dc6f34a58e4085d05238a5db3f45cba)

qa: add unit tests for MgrMap down flag

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 9ebcbdbed0fbaf37d60fbd8db321742ee5721d8c)

mon/MgrMonitor: add "down" setting to simplify testing

This flag prevents promotion of a standby manager to the active. It also drops
the current active.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 2e2a3f15cdd9125029fca78b834b8b5bb53edbb1)

Merge pull request #56259 from guits/wip-64943-reef

reef: ceph-volume: add missing import

mgr/dashboard: Allow the user to add the access/secret key on zone edit
and not on zone creation

Fixes: https://tracker.ceph.com/issues/64080
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit d96a1805f3975e7eb098cb32a9a1da0e10321fb7)

mgr/dashboard: add system users to rgw user form

Fixes: https://tracker.ceph.com/issues/65074
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit b658bb9c32ad31608921e77603003c004ab0f15b)

Merge pull request #55987 from joscollin/wip-64743-reef

reef: mds: add a command to dump directory information

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc/start: improve MDS explanation

Improve the explanation of MDS as requested by Anthony D'Atri here:

https://github.com/ceph/ceph/pull/56367#discussion_r1536667249

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e7eff3cf8738ddd378c2fd70075ac61dbac3cf55)

Merge pull request #56452 from rhcs-dashboard/wip-65111-reef

reef: mgr/dashboard: sanitize dashboard user creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #56151 from sseshasa/wip-64881-reef

reef: qa: Add benign cluster warning from ec-inconsistent-hinfo test to ignorelist

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #54981 from sseshasa/wip-63874-reef

reef: osd: Apply randomly selected scheduler type across all OSD shards

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #56325 from adk3798/wip-64994-reef

reef: mgr/cephadm: refresh public_network for config checks before checking

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56307 from adk3798/reef-timemaster

reef: cephadm: add timemaster to timesync services list

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56302 from adk3798/reef-only-bind-to-network

reef: mgr/cephadm: allow grafana and prometheus to only bind to specific network

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56292 from adk3798/reef-cephadm-pull-usage

reef: cephadm: improve cephadm pull usage message

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56286 from adk3798/reef-haproxy-healthcheck-interval

reef: cephadm: adjust the ingress ha proxy health check interval

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56221 from adk3798/reef-regex-host-pattern

reef: mgr/cephadm: support for regex based host patterns

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56443 from rhcs-dashboard/wip-65103-reef

reef: mgr/dashboard: rm warning/error threshold for cpu usage

Reviewed-by: afreen23 <NOT@FOUND>