]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/log
rocksdb.git
10 years agoupdate fb-specific dependencies by running update_dependencies.sh rocksdb-4.4 rocksdb-4.4.1 v4.4 v4.4.1
agiardullo [Thu, 18 Feb 2016 23:13:33 +0000 (15:13 -0800)]
update fb-specific dependencies by running update_dependencies.sh

10 years agoUpdate fbcode_config4.8.1.sh to use update_dependencies.sh
Islam AbdelRahman [Tue, 26 Jan 2016 20:13:27 +0000 (12:13 -0800)]
Update fbcode_config4.8.1.sh to use update_dependencies.sh

Summary:
This patch update fbcode_config4.8.1.sh to get it's dependencies the same way we updated fbcode_config.sh in D53037

as a result zstd is upgraded to 0.4.7 instead of 0.4.5

Test Plan:
make clean && ROCKSDB_FBCODE_BUILD_WITH_481=1 make check -j64
make clean && ROCKSDB_FBCODE_BUILD_WITH_481=1 USE_CLANG=1 make check -j64

Reviewers: yhchiang, andrewkr, rven, kradhakrishnan, sdong

Reviewed By: sdong

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D53355

(cherry picked from commit 77ef87ccb0ba4559147d3e8b761e2b1b91d89596)

10 years agoInclude rest of dependencies in dependencies.sh
Islam AbdelRahman [Mon, 25 Jan 2016 22:35:04 +0000 (14:35 -0800)]
Include rest of dependencies in dependencies.sh

Summary:
This diff

  - Include the rest of the dependencies (kernel-headers, binutils, valgrind) in dependencies.sh
  - updtade zst to 0.4.7
  - It also fix a problem in clang scan build

Test Plan:
make check
USE_CLANG=1 make check
USE_CLANG=1 make analyze
coverage_test.sh

Reviewers: sdong, yhchiang, rven, andrewkr, kradhakrishnan

Reviewed By: kradhakrishnan

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D53301

(cherry picked from commit f7ef1a613276641af93f02f74f17cf66174d8126)

10 years agoUpdate fbcode_config.sh to use latest versions automatically
Islam AbdelRahman [Fri, 22 Jan 2016 19:56:32 +0000 (11:56 -0800)]
Update fbcode_config.sh to use latest versions automatically

Summary:
Update fbcode_config.sh so that It try to use the latest version for dependencies that we are using, after updating the code these libraries where updated

```
Snappy: 1.0.3 => 1.1.3
GFLAGS: 1.6 => 2.1.1
JEMALLOC: 3.6.0 => 4.0.3
```

I have also updated clang from 3.7 to 3.7.1

```
Clang 3.7 => 3.7.1
```

Another change is that we use the same tp2 directory as fbcode, so we dont need to keep changing commit hash every time we need to change a version of a compiler or a library

Test Plan:
make check -j64
USE_CLANG=1 make check -j64

DISABLE_JEMALLOC=1 OPT=-g make all valgrind_check -j32 (make sure it's running)

Reviewers: yhchiang, anthony, rven, kradhakrishnan, andrewkr, sdong

Reviewed By: sdong

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D53037

(cherry picked from commit 538eec0661e6e66bc54fc189295c342a84ea7f54)

10 years agoupdate build version to 4.4.1
agiardullo [Thu, 18 Feb 2016 21:52:49 +0000 (13:52 -0800)]
update build version to 4.4.1

Summary: prepare to release 4.4.1

Test Plan: unit tests pass

Reviewers: kradhakrishnan, IslamAbdelRahman, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54393

10 years agoFix transaction locking
agiardullo [Wed, 10 Feb 2016 02:24:41 +0000 (18:24 -0800)]
Fix transaction locking

Summary: Broke transaction locking in 4.4 in D52197.  Will cherry-pick this change into 4.4 (which hasn't yet been fully released).  Repro'd using db_bench.

Test Plan: unit tests and db_Bench

Reviewers: sdong, yhchiang, kradhakrishnan, ngbronson

Reviewed By: ngbronson

Subscribers: ngbronson, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54021

(cherry picked from commit d08d50295cfaae2153c88c4065be1881e5ca0c99)

10 years agoRemove the SyncPoint usage in the destructor of PosixEnv
Yueh-Hsuan Chiang [Thu, 18 Feb 2016 07:32:14 +0000 (23:32 -0800)]
Remove the SyncPoint usage in the destructor of PosixEnv

Summary:
Remove the SyncPoint usage in the destructor of PosixEnv as none
of any active tests is using it.

SyncPoint is a test-only utility class, and it's a static varible.
As a result, using SyncPoint in the destructor of PosixEnv will
make default Env depends on SyncPoint.  Removing such dependency
could solve the problem crash issue only reproducable in Mac
environment.

Test Plan: OPT=-DTRAVIS V=1 make -j4 check on Mac environment

Reviewers: sdong, anthony

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54333

10 years agoAdd missing SyncPoint::DisableProcessing in compact_file_test
Yueh-Hsuan Chiang [Thu, 18 Feb 2016 07:19:06 +0000 (23:19 -0800)]
Add missing SyncPoint::DisableProcessing in compact_file_test

Summary: Add missing SyncPoint::DisableProcessing in compact_file_test

Test Plan: compact_file_test

Reviewers: anthony, sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54327

10 years agoFixed a dependency issue of ThreadLocalPtr
Yueh-Hsuan Chiang [Thu, 11 Feb 2016 00:56:01 +0000 (16:56 -0800)]
Fixed a dependency issue of ThreadLocalPtr

Summary:
When a child thread that uses ThreadLocalPtr, ThreadLocalPtr::OnThreadExit
will be called when that child thread is destroyed.  However,
OnThreadExit will try to access a static singleton of ThreadLocalPtr,
which will be destroyed when the main thread exit.  As a result,
when a child thread that uses ThreadLocalPtr exits AFTER the main thread
exits, illegal memory access will occur.

This diff includes a test that reproduce this legacy bug.

    ==2095206==ERROR: AddressSanitizer: heap-use-after-free on address
    0x608000007fa0 at pc 0x959b79 bp 0x7f5fa7426b60 sp 0x7f5fa7426b58
    READ of size 8 at 0x608000007fa0 thread T1

This patch fix this issue by having the thread local mutex never be deleted
(but will leak small piece of memory at the end.)   The patch also describe
a better solution (thread_local) in the comment that requires gcc 4.8.1 and
in latest clang as a future work once we agree to move toward gcc 4.8.

Test Plan:
COMPILE_WITH_ASAN=1 make thread_local_test -j32
./thread_local_test --gtest_filter="*MainThreadDiesFirst"

Reviewers: anthony, hermanlee4, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D53013

10 years agoFix LITE db_test build broken by previous commit
sdong [Fri, 5 Feb 2016 22:26:26 +0000 (14:26 -0800)]
Fix LITE db_test build broken by previous commit

Summary: Previous commit introduces a test that is not supported in LITE. Fix it.

Test Plan: Build the test with ROCKSDB_LITE.

Reviewers: kradhakrishnan, IslamAbdelRahman, anthony, yhchiang, andrewkr

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D53901