]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Yuri Weinstein [Wed, 20 Jul 2022 16:38:04 +0000 (09:38 -0700)]
Merge pull request #47002 from rzarzynski/wip-mgr-fix-daemon-server-race
mgr: fix a race condition in DaemonServer::handle_report()
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Casey Bodley [Wed, 20 Jul 2022 14:19:39 +0000 (10:19 -0400)]
Merge pull request #46933 from clwluvw/s3-website-empty-bucket
rgw: s3website check for bucket before retargeting
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Adam C. Emerson [Wed, 20 Jul 2022 13:16:19 +0000 (09:16 -0400)]
Merge pull request #47009 from adamemerson/wip-chatty-bucket-sync-run
rgw: User friendly progress report on bucket sync run
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ernesto Puerta [Wed, 20 Jul 2022 12:08:50 +0000 (14:08 +0200)]
Merge pull request #47163 from rhcs-dashboard/get-storage-class-metrics
mgr/dashboard:Get different storage class metrics in Prometheus dashboard
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Rishabh Dave [Wed, 20 Jul 2022 11:44:17 +0000 (17:14 +0530)]
Merge pull request #46993 from rishabh-d-dave/qa-caps-helper-multiple-errmsgs
qa/cephfs: allow checking for multiple error messages while...
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Yingxin [Wed, 20 Jul 2022 08:14:55 +0000 (16:14 +0800)]
Merge pull request #47185 from cyx1231st/wip-seastore-backref-block-size
crimson/os/seastore/backref: decouple SegmentManagerGroup
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Yingxin [Wed, 20 Jul 2022 08:14:21 +0000 (16:14 +0800)]
Merge pull request #47183 from cyx1231st/wip-seastore-cleaner-journal-head
crimson/os/seastore/async_cleaner: re-introduce journal_header member
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Yingxin [Wed, 20 Jul 2022 08:13:22 +0000 (16:13 +0800)]
Merge pull request #47125 from xxhdx1985126/wip-56535
crimson/os/seastore/async_cleaner: avoid trimming backrefs when reclaiming space
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Rishabh Dave [Wed, 15 Sep 2021 09:11:02 +0000 (14:41 +0530)]
qa/cephfs: allow checking for multiple error messages while...
while negative testing.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Wed, 20 Jul 2022 07:34:08 +0000 (13:04 +0530)]
Merge pull request #47013 from rishabh-d-dave/qa-caps-method-authorize
qa/cephfs: upgrade method authorize in class Filesystem
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Rishabh Dave [Wed, 20 Jul 2022 07:31:51 +0000 (13:01 +0530)]
Merge pull request #46991 from rishabh-d-dave/qa-caps-helper-rm-path
qa/cephfs: delete path from cmd args after use
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Nizamudeen A [Wed, 20 Jul 2022 07:28:41 +0000 (12:58 +0530)]
Merge pull request #46998 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-moment-2.29.4
mgr/dashboard: bump moment from 2.29.3 to 2.29.4 in /src/pybind/mgr/dashboard/frontend
Reviewed-by: Nizamudeen A <nia@redhat.com>
Rishabh Dave [Wed, 20 Jul 2022 07:27:50 +0000 (12:57 +0530)]
Merge pull request #42335 from rishabh-d-dave/qa-get-keyring
qa: add a method to get keyring for a client_id
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Aashish Sharma [Tue, 19 Jul 2022 09:04:18 +0000 (14:34 +0530)]
mgr/dashboard:Get "Different Storage Class" metrics in Prometheus dashboard
Get metrics of the different "HDDRule" and "MixedUse" classes of the "Raw Storage" for their ceph VMs. So that Prometheus can scrape the data and display it to them in grafana
Fixes: https://tracker.ceph.com/issues/56625
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Yingxin Cheng [Wed, 20 Jul 2022 05:51:59 +0000 (13:51 +0800)]
crimson/os/seastore/backref: decouple SegmentManagerGroup
Backref tree is not specific to segments.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 20 Jul 2022 05:51:14 +0000 (13:51 +0800)]
crimson/os/seastore: drop unused code
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Pedro Gonzalez Gomez [Wed, 20 Jul 2022 05:50:07 +0000 (07:50 +0200)]
Merge pull request #47137 from rhcs-dashboard/cephadm-e2e-more-fixes
mgr/dashboard: fix dashboard cephadm e2e errors
Reviewed-by: Pedro González <pegonzal@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Yingxin Cheng [Wed, 20 Jul 2022 04:14:46 +0000 (12:14 +0800)]
crimson/os/seastore/async_cleaner: re-introduce journal_header member
RBM won't have segments_info_t, it has to maintain the journal_header by
itself.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Soumya Koduri [Wed, 20 Jul 2022 03:54:01 +0000 (09:24 +0530)]
Merge pull request #47173 from alimaredia/wip-rgw-s3tests-cloudtransitions-iam-section-add
qa: add iam section to cloud transitions config
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Xuehan Xu [Wed, 20 Jul 2022 03:05:33 +0000 (11:05 +0800)]
crimson/os/seastore/backref_manager: rename some methods for the sake of readability
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Xuehan Xu [Tue, 19 Jul 2022 07:48:47 +0000 (15:48 +0800)]
crimson/os/seastore/async_cleaner: don't trim backref when reclaiming space
Since the current backref cache doesn't invalidate duplicated backrefs any more
and backrefs get trimmed in the exact order of journal seqs, there's no need to trim
backrefs when reclaiming space
Fixes: https://tracker.ceph.com/issues/56535
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Yingxin [Wed, 20 Jul 2022 01:49:55 +0000 (09:49 +0800)]
Merge pull request #47140 from cyx1231st/wip-seastore-split-fix
crimson/os/seastore: do not assign gen/hint when split a clean extent
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Zhang Song <zhangsong325@gmail.com>
Ali Maredia [Tue, 19 Jul 2022 15:37:35 +0000 (11:37 -0400)]
qa: add iam section to cloud transitions config
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Ilya Dryomov [Tue, 19 Jul 2022 16:56:19 +0000 (18:56 +0200)]
Merge pull request #46736 from baergj/fix-log-buffer-resize
log: Make log_max_recent have an effect again
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Guillaume Abrioux [Tue, 19 Jul 2022 15:22:51 +0000 (17:22 +0200)]
Merge pull request #46666 from MrFreezeex/batch-blockdb-fix
ceph-volume: fix fast device alloc size on mulitple device
Matt Benjamin [Tue, 19 Jul 2022 14:46:07 +0000 (10:46 -0400)]
Merge pull request #46928 from linuxbox2/wip-rgwlc-azone
rgwlc: permit lifecycle to reduce data conditionally in archive zone
Yuri Weinstein [Tue, 19 Jul 2022 14:07:14 +0000 (07:07 -0700)]
Merge pull request #47019 from badone/wip-get_or_fail-debug-louder
msg: Log at higher level when Throttle::get_or_fail() fails
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Yuri Weinstein [Tue, 19 Jul 2022 14:05:47 +0000 (07:05 -0700)]
Merge pull request #46866 from myoungwon/wip-fix-53294
osd: return ENOENT if pool information is invalid during tier-flush
Reviewed-by: Laura Flores <lflores@redhat.com>
Ilya Dryomov [Tue, 19 Jul 2022 08:27:44 +0000 (10:27 +0200)]
Merge pull request #47116 from chrisphoffman/wip-rbd-56549
librbd: bail from schedule_request_lock() if already lock owner
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Jos Collin [Tue, 19 Jul 2022 07:45:40 +0000 (13:15 +0530)]
Merge pull request #47139 from rishabh-d-dave/cephfs-top-man
doc/man/cephfs-top.rst: add missing options: --delay, --conffile
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Nizamudeen A [Tue, 19 Jul 2022 07:36:34 +0000 (13:06 +0530)]
Merge pull request #46889 from rhcs-dashboard/osd-followup-iops
mgr/dashboard: do not recommend throughput for ssd's only cluster
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
Aashish Sharma [Tue, 19 Jul 2022 06:17:26 +0000 (11:47 +0530)]
Merge pull request #47135 from rhcs-dashboard/doc-default-main
mgr/dashboard: change doc service default release from master to main
Kefu Chai [Tue, 19 Jul 2022 04:27:06 +0000 (12:27 +0800)]
Merge pull request #47034 from tchaikov/wip-mon-signness-cleanup
mon: make paxos_size() unsigned
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Samuel Just [Tue, 19 Jul 2022 03:31:26 +0000 (20:31 -0700)]
Merge pull request #47089 from athanatos/sjust/wip-pg-shard-manager
crimson: introduce pg_shard_manager, begin to separate osd-wide from core-local state
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
wangxinyu [Wed, 23 Mar 2022 01:21:36 +0000 (09:21 +0800)]
doc/man/cephfs-top.rst: add missing options: --delay, --conffile
add missing options: --delay, --conffile
Signed-off-by: wangxinyu <wangxinyu@inspur.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Kefu Chai [Tue, 19 Jul 2022 02:30:49 +0000 (10:30 +0800)]
Merge pull request #47152 from tchaikov/wip-crimson-close-later
crimson/net: postpone the close() using yield()
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Adam King [Mon, 18 Jul 2022 21:29:51 +0000 (17:29 -0400)]
Merge pull request #46493 from adk3798/tuned-profiles
mgr/cephadm: support for os tuning profiles
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Adam King [Mon, 18 Jul 2022 21:27:20 +0000 (17:27 -0400)]
Merge pull request #46924 from hookak/loki-support
mgr/cephadm: fix the loki address in grafana, promtail configuration file
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Yuri Weinstein [Mon, 18 Jul 2022 20:38:05 +0000 (13:38 -0700)]
Merge pull request #46620 from rzarzynski/wip-tools-cot-force-pg-import
tools: COT ignores fsid mismatch when importing PG with --force
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Ali Maredia [Mon, 18 Jul 2022 19:21:29 +0000 (15:21 -0400)]
Merge pull request #47044 from alimaredia/wip-rgw-suite-s3test-refactor
add s3tests-brach.yaml for rgw teuthology suites that run s3tests
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Ali Maredia [Mon, 18 Jul 2022 19:15:56 +0000 (15:15 -0400)]
Merge pull request #46615 from selvakumaar5496/main
rgw: fix api response in case of get and delete object tagging apis
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Kefu Chai [Mon, 18 Jul 2022 14:35:19 +0000 (22:35 +0800)]
crimson/net: postpone the close() using yield()
otherwise we'd erase an element in a container when we are still
iterating through it.
Fixes: https://tracker.ceph.com/issues/56589
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Ilya Dryomov [Mon, 18 Jul 2022 14:42:42 +0000 (16:42 +0200)]
Merge pull request #47136 from idryomov/wip-48038
qa/suites/rbd: disable workunit timeout for dynamic_features_no_cache
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Christopher Hoffman [Thu, 14 Jul 2022 18:20:29 +0000 (12:20 -0600)]
librbd: bail from schedule_request_lock() if already lock owner
Race condition may be hit if there are multiple pending locks for the
same image and pending callbacks. Abort exclusive lock process if
already exclusive lock owner.
Fixes: https://tracker.ceph.com/issues/56549
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
Igor Fedotov [Mon, 18 Jul 2022 09:06:46 +0000 (12:06 +0300)]
Merge pull request #46911 from ifed01/wip-ifed-fix-mempool-cache-other
os/bluestore: fix AU accounting in bluestore_cache_other mempool.
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Ilya Dryomov [Mon, 18 Jul 2022 08:08:20 +0000 (10:08 +0200)]
Merge pull request #47106 from idryomov/wip-56561
rbd: don't default empty pool name unless namespace is specified
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Matan [Mon, 18 Jul 2022 07:40:06 +0000 (10:40 +0300)]
Merge pull request #46741 from Matan-B/wip-matanb-docker-debug
script: CentOS 8 EOL, use archived mirror in ceph-debug-docker.sh
Reviewed-by: Nitzan Mordechai nmordech@redhat.com
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Guillaume Abrioux [Mon, 18 Jul 2022 07:24:24 +0000 (09:24 +0200)]
Merge pull request #46375 from ceph/cv-loop-devs
ceph-volume: Optionally consume loop devices
Yingxin Cheng [Mon, 18 Jul 2022 03:29:46 +0000 (11:29 +0800)]
crimson/os/seastore: do not assign gen/hint when split a clean extent
Gen/hint is only required when need to write the extent to disk.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Nizamudeen A [Mon, 18 Jul 2022 05:38:28 +0000 (11:08 +0530)]
mgr/dashboard: do not recommend throughput for ssd's only cluster
This is just a bug fix where we recommend the throughput option even if
there are only ssd's are present in the cluster.
Fixes: https://tracker.ceph.com/issues/56413
Signed-off-by: Nizamudeen A <nia@redhat.com>
Yingxin Cheng [Mon, 18 Jul 2022 03:23:20 +0000 (11:23 +0800)]
crimson/os/seastore: introduce PLACEMENT_HINT_NULL
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Mon, 18 Jul 2022 02:42:29 +0000 (10:42 +0800)]
Merge pull request #47113 from zhscn/fix-split-test
crimson/os/seastore: fix bugs in test_map_existing_extent_concurrent
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Matt Benjamin [Fri, 15 Jul 2022 15:01:15 +0000 (11:01 -0400)]
rgwlc: return std::string_view from sal::Zone::get_tier_type()
Valid values are all small strings, often static.
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Fri, 15 Jul 2022 00:04:20 +0000 (20:04 -0400)]
rgwlc: count LCFilter flags towards multi-condition
Found by Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Wed, 13 Jul 2022 18:28:08 +0000 (14:28 -0400)]
rgwlc: return real default zone type from sal_dbstore and sal_motr
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Thu, 7 Jul 2022 21:29:27 +0000 (17:29 -0400)]
rgwlc: update LCFilter::dump_xml(...) to add flags/ArchiveZone
Also updates the location of Prefix, which is supposed to *generate*
as <Filter><Prefix/></Filter>, regardless of how we parsed it.
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Tue, 5 Jul 2022 22:33:09 +0000 (18:33 -0400)]
rgwlc: activate lifecycle processing on non-master zones
The basic idea of this change is the same as the proposal by
Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed.
The main differences are to use the existing
RGWLC::set(remove)_bucket_config methods, and to use the
RGWBucketInstanceMetadataHandler infrastructue to dispatch
the corresponding calls. Thank you!
Fixes: https://tracker.ceph.com/issues/44268
Related PR: #33524
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Fri, 1 Jul 2022 21:55:33 +0000 (17:55 -0400)]
rgwlc: zone-conditional lifecycle processing
Lifecycle rules with the ArchiveZone flag must execute on archive zones,
but must not execute on others.
Fixes: https://tracker.ceph.com/issues/56440
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Fri, 1 Jul 2022 12:54:32 +0000 (08:54 -0400)]
rgwlc: represent lc filter flags as XML elements
Suggested by Casey in review, this makes the XML prettier.
also: fix filter parsing, remove unused code
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Sat, 20 Nov 2021 18:45:51 +0000 (13:45 -0500)]
rgwlc: introduce lifecycle config flags extension
rgwlc: add uint32_t flags bitmap to LCFilter
This is intended to support a concise set of extensions to S3
LifecycleConfiguration, initially, just a flag that indicates a
rule is intended for execution on RGW ArchiveZone.
rgwlc: add machinery to define and recognize LCFilter flags
Add a concept of filter flags to lifecycle filter rules, an RGW
extension. The initial purpose of flags is to permit marking
specific lifecycle rules as specific to an RGW archive zone, but
other flags could be added in future.
rgwlc: add new unittest_rgw_lc to run internal checks, add a few
valid and invalid lifecycle configuration xml parses for now.
Fixes: https://tracker.ceph.com/issues/53361
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Nizamudeen A [Sun, 17 Jul 2022 18:38:13 +0000 (00:08 +0530)]
mgr/dashboard: fix dashboard cephadm e2e errors
https://tracker.ceph.com/issues/56079
Signed-off-by: Nizamudeen A <nia@redhat.com>
Ilya Dryomov [Fri, 20 May 2022 12:05:03 +0000 (14:05 +0200)]
qa/suites/rbd: disable workunit timeout for dynamic_features_no_cache
The I/O workload in this test is xfstests (qa/run_xfstests_qemu.sh)
which isn't subjected to any timeout other than global max_job_time
limit in any other subsuite (e.g. qemu/workloads/qemu_xfstests.yaml).
But here, there is a parallel "op" workload defined as a workunit.
The workunit task has a default timeout of 3 hours which is effectively
imposed on the entire job. In the "rbd cache = false" configuration,
it's sometimes exceeded.
Fixes: https://tracker.ceph.com/issues/48038
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Nizamudeen A [Sun, 17 Jul 2022 15:12:28 +0000 (20:42 +0530)]
mgr/dashboard: change doc service default release from master to main
Signed-off-by: Nizamudeen A <nia@redhat.com>
Adam C. Emerson [Fri, 8 Jul 2022 12:42:49 +0000 (08:42 -0400)]
rgw: Print syncing objects during `bucket sync run`
When --extra-info is provided to radosgw-admin.
This is a bit minimal but they weren't too clear in precisely what
information they wanted, and this should give a definite indication of
forward progress.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Thu, 30 Jun 2022 18:29:30 +0000 (14:29 -0400)]
rgw: Print user friendly progress on `bucket sync init`
When `--extra-info` is provided
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Thu, 30 Jun 2022 17:48:49 +0000 (13:48 -0400)]
rgw: RGWBucketPipeSyncStatusManger takes optional ostream
`radosgw-admin` provides it when the `--extra-info` option is provided.
It gets stashed in the SyncEnv for later use.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Thu, 30 Jun 2022 17:48:04 +0000 (13:48 -0400)]
rgw: RGWBucketPipeSyncStatusManager gets zone name on construction
So we can print it in the user friendly messages to come.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Thu, 30 Jun 2022 17:44:24 +0000 (13:44 -0400)]
rgw: Fix interface of RGWSI_Zone::find_zone
Since nullable pointers are nullable, it makes no sense to return a
bool and take a nullable pointer out parameter.
Just return the pointer.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Sun, 17 Jul 2022 02:17:05 +0000 (22:17 -0400)]
Merge pull request #47025 from adamemerson/wip-55765
rgw: Guard against malformed bucket URLs
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Adam King [Sat, 16 Jul 2022 22:43:11 +0000 (18:43 -0400)]
Merge pull request #46897 from rkachach/fix_issue_55808
mgr/cephadm: check for events key before accessing it
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King [Thu, 23 Jun 2022 19:46:22 +0000 (15:46 -0400)]
doc/cephadm: os tuning profile documentation
Signed-off-by: Adam King <adking@redhat.com>
Adam King [Thu, 23 Jun 2022 16:57:14 +0000 (12:57 -0400)]
mgr/cephadm: unit tests for tuned os profiles
Signed-off-by: Adam King <adking@redhat.com>
Adam King [Tue, 31 May 2022 20:22:49 +0000 (16:22 -0400)]
mgr/cephadm: support for os tuning profiles
Fixes: https://tracker.ceph.com/issues/55819
Signed-off-by: Adam King <adking@redhat.com>
Nizamudeen A [Sat, 16 Jul 2022 13:56:26 +0000 (19:26 +0530)]
Merge pull request #47011 from s0nea/wip-prevent-alert-redirects
mgr/dashboard: prevent alert redirect
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Ilya Dryomov [Sat, 16 Jul 2022 09:34:55 +0000 (11:34 +0200)]
Merge pull request #44217 from CongMinYin/fix-pwl-recovery-test
qa/suites/rbd/pwl-cache: ensure recovery is actually tested
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Xuehan Xu [Thu, 23 Jun 2022 09:26:01 +0000 (17:26 +0800)]
crimson/os/seastore/segment_cleaner: trim backrefs first
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Ilya Dryomov [Thu, 14 Jul 2022 12:42:45 +0000 (14:42 +0200)]
rbd: drop unused default_empty_pool_name argument
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 14 Jul 2022 12:19:06 +0000 (14:19 +0200)]
rbd: don't default empty pool name unless namespace is specified
Commit
96f05a7956b3 ("rbd: delay determination of default pool name")
broke "rbd perf image iostat" and "rbd perf image iotop" GLOBAL_POOL_KEY
support (the ability to blend all rbd pools together into a single
view).
Fixes: https://tracker.ceph.com/issues/56561
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sat, 16 Jul 2022 06:54:38 +0000 (08:54 +0200)]
qa/tasks: rename persistent write log cache trash task
It doesn't really thrash anything, just repeatedly restarts the
workload on top of a dirty cache file. rbd_pwl_cache_recovery is
more on point and gets covered by existing CODEOWNERS.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Sun, 10 Jul 2022 04:50:14 +0000 (00:50 -0400)]
mon: make paxos_size() unsigned
* make paxos_size() unsigned, as paxos_size() returns the size of
MonMap::mon_info, so it should be always a non-negative value,
and more importantly, it represents a size.
* change the type of MonMap::removed_ranks from std::set<int>
to std::set<unsigned>. for two reasons:
- removed_ranks only tracks the rank which is greater or equal to 0
- helps to silence the warnings listed below.
MonMap::removed_ranks is persisted using encode()/decode(), but this
change is backward compatible, as we use the raw encoder to encode
signed and unsigned integers, the difference between the encoding
schema between them only matters when MSB in the number is used,
but this is not likely happen, as we neither have a negative
rank in removed_ranks, no have a rank greater than `(unsigned)-1`,
i.e., 0xffffffff.
this change partially reverts
f75dfbc055ccf4e43b817ed5aa52898ff680e19e
to address the compiling warnings like:
/home/kefu/dev/ceph/src/mon/ElectionLogic.cc: In member function ‘void ElectionLogic::end_election_period()’:
/home/kefu/dev/ceph/src/mon/ElectionLogic.cc:173:23: error: comparison of integer expressions of different signedness: ‘std::set<int>::size_type’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
173 | acked_me.size() > (elector->paxos_size() / 2)) {
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kefu/dev/ceph/src/mon/ElectionLogic.cc: In member function ‘void ElectionLogic::propose_connectivity_handler(int, epoch_t, const ConnectionTracker*)’:
/home/kefu/dev/ceph/src/mon/ElectionLogic.cc:338:28: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
338 | for (unsigned i = 0; i < elector->paxos_size(); ++i) {
| ~~^~~~~~~~~~~~~~~~~~~~~~~
/home/kefu/dev/ceph/src/mon/ElectionLogic.cc: In member function ‘void ElectionLogic::receive_ack(int, epoch_t)’:
/home/kefu/dev/ceph/src/mon/ElectionLogic.cc:469:25: error: comparison of integer expressions of different signedness: ‘std::set<int>::size_type’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
469 | if (acked_me.size() == elector->paxos_size()) {
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [src/mon/CMakeFiles/mon.dir/build.make:328: src/mon/CMakeFiles/mon.dir/ElectionLogic.cc.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/home/kefu/dev/ceph/build'
[ 48%] Built target libglobal_objs
/home/kefu/dev/ceph/src/mon/Elector.cc: In member function ‘void Elector::notify_rank_removed(int)’:
/home/kefu/dev/ceph/src/mon/Elector.cc:734:43: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
734 | for (unsigned i = rank_removed + 1; i <= paxos_size() ; ++i) {
| ~~^~~~~~~~~~~~~~~
Fixes: https://tracker.ceph.com/issues/56581
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Sat, 16 Jul 2022 02:28:43 +0000 (12:28 +1000)]
Merge pull request #47109 from zdover23/wip-doc-2022-07-15-start-hw-recs-cleanup-1
doc/start: update hardware recs
Reviewed-by: Anthony D'Atri
Neha Ojha [Fri, 15 Jul 2022 20:50:47 +0000 (13:50 -0700)]
Merge pull request #46908 from mlausch/snapshot_key_conversion
osd/SnapMapper: fix legacy key conversion in snapmapper class
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Adam C. Emerson [Fri, 8 Jul 2022 18:58:16 +0000 (14:58 -0400)]
rgw: Guard against malformed bucket URLs
Misplaced colons can result in radosgw thinking is has a bucket URL
but with no bucket name, leading to a crash later on.
Fixes: https://tracker.ceph.com/issues/55765
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Mon, 11 Jul 2022 15:52:09 +0000 (11:52 -0400)]
rgw: Fix `rgw::sal::Bucket::empty` static method signatures
`unique_ptr` overload should take by reference.
Both should be const.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Neha Ojha [Fri, 15 Jul 2022 18:36:18 +0000 (11:36 -0700)]
Merge pull request #47052 from neha-ojha/wip-cot-label
.github/labeler.yml: add core label to some tools
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Fri, 15 Jul 2022 16:48:47 +0000 (18:48 +0200)]
Merge pull request #47115 from ceph/fix-mib
ceph.spec.in: fix path for mib file and properly mark in %files
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 15 Jul 2022 13:46:24 +0000 (15:46 +0200)]
Merge pull request #47035 from idryomov/wip-56516
rbd-mirror: remove bogus completed_non_primary_snapshots_exist check
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Justin Caratzas [Thu, 14 Jul 2022 22:45:49 +0000 (18:45 -0400)]
ceph.spec.in: fix path for mib file and properly mark in %files
Fixes typos introduced in https://github.com/ceph/ceph/pull/46918
Signed-off-by: Justin Caratzas <jcaratza@redhat.com>
myoungwon oh [Tue, 28 Jun 2022 04:42:21 +0000 (13:42 +0900)]
osd: return ENOENT if pool information is invalid during tier-flush
During tier-flush, OSD sends reference increase message to target OSD.
At this point, sending message with invalid pool information (e.g., deleted pool)
causes unexpected behavior.
Therefore, this commit return ENOENT early before sending the message
fixes: https://tracker.ceph.com/issues/53294
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Yingxin [Fri, 15 Jul 2022 07:16:42 +0000 (15:16 +0800)]
Merge pull request #47028 from xxhdx1985126/wip-seastore-backref-cache-refactor
crimson/os/seastore: simplify backref cache
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zhang Song [Fri, 15 Jul 2022 06:40:46 +0000 (14:40 +0800)]
crimson/os/seastore: fix bugs in test_map_existing_extent_concurrent
Signed-off-by: Zhang Song <zhangsong325@gmail.com>
Xuehan Xu [Thu, 7 Jul 2022 08:05:20 +0000 (16:05 +0800)]
crimson/os/seastore: simplify backref cache
Currently, the following transaction exec sequence would lead to
loss of backref:
1. Trans `A` merge a alloc backref for extent `X`
2. Trans `B` add a release backref for extent `X` to backref cache,
during which it finds an in-cache alloc backref for extent `X` and
decide not to add the release backref to cache
3. Trans `A` commit
In the above sequece, the release backref for extent `X` is lost.
This is a regression introduced when we try to optimize the backref cache.
This commit fix the issue by caching inflight backrefs in a multiset,
alloc/release ops that happen on the same paddr are queued in the order of
their happening. When doing gc, all those backrefs are merged.
Fixes: https://tracker.ceph.com/issues/56519
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Zac Dover [Thu, 14 Jul 2022 19:29:11 +0000 (05:29 +1000)]
doc/start: update hardware recs
This PR picks up the parts of
https://github.com/ceph/ceph/pull/44466
that were not merged back in January, when that
pull request was raised.
Matters added here:
* improved organzation of matter
* emphasis of IOPs per core over cores per OSD
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Adam King [Thu, 14 Jul 2022 18:02:32 +0000 (14:02 -0400)]
Merge pull request #46546 from mgfritch/vstart-stop-mds
src/stop.sh: stop existing ceph-mds daemons
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Pere Diaz Bou [Thu, 14 Jul 2022 16:20:24 +0000 (18:20 +0200)]
Merge pull request #46014 from vrushch/rbd_form_fix
mgr/dashboard: rbd striping setting pre-population and pop-over
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Adam King [Thu, 14 Jul 2022 15:07:08 +0000 (11:07 -0400)]
Merge pull request #47066 from adk3798/osd-removal-docs-update
doc/cephadm: add note about OSDs being recreated to OSD removal section
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Adam King [Thu, 14 Jul 2022 15:03:39 +0000 (11:03 -0400)]
Merge pull request #47062 from guits/update-latest-stable-default
cephadm: update LATEST_STABLE_RELEASE
Reviewed-by: Adam King <adking@redhat.com>
Ilya Dryomov [Thu, 14 Jul 2022 13:21:29 +0000 (15:21 +0200)]
Merge pull request #46260 from CongMinYin/wip-enable-ndctl
cmake: enable ndctl when building PMDK for WITH_BLUESTORE_PMEM
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Nizamudeen A [Thu, 14 Jul 2022 11:34:31 +0000 (17:04 +0530)]
Merge pull request #46644 from rhcs-dashboard/rbd-list-pagination
mgr/dashboard: rbd image pagination
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Thu, 14 Jul 2022 11:13:49 +0000 (16:43 +0530)]
Merge pull request #45981 from rhcs-dashboard/box-no-more-ultron
cephadm/box: Rootless podman box implementation
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: anthonyeleven <NOT@FOUND>
Reviewed-by: melissa-kun-li <NOT@FOUND>