Nizamudeen A [Tue, 16 Sep 2025 07:02:45 +0000 (12:32 +0530)]
mgr/dashboard: fix total capacity value in dashboard
Regression from a different commit
https://github.com/ceph/ceph/commit/2609d4f62e9e3906cf3e3fcc042bfdf0bcc633bf#diff-caee5ab662130fe721d15eca7a6e2dc79b671df025bde3bfd78c3c3ca4c578d1R249
Fixes: https://tracker.ceph.com/issues/73036 Signed-off-by: Nizamudeen A <nia@redhat.com>
libcephfs_proxy: fix userperm pointer decoding for older protocols
The random data used to decode pointers coming from the old protocol was
taken from the client instead of using the global_random data, which is
the correct one.
libcephfs_proxy: remove unnecessary protocol references in daemon
With the new protocol structure definitions, it's not necessary to
explicitly access each field inside its version substructure (v0, for
example). Now all fields of the latest version are declared inside an
anonymous substructure that can be accessed without a prefix.
libcephfs_proxy: remove unnecessary protocol references in client
With the new protocol structure definitions, it's not necessary to
explicitly access each field inside its version substructure (v0, for
example). Now all fields of the latest version are declared inside an
anonymous substructure that can be accessed without a prefix.
libcephfs_proxy: fix protocol structures for backward compatibility
The structures used for transferring data between the proxy client and
the proxy daemon had been reworked in a recent change to be able to
expand the protocol. This caused an inconsistency in the size of the
data transferred when communication with a peer using the older version.
The result was that the peer receiving the data with an unexpected size
was closing the connection, causing unexpected errors.
The discrepancy in size is the result of how compilers pad structures
combined with the change in the structure layout introduced when
extending the protocol. With these changes, the computation of the size
of each version of the structures was not done correctly.
This change makes the layout equal to the older version, so that
computing the size of the structures becomes easier and doesn't depend
on unexpected paddings.
Venky Shankar [Mon, 2 Jun 2025 05:08:01 +0000 (05:08 +0000)]
test/libcephfs: validate asynchronous write and fsync executing concurrently
This synthetic reproducer does three things:
- setup a client mount with a configuration to delay write operations and
initiates a write operation via a thread.
- a thread that invokes asynchronous fsync
- a thread that invokes setxattr for the client to track early replies
Without the fix[0], the test reproduces the following crash:
Venky Shankar [Tue, 3 Jun 2025 10:04:44 +0000 (10:04 +0000)]
client: catch buggy reference count drop for MetaRequest
With the prior commit that introduces a synthetic delay in write
operation so as to write a test reproducer which would interleave
asynchronous fsync and an operation that makes the MDS send a early
reply to the client (therefore, having the client track the early
replied response for an inode in Inode::unsafe_ops). Now, this is
enough to trick the client into the code path that causes a buggy
reference drop for the request (MetaRequest), but, hitting the
_exact_ crash backtrace requires the request to be a in various
[x]list's.
This last bit is tricky to synthetically massage in the test. So,
in order to catch the buggy reference drop, it would suffice to
assert on the reference count dropping to less than zero (0).
Laura Flores [Fri, 5 Sep 2025 21:46:20 +0000 (16:46 -0500)]
doc/rados/operations: add kernel client procedure to read balancer documentation
As of now, the kernel client does not support `pg-upmap-primary`. I have
added some troubleshooting steps to help users who are unable to
mount images and filesystems with the kernel client while using `pg-upmap-primary`.
Once the feature is supported by the kernel client, users will be able
to perform mounts along with `pg-upmap-primary`.
Fixes: https://tracker.ceph.com/issues/72897 Signed-off-by: Laura Flores <lflores@ibm.com>
N Balachandran [Thu, 28 Aug 2025 06:22:23 +0000 (11:52 +0530)]
rgw/logging: fixes data loss during rollover
Multiple threads attempting to roll over the same log object can result
in the creation of numerous orphan tail objects, each with a single record.
This occurs when a NULL RGWObjVersionTracker is used during the creation of
a new logging object. These records are inaccessible, leading to data loss,
which is particularly critical in Journal mode.
Furthermore, valid log tail objects may be added to the Garbage Collection (GC)
list, exacerbating data loss.
Fixes: https://tracker.ceph.com/issues/72740 Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>
Bill Scales [Wed, 9 Apr 2025 09:58:15 +0000 (10:58 +0100)]
test: add replica pool support to ceph_test_rados_io_sequence
Make 'ceph_test_rados_io_sequenece --pool rbd' work, replica
pools don't have an erausre code profile and do not have the
ec_allow_overwrites or ec_allow_optimizations flags
Fixes: https://tracker.ceph.com/issues/70844 Signed-off-by: Bill Scales <bill_scales@uk.ibm.com> Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
Jon Bailey [Mon, 14 Jul 2025 12:52:28 +0000 (13:52 +0100)]
common: Added values to json::OSDPoolGetReply
OSDPoolGetReply actually returns a lot more values than what is currently supplied. These have been added in as optionals (as they can not be give as well) so its possible to query them to find out if they exist and use them if they do.
Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
Modify collect_omap_stats() to guarantee that only
one 'large omap entry' warning message is logged
per chunk, thus maintaining the existing behaviour.
Unlike the existing behaviour - all 'large omap'
entries are counted.
Laura Flores [Fri, 11 Jul 2025 17:24:44 +0000 (13:24 -0400)]
script: add script to help format QA review summaries
Run the following command for help:
```
qa-summary.sh --help
```
This is how the script can be used:
```
qa-summary.sh < test_failure_tickets.txt
```
Before running the script, prep a 'test_failure_tickets.txt' file
(name is subjective) containing links to all the tracker tickets
you want to format in your test failures summary.
Laura Flores [Thu, 4 Sep 2025 21:02:05 +0000 (16:02 -0500)]
qa/tasks/thrashosds-health: fine tune ignorelist for degraded and undersized pgs
These warnings, part of the Ceph health detail, are expected in osd thrashing
tests. In the original test failure, the cluster eventually got back to
HEALTH_OK after the thrashing task completed.
Fixes: https://tracker.ceph.com/issues/72312 Signed-off-by: Laura Flores <lflores@ibm.com>
Conflicts:
qa/tasks/thrashosds-health.yaml - OSD_DOWN warnings were not present when the commit was first made
John Mulligan [Thu, 28 Aug 2025 23:39:06 +0000 (19:39 -0400)]
build-with-container: ensure npm dir is set up before configure
When the npm cache path option is passed the npm cache dir is passed
to all container `run` commands, ensure the dir has been created
before the first container command (configure) is used.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
according to `dpkg-buildflags`, ubuntu 24 raised this value to
`-D_FORTIFY_SOURCE=3` which causes `error: "_FORTIFY_SOURCE" redefined`
compilation failures because Ceph itself adds `-D_FORTIFY_SOURCE=2`
`_FORTIFY_SOURCE` is a hardening option. both our rpm and debian builds
already specify that via environment variables, so Ceph's cmake should
leave it alone
It is possible to modify the monitor election
strategy once stretch mode is enabled.
Solution:
Restrict the ability for Ceph to change election strategy
while using stretch mode.
Also, notify the user if they attempt to change to the current election
strategy. This change prevents unnecessary resource usage by informing
the user when they try to switch to an election strategy that is already in use.
This avoids redundant updates to the monmap.