]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 months agoMerge pull request #61015 from nbalacha/wip-nbalacha-rbd-mirror-namespace-2
Ilya Dryomov [Wed, 26 Feb 2025 14:15:21 +0000 (15:15 +0100)]
Merge pull request #61015 from nbalacha/wip-nbalacha-rbd-mirror-namespace-2

rbd-mirror: default <-> non-default namespace remapping

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #61269 from cbodley/wip-rgw-createbucket-layout
Casey Bodley [Wed, 26 Feb 2025 14:09:58 +0000 (09:09 -0500)]
Merge pull request #61269 from cbodley/wip-rgw-createbucket-layout

rgw/s3: CreateBucket extension for layout type and shard count

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 months agoMerge pull request #61982 from anthonyeleven/nvme-proxy
Zac Dover [Wed, 26 Feb 2025 13:53:02 +0000 (23:53 +1000)]
Merge pull request #61982 from anthonyeleven/nvme-proxy

doc/rbd: Improve nvmeof-requirements.rst with proxy and other info

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #60524 from thotz/multisitie-fix-cloud-restore
Soumya Koduri [Wed, 26 Feb 2025 13:37:43 +0000 (19:07 +0530)]
Merge pull request #60524 from thotz/multisitie-fix-cloud-restore

rgw/cloudrestore: sync cloud restore objects accoridngly

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
4 months agoMerge pull request #61849 from yuvalif/wip-yuval-69944
Yuval Lifshitz [Wed, 26 Feb 2025 12:28:29 +0000 (14:28 +0200)]
Merge pull request #61849 from yuvalif/wip-yuval-69944

rgw: be explicit on moving rados op in APIs

4 months agoMerge pull request #61376 from athanatos/sjust/wip-crimson-gcc-13
Matan Breizman [Wed, 26 Feb 2025 11:41:10 +0000 (13:41 +0200)]
Merge pull request #61376 from athanatos/sjust/wip-crimson-gcc-13

src/CMakeLists: require gcc13 for crimson, clarify error messages

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61846 from rhcs-dashboard/tox-generate-proto
Nizamudeen A [Wed, 26 Feb 2025 11:37:10 +0000 (17:07 +0530)]
Merge pull request #61846 from rhcs-dashboard/tox-generate-proto

mgr/dashboard: tox command to generate the nvmeof proto files

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 months agoMerge pull request #61903 from ronen-fr/wip-rf-crimson-conf
Matan Breizman [Wed, 26 Feb 2025 11:11:48 +0000 (13:11 +0200)]
Merge pull request #61903 from ronen-fr/wip-rf-crimson-conf

crimson/osd: replace obsolete get_tracked_conf_keys()

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #62001 from cybozu/fix-stale-delete
Zac Dover [Wed, 26 Feb 2025 10:48:18 +0000 (20:48 +1000)]
Merge pull request #62001 from cybozu/fix-stale-delete

doc: fix incorrect radosgw-admin subcommand

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #60871 from leonidc/leonidc-epoch-filter
Ronen Friedman [Wed, 26 Feb 2025 07:16:51 +0000 (09:16 +0200)]
Merge pull request #60871 from leonidc/leonidc-epoch-filter

Epoch filtering

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 months agodoc: fix incorrect radosgw-admin subcommand 62001/head
Toshikuni Fukaya [Wed, 26 Feb 2025 04:34:23 +0000 (04:34 +0000)]
doc: fix incorrect radosgw-admin subcommand

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
4 months agoMerge PR #61889 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:36:12 +0000 (16:36 -0500)]
Merge PR #61889 into main

* refs/pull/61889/head:
msg/async/Stack: include cleanup
msg/Message: include cleanup
msg/async/crypto_onwire: include cleanup
msg/async/ProtocolV1: add missing includes
msg/async/frames_v2: add missing includes
msg/msg_types: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61888 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:35:47 +0000 (16:35 -0500)]
Merge PR #61888 into main

* refs/pull/61888/head:
os/memstore: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61876 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:35:12 +0000 (16:35 -0500)]
Merge PR #61876 into main

* refs/pull/61876/head:
qa/cephfs: ignore warning that pg is stuck peering for upgrade jobs

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61802 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:34:53 +0000 (16:34 -0500)]
Merge PR #61802 into main

* refs/pull/61802/head:
perfglue: add missing include

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61801 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:34:33 +0000 (16:34 -0500)]
Merge PR #61801 into main

* refs/pull/61801/head:
kv: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61799 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:34:11 +0000 (16:34 -0500)]
Merge PR #61799 into main

* refs/pull/61799/head:
erasure-code: add missing include

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61798 into main
Patrick Donnelly [Tue, 25 Feb 2025 21:33:47 +0000 (16:33 -0500)]
Merge PR #61798 into main

* refs/pull/61798/head:
crush: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61955 from idryomov/wip-70075-test
Ilya Dryomov [Tue, 25 Feb 2025 19:32:13 +0000 (20:32 +0100)]
Merge pull request #61955 from idryomov/wip-70075-test

qa/workunits/rbd: add a test for force promote with a user snapshot

Reviewed-by: N Balachandran <nibalach@redhat.com>
4 months agorgw: reject PutBucketLifecycleConfiguration on indexless buckets 61269/head
Casey Bodley [Wed, 8 Jan 2025 21:55:19 +0000 (16:55 -0500)]
rgw: reject PutBucketLifecycleConfiguration on indexless buckets

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw: improved error when listing indexless bucket
Casey Bodley [Wed, 8 Jan 2025 21:48:24 +0000 (16:48 -0500)]
rgw: improved error when listing indexless bucket

without this change, ListObjects would attempt to list index shard
objects that don't exist and fail with:

> ERROR: S3 error: 404 (NoSuchKey)

after:

> ERROR: S3 error: 405 (MethodNotAllowed): Indexless buckets cannot be listed

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoexamples/rgw: register boto extension for BucketIndex on CreateBucket
Casey Bodley [Wed, 8 Jan 2025 20:41:10 +0000 (15:41 -0500)]
examples/rgw: register boto extension for BucketIndex on CreateBucket

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw/s3: CreateBucket extension for layout type and shard count
Casey Bodley [Wed, 8 Jan 2025 19:52:03 +0000 (14:52 -0500)]
rgw/s3: CreateBucket extension for layout type and shard count

extend s3's CreateBucketConfiguration [1] with a custom BucketIndex element
that can override rgw's default bucket index type and shard count

to create an indexless bucket:
  <CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <BucketIndex>
      <Type>Indexless</Type>
    </BucketIndex>
  </CreateBucketConfiguration>

to create a normal pre-sharded bucket:
  <CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <BucketIndex>
      <Type>Normal</Type>
      <NumShards>1023</NumShards>
    </BucketIndex>
  </CreateBucketConfiguration>

[1] https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html#API_CreateBucket_RequestSyntax

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw/rados: create_bucket() can override index type and shards
Casey Bodley [Wed, 8 Jan 2025 19:25:20 +0000 (14:25 -0500)]
rgw/rados: create_bucket() can override index type and shards

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw/rados: indexless buckets skip init_index/clean_index
Casey Bodley [Wed, 8 Jan 2025 21:17:47 +0000 (16:17 -0500)]
rgw/rados: indexless buckets skip init_index/clean_index

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw/s3: CreateBucket's LocationConstraint is optional
Casey Bodley [Wed, 8 Jan 2025 19:50:33 +0000 (14:50 -0500)]
rgw/s3: CreateBucket's LocationConstraint is optional

clean up the parsing and make the LocationConstraint optional

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #61740 from Matan-B/wip-matanb-clang-16
Matan Breizman [Tue, 25 Feb 2025 12:52:11 +0000 (14:52 +0200)]
Merge pull request #61740 from Matan-B/wip-matanb-clang-16

script/run-make: clang 14->19

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agoMerge pull request #61319 from rhcs-dashboard/gklm-kmip
afreen23 [Tue, 25 Feb 2025 12:35:32 +0000 (18:05 +0530)]
Merge pull request #61319 from rhcs-dashboard/gklm-kmip

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #61619 from ronen-fr/wip-rf-more-keys
Ronen Friedman [Tue, 25 Feb 2025 12:25:17 +0000 (14:25 +0200)]
Merge pull request #61619 from ronen-fr/wip-rf-more-keys

rgw: replace obsolete get_tracked_conf_keys()
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
4 months agoMerge pull request #61928 from rhcs-dashboard/smb-share-edit
Pedro Gonzalez Gomez [Tue, 25 Feb 2025 10:13:41 +0000 (11:13 +0100)]
Merge pull request #61928 from rhcs-dashboard/smb-share-edit

mgr/dashboard: SMB - Edit Share

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agoMerge pull request #61976 from guits/cv-update-batch-unit-tests
Guillaume Abrioux [Tue, 25 Feb 2025 09:14:07 +0000 (10:14 +0100)]
Merge pull request #61976 from guits/cv-update-batch-unit-tests

ceph-volume: update lvm batch unit tests

4 months agoMerge pull request #61985 from zdover23/wip-doc-2025-02-25-releases-squid-order
Zac Dover [Tue, 25 Feb 2025 06:57:50 +0000 (16:57 +1000)]
Merge pull request #61985 from zdover23/wip-doc-2025-02-25-releases-squid-order

doc/releases: correct squid release order

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61788 from VallariAg/wip-nvmeof-teuthology-improve
Vallari Agrawal [Tue, 25 Feb 2025 06:36:36 +0000 (12:06 +0530)]
Merge pull request #61788 from VallariAg/wip-nvmeof-teuthology-improve

qa/suite/nvmeof: Add asserts to scalability_test and extra logs in fio_test

4 months agoMerge pull request #61984 from cbodley/wip-doc-rgw-path-style
Zac Dover [Tue, 25 Feb 2025 05:08:29 +0000 (15:08 +1000)]
Merge pull request #61984 from cbodley/wip-doc-rgw-path-style

doc/rgw: clarify path-style vs virtual-hosted-style access

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/releases: correct squid release order 61985/head
Zac Dover [Tue, 25 Feb 2025 04:57:11 +0000 (14:57 +1000)]
doc/releases: correct squid release order

Put the releases of Squid in descending order. This change alters the
order of the Squid releases so that it is the same as the order of the
other Ceph releases.

Signed-off-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61875 from rhcs-dashboard/update-bucket-details
Aashish Sharma [Tue, 25 Feb 2025 04:37:02 +0000 (10:07 +0530)]
Merge pull request #61875 from rhcs-dashboard/update-bucket-details

mgr/dashboard: Update bucket details section after making bucket lifecycle changes

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agomgr/dashboard: Add GKLM(KMIP) option to SSE-KMS dropdown Menu in the Dashboard UI 61319/head
Prachi Goel [Fri, 10 Jan 2025 12:21:07 +0000 (17:51 +0530)]
mgr/dashboard: Add GKLM(KMIP) option to SSE-KMS dropdown Menu in the Dashboard UI

Fixes: https://tracker.ceph.com/issues/69490
Signed-off-by: Prachi Goel <prachi.goel@li-25d455cc-279f-11b2-a85c-b097dffa3f04.ibm.com>
Changes for GKLM dropdown UI:

1.Added option kmip in KMS dropdown in configuration page RGW
2.Made API dynamic for setting form data for Vault, kmip both for (S3 and
KMS)
3.Both Getdata and setdata API for RGW config page is modified

4 months agomgr/dashboard: SMB - Edit Share. 61928/head
Dnyaneshwari [Thu, 20 Feb 2025 05:28:02 +0000 (10:58 +0530)]
mgr/dashboard: SMB - Edit Share.

Fixes: https://tracker.ceph.com/issues/70094
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
4 months agoMerge PR #61979 into main
Patrick Donnelly [Mon, 24 Feb 2025 23:54:04 +0000 (18:54 -0500)]
Merge PR #61979 into main

* refs/pull/61979/head:
script/ceph-backport: remove upstream remote inferencing

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
4 months agodoc/rgw: clarify path-style vs virtual-hosted-style access 61984/head
Casey Bodley [Mon, 24 Feb 2025 21:50:39 +0000 (16:50 -0500)]
doc/rgw: clarify path-style vs virtual-hosted-style access

instead of referring to "vhost-style", copy the "path-style" and
"virtual-hosted-style" language from https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html

expand the FQDN acronym to avoid potential confusion

"The second method is deprecated by AWS" had incorrectly referred to the
vhost-style method - clarify that it refers to path-style access

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #61943 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:44:46 +0000 (16:44 -0500)]
Merge PR #61943 into main

* refs/pull/61943/head:
qa: ignore variant of down fs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge PR #61792 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:43:04 +0000 (16:43 -0500)]
Merge PR #61792 into main

* refs/pull/61792/head:
libcephsqlite: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61701 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:41:59 +0000 (16:41 -0500)]
Merge PR #61701 into main

* refs/pull/61701/head:
client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61697 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:41:00 +0000 (16:41 -0500)]
Merge PR #61697 into main

* refs/pull/61697/head:
osdc/ObjectCacher: include cleanup
osdc/Objecter: include cleanup
osdc/Journaler: include cleanup
osdc/Striper: add missing includes
osdc/Filer: include cleanup
crush/CrushWrapper: un-inline methods to fix linker errors
client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61872 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:39:41 +0000 (16:39 -0500)]
Merge PR #61872 into main

* refs/pull/61872/head:
crush/CrushWrapper: un-inline methods to fix linker errors

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61733 from phlogistonjohn/jjm-ctr-cleaner
Adam King [Mon, 24 Feb 2025 20:56:44 +0000 (15:56 -0500)]
Merge pull request #61733 from phlogistonjohn/jjm-ctr-cleaner

container: small container image improvements

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dan Mick <dan.mick@redhat.com>
4 months agodoc/rbd: Improve nvmeof-requirements.rst with proxy and other info 61982/head
Anthony D'Atri [Mon, 24 Feb 2025 17:08:01 +0000 (12:08 -0500)]
doc/rbd: Improve nvmeof-requirements.rst with proxy and other info

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #61400 from salieri11/igolikov-wip-fscrypt-68776
Christopher Hoffman [Mon, 24 Feb 2025 19:50:16 +0000 (14:50 -0500)]
Merge pull request #61400 from salieri11/igolikov-wip-fscrypt-68776

client: Use custom fscrypt cli in fs/fscrypt suite

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
4 months agoMerge pull request #61693 from aainscow/interval_set_strict
Adam Kupczyk [Mon, 24 Feb 2025 17:01:41 +0000 (18:01 +0100)]
Merge pull request #61693 from aainscow/interval_set_strict

include: interval_set: Re-introduce the original behaviour strict interval set

4 months agoMerge pull request #61679 from aclamk/wip-aclamk-fragmentation-histogram-defaults
Adam Kupczyk [Mon, 24 Feb 2025 17:01:15 +0000 (18:01 +0100)]
Merge pull request #61679 from aclamk/wip-aclamk-fragmentation-histogram-defaults

os/bluestore: Fix default base size for histogram

4 months agoMerge pull request #61455 from jbaergen-do/limit-discard-qlen-upstream
Adam Kupczyk [Mon, 24 Feb 2025 17:00:52 +0000 (18:00 +0100)]
Merge pull request #61455 from jbaergen-do/limit-discard-qlen-upstream

blk/KernelDevice: Introduce a cap on the number of pending discards

4 months agorbd-mirror: default <-> non-default namespace remapping 61015/head
N Balachandran [Tue, 17 Dec 2024 09:40:11 +0000 (15:10 +0530)]
rbd-mirror: default <-> non-default namespace remapping

These changes allow the pool to be configured to disable mirroring on
the default namespace if required (init-only mode). It also allows the
default namespace to be mirrored to a non-default namespace on the
remote pool.

Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: N Balachandran <nibalach@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #59740 from phlogistonjohn/jjm-smb-proxy-sidecar
Adam King [Mon, 24 Feb 2025 16:22:08 +0000 (11:22 -0500)]
Merge pull request #59740 from phlogistonjohn/jjm-smb-proxy-sidecar

smb: add support for proxy sidecar

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Sachin Prabhu <sp@spui.uk>
4 months agomgr/dashboard: Update bucket details section after making bucket lifecycle changesn 61875/head
Naman Munet [Tue, 18 Feb 2025 12:58:01 +0000 (18:28 +0530)]
mgr/dashboard: Update bucket details section after making bucket lifecycle changesn

Fixes: https://tracker.ceph.com/issues/69988
Signed-off-by: Naman Munet <naman.munet@ibm.com>
4 months agocmake/modules/BuildISAL.cmake: use GNU assembler 61740/head
Matan Breizman [Wed, 19 Feb 2025 17:56:11 +0000 (17:56 +0000)]
cmake/modules/BuildISAL.cmake: use GNU assembler

avoid the following error by disabling clang assembler:
```
[670/2691] Performing build step for 'isal_ext'
FAILED: src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build src/isa-l/install/lib/libisal.a /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/isa-l/install/lib/libisal.a
cd /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/isa-l && /usr/bin/cmake -P /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build-Debug.cmake && /usr/bin/cmake -E touch /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build
CMake Error at /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build-Debug.cmake:37 (message):
  Command failed: 2

   '/usr/bin/cmake' '-E' 'env' '--unset=DESTDIR' 'make' '-j3'

  See also

    /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build.log

-- Log output is:
...skipping to end...
hile in macro instantiation
crc64_refl_func crc64_ecma_refl_pmull
^
<instantiation>:2:26: error: unexpected token in argument list
 movk x7, p1_low_b1, lsl 16
                         ^
<instantiation>:54:2: note: while in macro instantiation
 crc64_fold_512b_to_128b
 ^
crc/aarch64/crc64_ecma_refl_pmull.S:33:1: note: while in macro instantiation
crc64_refl_func crc64_ecma_refl_pmull
^
<instantiation>:3:26: error: unexpected token in argument list
 movk x7, p1_low_b2, lsl 32
                         ^
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agosrc/CMakeLists.txt: -Wno-vla-cxx-extension only on clang >= 18
Matan Breizman [Tue, 18 Feb 2025 11:07:17 +0000 (11:07 +0000)]
src/CMakeLists.txt: -Wno-vla-cxx-extension only on clang >= 18

```
error: unknown warning option '-Wno-vla-cxx-extension'; did you mean '-Wno-vla-extension'? [-Werror,-Wunknown-warning-option]
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61949 from phlogistonjohn/jjm-c10s
Adam King [Mon, 24 Feb 2025 15:59:21 +0000 (10:59 -0500)]
Merge pull request #61949 from phlogistonjohn/jjm-c10s

build: a pair of needed changes to build on centos 10 stream

Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>
4 months agoMerge pull request #61592 from hasan4791/issue-69732
Yuri Weinstein [Mon, 24 Feb 2025 15:38:41 +0000 (07:38 -0800)]
Merge pull request #61592 from hasan4791/issue-69732

Isolate the absl flags to ceph-mon & ceph-nvmeof-monitor-client targets

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 months agoMerge pull request #60213 from NitzanMordhai/wip-nitzan-thrash-old-client-ignore...
Yuri Weinstein [Mon, 24 Feb 2025 15:37:48 +0000 (07:37 -0800)]
Merge pull request #60213 from NitzanMordhai/wip-nitzan-thrash-old-client-ignore-list

suite: thrash old client ignore list expend

Reviewed-by: Laura Flores <lflores@redhat.com>
4 months agoMerge pull request #55103 from kamoltat/wip-ksirivad-fix-63861
Yuri Weinstein [Mon, 24 Feb 2025 15:33:41 +0000 (07:33 -0800)]
Merge pull request #55103 from kamoltat/wip-ksirivad-fix-63861

src/mon/OSDMonitor.cc: [Stretch Mode] WRN non-existent CRUSH location assigned to MON

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
4 months agoscript/ceph-backport: remove upstream remote inferencing 61979/head
Patrick Donnelly [Mon, 24 Feb 2025 13:48:32 +0000 (08:48 -0500)]
script/ceph-backport: remove upstream remote inferencing

It's unnecessary.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoqa/workunits/rbd: add a test for force promote with a user snapshot 61955/head
Ilya Dryomov [Thu, 20 Feb 2025 15:38:41 +0000 (16:38 +0100)]
qa/workunits/rbd: add a test for force promote with a user snapshot

Add a reproducer for the crash on a bad variant access which was fixed
in commit 7d75161051da ("librbd: fix a crash in get_rollback_snap_id").

The reproducer deliberately works around many other issues with force
promote in snapshot-based mirroring: stopping rbd-mirror daemon
shouldn't be necessary (let alone with SIGKILL), get_rollback_snap_id()
and its caller can_create_primary_snapshot() are flawed and can pick
the wrong snapshot to roll back to or skip rollback when it's actually
required, the user snapshot in this scenario should be removed as part
of force promoting because it's incomplete and won't be usable after
the image is promoted, etc.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoceph-volume: update lvm batch unit tests 61976/head
Guillaume Abrioux [Mon, 24 Feb 2025 12:16:05 +0000 (12:16 +0000)]
ceph-volume: update lvm batch unit tests

This adds the recently `has_block_db_size_without_db_devices` attribute to the
mocked `args` object for lvm batch unit tests.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agorgw/cloudtier : disable sync for cloud tier objects 60524/head
Jiffin Tony Thottan [Wed, 30 Oct 2024 14:14:43 +0000 (19:44 +0530)]
rgw/cloudtier : disable sync for cloud tier objects

Also modified the modify_obj_attr api to include flags similar to set_obj_attrs

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
4 months agoMerge pull request #61668 from badone/wip-fix-rados-verify-cluster-selection
Matan Breizman [Mon, 24 Feb 2025 09:43:13 +0000 (11:43 +0200)]
Merge pull request #61668 from badone/wip-fix-rados-verify-cluster-selection

qa/suites/rados/verify: Allow selection of 2 or 4 node cluster

Reviewed-by: Laura Flores <lflores@redhat.com>
4 months agoMerge pull request #61196 from xxhdx1985126/wip-crimson-mgr-dynamic-perf-report
Matan Breizman [Mon, 24 Feb 2025 09:42:37 +0000 (11:42 +0200)]
Merge pull request #61196 from xxhdx1985126/wip-crimson-mgr-dynamic-perf-report

crimson/osd: support mgr's dynamic perf stats

Reviewed-by: Samuel Just <sjust@redhat.com>
4 months agoMerge pull request #60185 from xxhdx1985126/wip-68306
Matan Breizman [Mon, 24 Feb 2025 09:41:55 +0000 (11:41 +0200)]
Merge pull request #60185 from xxhdx1985126/wip-68306

crimson/osd/pg_recovery: trigger BackfillState events synchronously

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
4 months agoMerge pull request #61848 from guits/split-db-block-collocated
Guillaume Abrioux [Mon, 24 Feb 2025 08:34:26 +0000 (09:34 +0100)]
Merge pull request #61848 from guits/split-db-block-collocated

ceph-volume: support splitting db even on collocated scenario

4 months agoMerge pull request #61941 from ronen-fr/wip-rf-test-match
Ronen Friedman [Mon, 24 Feb 2025 08:30:20 +0000 (10:30 +0200)]
Merge pull request #61941 from ronen-fr/wip-rf-test-match

qa/standalone/scrub: retry in TEST_abort_periodic_for_operator()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #61899 from rhcs-dashboard/disable-deleting-bucket-with-objects
Aashish Sharma [Mon, 24 Feb 2025 06:19:17 +0000 (11:49 +0530)]
Merge pull request #61899 from rhcs-dashboard/disable-deleting-bucket-with-objects

mgr/dashboard: disable deleting bucket with objects

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #61893 from laimis9133/main
Nizamudeen A [Mon, 24 Feb 2025 05:06:12 +0000 (10:36 +0530)]
Merge pull request #61893 from laimis9133/main

mgr/dashboard: update openapi specification for /api/cluster/user/export

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #60872 from ronen-fr/wip-rf-repaironly
Ronen Friedman [Sun, 23 Feb 2025 14:31:28 +0000 (16:31 +0200)]
Merge pull request #60872 from ronen-fr/wip-rf-repaironly

osd/scrub: remove config option osd_repair_during_recovery
Reviewed-by: Samuel Just <sjust@redhat.com>
4 months agoMerge pull request #61950 from anthonyeleven/improve-rgw-yaml
Anthony D'Atri [Fri, 21 Feb 2025 13:51:28 +0000 (08:51 -0500)]
Merge pull request #61950 from anthonyeleven/improve-rgw-yaml

src/common/options: Improve descriptions in rgw.yaml.in

4 months agodoc: fix syntax (squash this) 61950/head
Zac Dover [Fri, 21 Feb 2025 04:38:23 +0000 (14:38 +1000)]
doc: fix syntax (squash this)

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 months agodoc: fixup (squash this)
Zac Dover [Fri, 21 Feb 2025 03:47:07 +0000 (13:47 +1000)]
doc: fixup (squash this)

Remove a colon from a yaml field that will not accept a colon.

Signed-off-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61948 from anthonyeleven/osd-rst-reimprove
Zac Dover [Fri, 21 Feb 2025 03:10:45 +0000 (13:10 +1000)]
Merge pull request #61948 from anthonyeleven/osd-rst-reimprove

doc/cephadm/services: Re-improve osd.rst

Reviewed-by: Mike Perez <thingee@gmail.com>
4 months agomgr/dashboard: update openapi specification for /api/cluster/user/export 61893/head
Laimis Juzeliūnas [Wed, 19 Feb 2025 09:58:56 +0000 (11:58 +0200)]
mgr/dashboard: update openapi specification for /api/cluster/user/export

This commit updates the openapi specification for /api/cluster/user/export endpoint to reflect the current api behaviour.

Fixes: https://tracker.ceph.com/issues/70043
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
4 months agosrc/common/options: Improve descriptions in rgw.yaml.in
Anthony D'Atri [Thu, 20 Feb 2025 21:34:28 +0000 (16:34 -0500)]
src/common/options: Improve descriptions in rgw.yaml.in

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoinstall-deps.sh: enable crb repository for centos 10 stream 61949/head
John Mulligan [Thu, 13 Feb 2025 21:00:27 +0000 (16:00 -0500)]
install-deps.sh: enable crb repository for centos 10 stream

The centos 10 stream distribution is like centos 9 and needs the crb
repository enabled to even think about building ceph. Note that I made
it a separate block in case more stuff needs to be added for it later.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agodo_cmake.sh: specify correct python version for centos 10 stream
John Mulligan [Thu, 13 Feb 2025 20:59:58 +0000 (15:59 -0500)]
do_cmake.sh: specify correct python version for centos 10 stream

Update the python version in the same tedious manner for centos 10
stream.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agodoc/cephadm/services: Re-improve osd.rst 61948/head
Anthony D'Atri [Thu, 20 Feb 2025 21:13:44 +0000 (16:13 -0500)]
doc/cephadm/services: Re-improve osd.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoqa: ignore variant of down fs 61943/head
Patrick Donnelly [Thu, 20 Feb 2025 18:59:03 +0000 (13:59 -0500)]
qa: ignore variant of down fs

Fixes: https://tracker.ceph.com/issues/70107
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61870 from afreen23/backward-compatibility
afreen23 [Thu, 20 Feb 2025 17:42:55 +0000 (23:12 +0530)]
Merge pull request #61870 from afreen23/backward-compatibility

mgr/dashboard: Make API backward compatible with size param change

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agotests: add call to fscrypt_cli_setup.sh to all fscrypt YAML files 61400/head
Igor Golikov [Thu, 20 Feb 2025 16:27:06 +0000 (18:27 +0200)]
tests: add call to fscrypt_cli_setup.sh to all fscrypt YAML files

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/68776
4 months agotests: use custom fscrypt cli for xfs tests
Igor Golikov [Thu, 20 Feb 2025 16:25:59 +0000 (18:25 +0200)]
tests: use custom fscrypt cli for xfs tests

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/68776
4 months agotests: add --verbose for better debugging of the custom fscript cli
Igor Golikov [Thu, 20 Feb 2025 16:25:12 +0000 (18:25 +0200)]
tests: add --verbose for better debugging of the custom fscript cli

Signed-off-by: Igor Golikov <igolikov@ibm.com>
4 months agotests: add new script for custom fscrypt cli setup
Igor Golikov [Thu, 20 Feb 2025 16:23:43 +0000 (18:23 +0200)]
tests: add new script for custom fscrypt cli setup

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/68776
4 months agoqa/standalone/scrub: retry in TEST_abort_periodic_for_operator() 61941/head
Ronen Friedman [Thu, 20 Feb 2025 16:15:44 +0000 (10:15 -0600)]
qa/standalone/scrub: retry in TEST_abort_periodic_for_operator()

The scenario created in the test requires two PGs that share the same
Primary, and at least one more member of their active sets.
The PR handles the (unlikely) case where the first PG tried does not
have a counterpart that matches the requirements.

A minor related fix in scrub-helpers.sh: using 'printf' to
return a value, instead of an out (ref) parameter.

Fixes: https://tracker.ceph.com/issues/69837
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoosdc/ObjectCacher: include cleanup 61697/head
Max Kellermann [Mon, 7 Oct 2024 03:37:31 +0000 (05:37 +0200)]
osdc/ObjectCacher: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Objecter: include cleanup
Max Kellermann [Mon, 7 Oct 2024 03:28:45 +0000 (05:28 +0200)]
osdc/Objecter: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Journaler: include cleanup
Max Kellermann [Mon, 7 Oct 2024 02:40:40 +0000 (04:40 +0200)]
osdc/Journaler: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Striper: add missing includes
Max Kellermann [Mon, 7 Oct 2024 02:31:00 +0000 (04:31 +0200)]
osdc/Striper: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Filer: include cleanup
Max Kellermann [Mon, 7 Oct 2024 02:27:49 +0000 (04:27 +0200)]
osdc/Filer: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agocrush/CrushWrapper: un-inline methods to fix linker errors
Max Kellermann [Thu, 9 Jan 2025 13:49:22 +0000 (14:49 +0100)]
crush/CrushWrapper: un-inline methods to fix linker errors

The `crush_objs` library is not part of the `libceph-common` ABI, so
applications linking with `libceph-common` may fail to build because
the linker cannot find `crush_destroy()`.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoclient/Client: add missing include and forward declaration
Max Kellermann [Thu, 10 Oct 2024 06:27:49 +0000 (08:27 +0200)]
client/Client: add missing include and forward declaration

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoos/memstore: add missing includes 61888/head
Max Kellermann [Thu, 10 Oct 2024 06:50:37 +0000 (08:50 +0200)]
os/memstore: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoMerge pull request #61880 from idryomov/wip-70041
Ilya Dryomov [Thu, 20 Feb 2025 15:14:12 +0000 (16:14 +0100)]
Merge pull request #61880 from idryomov/wip-70041

test/rbd_mirror: clear Namespace::s_instance at the end of a test

Reviewed-by: Vinay Bhaskar Varada <vvarada@redhat.com>
4 months agoMerge pull request #61841 from MaxKellermann/librbd__unordered_map
Ilya Dryomov [Thu, 20 Feb 2025 15:08:33 +0000 (16:08 +0100)]
Merge pull request #61841 from MaxKellermann/librbd__unordered_map

include/unordered_{map,set}: remove, use `std` directly instead

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 months agosrc/libcephfs_proxy/CMakeLists.txt: add -Wno-gnu-pointer-arith
Matan Breizman [Mon, 17 Feb 2025 10:21:31 +0000 (10:21 +0000)]
src/libcephfs_proxy/CMakeLists.txt: add -Wno-gnu-pointer-arith

```
Building C object src/libcephfs_proxy/CMakeFiles/cephfs_proxy.dir/proxy_link.c.o
/home/./ceph/src/libcephfs_proxy/proxy_link.c:198:10: warning: arithmetic on a pointer to void is a GNU extension [-Wgnu-pointer-arith]
  198 |                 buffer += len;
      |                 ~~~~~~ ^
/home/./ceph/src/libcephfs_proxy/proxy_link.c:232:18: warning: arithmetic on a pointer to void is a GNU extension [-Wgnu-pointer-arith]
  232 |                         iov->iov_base += len;
      |                         ~~~~~~~~~~~~~ ^
/home/./ceph/src/libcephfs_proxy/proxy_link.c:268:18: warning: arithmetic on a pointer to void is a GNU extension [-Wgnu-pointer-arith]
  268 |                         iov->iov_base += len;
      |                         ~~~~~~~~~~~~~ ^
/home/./ceph/src/libcephfs_proxy/proxy_link.c:328:17: warning: arithmetic on a pointer to void is a GNU extension [-Wgnu-pointer-arith]
  328 |                 iov->iov_base += sizeof(proxy_link_req_t);
      |                 ~~~~~~~~~~~~~ ^
/home/./ceph/src/libcephfs_proxy/proxy_link.c:391:17: warning: arithmetic on a pointer to void is a GNU extension [-Wgnu-pointer-arith]
  391 |                 iov->iov_base += sizeof(proxy_link_ans_t);
      |                 ~~~~~~~~~~~~~ ^
5 warnings generated.
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agosrc/erasure-code/jerasure/CMakeLists.txt:: add -Wno-unused-but-set-variable
Matan Breizman [Mon, 17 Feb 2025 10:16:03 +0000 (10:16 +0000)]
src/erasure-code/jerasure/CMakeLists.txt:: add -Wno-unused-but-set-variable

```
[460/1945] Building C object src/erasure-code/jerasure/CMakeFiles/jerasure_objs.dir/jerasure/src/jerasure.c.o
ceph/src/erasure-code/jerasure/jerasure/src/jerasure.c:722:7: warning: variable 'ddf' set but not used [-Wunused-but-set-variable]
  722 |   int ddf, cdf;
      |       ^
ceph/src/erasure-code/jerasure/jerasure/src/jerasure.c:722:12: warning: variable 'cdf' set but not used [-Wunused-but-set-variable]
  722 |   int ddf, cdf;
      |            ^
ceph/src/erasure-code/jerasure/jerasure/src/jerasure.c:777:7: warning: variable 'ddf' set but not used [-Wunused-but-set-variable]
  777 |   int ddf, cdf;
      |       ^
ceph/src/erasure-code/jerasure/jerasure/src/jerasure.c:777:12: warning: variable 'cdf' set but not used [-Wunused-but-set-variable]
  777 |   int ddf, cdf;
      |            ^
4 warnings generated.
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>