]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Adam King [Thu, 3 Oct 2024 11:56:53 +0000 (07:56 -0400)]
Merge pull request #60022 from ShwetaBhosale1/add-email
mailmap, githubmap, organisationmap: Add Shweta
Reviewed-by: Laura Flores <lflores@ibm.com>
SrinivasaBharathKanta [Thu, 3 Oct 2024 09:45:47 +0000 (15:15 +0530)]
Merge pull request #58293 from Suyashd999/fix-uam9
ceph_osd: false use-after-move on store
afreen23 [Thu, 3 Oct 2024 09:30:17 +0000 (15:00 +0530)]
Merge pull request #60072 from rhcs-dashboard/delete-popover
mgr/dashboard: Unable to delete realm via dashboard
Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
leonidc [Wed, 2 Oct 2024 07:30:42 +0000 (10:30 +0300)]
Merge pull request #60069 from leonidc/fix-corruption-upon-add-gw
mon/nvmeofgw*:fix monitor database corruption upon add gw
Ilya Dryomov [Wed, 2 Oct 2024 05:50:27 +0000 (07:50 +0200)]
Merge pull request #60005 from idryomov/wip-68213
qa/suites/rbd/iscsi: enable all supported container hosts
Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Shweta Bhosale [Fri, 27 Sep 2024 09:29:16 +0000 (14:59 +0530)]
mailmap, githubmap, organisationmap: Add Shweta Bhosale
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Casey Bodley [Tue, 1 Oct 2024 20:46:15 +0000 (16:46 -0400)]
Merge pull request #59745 from cbodley/wip-qa-rgw-multifs-combined
qa/rgw/multifs: add tasks/+ to concatenate tasks into same job
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Yuri Weinstein [Tue, 1 Oct 2024 15:04:04 +0000 (08:04 -0700)]
Merge pull request #56980 from sajibreadd/device-class-mask-65228
osd: class:device-class config database mask does not work for osd_compact_on_start
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Yuri Weinstein [Tue, 1 Oct 2024 15:00:33 +0000 (08:00 -0700)]
Merge pull request #55334 from trociny/wip-rados-setomapheader
tools/rados: allow to read setomapheader value from file
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
afreen23 [Tue, 1 Oct 2024 14:27:34 +0000 (19:57 +0530)]
Merge pull request #59978 from afreen23/nvme-gateway-fix
mgr/dashboard: Fix adding listener and null issue for groups
Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Adam King [Tue, 1 Oct 2024 12:53:38 +0000 (08:53 -0400)]
Merge pull request #60015 from Kushal-deb/kushaldeb-add-email-contact
mailmap, githubmap, organisationmap: Add Kushal
Reviewed-by: Laura Flores <lflores@ibm.com>
Dnyaneshwari [Tue, 1 Oct 2024 11:48:13 +0000 (17:18 +0530)]
mgr/dashboard: Unable to delete realm via dashboard
Replacing Bootstrap Modal Service (ModalService) with Carbon Modal Service (ModalCdsService)
Fixes: https://tracker.ceph.com/issues/68290
Signed-off-by: Dnyaneshwari talwekar <dtalweka@redhat.com>
Pedro Gonzalez Gomez [Tue, 1 Oct 2024 09:11:25 +0000 (11:11 +0200)]
Merge pull request #59159 from rhcs-dashboard/rbd-table
mgr/dashboard: rbd table actions enhancements
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Afreen Misbah [Wed, 25 Sep 2024 11:15:10 +0000 (16:45 +0530)]
mgr/dashboard: Allow adding all listeners unders a subsystems
Issue:
- Currently a user cannot add all listeners under a subsystem
- This results into an error: `Failure adding nqn.2001-07.com.ceph:
1725013182540 listener at 10.70.44.140:4420: Gateway's host name must match current host (dhcp47-54)`
Reason:
- The gateway address used while creating listener is random now in nvmeof client
- After checking the gateway logs of each node, its is found that no grpc request recieved for adding listener on the respective node rather going to the node that is chosen by default in nvmeof client.
- But nvmeof backend check that current gateway matches the one with sent in request for adding listener (ref: https://github.com/ceph/ceph-nvmeof/blob/devel/control/grpc.py#L2104)
Fix:
- Using `traddr` from listener API to set the current gateway address
- Since `traddr` gives only IP address, without port therefore extracting full address from `NvmeofGatewaysConfig.get_gateways_config()`
- This ensures correct path usage
Fixes https://tracker.ceph.com/issues/68229
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
Guillaume Abrioux [Tue, 1 Oct 2024 07:37:13 +0000 (09:37 +0200)]
Merge pull request #60006 from guits/tracker_64353
ceph-volume: add new class UdevData
Leonid Chernin [Mon, 30 Sep 2024 16:43:38 +0000 (16:43 +0000)]
mon/nvmeofgw*:fix monitor database corruption upon add gw
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
Venky Shankar [Tue, 1 Oct 2024 04:08:40 +0000 (09:38 +0530)]
Merge pull request #59875 from joscollin/wip-B68131-revert-sync-duration
cephfs_mirror: revert sync_duration to seconds
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Laura Flores [Mon, 30 Sep 2024 21:29:38 +0000 (16:29 -0500)]
Merge pull request #52636 from baergj/subsecond-history-slow-op-upstream
TrackedOp: Make history_slow_op_threshold a float
Laura Flores [Mon, 30 Sep 2024 21:29:16 +0000 (16:29 -0500)]
Merge pull request #58749 from rzarzynski/wip-bug-67087
osd: fix partial reading during multi-region EC reads
Casey Bodley [Mon, 30 Sep 2024 18:03:53 +0000 (14:03 -0400)]
Merge pull request #59998 from cbodley/wip-63935
rgw/rados: don't rely on IoCtx::get_last_version() for async ops
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Samuel Just [Mon, 30 Sep 2024 17:21:51 +0000 (10:21 -0700)]
Merge pull request #59815 from athanatos/sjust/wip-68068
crimson: don't retain InternalClientRequest on interval change even if primary does not change
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Afreen Misbah [Tue, 24 Sep 2024 11:13:41 +0000 (16:43 +0530)]
mgr/dashboard: Fix `null` gateway group
- when no group is set a bad request is made `?gw_group=null`
- this causes a dashboard exception to be raised as well
- avoiding sending any request when no group is present
- fixes casing of "hostname" in gateway column
Fixes https://tracker.ceph.com/issues/68230
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
Casey Bodley [Mon, 30 Sep 2024 14:45:08 +0000 (10:45 -0400)]
Merge pull request #59567 from clwluvw/rgw-datachangelog
rgw: remove rgw_data_log_obj_prefix
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kushal-deb [Mon, 30 Sep 2024 14:03:02 +0000 (19:33 +0530)]
Merge branch 'ceph:main' into kushaldeb-add-email-contact
Ilya Dryomov [Mon, 30 Sep 2024 10:27:07 +0000 (12:27 +0200)]
Merge pull request #59842 from chanyoung/set-journaling-feature
rbd: set journaling feature when --mirror-image-mode is journal
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Venky Shankar [Mon, 30 Sep 2024 10:08:04 +0000 (15:38 +0530)]
Merge PR #59874 into main
* refs/pull/59874/head:
mds: invalid id for client eviction is to be treated as success
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Pedro Gonzalez Gomez [Mon, 30 Sep 2024 09:13:44 +0000 (11:13 +0200)]
Merge pull request #60029 from rhcs-dashboard/fix-68295
mgr/dashboard: fix doc links in rgw-multisite
Reviewed-by: Nizamudeen A <nia@redhat.com>
Guillaume Abrioux [Thu, 26 Sep 2024 14:58:56 +0000 (16:58 +0200)]
ceph-volume: add new class UdevData
This adds a new class `UdevData` to represent
udev data for a given device.
Fixes: https://tracker.ceph.com/issues/64353
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Guillaume Abrioux [Mon, 30 Sep 2024 08:56:35 +0000 (10:56 +0200)]
Merge pull request #60031 from guits/cv-quick-fix
ceph-volume: docstring and typing corrections
Venky Shankar [Mon, 30 Sep 2024 06:58:05 +0000 (12:28 +0530)]
Merge PR #52623 into main
* refs/pull/52623/head:
ceph-dencoder: MDS - Add missing types
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Zac Dover [Mon, 30 Sep 2024 04:12:48 +0000 (14:12 +1000)]
Merge pull request #60039 from zdover23/wip-doc-2024-09-29-rados-tshooting-tshooting-pg
doc/rados: edit "Placement Groups Never Get Clean"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
leonidc [Sun, 29 Sep 2024 12:36:19 +0000 (15:36 +0300)]
Merge pull request #59999 from leonidc/tracking-gw-deleting
mon/nvmeofgw*: fix tracking gateways in DELETING state
Zac Dover [Sun, 29 Sep 2024 06:10:29 +0000 (16:10 +1000)]
doc/rados: edit "Placement Groups Never Get Clean"
Make grammar improvements (and correct a verb disagreement) in the
section "Placement Groups Never Get Clean" in
doc/rados/troubleshooting/troubleshooting-pg.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 29 Sep 2024 05:48:27 +0000 (15:48 +1000)]
Merge pull request #60036 from solmagd/main
reef: doc: Adds release date.
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Sat, 28 Sep 2024 12:44:25 +0000 (08:44 -0400)]
Merge pull request #60038 from zdover23/wip-doc-2024-09-28-releases-squid-dashboard
doc/releases: move Dashboard items from CephFS
Zac Dover [Sat, 28 Sep 2024 11:49:03 +0000 (21:49 +1000)]
doc/releases: move Dashboard items from CephFS
Move three dashboard-related items from beneath a heading reading
"CephFS" and put them beneath a heading reading "Dashboard".
Fixes: https://github.com/ceph/ceph/pull/59539#discussion_r1777960130
Signed-off-by: Zac Dover <zac.dover@proton.me>
Samuel Just [Sat, 28 Sep 2024 02:05:57 +0000 (19:05 -0700)]
Merge pull request #59366 from athanatos/sjust/wip-67640-module-fix
.gitmodules: remove shallow=true config from nvmeof/gateway
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Joel Davidow [Fri, 27 Sep 2024 22:44:54 +0000 (22:44 +0000)]
doc: Adds release date.
Signed-off-on-by: Joel Davidow <jdavidow@nso.edu>
SrinivasaBharathKanta [Fri, 27 Sep 2024 21:45:24 +0000 (03:15 +0530)]
Merge pull request #58598 from sajibreadd/wip-66215
common/Formatter: dump inf/nan as null
SrinivasaBharathKanta [Fri, 27 Sep 2024 21:44:45 +0000 (03:14 +0530)]
Merge pull request #57659 from mkogan1/wip-graceful-shutdown
rgw: delay the RGW process exit until all actice requests have completed
Zac Dover [Fri, 27 Sep 2024 21:25:13 +0000 (07:25 +1000)]
Merge pull request #60030 from petrutlucian94/document_windows_ci
doc: Document the Windows CI job
Reviewed-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Fri, 27 Sep 2024 18:32:27 +0000 (14:32 -0400)]
Merge pull request #60026 from batrick/i68291
osdc: fix mutex assert for !debug builds
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Lucian Petrut [Fri, 27 Sep 2024 14:09:34 +0000 (14:09 +0000)]
doc: Document the Windows CI job
We're adding a document that describes:
* the steps performed by the Windows CI job
* artifact structure
* frequently asked questions
The document is meant to assist the Ceph developers in investigating
CI failures. This is especially important as the Windows CI job runs
integration tests that would otherwise only be executed by
Teuthology, thus helping catch potential regressions quickly.
Note that the identified regressions are not necessarily Windows
specific, usually affecting Linux builds as well.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Guillaume Abrioux [Fri, 27 Sep 2024 14:52:39 +0000 (16:52 +0200)]
ceph-volume: docstring and typing corrections
This corrects some error in disk.py:
- get_partitions has an incorrect typing
+ adding docstring for this function.
- get_lvm_mapper_path_from_dm docstring is wrong
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Pedro Gonzalez Gomez [Fri, 27 Sep 2024 13:59:15 +0000 (15:59 +0200)]
mgr/dashboard: fix doc links in rgw-multisite
Fixes: https://tracker.ceph.com/issues/68295
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Patrick Donnelly [Fri, 27 Sep 2024 12:13:23 +0000 (08:13 -0400)]
osdc: fix mutex assert for !debug builds
Fixes: 55652f0819761d410bddcf3688b1c3e10ed64f5b
Fixes: https://tracker.ceph.com/issues/68291
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Prachi Goel [Sun, 11 Aug 2024 17:05:59 +0000 (22:35 +0530)]
mgr/dashboard: rbd table actions enhancements
Fixes:https://tracker.ceph.com/issues/67198
Below are the changes:-
Delete option moved to last in list.
Delete is disabled in case image is secondary.
Move to trash should be second last option.
Tooltip is added for ‘Move to Trash’ and ‘Delete’
Tooltip is added for Copy option
Subheading is added for Copy Form.
Tooltip is added for ‘Flatten’ option.
Delete tooltip content has been in case image is primary.
Signed-off-by: Prachi Goel <prachi@li-f0e8f2cc-27e0-11b2-a85c-b2772164128d.ibm.com>
Leonid Chernin [Thu, 26 Sep 2024 13:47:00 +0000 (13:47 +0000)]
mon/nvmeofgw*: fix tracking gateways in DELETING state
1.Ignore subsystems of GWs in state DELETING when calculate number namespaces
2.Call tracking function always in the monitor's tick - not just if the
beacon is active
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
Ilya Dryomov [Fri, 27 Sep 2024 07:17:14 +0000 (09:17 +0200)]
Merge pull request #57836 from guojidan/warn-pool-app
src/mon/PGMap: raise POOL_APP_NOT_ENABLED after some time for new pool
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Kushal Jyoti Deb [Fri, 27 Sep 2024 06:05:45 +0000 (11:35 +0530)]
mailmap, githubmap, organisationmap: Add Kushal
Signed-off-by: Kushal Deb <Kushal.Deb@ibm.com>
Laura Flores [Thu, 26 Sep 2024 22:18:36 +0000 (17:18 -0500)]
Merge pull request #59539 from zdover23/wip-doc-2024-08-31-add-squid-19-2-0-release-notes
doc: Add Squid 19.2.0 release notes
Laura Flores [Thu, 26 Sep 2024 18:13:42 +0000 (13:13 -0500)]
doc/releases: add highlights section
Signed-off-by: Laura Flores <lflores@ibm.com>
Casey Bodley [Wed, 25 Sep 2024 22:38:08 +0000 (18:38 -0400)]
rgw/rados: rgw_rados_operate() takes version_t*
instead of calling ioctx.get_last_version() after a rados operation,
callers now pass version_t* as an output parameter. in the null_yield
case, that version is assigned to ioctx.get_last_version() as normal. in
the async case, we get the version out of librados::async_operate()'s
return value
Fixes: https://tracker.ceph.com/issues/63935
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 26 Sep 2024 18:49:26 +0000 (14:49 -0400)]
Merge pull request #58461 from cbodley/wip-cls-rgw-index-async
cls/rgw: warn about CLSRGWConcurrentIO use in asio threads
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Adam King [Thu, 26 Sep 2024 17:43:51 +0000 (13:43 -0400)]
Merge pull request #59726 from avanthakkar/earmark-nfs
mgr/nfs: earmark resolver for subvolume
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Laura Flores [Thu, 26 Sep 2024 17:26:18 +0000 (12:26 -0500)]
doc/releases: update squid release date
Signed-off-by: Laura Flores <lflores@ibm.com>
Casey Bodley [Wed, 25 Sep 2024 20:20:31 +0000 (16:20 -0400)]
librados/asio: add version_t to completion signatures
IoCtx::aio_operate() doesn't update IoCtx::get_last_version(). to make
the resulting version_t available to the caller, we have to read it out
of the AioCompletionImpl and return it to the caller
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Zac Dover [Thu, 26 Sep 2024 16:21:09 +0000 (02:21 +1000)]
doc/releases: Add warning about iSCSI bug
Add a warning about an iSCSI-related bug encountered when upgrading from
19.1.1 to 19.2.0.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ilya Dryomov [Tue, 24 Sep 2024 12:06:42 +0000 (14:06 +0200)]
qa/suites/rbd/iscsi: enable all supported container hosts
On Ubuntu open-iscsi and multipath-tools need to be installed instead
of iscsi-initiator-utils and device-mapper-multipath.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 26 Sep 2024 15:36:37 +0000 (17:36 +0200)]
qa: avoid a non-standard shell construct in rbd/iscsi_client.t
dash which is used as /bin/sh on Ubuntu interprets "2&> /dev/null" as
an instruction to launch iscsiadm in the background. While that is
mostly compensated by the following sleep, stderr isn't redirected to
/dev/null either -- the output gets polluted and the test fails.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 25 Sep 2024 09:34:34 +0000 (11:34 +0200)]
qa: don't hardcode podman in rbd/gwcli_{create,delete}.t
If podman isn't available (e.g. on Ubuntu), cephadm falls back to
docker.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 25 Sep 2024 07:53:35 +0000 (09:53 +0200)]
qa/tasks/ceph_iscsi_client: don't use mpathconf
... since it's not available on Ubuntu. In this case mpathconf just
sets a couple of default values and defines an empty blacklist section,
so it's easy enough to replicate.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Patrick Donnelly [Thu, 26 Sep 2024 15:24:58 +0000 (11:24 -0400)]
Merge PR #58936 into main
* refs/pull/58936/head:
mds: do not duplicate journaler write heads
mds: use Journaler getters
osdc: properly acquire locks for getters
osdc: add print method for Journaler::Header
mds: do not trim segments after open file table commit
mds: delay expiry if LogSegment is ahead of committed oft seq
mds: do not write journal head twice on trim
mds: simplify and explain expiry finisher ctx
mds: add mds_lock asserts for journal flush
mds: skip second wait_for_safe
mds: trim only to the LogSegment created for flush
mds: allow passing explicit seq to trim to
mds: quiet unhelpful debug message
mds: add C_IO_Wrapper completion debugging
mds: add dout for new segment
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Casey Bodley [Thu, 26 Sep 2024 15:05:07 +0000 (11:05 -0400)]
Merge pull request #59864 from cbodley/wip-68134
rgw/rados: RGWRados::delete_objs_inline() uses AioThrottle
Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
Casey Bodley [Thu, 26 Sep 2024 14:58:23 +0000 (10:58 -0400)]
Merge pull request #59536 from smanjara/rgw-full-sync-cr
rg/multisite: handle errors properly in RGWDataFullSyncSingleEntryCR()
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kamoltat (Junior) Sirivadhna [Thu, 26 Sep 2024 14:15:04 +0000 (10:15 -0400)]
Merge pull request #57146 from kamoltat/wip-ksirivad-fix-connection-score-json
src/mon/ConnectionTracker.cc: Fix dump function
Reviewed-by Kamoltat Sirivadhna <ksirivad@redhat.com>
Kamoltat (Junior) Sirivadhna [Thu, 26 Sep 2024 14:14:36 +0000 (10:14 -0400)]
Merge pull request #58472 from YiteGu/reinforce-mon-scrub-db-get-error
mon/scrub: log error details of store access failures
Reviewed-by Kamoltat Sirivadhna <ksirivad@redhat.com>
Casey Bodley [Thu, 26 Sep 2024 13:44:09 +0000 (09:44 -0400)]
Merge pull request #59609 from cbodley/wip-rgw-dir-suggest-reshard
rgw/rados: guard against dir suggest during reshard
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Casey Bodley [Thu, 26 Sep 2024 13:07:26 +0000 (09:07 -0400)]
Merge pull request #59441 from ceph/wip-oozmen-67656-integration-test
test/rgw/notifications: integration test for the procedure of migrating an existing v2 topic to an account
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Casey Bodley [Thu, 26 Sep 2024 13:07:04 +0000 (09:07 -0400)]
Merge pull request #59244 from cbodley/wip-rgw-notification-token-waiter
rgw/notify: process_queue() constructs wait tokens when spawning
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Guillaume Abrioux [Thu, 26 Sep 2024 12:19:49 +0000 (14:19 +0200)]
Merge pull request #59981 from guits/fix_68231
node-proxy: fix a regression when processing the RedFish API
afreen23 [Thu, 26 Sep 2024 07:53:57 +0000 (13:23 +0530)]
Merge pull request #59946 from rhcs-dashboard/rbd-snapshot
mgr/dashboard: Forbid snapshot name "." and any containing "/".
Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Zac Dover [Thu, 26 Sep 2024 07:17:21 +0000 (17:17 +1000)]
Merge pull request #59986 from nbalacha/wip-nbalacha-doc-typo
doc: fix typo
Reviewed-by: Zac Dover <zac.dover@proton.me>
Nizamudeen A [Thu, 26 Sep 2024 06:42:44 +0000 (12:12 +0530)]
Merge pull request #59846 from rhcs-dashboard/usermanagment-roles
mgr/dashboard: carbonize user management-role form
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: nmunet <NOT@FOUND>
Aashish Sharma [Thu, 26 Sep 2024 06:03:46 +0000 (11:33 +0530)]
Merge pull request #59194 from rhcs-dashboard/add-ssl-prometheus-federate
mgr/dashboard: Add ssl prometheus federate
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
N Balachandran [Thu, 26 Sep 2024 04:16:56 +0000 (09:46 +0530)]
doc: fix typo
Fixed a typo in the jaeger traces documentation.
Signed-off-by: N Balachandran <nibalach@redhat.com>
Nizamudeen A [Thu, 26 Sep 2024 03:57:08 +0000 (09:27 +0530)]
Merge pull request #58719 from rhcs-dashboard/add-progress-multisite-automation
mgr/dashboard: Add progress step to multisite automation wizard
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Patrick Donnelly [Wed, 25 Sep 2024 21:03:09 +0000 (17:03 -0400)]
Merge PR #56776 into main
* refs/pull/56776/head:
client: fix d_reclen for readdir
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 25 Sep 2024 21:02:41 +0000 (17:02 -0400)]
Merge PR #59467 into main
* refs/pull/59467/head:
qa: correct daemon for warning conf
qa: print config dump after setting
Reviewed-by: Adam King <adking@redhat.com>
Patrick Donnelly [Wed, 25 Sep 2024 21:02:13 +0000 (17:02 -0400)]
Merge PR #59504 into main
* refs/pull/59504/head:
mds: dump next_snap when checking dentry corruption
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 25 Sep 2024 21:01:38 +0000 (17:01 -0400)]
Merge PR #59810 into main
* refs/pull/59810/head:
client: remove hypertable
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Laura Flores [Wed, 25 Sep 2024 20:28:15 +0000 (15:28 -0500)]
doc/_ext: accomodate three active releases in the Ceph timeline
Avoid this error:
```
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/releases/index.rst:64: ERROR: Error in "ceph_timeline" directive:
maximum 3 argument(s) allowed, 4 supplied.
```
Signed-off-by: Laura Flores <lflores@ibm.com>
Patrick Donnelly [Wed, 28 Aug 2024 03:07:48 +0000 (23:07 -0400)]
mds: do not duplicate journaler write heads
The MDS can unnecessarily write out the journaler head multiple times. Check
the last_written Header to see if it's necessary to write and gather waiters.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 28 Aug 2024 03:07:00 +0000 (23:07 -0400)]
mds: use Journaler getters
To access the Journaler::Header safely.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 28 Aug 2024 03:05:11 +0000 (23:05 -0400)]
osdc: properly acquire locks for getters
This was left as a TODO. : /
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 28 Aug 2024 03:03:33 +0000 (23:03 -0400)]
osdc: add print method for Journaler::Header
For dout prints.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 27 Aug 2024 21:07:06 +0000 (17:07 -0400)]
mds: do not trim segments after open file table commit
Previously, the trimming of expired segments would only occur if the open file
table's committed sequence number is past the segment to be trimmed. This is
now part of the expiry checks so it's no longer necessary to restart trimming
when the open file table commit completes.
Furthermore, this was confusing to `flush journal` as it was waiting for the
journal head write but the open file table commit already triggered the trim.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 27 Aug 2024 17:50:55 +0000 (13:50 -0400)]
mds: delay expiry if LogSegment is ahead of committed oft seq
And remove the misplaced conditional in ::trim_expiring_segments.
This is necessary as the `flush journal` command gets confused by missing a
wait_for_expiry on a LogSegment that is not actually expired.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 14 Aug 2024 19:24:51 +0000 (15:24 -0400)]
mds: do not write journal head twice on trim
Add context to wait for MDLog::trim_expired_segments to write the journal head.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 14 Aug 2024 18:45:53 +0000 (14:45 -0400)]
mds: simplify and explain expiry finisher ctx
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 30 Jul 2024 20:40:06 +0000 (16:40 -0400)]
mds: add mds_lock asserts for journal flush
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 30 Jul 2024 20:28:33 +0000 (16:28 -0400)]
mds: skip second wait_for_safe
Now that we only trim up to the segment created for the flush, this second wait
should no longer be necessary.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 30 Jul 2024 20:19:32 +0000 (16:19 -0400)]
mds: trim only to the LogSegment created for flush
This neatly avoids a situation where the MDS trims past the segment created for
the `flush journal` command.
Here's what it looks like:
2024-07-30T20:15:51.679+0000
7f70a809a640 1 mds.d asok_command: flush journal {prefix=flush journal} (starting...)
2024-07-30T20:15:51.679+0000
7f70a809a640 10 mds.1.26 handle_asok_command: flush journal
2024-07-30T20:15:51.679+0000
7f70a809a640 20 mds.1.26 send
2024-07-30T20:15:51.679+0000
7f70a809a640 20 mds.1.26 flush_mdlog
2024-07-30T20:15:51.679+0000
7f70a809a640 10 mds.1.cache create_subtree_map 106 subtrees, 105 fullauth
...
2024-07-30T20:15:51.680+0000
7f70a809a640 20 mds.1.log _submit_entry ESubtreeMap 105 subtrees , 0 ambiguous [metablob 0x101, 107 dirs]
2024-07-30T20:15:51.680+0000
7f70a809a640 20 mds.1.log _start_new_segment: seq = 522843 starting new segment LogSegment(522843/0xffffffffffffffff events=0)
...
2024-07-30T20:15:51.686+0000
7f709e887640 20 mds.1.26 handle_clear_mdlog: r=0
2024-07-30T20:15:51.686+0000
7f709e887640 5 mds.1.26 trim_mdlog: beginning segment expiry
2024-07-30T20:15:51.686+0000
7f709e887640 10 mds.1.log trim_to: 522843 23/0/0
...
2024-07-30T20:15:51.858+0000
7f709e887640 20 mds.1.26 expire_segments
2024-07-30T20:15:51.858+0000
7f709e887640 5 mds.1.26 expire_segments: waiting for 22 segments to expire
...
2024-07-30T20:15:52.386+0000
7f70a008a640 20 mds.1.26 handle_expire_segments: r=0
2024-07-30T20:15:52.386+0000
7f70a008a640 20 mds.1.26 trim_segments
2024-07-30T20:15:52.386+0000
7f709e887640 5 mds.1.26 trim_expired_segments: expiry complete, expire_pos/trim_pos is now
22f4c774 /
22c00000
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(503314/0x22f4c774 events=649)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(503314/0x22f4c774 events=649)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(503963/0x230019e6 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(503963/0x230019e6 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(504987/0x23119d93 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(504987/0x23119d93 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(506011/0x23234d24 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(506011/0x23234d24 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(507035/0x23392678 events=397)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(507035/0x23392678 events=397)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(507432/0x23400db4 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(507432/0x23400db4 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(508456/0x2351c0af events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(508456/0x2351c0af events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(509480/0x23639df0 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(509480/0x23639df0 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(510504/0x2375912d events=607)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(510504/0x2375912d events=607)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(511111/0x2380290f events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(511111/0x2380290f events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(512135/0x2391b7f3 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(512135/0x2391b7f3 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(513159/0x23a6a15f events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(513159/0x23a6a15f events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(514183/0x23b855e7 events=442)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(514183/0x23b855e7 events=442)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(514625/0x23c01325 events=979)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(514625/0x23c01325 events=979)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(515604/0x23d0e086 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: expiring up to this major segment seq=515604
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(503314/0x22f4c774 events=649)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(503963/0x230019e6 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(504987/0x23119d93 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(506011/0x23234d24 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(507035/0x23392678 events=397)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(507432/0x23400db4 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(508456/0x2351c0af events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(509480/0x23639df0 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(510504/0x2375912d events=607)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(511111/0x2380290f events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(512135/0x2391b7f3 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(513159/0x23a6a15f events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(514183/0x23b855e7 events=442)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(514625/0x23c01325 events=979)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(515604/0x23d0e086 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(516628/0x23e2a879 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(516628/0x23e2a879 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(517652/0x23f47dbf events=665)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(517652/0x23f47dbf events=665)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(518317/0x240007be events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(518317/0x240007be events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(519341/0x2411af83 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(519341/0x2411af83 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(520365/0x24234a83 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(520365/0x24234a83 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(521389/0x24344292 events=691)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(521389/0x24344292 events=691)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(522080/0x24400e24 events=763)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: maybe expiring LogSegment(522080/0x24400e24 events=763)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: examining LogSegment(522843/0x244c4fda events=1)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments: expiring up to this major segment seq=522843
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(515604/0x23d0e086 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(516628/0x23e2a879 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(517652/0x23f47dbf events=665)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(518317/0x240007be events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(519341/0x2411af83 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(520365/0x24234a83 events=1024)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(521389/0x24344292 events=691)
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.log _trim_expired_segments: expiring LogSegment(522080/0x24400e24 events=763)
2024-07-30T20:15:52.386+0000
7f709e887640 10 mds.1.log _trim_expired_segments waiting for expiry LogSegment(522843/0x244c4fda events=1)
2024-07-30T20:15:52.386+0000
7f709e887640 1 -- [v2:127.0.0.1:6872/
1197350146 ,v1:127.0.0.1:6873/
1197350146 ] --> [v2:127.0.0.1:6850/
2027314847 ,v1:127.0.0.1:6851/
2027314847 ] -- osd_op(unknown.0.26:131573 2.7 2:
ea85266a :::201.
00000000 :head [writefull 0~90 [fadvise_dontneed] in=90b] snapc 0=[] ondisk+write+known_if_redirected+full_force+supports_pool_eio e76) -- 0x555daee1ac00 con 0x555da2bc7180
2024-07-30T20:15:52.386+0000
7f709e887640 5 mds.1.26 trim_expired_segments: trim complete, expire_pos/trim_pos is now
244c4fda /
22c00000
2024-07-30T20:15:52.386+0000
7f709e887640 20 mds.1.26 write_journal_head
Related-to: https://tracker.ceph.com/issues/59119
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 30 Jul 2024 20:18:39 +0000 (16:18 -0400)]
mds: allow passing explicit seq to trim to
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 27 Aug 2024 17:49:42 +0000 (13:49 -0400)]
mds: quiet unhelpful debug message
looks like
2024-08-15T06:08:36.056+0000
7f29379f4640 10 mds.0.journal try_to_expire waiting for purge of []
Nothing to purge!
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 27 Aug 2024 20:03:05 +0000 (16:03 -0400)]
mds: add C_IO_Wrapper completion debugging
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 30 Jul 2024 20:17:54 +0000 (16:17 -0400)]
mds: add dout for new segment
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Laura Flores [Wed, 25 Sep 2024 17:36:28 +0000 (12:36 -0500)]
doc/releases: add fixes
Signed-off-by: Laura Flores <lflores@ibm.com>
Dnyaneshwari [Tue, 24 Sep 2024 06:23:01 +0000 (11:53 +0530)]
mgr/dashboard: Forbid snapshot name "." and any containing "/".
Fixes: https://tracker.ceph.com/issues/68198
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
Ilya Dryomov [Wed, 25 Sep 2024 15:59:04 +0000 (17:59 +0200)]
Merge pull request #59959 from idryomov/wip-librbd-supports-group-snap-get-info-define
librbd: add LIBRBD_SUPPORTS_GROUP_SNAP_GET_INFO define
Reviewed-by: N Balachandran <nibalach@redhat.com>