Merge pull request #14456 from tchaikov/wip-rocksdb-freebsd-build

rocksdb: sync with upstream

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #14609 from linuxbox2/wip-rgw-file-wattrs

rgw_file:  pre-compute unix attrs in write_finish()

Merge pull request #14488 from dzafman/wip-15789

Give requested scrub work a higher priority

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14600 from tchaikov/wip-19390

debian: package ceph.logroate properly

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

rgw_file:  pre-compute unix attrs in write_finish()

New serialized Unix attrs need to reflect the change being made,
and should be reverted if the change fails.

Fixes: http://tracker.ceph.com/issues/19653
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #14396 from jcsp/wip-19550

qa: re-enable ENOSPC tests for kclient

Merge pull request #14589 from jcsp/wip-19640

client: refine fsync/close writeback error handling

Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #14272 from jcsp/wip-vstart-fixup

qa: fix test_standby_for_invalid_fscid with vstart_runner

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #14196 from jcsp/wip-cephfs-relnotes

PendingReleaseNotes: recent cephfs changes

Merge pull request #14105 from jcsp/wip-pretty-tell

mds: pretty json from `tell` commands

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #14104 from jcsp/wip-18509

mds: include advisory `path` field in damage

Reviewed-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #14164 from jcsp/wip-16842-mitigation

Mitigation for #16842, validate sessions after load

Reviewed-by: Yan, Zheng <zyan@redhat.com>

client: refine fsync/close writeback error handling

Previously, errors stuck indelibly to the inode, which
meant that a close call would see an error even if the
user already dutifully fsync()'d and handled it.

We should emit each error only once per file handle.

Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #14585 from optimistyzy/414

bluestore/NVMEDEVICE: update SPDK to version 17.03

Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge pull request #12535 from ceph/wip-rgw-multisite-teuthology

rgw: multisite enabled over multiple clusters
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14555 from yaozongyou/fix-readme-notconsistent

README.md: fix build instructions inconsistent.

Reviewed-by: Kefu Chai <kchai@redhat.com>

debian: package ceph.logroate properly

see also "man dh_installlogrotate"

Fixes: http://tracker.ceph.com/issues/19390
Signed-off-by: Kefu Chai <kchai@redhat.com>

bluestore/NVMEDEVICE: update SPDK to version 17.03

Do some minor changes:

1 Restrict the total DPDK memory used by an osd instance.
change the name from bluestore_spdk_socket_mem to
bluestore_spdk_mem.

2 use spdk_env_init instead of rte_eal_init. The reason is that
SPDK lib invokes rte_eal_init which reduces the initilization
paramter conversion and check, also spdk 17.03 invokes
spdk_vtophys_register_dpdk_mem() (which is an internal function)
in spdk_env_init, and this func must be called.

Signed-off-by: optimistyzy <optimistyzy@gmail.com>

osd: Give requested scrub work a higher priority

Once started we now queue scrub work at higher priority than
scheduled scrubs.

Fixes: http://tracker.ceph.com/issues/15789
Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #14591 from tchaikov/wip-readme-headings

README.md: use github heading syntax to mark the headings

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #13968 from dzafman/wip-15912-followon

osd,mon: misc full fixes and cleanups

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14440 from liewegas/wip-status-flags

osd/OSDMap: hide require_*_osd and sortbitwise flags

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

test: Test health check output for full ratios

Test out of order ratios summary and details
Test various full osd conditions summary and details

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #14561 from linuxbox2/wip-rgw-reread-dir

rgw_file: fix readdir after dirent-change

README.md: use github heading syntax to mark the headings

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14466 from fangyuxiangGL/bi

rgw: bucket stats display bucket index type

Reviewed-by: liuchang0812 <liuchang0812@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

mon, osd: Add detailed full information for now in the mon

Show ceph health doc output in the correct order

Signed-off-by: David Zafman <dzafman@redhat.com>

mon: Issue warning or error if a full ratio out of order

The full ratios should be in this order: nearfull, backfillfull, full, failsafe full

Signed-off-by: David Zafman <dzafman@redhat.com>

mon: Always fix-up full ratios when specified incorrectly in config

Signed-off-by: David Zafman <dzafman@redhat.com>

mon: Use currently configure full ratio to determine available space

This is a bug that would not adjust available space based on the
currently configured full ratio, but rather the mon_osd_full_ratio
default initial value.

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: check_full_status() remove bogus comment and use equivalent computation

We actually compute kb_used as the kb - kb_avail.  We don't have the
statfs() system call issue of non-privileged f_bavail vs f_bfree.  It
was assumed that used was really like (blocks - f_bfree).  It is not.

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Check whether any OSD is full before starting recovery

Add event RecoveryTooFull to move to NotRecovering state

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Add PG state and flag for too full for recovery

New state machine state NotRecovering
New PG state PG_STATE_RECOVERY_TOOFULL

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Add check_osdmap_full() to check for shard OSD fullness

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Rename backfill_request_* to recovery_request_*

To be used by both recovery and backfill

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Check failsafe full and crash on push/pull

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Revamp injectfull op to support all full states

Use check_* for injectable full checks
Use is_* to just test simple cur_state

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Handle backfillfull_ratio just like nearfull and full

Add BACKFILLFULL as a local OSD cur_state
Notify monitor of this new fullness state

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: For testing full disks add injectfull socket command

Signed-off-by: David Zafman <dzafman@redhat.com>

common: Bump ratio for backfillfull from 85% to 90%

Signed-off-by: David Zafman <dzafman@redhat.com>

common: Remove unused config option osd_recovery_threads

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: too_full_for_backfill() returns ostream for reason

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Fail-safe full is a hard stop even for mds

We can't allow OSD to become non-startable even if mds
could be writing as part of file removals.

Signed-off-by: David Zafman <dzafman@redhat.com>

test: Fix intended test flow and restore nearfull-ratio

This is inconsequential but seems to have always been wrong since original
commit 6cafb0e3e0bc5f992c2483a46cb00e83dca035cc

Signed-off-by: David Zafman <dzafman@redhat.com>

test: Switch from pg to osd for set-*-ratio commands

Testing of 6422e0a220fb3f32ccae50e0c7e52dc9984685c6

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Remove unused argument to clear_queued_recovery

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Increase osd_backfill_retry_interval to 30 seconds

Signed-off-by: David Zafman <dzafman@redhat.com>

ceph-objectstore-tool: cleanup comment

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Fix log message

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #12536 from ilc/cls_rgw_minor_refactor

cls/rgw: Clean up the "magic string" usage in the cls layer for RGW.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #14046 from songbaisen/m7

mgr: optimization some judgment and adjust the debug remove value in register_new_pgs

Reviewed-by: John Spray <john.spray@redhat.com>

mgr: optimization some judgment and adjust the debug remove value in register_new_pgs

Signed-off-by: song baisen <song.baisen@zte.com.cn>

Merge pull request #14267 from yunfeiguan/master

cephfs: fix mount point break off problem after mds switch occured

Reviewed-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #13587 from yanghonggang/master

cephfs: fix write_buf's _len overflow problem

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #13522 from singler/wip-reconnect-client

client/Client.cc: after reset session from MDS - reconnect

Reviewed-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #13466 from jcsp/wip-cephfs-ecoverwrites

Add test for is_hacky_ecoverwrites in cephfs pool checks

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14207 from jcsp/wip-19401

mds: ignore ENOENT on writing backtrace

Reviewed-by: Yan, Zheng <zyan@redhat.com>

rgw_file: fix readdir after dirent-change

Also, fixes link count computation off-by-one, update of state.nlink
after computation, link computation reset at start, and a time print
in debug log.

Fixes: http://tracker.ceph.com/issues/19634
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
link count

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #13579 from ukernel/wip-19022

client: drop cap snaps when auth mds session gets closed

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #14490 from liewegas/wip-no-luminous

mon: add mon_debug_no_require_luminous

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14553 from guihecheng/rgw_file-revert

rgw_file: fix up potential race condition

verified f23

Merge pull request #14546 from dachary/wip-19628-directory-boot

ceph-disk: enable directory backed OSD at boot time

Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/suites/rados/thrash: do not thrash cluster full without luminous flag

The interface changes with the luminous flag; this will fail.

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/rados: expand other collections with no-require-luminous

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14551 from tchaikov/wip-19584

mon/OSDMonitor: transit creating_pgs from pgmap when upgrading

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14435 from liewegas/wip-bluestore-deferred

os/bluestore: tune deferred_batch_ops separately for hdd and ssd

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>

Merge pull request #14489 from liewegas/wip-bluestore-fix-flush

os/bluestore: fix narrow osr->flush() race

mon/OSDMonitor: require_luminous_osds for pg-remap[-items]

Signed-off-by: Sage Weil <sage@redhat.com>

Fix build instructions inconsistent.

Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>

ceph-disk: enable directory backed OSD at boot time

https://github.com/ceph/ceph/commit/539385b143feee3905dceaf7a8faaced42f2d3c6
introduced a regression preventing directory backed OSD from starting at
boot time.

For device backed OSD the boot sequence starts with ceph-disk@.service
and proceeds to

    systemctl enable --runtime ceph-osd@.service

where the --runtime ensure ceph-osd@12 is removed when the machine
reboots so that it does not compete with the ceph-disk@/dev/sdb1 unit at
boot time.

However directory backed OSD solely rely on the ceph-osd@.service unit
to start at boot time and will therefore fail to boot.

The --runtime flag is selectively set for device backed OSD only.

Fixes: http://tracker.ceph.com/issues/19628
Signed-off-by: Loic Dachary <loic@dachary.org>

rgw_file: add locks to fix potential race

Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>

Merge pull request #13859 from jcsp/wip-19204

mds: shut down finisher before objecter

Reviewed-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #14505 from jcsp/wip-19566

mds: fix mgrc shutdown

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #14398 from jcsp/wip-19551

mon: emit cluster log messages on MDS health changes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

qa: add log whitelists for MDS health messages

Now that we send these to the cluster log, we must
whitelist them in the tests that exercise those
unhealthy states.

Fixes: http://tracker.ceph.com/issues/19551
Signed-off-by: John Spray <john.spray@redhat.com>

mon/OSDMonitor: transit creating_pgs from pgmap when upgrading

there could be some pg(s) still being created when we are upgrading to
luminous, and the pools holding them are not changed in the sense of
pg_pool_t::last_change after the upgrade and before we scan for
creating pgs. in that case, the existing update_pending_creatings()
will fail to collect the pgs being created before the upgrade.

with this change, the creating_pgs in pgmap are also used for updating
the OSDMonitor's creating_pgs if it's updated.

but we should stopupdating the pgmap once the upgrade completes. i.e.
stop dispatching MSG_PGSTATS messages to PGMonitor if the quorum and all
osds are luminous.

Fixes: http://tracker.ceph.com/issues/19584
Signed-off-by: Kefu Chai <kchai@redhat.com>

Revert "rgw_file.h: fix potential data race condition"

This reverts commit 3f7b411e1e304e8a6f295dc50b8cf3c6c496f4cc.
Causing hung up due to double lock.

Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>

Merge pull request #10851 from atheism/rgw-s3-doc-update

doc/radosgw/s3/cpp.rst: update usage of libs3 APIs to make the examples work

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14469 from badone/wip-return-error-on-missing-client-id

mds: Return error message instead of asserting

Reviewed-by: John Spray <john.spray@redhat.com>

mon/OSDMonitor: slightly better debug output

Signed-off-by: Sage Weil <sage@redhat.com>

mon/OSDMonitor: fix creating pg trimming during upgrade

The creating pgs are in the PGMap with the CREATING
state bit set.

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/rados: require_luminous_osds at end of run, then scrub

Signed-off-by: Sage Weil <sage@redhat.com>

qa/tasks/exec_on_cleanup.py: add

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14508 from smithfarm/wip-doc-dev

doc: dev guide: how to run s3-tests locally against vstart

Reviewed-by: Loic Dachary <ldachary@redhat.com>

os/bluestore: tune deferred_batch_ops separately for hdd and ssd

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14420 from optimistyzy/329

os/bluestore/NVMEDevice: Add multiple thread support for SPDK I/O thread

Reviewed-by: Haomai Wang <haomai@xsky.com>

doc: dev guide: how to run s3-tests locally against vstart

Add a bunch of verbiage to the Developer Guide

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #14458 from linuxbox2/wip-rgw_file-readahead

rgw_file: support readdir cb type hints (plus fixes)

mds: shut down finisher before objecter

Some of the finisher contexts would try to call into Objecter.
We mostly are protected from this by mds_lock+the stopping
flag, but at the Filer level there's no mds_lock, so in the
case of file size probing we have a problem.

Fixes: http://tracker.ceph.com/issues/19204
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #13966 from jcsp/wip-client-logmsg

client: specify inode in get_caps log message

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #14087 from jcsp/wip-doc-fscid

doc: how to specify filesystem for cephfs clients

Reviewed-by: Yan, Zheng <zyan@redhat.com>

mds: include advisory `path` field in damage

This will just be whatever path we were looking
at at the point that damage was notified -- no
intention whatsoever of providing any up to date
path or resolution when there are multiple paths
to an inode.

Fixes: http://tracker.ceph.com/issues/18509
Signed-off-by: John Spray <john.spray@redhat.com>

mds: validate prealloc_inos on sessions after load

Mitigates http://tracker.ceph.com/issues/16842

Signed-off-by: John Spray <john.spray@redhat.com>

mds: operator<< for Session

Use this to get a nice human readable name
when available (also including the session id in
parentheses)

Signed-off-by: John Spray <john.spray@redhat.com>

mds: pretty json from `tell` commands

The overhead of the whitespace is trivial and
makes the output somewhat human readable.  Previously
I was always taking `damage ls` into a file and
parsing it out with python.

Signed-off-by: John Spray <john.spray@redhat.com>

PendingReleaseNotes: recent cephfs changes

Signed-off-by: John Spray <john.spray@redhat.com>

mds: ignore ENOENT on writing backtrace

We get ENOENT when a pool doesn't exist.  This can
happen because we don't prevent people deleting
former cephfs data pools whose files may not have
had their metadata flushed yet.

http://tracker.ceph.com/issues/19401
Signed-off-by: John Spray <john.spray@redhat.com>

rgw multisite: use get_config_master_client for radosgw_admin task

Signed-off-by: Ali Maredia <amaredia@redhat.com>

rgw: multisite enabled over multiple clusters

Added '--cluster' to all necessary commands
ex: radosgw-admin, rados, ceph, made sure
necessary checks were in place so that clients
can be read with our without a cluster_name
preceeding them

Made master_client defined in the config for
radosgw-admin task

Signed-off-by: Ali Maredia <amaredia@redhat.com>

rgw_file: don't expire directories being read

If a readdir expire event turns out to be older than last_readdir,
just reschedule it (but actually, we should just discard it, as
another expire event must be in queue.

Fixes: http://tracker.ceph.com/issues/19625
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>