supervisor.reimage: Change error message wording

Signed-off-by: Zack Cerza <zack@cerza.org>

lock.ops.lock_many: Unlock on reimage failure

Signed-off-by: Zack Cerza <zack@cerza.org>

task/install: don't attempt to handle strings for extra_system_packages

To the best of my knowledge, extra_system_packages has never accepted
a string as a value -- whether at the top level (i.e. on the install
task itself) or on a particular project (e.g. ceph).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

task/install: extra_system_packages at the top level can be a list

Commit fc5a3197f22e ("task/install: allow both list and dicts for
extra_system_packages") introduced a regression for job definitions
where extra_system_packages at the top level (i.e. on the install
task itself) is a list.  For example

  overrides:
    install:
      ceph:
        flavor: default
        sha1: b7d57fefbec68934ae5e6e7d7c48ac09182397a5
      extra_system_packages:
      - pv

produces AssertionError on

  assert isinstance(b, dict)

in deep_merge() when it's called from _override_extra_system_packages().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

orchestra/test: drop opensuse 42.2 from opsys

Signed-off-by: Kyrylo Shatskyy <kyrylo.shatskyy@gmail.com>

packaging: fix test for distro version

Signed-off-by: Kyrylo Shatskyy <kyrylo.shatskyy@clyso.com>

orchestra/opsys: update suse related versions

Signed-off-by: Kyrylo Shatskyy <kyrylo.shatskyy@clyso.com>

cargo-cult some packaging updates for rocky

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

task/install/rpm: don't use builder when using custom repos

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>

task/install/rpm: add/remove yum repos

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>

orchestra/opsys: alma and rocky are rpm distro

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>

task/install: allow both list and dicts for extra_system_packages

Fixes: https://tracker.ceph.com/issues/73527
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>

Openstack: handle attached_volumes field when fetching volumes

Some clouds use attached_volumes instead of os-extended-volumes:volumes_attached

Signed-off-by: deepssin <deepssin@redhat.com>

orchestra/console.py: increase 'power status' timeout

in set_power() we check to see if the power operation worked by
examining ipmi power status.  Give longer than 1s for the
status command to complete.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

lock.ops.unlock_one_safe: Invert run-match logic

When unlock_one_safe is called with run_name, the caller means to express
"unlock this node if it belongs to this run".
When it is called with run_name and job_id, it means "unlock this node if it
belongs to this job in this run".
We had inverted the logic, causing leaks on reimage failures.

Signed-off-by: Zack Cerza <zack@cerza.org>