mds: make encode_lease a proper method

So we can print debugging.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

mds: add fscrypt metadata for inode stat size

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client: use DentryRef for ref counting in MetaRequest

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client: add DentryRef

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client: add helper for determining if a perm check is necessary

To be used in subsequent commits.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client: cache client_permissions config

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client: add debugging for conf changes

So logs show when they are modified.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: sort configs

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client/UserPerm: add print method

For debug prints.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

client: note mount parameters in debug log

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: print stat mode in octal

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

common: add missing op string

This gets converted in messenger douts.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

include/filepath: add empty path check

When passing an empty string to filepath, it would test if the first character
is '/' which is an invalid access through std::string_view.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/66373

Merge PR #61991 into main

* refs/pull/61991/head:
qa: remove unreacheable/redundant code from test_data_scan.py

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #62019 from ceph/template-updates

Links to Jenkins jobs in PR comment commands / Remove deprecated commands

Merge pull request #61863 from spuiuk/ctdb_ports

cephadm/smb: add ctdb ports to smb daemon endpoint

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61925 from JoshuaGabriel/joshua_70058

mgr/cephadm: Check if a daemon is ok-to-stop before scheduling a restart

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61897 from cbodley/wip-70077

qa/rgw: configure 'iam root' accounts outside of rgw/verify

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #61920 from adk3798/cephadm-rgw-ingress-test-timeouts

qa/cephadm: add timeouts and debug commands to rgw-ingress test

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61710 from adk3798/mgr-nfs-upgrade-start-reef

qa/cephadm: start mgr-nfs-upgrade test from reef

Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #61013 from Kushal-deb/fix_issue-2047153

cephadm: orch upgrade status to return output according to the format specified

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61504 from kchheda3/wip-fix-healthchecks

rgw:lua: Skip the healthchecks and system requests from going to backend storage

Merge pull request #61509 from kchheda3/wip-config-lua

rgw/lua: Add rgw config to enable/disable lua

Merge pull request #61560 from oshrey16/fix-lua-runtime-background

rgw/lua: Fix Lua background thread execution timing and config updates

Merge pull request #61938 from ceph/retrigger-rtd

doc: Support to retrigger docs/readthedocs.org:ceph PR build

doc: PR Template - Remove non-functional trigger phrases

Signed-off-by: David Galloway <david.galloway@ibm.com>

doc: PR Template - Add Jenkins job URLs to commands

Signed-off-by: David Galloway <david.galloway@ibm.com>

Merge pull request #61822 from rhcs-dashboard/smb-edit-cluster

mgr/dashboard: SMB - Edit Cluster

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

Merge pull request #61815 from ljflores/wip-tracker-69456

qa/suites/upgrade: ignore when pg is stuck peering

Merge pull request #61703 from MaxKellermann/kstore_includes

os/kstore: add missing include

Merge pull request #61674 from connorfawcett/wip-ec-default-fixes

erasure-code: Set reed_sol_van to be the default technique for Jerasure if none is specified.

Merge pull request #61015 from nbalacha/wip-nbalacha-rbd-mirror-namespace-2

rbd-mirror: default <-> non-default namespace remapping

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61269 from cbodley/wip-rgw-createbucket-layout

rgw/s3: CreateBucket extension for layout type and shard count

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #61982 from anthonyeleven/nvme-proxy

doc/rbd: Improve nvmeof-requirements.rst with proxy and other info

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #60524 from thotz/multisitie-fix-cloud-restore

rgw/cloudrestore: sync cloud restore objects accoridngly

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #61849 from yuvalif/wip-yuval-69944

rgw: be explicit on moving rados op in APIs

Merge pull request #61376 from athanatos/sjust/wip-crimson-gcc-13

src/CMakeLists: require gcc13 for crimson, clarify error messages

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #61846 from rhcs-dashboard/tox-generate-proto

mgr/dashboard: tox command to generate the nvmeof proto files

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #61903 from ronen-fr/wip-rf-crimson-conf

crimson/osd: replace obsolete get_tracked_conf_keys()

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #62001 from cybozu/fix-stale-delete

doc: fix incorrect radosgw-admin subcommand

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #60871 from leonidc/leonidc-epoch-filter

Epoch filtering

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

doc: fix incorrect radosgw-admin subcommand

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>

Merge PR #61889 into main

* refs/pull/61889/head:
msg/async/Stack: include cleanup
msg/Message: include cleanup
msg/async/crypto_onwire: include cleanup
msg/async/ProtocolV1: add missing includes
msg/async/frames_v2: add missing includes
msg/msg_types: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61888 into main

* refs/pull/61888/head:
os/memstore: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61876 into main

* refs/pull/61876/head:
qa/cephfs: ignore warning that pg is stuck peering for upgrade jobs

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61802 into main

* refs/pull/61802/head:
perfglue: add missing include

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61801 into main

* refs/pull/61801/head:
kv: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61799 into main

* refs/pull/61799/head:
erasure-code: add missing include

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61798 into main

* refs/pull/61798/head:
crush: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #61955 from idryomov/wip-70075-test

qa/workunits/rbd: add a test for force promote with a user snapshot

Reviewed-by: N Balachandran <nibalach@redhat.com>

rgw: reject PutBucketLifecycleConfiguration on indexless buckets

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: improved error when listing indexless bucket

without this change, ListObjects would attempt to list index shard
objects that don't exist and fail with:

> ERROR: S3 error: 404 (NoSuchKey)

after:

> ERROR: S3 error: 405 (MethodNotAllowed): Indexless buckets cannot be listed

Signed-off-by: Casey Bodley <cbodley@redhat.com>

examples/rgw: register boto extension for BucketIndex on CreateBucket

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw/s3: CreateBucket extension for layout type and shard count

extend s3's CreateBucketConfiguration [1] with a custom BucketIndex element
that can override rgw's default bucket index type and shard count

to create an indexless bucket:
  <CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <BucketIndex>
      <Type>Indexless</Type>
    </BucketIndex>
  </CreateBucketConfiguration>

to create a normal pre-sharded bucket:
  <CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <BucketIndex>
      <Type>Normal</Type>
      <NumShards>1023</NumShards>
    </BucketIndex>
  </CreateBucketConfiguration>

[1] https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html#API_CreateBucket_RequestSyntax

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw/rados: create_bucket() can override index type and shards

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw/rados: indexless buckets skip init_index/clean_index

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw/s3: CreateBucket's LocationConstraint is optional

clean up the parsing and make the LocationConstraint optional

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61740 from Matan-B/wip-matanb-clang-16

script/run-make: clang 14->19

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #61319 from rhcs-dashboard/gklm-kmip

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61619 from ronen-fr/wip-rf-more-keys

rgw: replace obsolete get_tracked_conf_keys()
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

mgr/dashboard: SMB - Edit Cluster
Fixes: https://tracker.ceph.com/issues/69964
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

qa: remove unreacheable/redundant code from test_data_scan.py

call to self.fs.journal_tool(["journal", "reset", "--force", "--yes-i-really-really-mean-it"], 0)
is already made below it, the same call under if False is unreachable.

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #61928 from rhcs-dashboard/smb-share-edit

mgr/dashboard: SMB - Edit Share

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

Merge pull request #61976 from guits/cv-update-batch-unit-tests

ceph-volume: update lvm batch unit tests

Merge pull request #61985 from zdover23/wip-doc-2025-02-25-releases-squid-order

doc/releases: correct squid release order

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61788 from VallariAg/wip-nvmeof-teuthology-improve

qa/suite/nvmeof: Add asserts to scalability_test and extra logs in fio_test

Merge pull request #61984 from cbodley/wip-doc-rgw-path-style

doc/rgw: clarify path-style vs virtual-hosted-style access

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/releases: correct squid release order

Put the releases of Squid in descending order. This change alters the
order of the Squid releases so that it is the same as the order of the
other Ceph releases.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61875 from rhcs-dashboard/update-bucket-details

mgr/dashboard: Update bucket details section after making bucket lifecycle changes

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: Add GKLM(KMIP) option to SSE-KMS dropdown Menu in the Dashboard UI

Fixes: https://tracker.ceph.com/issues/69490
Signed-off-by: Prachi Goel <prachi.goel@li-25d455cc-279f-11b2-a85c-b097dffa3f04.ibm.com>
Changes for GKLM dropdown UI:

1.Added option kmip in KMS dropdown in configuration page RGW
2.Made API dynamic for setting form data for Vault, kmip both for (S3 and
KMS)
3.Both Getdata and setdata API for RGW config page is modified

mgr/dashboard: SMB - Edit Share.

Fixes: https://tracker.ceph.com/issues/70094
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

Merge PR #61979 into main

* refs/pull/61979/head:
script/ceph-backport: remove upstream remote inferencing

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

doc/rgw: clarify path-style vs virtual-hosted-style access

instead of referring to "vhost-style", copy the "path-style" and
"virtual-hosted-style" language from https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html

expand the FQDN acronym to avoid potential confusion

"The second method is deprecated by AWS" had incorrectly referred to the
vhost-style method - clarify that it refers to path-style access

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge PR #61943 into main

* refs/pull/61943/head:
qa: ignore variant of down fs

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #61792 into main

* refs/pull/61792/head:
libcephsqlite: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61701 into main

* refs/pull/61701/head:
client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61697 into main

* refs/pull/61697/head:
osdc/ObjectCacher: include cleanup
osdc/Objecter: include cleanup
osdc/Journaler: include cleanup
osdc/Striper: add missing includes
osdc/Filer: include cleanup
crush/CrushWrapper: un-inline methods to fix linker errors
client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #61872 into main

* refs/pull/61872/head:
crush/CrushWrapper: un-inline methods to fix linker errors

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #61733 from phlogistonjohn/jjm-ctr-cleaner

container: small container image improvements

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dan Mick <dan.mick@redhat.com>

doc/rbd: Improve nvmeof-requirements.rst with proxy and other info

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #61400 from salieri11/igolikov-wip-fscrypt-68776

client: Use custom fscrypt cli in fs/fscrypt suite

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #61693 from aainscow/interval_set_strict

include: interval_set: Re-introduce the original behaviour strict interval set

Merge pull request #61679 from aclamk/wip-aclamk-fragmentation-histogram-defaults

os/bluestore: Fix default base size for histogram

Merge pull request #61455 from jbaergen-do/limit-discard-qlen-upstream

blk/KernelDevice: Introduce a cap on the number of pending discards

rbd-mirror: default <-> non-default namespace remapping

These changes allow the pool to be configured to disable mirroring on
the default namespace if required (init-only mode). It also allows the
default namespace to be mirrored to a non-default namespace on the
remote pool.

Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: N Balachandran <nibalach@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

python-common: add ctdb port to smb service spec

Signed-off-by: Sachin Prabhu <sp@spui.uk>

cephadm/smb: add ctdb ports to smb daemon endpoint

When setting up a clustered SMB service, make sure that the port for the
ctdb service is opened up on the firewall. This port is used by the ctdb
servers to communicate with each other.

Signed-off-by: Sachin Prabhu <sp@spui.uk>

Merge pull request #59740 from phlogistonjohn/jjm-smb-proxy-sidecar

smb: add support for proxy sidecar

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Sachin Prabhu <sp@spui.uk>

mgr/dashboard: Update bucket details section after making bucket lifecycle changesn

Fixes: https://tracker.ceph.com/issues/69988
Signed-off-by: Naman Munet <naman.munet@ibm.com>

cmake/modules/BuildISAL.cmake: use GNU assembler

avoid the following error by disabling clang assembler:
```
[670/2691] Performing build step for 'isal_ext'
FAILED: src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build src/isa-l/install/lib/libisal.a /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/isa-l/install/lib/libisal.a
cd /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/isa-l && /usr/bin/cmake -P /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build-Debug.cmake && /usr/bin/cmake -E touch /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build
CMake Error at /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build-Debug.cmake:37 (message):
  Command failed: 2

   '/usr/bin/cmake' '-E' 'env' '--unset=DESTDIR' 'make' '-j3'

  See also

    /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/src/erasure-code/isa/isal_ext-prefix/src/isal_ext-stamp/isal_ext-build.log

-- Log output is:
...skipping to end...
hile in macro instantiation
crc64_refl_func crc64_ecma_refl_pmull
^
<instantiation>:2:26: error: unexpected token in argument list
 movk x7, p1_low_b1, lsl 16
                         ^
<instantiation>:54:2: note: while in macro instantiation
 crc64_fold_512b_to_128b
 ^
crc/aarch64/crc64_ecma_refl_pmull.S:33:1: note: while in macro instantiation
crc64_refl_func crc64_ecma_refl_pmull
^
<instantiation>:3:26: error: unexpected token in argument list
 movk x7, p1_low_b2, lsl 32
                         ^
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

src/CMakeLists.txt: -Wno-vla-cxx-extension only on clang >= 18

```
error: unknown warning option '-Wno-vla-cxx-extension'; did you mean '-Wno-vla-extension'? [-Werror,-Wunknown-warning-option]
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #61949 from phlogistonjohn/jjm-c10s

build: a pair of needed changes to build on centos 10 stream

Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>

Merge pull request #61592 from hasan4791/issue-69732

Isolate the absl flags to ceph-mon & ceph-nvmeof-monitor-client targets

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #60213 from NitzanMordhai/wip-nitzan-thrash-old-client-ignore-list

suite: thrash old client ignore list expend

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #55103 from kamoltat/wip-ksirivad-fix-63861

src/mon/OSDMonitor.cc: [Stretch Mode] WRN non-existent CRUSH location assigned to MON

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

script/ceph-backport: remove upstream remote inferencing

It's unnecessary.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

qa/workunits/rbd: add a test for force promote with a user snapshot

Add a reproducer for the crash on a bad variant access which was fixed
in commit 7d75161051da ("librbd: fix a crash in get_rollback_snap_id").

The reproducer deliberately works around many other issues with force
promote in snapshot-based mirroring: stopping rbd-mirror daemon
shouldn't be necessary (let alone with SIGKILL), get_rollback_snap_id()
and its caller can_create_primary_snapshot() are flawed and can pick
the wrong snapshot to roll back to or skip rollback when it's actually
required, the user snapshot in this scenario should be removed as part
of force promoting because it's incomplete and won't be usable after
the image is promoted, etc.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

ceph-volume: update lvm batch unit tests

This adds the recently `has_block_db_size_without_db_devices` attribute to the
mocked `args` object for lvm batch unit tests.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

rgw/cloudtier : disable sync for cloud tier objects

Also modified the modify_obj_attr api to include flags similar to set_obj_attrs

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

Merge pull request #61668 from badone/wip-fix-rados-verify-cluster-selection

qa/suites/rados/verify: Allow selection of 2 or 4 node cluster

Reviewed-by: Laura Flores <lflores@redhat.com>