]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
11 days agoMerge pull request #64237 from Hezko/wip-71884-tentacle
afreen23 [Tue, 8 Jul 2025 03:14:10 +0000 (08:44 +0530)]
Merge pull request #64237 from Hezko/wip-71884-tentacle

tentacle: mgr/dashboard: align response of subsystem add and ns add with old cli

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 days agoMerge pull request #64080 from adk3798/wip-71665-tentacle
Adam King [Mon, 7 Jul 2025 17:18:16 +0000 (13:18 -0400)]
Merge pull request #64080 from adk3798/wip-71665-tentacle

tentacle: src/pybind/mgr/cephadm/service_discovery: fixed HAProxy labels

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 days agoMerge pull request #64078 from adk3798/wip-71196-tentacle
Adam King [Mon, 7 Jul 2025 17:06:54 +0000 (13:06 -0400)]
Merge pull request #64078 from adk3798/wip-71196-tentacle

tentacle: mgr/cephadm: Add command to stop host drain

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 days agoMerge pull request #64209 from shraddhaag/wip-71858-tentacle
Shraddha Agrawal [Mon, 7 Jul 2025 15:48:56 +0000 (21:18 +0530)]
Merge pull request #64209 from shraddhaag/wip-71858-tentacle

tentacle: mon: add command osd pool clear-availability-status

12 days agoMerge pull request #64129 from NitzanMordhai/wip-71799-tentacle
Shraddha Agrawal [Mon, 7 Jul 2025 15:48:42 +0000 (21:18 +0530)]
Merge pull request #64129 from NitzanMordhai/wip-71799-tentacle

tentacle: src/mon/MgrStatMonitor: fix invalid iterator increment in calc_pool_availability()

12 days agoMerge pull request #64064 from aainscow/wip-71717-tentacle
Laura Flores [Mon, 7 Jul 2025 14:55:51 +0000 (10:55 -0400)]
Merge pull request #64064 from aainscow/wip-71717-tentacle

tentacle: osd: Correct scrub analysis for optimised EC

12 days agoMerge pull request #64077 from adk3798/wip-71195-tentacle
Adam King [Mon, 7 Jul 2025 14:31:37 +0000 (10:31 -0400)]
Merge pull request #64077 from adk3798/wip-71195-tentacle

tentacle: mgr/nfs: Add VIP to HAProxy_Hosts list for ingress type haproxy-protocol

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 days agoMerge pull request #64197 from idryomov/wip-71838-tentacle
Sunil Angadi [Mon, 7 Jul 2025 06:24:40 +0000 (11:54 +0530)]
Merge pull request #64197 from idryomov/wip-71838-tentacle

tentacle: librbd/migration/QCOWFormat: don't complete read_clusters() inline

13 days agoMerge pull request #64242 from NitzanMordhai/wip-71867-tentacle
NitzanMordhai [Sun, 6 Jul 2025 11:00:37 +0000 (14:00 +0300)]
Merge pull request #64242 from NitzanMordhai/wip-71867-tentacle

tentacle: test/librados/aio_cxx: skip EIO boundary assertion when no in-flight I/Os

13 days agoMerge pull request #64188 from Matan-B/wip-71821-tentacle
NitzanMordhai [Sun, 6 Jul 2025 08:01:41 +0000 (11:01 +0300)]
Merge pull request #64188 from Matan-B/wip-71821-tentacle

tentacle: src: fix NDEBUG typo

13 days agoMerge pull request #64134 from JonBailey1993/wip-71798-tentacle
NitzanMordhai [Sun, 6 Jul 2025 08:01:26 +0000 (11:01 +0300)]
Merge pull request #64134 from JonBailey1993/wip-71798-tentacle

tentacle: test/osd: Improve readability of errors in ceph_test_rados_io_sequence

13 days agoMerge pull request #63014 from jamiepryde/tentacle-ec-plugins-tidying-nits-and-bits
NitzanMordhai [Sun, 6 Jul 2025 08:01:01 +0000 (11:01 +0300)]
Merge pull request #63014 from jamiepryde/tentacle-ec-plugins-tidying-nits-and-bits

tentacle: erasure-code: reformat EC plugins

13 days agomgr/dashboard: align response of subsystem add and ns add with old cli 64237/head
Tomer Haskalovitch [Tue, 20 May 2025 20:27:43 +0000 (23:27 +0300)]
mgr/dashboard: align response of subsystem add and ns add with old cli

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
(cherry picked from commit 512f2133bd746094bd1cecd9d1e897b79ec3dd6d)
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
13 days agoMerge pull request #64234 from Hezko/wip-71882-tentacle
Hezko [Sun, 6 Jul 2025 07:41:11 +0000 (10:41 +0300)]
Merge pull request #64234 from Hezko/wip-71882-tentacle

tentacle: mgr/dashboard: Nvmeof CLI plain format support

13 days agoMerge pull request #64257 from leonidc/wip-71893-tentacle
leonidc [Sun, 6 Jul 2025 05:33:34 +0000 (08:33 +0300)]
Merge pull request #64257 from leonidc/wip-71893-tentacle

tentacle: fix duplicated entity addr in the map during reboot of several GWs

13 days agoMerge pull request #64258 from leonidc/wip-71894-tentacle
leonidc [Sun, 6 Jul 2025 05:33:07 +0000 (08:33 +0300)]
Merge pull request #64258 from leonidc/wip-71894-tentacle

tentacle: nvmeofgw: fix sending acks during upgrade

2 weeks agomgr/dashboard: add plain output type support to nvme cli 64234/head
Tomer Haskalovitch [Thu, 8 May 2025 08:54:39 +0000 (11:54 +0300)]
mgr/dashboard: add plain output type support to nvme cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 27698aec2b1aedf9124725709e85803213633232)

2 weeks agoMerge pull request #64295 from rhcs-dashboard/sys-packages-dashboard-tentacle
afreen23 [Fri, 4 Jul 2025 08:00:20 +0000 (13:30 +0530)]
Merge pull request #64295 from rhcs-dashboard/sys-packages-dashboard-tentacle

tentacle: mgr/dashboard: use system packages when running tox

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64240 from Hezko/wip-71887-tentacle
afreen23 [Fri, 4 Jul 2025 07:52:25 +0000 (13:22 +0530)]
Merge pull request #64240 from Hezko/wip-71887-tentacle

tentacle: mgr/dashboard: update ceph nvmeof proto files

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64236 from Hezko/wip-71885-tentacle
afreen23 [Fri, 4 Jul 2025 07:52:10 +0000 (13:22 +0530)]
Merge pull request #64236 from Hezko/wip-71885-tentacle

tentacle: mgr/dashboard: align cli commands listener list, ns list, host list

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64342 from zdover23/wip-doc-2025-07-04-backport-63779-to-tentacle
Anthony D'Atri [Thu, 3 Jul 2025 22:36:14 +0000 (18:36 -0400)]
Merge pull request #64342 from zdover23/wip-doc-2025-07-04-backport-63779-to-tentacle

tentacle: doc/mgr: edit telemetry.rst

2 weeks agoMerge pull request #63980 from cbodley/wip-71690-tentacle
Casey Bodley [Thu, 3 Jul 2025 22:16:29 +0000 (18:16 -0400)]
Merge pull request #63980 from cbodley/wip-71690-tentacle

tentacle: test/common: unittest_fault_injector omits unit-main target

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 weeks agoMerge pull request #64337 from zdover23/wip-doc-2025-07-03-backport-64319-to-tentacle
Zac Dover [Thu, 3 Jul 2025 22:14:37 +0000 (08:14 +1000)]
Merge pull request #64337 from zdover23/wip-doc-2025-07-03-backport-64319-to-tentacle

tentacle: doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agodoc/mgr: edit telemetry.rst 64342/head
Zac Dover [Fri, 6 Jun 2025 04:57:19 +0000 (14:57 +1000)]
doc/mgr: edit telemetry.rst

Edit doc/mgr/telemetry.rst.

Incorporate the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63735.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 97ef126e4b6a9dcdf9872cf37cdebec289e84acd)

2 weeks agoMerge pull request #64279 from mkogan1/wip-71906-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:54:45 +0000 (09:54 -0700)]
Merge pull request #64279 from mkogan1/wip-71906-tentacle

tentacle: qa/rgw: fix perl tests missing Amazon::S3 module

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 weeks agoMerge pull request #63929 from cbodley/wip-71672-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:53:57 +0000 (09:53 -0700)]
Merge pull request #63929 from cbodley/wip-71672-tentacle

tentacle: qa/rgw: bump maven version in hadoop task to resolve 404 Not Found

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 weeks agoMerge pull request #63724 from cbodley/wip-71564-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:53:04 +0000 (09:53 -0700)]
Merge pull request #63724 from cbodley/wip-71564-tentacle

tentacle: debian: radosgw: add media-types packages as alternative for mime-support

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 weeks agoMerge pull request #63436 from mkogan1/wip-71420-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:52:21 +0000 (09:52 -0700)]
Merge pull request #63436 from mkogan1/wip-71420-tentacle

tentacle: rgw/d3n: fix valgrind invalid read during exit

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 weeks agoMerge pull request #63362 from cbodley/wip-71376-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:50:46 +0000 (09:50 -0700)]
Merge pull request #63362 from cbodley/wip-71376-tentacle

tentacle: rgw/rgw_rest: determine the domain uri prefix by rgw_transport_is_secure

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 weeks agoMerge pull request #64320 from zdover23/wip-doc-2025-07-03-backport-64306-to-tentacle
Anthony D'Atri [Thu, 3 Jul 2025 14:37:03 +0000 (10:37 -0400)]
Merge pull request #64320 from zdover23/wip-doc-2025-07-03-backport-64306-to-tentacle

tentacle: doc/rados/ops: add caps restore command

2 weeks agodoc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads 64337/head
Zac Dover [Thu, 3 Jul 2025 06:45:31 +0000 (16:45 +1000)]
doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads

Add rgw_enable_lc_threads and rgw_enable_gc_threads to
doc/radosgw/config-ref.rst.

Fixes: https://tracker.ceph.com/issues/58092
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 45e5468ea7fc57b1cb60f1936558dc2678adc6fd)

2 weeks agoMerge pull request #64079 from adk3798/wip-71571-tentacle
Adam King [Thu, 3 Jul 2025 12:43:47 +0000 (08:43 -0400)]
Merge pull request #64079 from adk3798/wip-71571-tentacle

tentacle: cephadm: don't collect image ids for daemons with no container info

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 weeks agoMerge pull request #63444 from JoshuaGabriel/wip-71407-tentacle
Adam King [Thu, 3 Jul 2025 12:39:56 +0000 (08:39 -0400)]
Merge pull request #63444 from JoshuaGabriel/wip-71407-tentacle

tentacle: orch/module: Make orch unpause an alias for orch resume

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2 weeks agomgr/dashboard: catch protobuf error due to mismatch in version 64295/head
Nizamudeen A [Thu, 26 Jun 2025 07:25:22 +0000 (12:55 +0530)]
mgr/dashboard: catch protobuf error due to mismatch in version

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 weeks agomgr/dashboard: unpin grpcio deps
Nizamudeen A [Thu, 26 Jun 2025 04:51:34 +0000 (10:21 +0530)]
mgr/dashboard: unpin grpcio deps

Fixes: https://tracker.ceph.com/issues/70411
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 84922d1ff0f3aae39ecd998b2b94469ce9989c08)

2 weeks agomgr/dashboard: sitepackages only for py3
Nizamudeen A [Mon, 17 Mar 2025 05:10:21 +0000 (10:40 +0530)]
mgr/dashboard: sitepackages only for py3

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 6985ed15ce20c24f7fa87c23ac65b28cf544c9b7)

2 weeks agoRevert "mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure"
Nizamudeen A [Thu, 13 Mar 2025 06:47:41 +0000 (12:17 +0530)]
Revert "mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure"

This reverts commit 1f84505f1232dd8445df1a2a819fa000062d3934.

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8e6b6cdd5c302577c81aa041ef4b3f494ed717a7)

2 weeks agomgr/dashboard: disable saml2 tests when the dep is not there
Nizamudeen A [Wed, 12 Mar 2025 08:32:10 +0000 (14:02 +0530)]
mgr/dashboard: disable saml2 tests when the dep is not there

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8acf8f7e4fe6d283212154857abd97b6e641de4d)

2 weeks agomgr/dashboard: use system packages when running tox
Nizamudeen A [Wed, 12 Mar 2025 05:27:29 +0000 (10:57 +0530)]
mgr/dashboard: use system packages when running tox

Fixes: https://tracker.ceph.com/issues/70411
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit ffde8d044a207d304ec8f916e45c98289f740bec)

2 weeks agodoc/rados/ops: add caps restore command 64320/head
Zac Dover [Wed, 2 Jul 2025 12:29:48 +0000 (22:29 +1000)]
doc/rados/ops: add caps restore command

Add a command that restores caps to client.admin after they have been
accidentally destroyed or removed.

Fixes: https://tracker.ceph.com/issues/23594
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit de8c148a2f99db3a1dc4eb70a19aca19a0e9bacf)

2 weeks agoMerge pull request #64180 from zdover23/wip-doc-2025-06-25-backport-64172-to-tentacle
Zac Dover [Thu, 3 Jul 2025 05:41:13 +0000 (15:41 +1000)]
Merge pull request #64180 from zdover23/wip-doc-2025-06-25-backport-64172-to-tentacle

tentacle: doc/radosgw: line edit bucket_logging.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agoMerge pull request #64314 from zdover23/wip-doc-2025-07-03-backport-63359-to-tentacle
Anthony D'Atri [Thu, 3 Jul 2025 02:02:18 +0000 (22:02 -0400)]
Merge pull request #64314 from zdover23/wip-doc-2025-07-03-backport-63359-to-tentacle

tentacle: doc/radosgw/s3: Document delete-if-unmodified-since

2 weeks agodoc/radosgw/s3: Document delete-if-unmodified-since 64314/head
Anthony D'Atri [Mon, 19 May 2025 14:14:00 +0000 (10:14 -0400)]
doc/radosgw/s3: Document delete-if-unmodified-since

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 3381041d190fd48cf9f6d53f679f1737028cccf4)
(cherry picked from commit 7e2bd1595d64c12e1959cc29acfaf906a9027fc6)

2 weeks agoMerge pull request #64232 from Hezko/wip-71880-tentacle
afreen23 [Wed, 2 Jul 2025 14:38:21 +0000 (20:08 +0530)]
Merge pull request #64232 from Hezko/wip-71880-tentacle

tentacle: mgr/dashboard: Add missing fields to subsytem list API/CLI

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64233 from Hezko/wip-71881-tentacle
afreen23 [Wed, 2 Jul 2025 14:37:03 +0000 (20:07 +0530)]
Merge pull request #64233 from Hezko/wip-71881-tentacle

tentacle: mgr/dashboard: fix set spdk log level cli command

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64146 from zdover23/wip-doc-2025-06-25-backport-64088-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:19:34 +0000 (23:19 +1000)]
Merge pull request #64146 from zdover23/wip-doc-2025-06-25-backport-64088-to-tentacle

tentacle: doc: Fixed a spelling error.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agoMerge pull request #64283 from zdover23/wip-doc-2025-07-01-backport-64239-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:19:05 +0000 (23:19 +1000)]
Merge pull request #64283 from zdover23/wip-doc-2025-07-01-backport-64239-to-tentacle

tentacle: doc/mgr/crash.rst: remove outdated module enabling instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agoMerge pull request #64286 from zdover23/wip-doc-2025-07-01-backport-64255-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:18:02 +0000 (23:18 +1000)]
Merge pull request #64286 from zdover23/wip-doc-2025-07-01-backport-64255-to-tentacle

tentacle: doc/rados/configuration: Small improvements in ceph-conf.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agoMerge pull request #64169 from zdover23/wip-doc-2025-06-25-backport-64163-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:09:53 +0000 (23:09 +1000)]
Merge pull request #64169 from zdover23/wip-doc-2025-06-25-backport-64163-to-tentacle

tentacle: doc: Fix unterminated inline literal in ceph-conf.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agodoc/radosgw: line edit bucket_logging.rst 64180/head
Zac Dover [Wed, 25 Jun 2025 09:19:49 +0000 (19:19 +1000)]
doc/radosgw: line edit bucket_logging.rst

Edit doc/radosgw/bucket_logging.rst so that it is not solecistic and so
that its punctuation is corrected and its use of articles is corrected.
This file remains in my judgment demotic and maybe demotic enough to
warrant another editorial pass in the future.

Fixes: https://tracker.ceph.com/issues/70758
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c01eb372326be49cbb76d602eabba951663979ec)

2 weeks agoMerge pull request #64231 from Hezko/wip-71879-tentacle
afreen23 [Wed, 2 Jul 2025 08:34:46 +0000 (14:04 +0530)]
Merge pull request #64231 from Hezko/wip-71879-tentacle

tentacle: mgr/dashboard: Remove map collection dec

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 weeks agoMerge pull request #64235 from Hezko/wip-71883-tentacle
afreen23 [Wed, 2 Jul 2025 08:22:18 +0000 (13:52 +0530)]
Merge pull request #64235 from Hezko/wip-71883-tentacle

tentacle: mgr/dashboard: align gw info, gw version, spdk_log_level get with old cli

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64076 from adk3798/tentacle-cephadm-guess-name
Adam King [Tue, 1 Jul 2025 15:30:48 +0000 (11:30 -0400)]
Merge pull request #64076 from adk3798/tentacle-cephadm-guess-name

tentacle: cephadm: minor ergonomic improvements for hackers

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 weeks agodoc/rados/configuration: Small improvements in ceph-conf.rst 64286/head
Ville Ojamo [Mon, 30 Jun 2025 07:30:34 +0000 (14:30 +0700)]
doc/rados/configuration: Small improvements in ceph-conf.rst

Fix a missing space typo.

Use title case in section titles.

Use ref for hyperlink to a section that already has a label instead of
linking to title text of the section.

Use privileged command prompt for all ceph commands except ceph commands
that invoke help.

Use INI preformatted block for last remaining block that was just using
plain preformatted.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 6687c9767d9764f34d7099ba6980992dd8ae8737)

2 weeks agodoc/mgr/crash.rst: remove outdated module enabling instructions 64283/head
Kefu Chai [Sun, 29 Jun 2025 02:55:30 +0000 (10:55 +0800)]
doc/mgr/crash.rst: remove outdated module enabling instructions

The crash module has been enabled by default since commit 18f253aa in
Nautilus and is now in the always_on_modules list. However, the
documentation still contained instructions for manually enabling it.

When users followed these outdated instructions, they encountered:
```
  module 'crash' is already enabled (always-on)
```

The module cannot be disabled either. Running:
```
  ceph mgr module disable crash
```

Returns the error:
```
  Error EINVAL: module 'crash' cannot be disabled (always-on)
```
In this change, we remove the obsolete enabling instructions and clarify
that this module is always active and cannot be disabled.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 0fcd7677586f7edf3eb091420a8ace0c4f887167)

2 weeks agoqa/rgw: fix perl tests missing Amazon::S3 module 64279/head
Mark Kogan [Wed, 25 Jun 2025 12:21:49 +0000 (12:21 +0000)]
qa/rgw: fix perl tests missing Amazon::S3 module

and a second case where perl tests can fail without error output

1. fix errors like: `Can't locate Amazon/S3.pm in @INC (you may need to
   install the Amazon::S3 module)`
by priming the perl tests with installing the Amazon::S3 module from cpan

ex:
```
2025-06-23T19:18:40.162 INFO:tasks.workunit.client.0.smithi090.stderr:Can't locate Amazon/S3.pm in @INC (you may need to install the Amazon::S3 module) (@INC contains: /usr/local/lib64/perl5/5.32 ...
```

2. log an error when RGW process is not detected

Fixes: https://tracker.ceph.com/issues/71577
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit 7faa23f160c9f4b40d25fe27f2345dbf999b0c84)

2 weeks agomgr/dashboard: align cli commands listener list, ns list, host list 64236/head
Tomer Haskalovitch [Mon, 19 May 2025 08:29:22 +0000 (11:29 +0300)]
mgr/dashboard: align cli commands listener list, ns list, host list

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 0e9c69ac8997195fa0b14e04afb3290479a2b39b)

2 weeks agomgr/dashboard: align gw info, gw version, spdk_log_level get with old cli 64235/head
Tomer Haskalovitch [Sun, 18 May 2025 18:58:37 +0000 (21:58 +0300)]
mgr/dashboard: align gw info, gw version, spdk_log_level get with old cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 443e50af1f34caebe6d03c0c20e43a03d8a17e5a)

2 weeks agomgr/dashboard: fix set spdk log level cli command 64233/head
Tomer Haskalovitch [Sun, 18 May 2025 17:21:04 +0000 (20:21 +0300)]
mgr/dashboard: fix set spdk log level cli command

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit bd51114ee330a1a480633f6f2f2f24e11e8ca969)

2 weeks agomgr/dashboard: add missing fields to subsytem list command 64232/head
Tomer Haskalovitch [Tue, 13 May 2025 23:40:59 +0000 (02:40 +0300)]
mgr/dashboard: add missing fields to subsytem list command

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 2962b4c02610a8445d34ca16961188250f3a2274)

2 weeks agoMerge pull request #64029 from VallariAg/wip-71721-tentacle
Vallari Agrawal [Mon, 30 Jun 2025 16:13:50 +0000 (21:43 +0530)]
Merge pull request #64029 from VallariAg/wip-71721-tentacle

tentacle: mon: Revert "mon: Add nvmeof group/gateway name in "ceph -s""

2 weeks agoMerge pull request #64120 from yuvalif/wip-logging-backports
Yuval Lifshitz [Mon, 30 Jun 2025 13:49:37 +0000 (16:49 +0300)]
Merge pull request #64120 from yuvalif/wip-logging-backports

tentacle: rgw: bucket logging backports

2 weeks agoMerge pull request #64116 from vshankar/wip-ignore-osd-down
Venky Shankar [Mon, 30 Jun 2025 10:33:52 +0000 (16:03 +0530)]
Merge pull request #64116 from vshankar/wip-ignore-osd-down

tentacle: qa/cephfs: ignore `OSD_DOWN/osds down` warning

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2 weeks agonvmeofgw: fix sending acks during upgrade 64258/head
Leonid Chernin [Thu, 5 Jun 2025 07:59:03 +0000 (10:59 +0300)]
nvmeofgw: fix sending acks during upgrade
          fix gw-epoch during upgrade
          1.fixed issue  when during upgrade before feature NVMEOFHAMAP is
          applyed, monitor did not send acks to beacon - this cause
          expiration GW mon-client beacon ack timeout and assert of the GW.
          2. fixed issue that during upgrade new GW epoch, generated
  after applying of new feature NVMEOFHAMAP was less than
  global epoch. So GW mon-client asserted on receiving new epoch
          that is less than its last received epoch

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
(cherry picked from commit 3042c3695cbdbc75bad1d3564e887f1b1ad77ef6)

2 weeks agomon: fix duplicated entity addr in the map during reboot of several nvvmeof GWs 64257/head
Leonid Chernin [Mon, 21 Apr 2025 13:56:07 +0000 (16:56 +0300)]
mon: fix duplicated entity addr in the map during reboot of several nvvmeof GWs

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
(cherry picked from commit e55730c073697f66f35d4ee7beb4c9a7dd59dd65)

2 weeks agoMerge pull request #64089 from vshankar/wip-cephfs-client-fixes
Venky Shankar [Mon, 30 Jun 2025 06:50:58 +0000 (12:20 +0530)]
Merge pull request #64089 from vshankar/wip-cephfs-client-fixes

tentacle: client: cephfs user-space client fixes

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2 weeks agoMerge pull request #63533 from vshankar/wip-revert-referent-inodes-tentacle
Venky Shankar [Mon, 30 Jun 2025 06:50:37 +0000 (12:20 +0530)]
Merge pull request #63533 from vshankar/wip-revert-referent-inodes-tentacle

tentacle: mds: revert referent inodes

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2 weeks agoMerge pull request #63457 from vshankar/wip-client-secfix-tentacle
Venky Shankar [Mon, 30 Jun 2025 06:50:22 +0000 (12:20 +0530)]
Merge pull request #63457 from vshankar/wip-client-secfix-tentacle

tentacle: client: disallow unprivileged users to escalate root privileges

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2 weeks agotest/librados/aio_cxx: Fix potential mutex destruction failure on PoolEIOFlag 64242/head
Nitzan Mordechai [Sun, 22 Jun 2025 13:43:55 +0000 (13:43 +0000)]
test/librados/aio_cxx: Fix potential mutex destruction failure on PoolEIOFlag

GTEST_SKIP() does not return and causes early test exit, which
skips any following cleanup logic.
In this case, the test skipped before releasing my_lock, causing
pthread_mutex_destroy() to fail with EBUSY and trigger a ceph_assert()
in the mutex debug wrapper.
Fix by explicitly unlocking the mutex before calling GTEST_SKIP().

Signed-off-by: Nitzan Mordechai <nmordech@ibm.com>
(cherry picked from commit 26e7bbf68142419d9e2991099e42853c1a7339b4)

2 weeks agotest/librados/aio_cxx: skip EIO boundary assertion when no in-flight I/Os
Nitzan Mordechai [Wed, 7 May 2025 13:37:34 +0000 (13:37 +0000)]
test/librados/aio_cxx: skip EIO boundary assertion when no in-flight I/Os

In the PoolEIOFlag test we now track whether any async writes were still
in flight at the moment we flipped the pool’s `eio=true` flag using an
atomic `missed_eio` flag set inside the helper thread.  If we never
actually overlapped any in-flight AIOs (we completed all aio successfully)
with the flag flip, we `GTEST_SKIP()` the final `max_success+1 == min_failed`
boundary assertion, avoiding spurious failures when all writes complete
before EIO takes effect.

Fixes: https://tracker.ceph.com/issues/70852
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 07319d9a37ef70b6422e26eba8a251f711db2c6b)

2 weeks agomgr/dashboard update ceph nvmoef proto files 64240/head
Tomer Haskalovitch [Tue, 27 May 2025 09:04:49 +0000 (12:04 +0300)]
mgr/dashboard update ceph nvmoef proto files

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
(cherry picked from commit a0398200b454a7f7144547c30f3093f394395052)

2 weeks agomgr/dashboard: remove map_collection decorator and adapt host list nvme endpoint 64231/head
Tomer Haskalovitch [Mon, 21 Apr 2025 09:48:00 +0000 (12:48 +0300)]
mgr/dashboard:  remove map_collection decorator and adapt host list nvme endpoint

Signed-off-by: Tomer Haskalovitch <il033030@tomers-mbp.givatayim.il.ibm.com>
(cherry picked from commit 63233196aee12a76203fd168e1cfb1cadaafdd21)

3 weeks agoMerge pull request #64098 from idryomov/wip-71335-tentacle
Ilya Dryomov [Fri, 27 Jun 2025 14:35:57 +0000 (16:35 +0200)]
Merge pull request #64098 from idryomov/wip-71335-tentacle

tentacle: librbd/cache/pwl: fix memory leak in SyncPoint persist context cleanup

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 weeks agoMerge pull request #64099 from idryomov/wip-67984-tentacle
Ilya Dryomov [Fri, 27 Jun 2025 14:35:38 +0000 (16:35 +0200)]
Merge pull request #64099 from idryomov/wip-67984-tentacle

tentacle: librbd: retry list_snap_orders() once instead of failing sort_snaps()

Reviewed-by: VinayBhaskar-V <vvarada@redhat.com>
3 weeks agoMerge pull request #64100 from idryomov/wip-71226-tentacle
Ilya Dryomov [Fri, 27 Jun 2025 14:34:56 +0000 (16:34 +0200)]
Merge pull request #64100 from idryomov/wip-71226-tentacle

tentacle: librbd/api/Mirror: return EINVAL from image_get_mode() when the image is disabled for mirroring

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 weeks agoMerge pull request #64101 from idryomov/wip-rbd-std-variant-tentacle
Ilya Dryomov [Fri, 27 Jun 2025 14:34:30 +0000 (16:34 +0200)]
Merge pull request #64101 from idryomov/wip-rbd-std-variant-tentacle

tentacle: librbd, tools: migrate from boost::variant to std::variant

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 weeks agoMerge pull request #64102 from idryomov/wip-cls-test-default-tentacle
Ilya Dryomov [Fri, 27 Jun 2025 14:34:08 +0000 (16:34 +0200)]
Merge pull request #64102 from idryomov/wip-cls-test-default-tentacle

tentacle: cls/rbd: use default values for non-decoded fields in test instances

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 weeks agoMerge pull request #64212 from ronen-fr/wip-rf-64211-tentacle
Ronen Friedman [Fri, 27 Jun 2025 12:36:58 +0000 (15:36 +0300)]
Merge pull request #64212 from ronen-fr/wip-rf-64211-tentacle

tentacle: osd/scrub: 'starts' messages should name PGs, not shards

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
3 weeks agoMerge pull request #64154 from zdover23/wip-doc-2025-06-25-backport-64107-to-tentacle
Zac Dover [Thu, 26 Jun 2025 20:18:53 +0000 (06:18 +1000)]
Merge pull request #64154 from zdover23/wip-doc-2025-06-25-backport-64107-to-tentacle

tentacle: doc/radosgw: remove "pubsub_event_triggered"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
3 weeks agodoc/radosgw: remove "pubsub_event_triggered" 64154/head
Zac Dover [Mon, 23 Jun 2025 08:07:40 +0000 (18:07 +1000)]
doc/radosgw: remove "pubsub_event_triggered"

Remove "pubsub_event_triggered" from the list of "Notification
Performance Statistics". It is obsolete.

Fixes: https://tracker.ceph.com/issues/71789
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 44dc57fc15749583fc13560c9409b7687df7c223)

3 weeks agoosd/scrub: 'starts' messages should name PGs, not shards 64212/head
Ronen Friedman [Thu, 26 Jun 2025 13:27:57 +0000 (08:27 -0500)]
osd/scrub: 'starts' messages should name PGs, not shards

By mistake, the 'scrub starts' message included the shard ID
of the primary OSD, instead of just the PG ID.

Fixes: https://tracker.ceph.com/issues/71780
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit e8cde5811f07f0847a1aac20279aa83f57e4562d)

3 weeks agosrc/mon/MgrStatMonitor: fix invalid iterator increment in calc_pool_availability() 64129/head
Nitzan Mordechai [Wed, 21 May 2025 11:41:01 +0000 (11:41 +0000)]
src/mon/MgrStatMonitor: fix invalid iterator increment in calc_pool_availability()

Erasing entries from `pool_availability` inside a range-for
loop invalidated the hidden iterator, triggering an
“Invalid read” under Valgrind.

- Use `std::erase_if(pool_availability, predicate)` for
  atomic removal.
- Refactor the stats-update loop to use structured bindings
  and a clear `++it` for readability.

Fixes: https://tracker.ceph.com/issues/71271
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 7369a4dded210d9410fb00e259d95df013532cc1)

3 weeks agodoc: update user docs and release notes 64209/head
Shraddha Agrawal [Thu, 19 Jun 2025 13:05:06 +0000 (18:35 +0530)]
doc: update user docs and release notes

Fixes: https://tracker.ceph.com/issues/71495
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>
(cherry picked from commit ba852da68d409e29c0f3e7be68001aebc1795e08)

3 weeks agoqa/standalone/mon/availability.sh: add tests
Shraddha Agrawal [Thu, 19 Jun 2025 13:01:52 +0000 (18:31 +0530)]
qa/standalone/mon/availability.sh: add tests

This commit adds tests for the new command to clear availability
status for a particular pool. The two tests do the following:

1. Checks if availability status is cleared successfully.
2. Checks availability status is not cleared if feature is
disabled.

Fixes: https://tracker.ceph.com/issues/71495
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>
(cherry picked from commit c08cf3277fbce6c02e9251b2985cf52ac0dbc165)

3 weeks agomon: add command osd pool clear-availability-status
Shraddha Agrawal [Wed, 28 May 2025 05:56:26 +0000 (11:26 +0530)]
mon: add command osd pool clear-availability-status

This commit adds a new command to allow users to clear the
calculated availability score for a specified pool. This can be
done by issuing the command:

  ceph osd pool clear-availability-status <pool_name>

Fixes: https://tracker.ceph.com/issues/71495
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>
(cherry picked from commit f6aed0b45efc60a8ca81bd3455c14a13106dd3c9)

3 weeks agoMerge pull request #64183 from ronen-fr/wip-rf-64182-tentacle
Ronen Friedman [Thu, 26 Jun 2025 10:34:52 +0000 (13:34 +0300)]
Merge pull request #64183 from ronen-fr/wip-rf-64182-tentacle

tentacle: osd/scrub: some perf counters had their priority set to '0'

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
3 weeks agolibrbd/migration/QCOWFormat: don't complete read_clusters() inline 64197/head
Ilya Dryomov [Wed, 25 Jun 2025 10:24:35 +0000 (12:24 +0200)]
librbd/migration/QCOWFormat: don't complete read_clusters() inline

When the cluster needs to be read, the completion is posted to ASIO.
However, in the two special cases (cluster DNE and zero cluster), the
completion is completed inline at the moment.  This violates invariants
and can eventually lead to a lockup.  For example, in a scenario of
a read from a clone image whose parent is under migration:

  io::ObjectReadRequest::read_parent()
    io::util::read_parent()
      < image_lock is taken for read >
      io::ImageDispatchSpec::send()
        migration::ImageDispatch::read()
          migration::QCOWFormat::ReadRequest::send()
            ...
            migration::QCOWFormat::ReadRequest::read_clusters()
              < cluster DNE >
              migration::QCOWFormat::ReadRequest::handle_read_clusters()
                io::AioCompletion::complete()
                  io::ObjectReadRequest::copyup()
                    is_copy_on_read()
                      < image_lock is taken for read >

copyup() expects to be called with no locks held, but going through
QCOWFormat in the "cluster DNE" case essentially maintains image_lock
taken in read_parent() and then it's taken again by the same thread in
is_copy_on_read().  Under pthreads, it's not a problem:

  A thread may hold multiple concurrent read locks on rwlock (that is,
  successfully call the pthread_rwlock_rdlock() function n times). If
  so, the thread must perform matching unlocks (that is, it must call
  the pthread_rwlock_unlock() function n times).

But according to C++ standard it's undefined behavior:

  If lock_shared is called by a thread that already owns the mutex in
  any mode (exclusive or shared), the behavior is undefined.

Other, longer and more elaborate, call chains are possible too and
there it may end up being a write lock, a tripped assertion, etc.  To
avoid this, make the special cases in read_clusters() behave the same
as the main path.

Fixes: https://tracker.ceph.com/issues/71838
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit a02cc13191d5e695620791c883ff1460d2e42f57)

3 weeks agolibrbd/migration/QCOWFormat: rename handle_read_cluster()
Ilya Dryomov [Wed, 25 Jun 2025 10:55:06 +0000 (12:55 +0200)]
librbd/migration/QCOWFormat: rename handle_read_cluster()

... to handle_read_clusters() as it's a callback for read_clusters().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 9d9c73435341f98cecf0a450357408f8d49624fa)

3 weeks agoMerge pull request #63615 from ceph/djg-tentacle-rtd
David Galloway [Wed, 25 Jun 2025 23:37:08 +0000 (19:37 -0400)]
Merge pull request #63615 from ceph/djg-tentacle-rtd

tentacle: .github: Fix RTD build retrigger

3 weeks agoMerge pull request #64051 from cbodley/wip-71752-tentacle
Casey Bodley [Wed, 25 Jun 2025 17:47:48 +0000 (13:47 -0400)]
Merge pull request #64051 from cbodley/wip-71752-tentacle

tentacle: fix: the RGW crash caused by special characters

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 weeks agosrc: fix NDEBUG typo 64188/head
Matan Breizman [Mon, 26 May 2025 14:26:44 +0000 (14:26 +0000)]
src: fix NDEBUG typo

_NDEBUG is a typo for NDEBUG. Possibly confused with _DEBUG which is a
Visual Studio concept.
Include other instances as well in the repo.

Fixes: https://tracker.ceph.com/issues/71456
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 36569bd2d4280640da4a950d5f5c9e0090c085a5)

3 weeks agoosd/scrub: some perf counters priority was '0' 64183/head
Ronen Friedman [Wed, 25 Jun 2025 14:25:08 +0000 (09:25 -0500)]
osd/scrub: some perf counters priority was '0'

Some scrub perf counters were created without specifying
individual priorities, assuming by mistake that the
default priority is '_INTERESTING'. That was not the case,
and those perf counters were not reported.

Fixes: https://tracker.ceph.com/issues/71842
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit cf1864a61061bc9de05eedd987f64307bcf7c501)

3 weeks agoMerge pull request #64133 from afreen23/wip-71809-tentacle
afreen23 [Wed, 25 Jun 2025 14:34:16 +0000 (20:04 +0530)]
Merge pull request #64133 from afreen23/wip-71809-tentacle

tentacle: mgr/dashboard: Add --force flag for listeners

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
3 weeks ago[DNM] change bucket logging branch 64120/head
Yuval Lifshitz [Wed, 25 Jun 2025 14:09:03 +0000 (14:09 +0000)]
[DNM] change bucket logging branch

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
3 weeks agoMerge pull request #64143 from zdover23/wip-doc-2025-06-25-backport-64105-to-tentacle
Zac Dover [Wed, 25 Jun 2025 13:59:06 +0000 (23:59 +1000)]
Merge pull request #64143 from zdover23/wip-doc-2025-06-25-backport-64105-to-tentacle

tentacle: doc/radosgw: add "persistent_topic_len"

Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
3 weeks agoMerge pull request #64131 from afreen23/wip-71805-tentacle
afreen23 [Wed, 25 Jun 2025 09:41:55 +0000 (15:11 +0530)]
Merge pull request #64131 from afreen23/wip-71805-tentacle

tentacle: mgr/dashboard: Allow host with labels in listener form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
3 weeks agodoc: Fix unterminated inline literal in ceph-conf.rst 64169/head
Kefu Chai [Wed, 25 Jun 2025 03:34:50 +0000 (11:34 +0800)]
doc: Fix unterminated inline literal in ceph-conf.rst

Add missing space after closing backticks to properly terminate inline literal.

Sphinx was generating a warning due to an unterminated inline literal
string:

```
/home/kefu/dev/ceph/doc/rados/configuration/ceph-conf.rst:320: WARNING: Inline literal start-string without end-string.
```

This fix ensures the inline literal is properly closed and eliminates the
build warning.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 7f79f3d6aa7f71c9b2434b843036a3f1da660231)

3 weeks agoMerge pull request #64045 from shraddhaag/wip-71743-tentacle
Shraddha Agrawal [Wed, 25 Jun 2025 08:05:15 +0000 (13:35 +0530)]
Merge pull request #64045 from shraddhaag/wip-71743-tentacle

tentacle: mon: add config option to toggle availability score feature

3 weeks agomgr/dashboard: Allow host with labels in listener form 64131/head
Afreen Misbah [Mon, 16 Jun 2025 17:09:46 +0000 (22:39 +0530)]
mgr/dashboard: Allow host with labels in listener form

- Currently, listeners cannot be added with the Ceph Dashboard if the gateway nodes are selected by label instead of hosts.

- Refactored the code to incorporate nodes with labels

- Also added missing typings and removed 'any'

Fixes https://tracker.ceph.com/issues/71686

Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit 0bd2704a88f517b48196a8b1a3c07b0f8032b0f6)

3 weeks agomgr/dashboard: Add --force flag for listeners 64133/head
Afreen Misbah [Mon, 16 Jun 2025 15:16:39 +0000 (20:46 +0530)]
mgr/dashboard: Add --force flag for listeners

Fixes https://tracker.ceph.com/issues/71685

Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit 604d351a4e7bbf47baf57e10f67219a2eea919e0)