doc: preen cephadm/troubleshooting.rst and radosgw/placement.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #50221 from zdover23/wip-doc-2023-02-23-glossary-bucket

doc/glossary: add "Bucket"

Merge pull request #50220 from tnyeanderson/fix-word-repeat

doc: remove word repeat in docs

doc/glossary: add "Bucket"

Add "Bucket" to the glossary. The definition added here is just a first
attempt, but a man's reach must exceed his grasp, or what's a heaven
for?

Signed-off-by: Zac Dover <zac.dover@proton.me>

doc/cephadm/troubleshooting: remove word repeat

The original text was "In case the cluster the last MGR of a cluster"

Signed-off-by: thomas <me@thomasanderson.cloud>

Merge PR #50196 into main

* refs/pull/50196/head:
qa: export DIFF_LENGTH env parameter to print the full git diff

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #50179 from rishabh-d-dave/doc-fs-quota

doc/cephfs: improve CephFS Quota document

Merge pull request #50213 from pponnuvel/osd_backfill_doc

doc/rados: update OSD_BACKFILLFULL description

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #50215 from ljflores/wip-temporarily-disable-cronjobs

qa/crontab: temporarily disable teuthology cronjobs

Temporarily disable teuthology cron jobs before
the Reef dev freeze. This commit is intended to
lessen the load on the teuthology queue as we
test final patches for Reef, but should be reverted
after the dev freeze.

Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #50201 from ceph/fix-github_action-main

.github/workflows: update failing action

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rkachach <NOT@FOUND>

Merge pull request #48127 from petrutlucian94/cephfs_tests

Windows tests follow-up (librados_asio error category, disable some tests)

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc/rados: update OSD_BACKFILLFULL description

Document that this warning can happen even when the OSDs' limits
haven't hit the backfill_full_ratio.

Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>

doc/cephfs: describe conf opt "client quota df" in quota doc

The ceph config file option (from the client section) "client quota df"
is mentioned in "CephFS Client Capabilities" document but not in the
"CephFS Quota" document. Adding information about this option to this
document too would make it easier for CephFS users to discover,
understand and use this option.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

doc/cephfs: rearrange CephFS Quota document

CephFS users, especially new users, would find it easier to discover,
understand and use CephFS Quota when basic information (like setting,
viewing and removing CephFS quota from a CephFS directory) is mentioned
in the documentation before advanced information (like limitations &
implementation details of CephFS Quota).

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #50207 from rhcs-dashboard/fix-58827-main

mgr/dashboard: fix constraints.txt

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge PR #50175 into main

* refs/pull/50175/head:
cephfs: upgrade cephfs-shell's path wherever necessary

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #49979 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-http-cache-semantics-4.1.1

mgr/dashboard: bump http-cache-semantics from 4.1.0 to 4.1.1 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #49192 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-decode-uri-component-0.2.2

mgr/dashboard: bump decode-uri-component from 0.2.0 to 0.2.2 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: fix constraints.txt

Replaces strict version matching with compatible version syntax.

Reference: https://peps.python.org/pep-0440/#version-specifiers

Fixes: https://tracker.ceph.com/issues/58827
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #45669 into main

* refs/pull/45669/head:
client: switch to use 32 bits ext_num_fwd
client: switch to use 32 bits ext_num_retry
ceph_fs.h: add 32 bits extended num_retry and num_fwd support
ceph_fs.h: switch to use its own encode/decode helpers

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa: export DIFF_LENGTH env parameter to print the full git diff

From the xfstests-dev's README doc set DIFF_LENGTH to 0 will print
the full diff instead of the default 10.

This will be very helpful to debug the test failures, or we will
lose many valuable debug infomation.

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge PR #49934 into main

* refs/pull/49934/head:
qa: add test_fscrypt_dummy_encryption test case support
qa: add 'options' parameter support for write_local_config
qa: add ceph.exclude file to exclude individual tests
qa: add require_kernel_mount helper support
qa: rename test_fscrypt to test_fscrypt_encrypt

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #50203 from zdover23/wip-doc-2023-02-22-radosgw-multisite-refine-top-matter

doc/rgw: clarify multisite.rst top matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rgw: clarify multisite.rst top matter

Improve the pragmatics of the top matter of multisite.rst. Organize the
text into sections, where doing so makes the nature of multi-site
configurations clearer.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #49605 from myoungwon/wip-rbm-integration-step2

crimson/os/seastore: enable metadata (*_INTERNAL and *_LEAF ) allocation using OOL path

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #49722 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-loader-utils-1.4.2

mgr/dashboard: bump loader-utils from 1.4.0 to 1.4.2 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #50042 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-sideway-formula-3.0.1

mgr/dashboard: bump @sideway/formula from 3.0.0 to 3.0.1 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

.github/workflows: update failing action

[Example](https://github.com/ceph/ceph/actions/runs/4222995073/jobs/7360873373) of failing run.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>

cephfs: upgrade cephfs-shell's path wherever necessary

Commit dc69033763cc116c6ccdf1f97149a74248691042 moves cephfs-shell from
"<CEPH-REPO-ROOT>/src/tools/cephfs/" to
"<CEPH-REPO-ROOT>/src/tools/cephfs/shell" but cephfs-shell's location in
src/vstart.sh and qa/tasks/cephfs/test_cephfs_shell.py is left
un-updated. This produces a broken vstart_environment.sh and broken
export command in test_cephfs_shell.py.

Introduced-by: dc69033763cc116c6ccdf1f97149a74248691042
Fixes: https://tracker.ceph.com/issues/58795
Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa: add test_fscrypt_dummy_encryption test case support

This will test around 130 test cases with the test_dummy_encryption
option enabled.

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #50165 from zdover23/wip-doc-2023-02-19-radosgw-multisite-multisite-top-matter-cleanup

doc/rgw: multisite ref. top matter cleanup

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

qa: add 'options' parameter support for write_local_config

This will allow the fscrypt test case to add dedicated options.

Signed-off-by: Xiubo Li <xiubli@redhat.com>

qa: add ceph.exclude file to exclude individual tests

Skip some tests, which will take to much time or will fail, for now.

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #50186 from zdover23/wip-doc-2023-02-21-radosgw-session-tags-render-fix

doc/rgw: session-tags.rst - fix link to keycloak

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge PR #49154 into main

* refs/pull/49154/head:
qa: add tests for cephfs-top
doc: updates --dump and --dumpfs
cephfs-top: dump values to stdout

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>

doc/rgw: session-tags.rst - fix link to keycloak

Fix a link in the doc/radosgw/session-tags.rst file that was intended to
link to the doc/radosgw/keycloak.rst file.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #43145 from pritha-srivastava/wip-rgw-sts-doc-fixes

rgw/sts: correcting documentation errors.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #49843 from shreyanshjain7174/compression_58410

rados: Set snappy as default value in ms_osd_compression_algorithm

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #49487 from trociny/wip-58269

mgr: don't dump global config holding gil

Reviewed-by: Tim Serong <tserong@suse.com>

Merge pull request #49379 from zhsgao/osd_deep_scrub_stride

osd/scrub: add a variable to store osd_deep_scrub_stride

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #49199 from ifed01/wip-ifed-fix-require-osd-release

mon: avoid exception when setting require-osd-release more than 2

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #45414 from ifed01/wip-ifed-log-before-assert-in-avl

os/bluestore: log before assert in AvlAllocator

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #49335 from yuvalif/wip-yuval-fix-58167

prevent anonymous topic operations

Reviewed-By: pritha-srivastava, cbodley

Merge pull request #48709 from yanghonggang/yhg-jaeger-port

common: add a config option for jaeger agent port

Reviewed-By: tchaikov, zenomri, yuvalif

Merge pull request #49910 from myoungwon/fix-58587

qa/workunits/rados/test_dedup_tool.sh: reset dedup tier during tests

Merge pull request #49950 from cbodley/wip-qa-ragweed-tox

qa/rgw: run ragweed tests with tox

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #49962 from robbat2/main-post_object_upload_size_rgw_chunk_size_bug

rgw: Fix Browser POST content-length-range min value

Reviewed-by: Casey Bodley <cbodley@redhat.com>

librados/asio: use boost::system::generic_category on Windows

librados uses "errno.h" error codes. On Windows,
boost::system::system_category refers to errors from winerror.h.

That being considered, we'll add a platform check and use
boost::system::generic_category on Windows. This ensures that
error code comparisons work as expected.

This issue was brought up by the following test assertion failure:

  ft2.4: ceph_test_rados_api_asio.AsioRados.AsyncWriteCallbacktesttools.
    testresult.real._StringException: details: {{{
  /ceph/src/test/librados/asio.cc:148
  Expected equality of these values:
    boost::system::errc::read_only_file_system
      Which is: 30
    ec
      Which is: system:30
  }}}

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

test/librados: avoid using rlimit on Windows

One of the librados tests is temporarily adjusting the file
rlimit. This is unsupported on Windows, so we're skipping it.

At the same time, asprintf is not available, so we'll switch
to sprint with a predefined buffer.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

Merge pull request #50166 from zdover23/wip-doc-2023-02-19-radosgw-multisite-zonegroup-setup-cleanup

doc/rgw: refine "Setting a Zonegroup"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rgw: refine "Setting a Zonegroup"

Streamline the "Setting a Zonegroup" section by separating out the
necessary prerequisite reading from the procedure itself.

I also corrected a typo in the word "following" in an unrelated section.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #50164 from zdover23/wip-doc-2023-02-19-radosgw-multisite-execute-removal

doc/radosgw: s/execute/run/ in multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #50160 from cbodley/wip-qa-rgw-notification-example

qa/rgw: update boto3 example path in notification_tests.py

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

doc/rgw: multisite ref. top matter cleanup

Edit the top matter in "Multi-site Configuration Reference" so that it
is semantically more natural.

Signed-off-by: Zac Dover <zac.dover@proton.me>

doc/radosgw: s/execute/run/ in multisite.rst

Replace "execute" with "run" in fourteen out of fifteen instances in
multisite.rst. "Execute" is plain old too grand in most of these
instances.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #48683 from linuxbox2/wip-rgwlc-faststop

rgwlc: prevent lc for one bucket from exceeding time budget

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #49785 from theanalyst/rgw-swift-key

rgw: swift : check for valid key in POST forms

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #49951 from ivancich/wip-clean-up-2023-Jan-23-coverity

rgw: clean up January 21, 2023 coverity scan issues

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #50157 from guits/fix-simple-scan-cv

ceph-volume: legacy_encrypted() shouldn't call lsblk() when device is 'tmpfs'

qa/rgw: update boto3 example path in notification_tests.py

fallout from https://github.com/ceph/ceph/pull/50102

Signed-off-by: Casey Bodley <cbodley@redhat.com>

ceph-volume: legacy_encrypted() shouldn't call lsblk() when device is 'tmpfs'

When the device variable is rebound and become 'tmpfs', lsblk() shouldn't be called.

Fixes: https://tracker.ceph.com/issues/58784
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #50154 from zdover23/wip-doc-2023-02-18-glossary-period-rgw

doc/glossary: add "Period" to glossary

doc/glossary: add "Period" to glossary

Add definition for "period" to glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #50020 from rkachach/fix_issue_58660

mgr/rgw: fix module crash because of typing_extensions missing

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #49728 from rkachach/fix_issue_58241

cephadm: Adding poststop actions and setting TimeoutStartSec to 200s

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #49754 from adk3798/ha-nfs-active-failover

mgr/cephadm: fix backends service in haproxy config with multiple nfs of same rank

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48973 from trociny/wip-58051

mgr/cephadm: try to avoid pull when getting container image info

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #50016 from max-licc/nobjects_begin_crash

rgw: catches nobjects_begin() exceptions

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #50041 from cbodley/wip-cls-rgw-cancel-deleted

cls/rgw: remove index entry after cancelling last racing delete op

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>

Merge pull request #50059 from cbodley/wip-rgw-stream-errors

rgw/beast: StreamIO remembers connection errors for graceful shutdown

Reviewed-by: Yixin Jin <yjin77@yahoo.ca>

Merge pull request #50131 from yima77/rgw_fix_segfault_due_to_concurrent_socket_use_at_timeout

rgw: Fix segfault due to concurrent socket use at timeout

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #50143 from ivancich/wip-flight-getobj-fix

rgw/flight: don't access non-existant flight store during GetObj

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #50096 from nbalacha/syncpercent-fix

rbd-mirror: fix syncing_percent calculation logic in get_replay_status()

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #49614 from isodude/wip-librbd-misalign-discard

librbd: Fix local rbd mirror journals growing forever

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

mgr/cephadm: fix error_ok not being passed in unit tests

Signed-off-by: Adam King <adking@redhat.com>

mgr/cephadm: try to avoid pull when getting container image info

Fixes: https://tracker.ceph.com/issues/58051
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>

mgr/cephadm: allow _run_cephadm_json to be silent on error

Signed-off-by: Mykola Golub <mykola.golub@clyso.com>

Merge pull request #49866 from rkachach/fix_issue_58466

cephadm: using short hostname to create the initial mon and mgr

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

win32_build.sh: build "ceph_test*"

At the moment, win32_build.sh builds the "tests" target, which
only includes the "unittest_*" tests.

We'll update the build script to include "ceph_test_*" targets
as well.

Note that we can't just build all the targets that were generated
by cmake since some of them are unavailable on Windows. When
doing the Windows port, we decided to avoid polluting the Cmake
files and keep the amount of Windows checks to a minimum.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

test/libcephfs: add missing includes

Some tests will need to include "compat.h" and "fs_types.h" in
order to build for Windows.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

Merge pull request #49961 from stefan-chivu/test_rbd_wnbd_latency

qa: Added latency to results table in test_rbd_wnbd.py

crimson/os/seastore: fix traversal behavior in scan_mapped_space to avoid replay-allocation conflicts

1. Traverse the allocations from backref-tree leaf-node entries;
2. Traverse the pending alloc-deltas by sequence;
3. Traverse the allocations from backref-tree internal-node entries;

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

qa/rgw: add tox task before ragweed

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/ragweed: run ragweed tests with tox

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49709 from yima77/rgw_fix_mp_upload_obj_leak_due_to_reupload

rgw: fix multipart upload object leaks due to re-upload

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rgw/flight: don't access non-existant flight store during GetObj

The front end must be configured via ceph.conf to start up both the
flight_server and the flight_store. RGWGetObj needs to check for the
existence of a flight_store prior to trying to use it.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

crimson/os/seastore: In rewrite_extent, do not resolve addr if address is RANDOM_BLOCK

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: determine whether lba_backref_node can be allocated to OOL

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

quincy: qa: update test_rbd_wnbd.py to report latency in seconds

At the moment, the latency results are reported in nanoseconds.
In order to improve readability, we'll convert it to seconds.

While at it, we'll fix the fio duration report, which we're
wrongfully dividing by 1000 twice.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

qa: Added latency to results table in test_rbd_wnbd.py

Added data regarding completion latency (ns) to the fio results
table, such as min, max, mean, stddev, etc.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

qa/workunits/rbd-nbd: work around "rbd feature disable" hang

"rbd feature disable" appears to reliably hang if the corresponding
remote request is proxied to rbd-nbd (because rbd-nbd happens to own
the exclusive lock after a series of blkdiscard calls) [1].  Work
around it here by enabling journaling before the image is mapped
and disabling it after the image is unmapped.

Also, don't assert on the output of "rbd journal inspect --verbose"
having a certain number of entries.  This is racy: if the script gets
delayed after the last blkdiscard call for some reason, there may be
fewer entries present in the journal or none at all.

[1] https://tracker.ceph.com/issues/58740

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

test/librbd: add LengthModifiedDiscardJournalAppendEnabled test

Currently nothing triggers the length_modified case in
ImageDiscardRequest::prune_object_extents() in isolation. It's only
triggered in DiscardGranularityJournalAppendEnabled test together with
the prune_required case and a bad refactoring could easily break the
length_modified logic again.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #50109 from rhcs-dashboard/landing-page-v3

mgr/dashboard: Landing page v3

Reviewed-by: bryanmontalvan <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

qa: add tests for cephfs-top

* Updated the existing tests
* Added new qa tests for --dump and --dumpfs options
* Updated the cluster configuration to 2 mds, 2 clients

Fixes: https://tracker.ceph.com/issues/57014
Signed-off-by: Jos Collin <jcollin@redhat.com>

doc: updates --dump and --dumpfs

Fixes: https://tracker.ceph.com/issues/57014
Signed-off-by: Jos Collin <jcollin@redhat.com>

cephfs-top: dump values to stdout

Fixes: https://tracker.ceph.com/issues/57014
Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #50114 from rhcs-dashboard/cephadm-prom-401-error

mgr/dashboard: ignore the rules 400 error in dashboard kcli e2e

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

rbd-mirror: fix syncing_percent calculation logic in get_replay_status()

When a snapshot sync is resumed and the get_replay_status function
is called before handle_copy_image_progress, the syncing_percent
value may be greater than 100 as the m_local_object_count is still
set to zero. This commit sets the syncing_percent to 0 in such cases.

Fixes: https://tracker.ceph.com/issues/58706
Signed-off-by: N Balachandran <nibalach@redhat.com>

Merge pull request #50111 from rzarzynski/wip-crimson-osd-ftbfs-fmtptr

crimson/osd: fix FTBFS due to smart-ptr-to-bool conversion in fmt::ptr

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>