]> git-server-git.apps.pok.os.sepia.ceph.com Git - googletest.git/log
googletest.git
10 years agoMerge pull request #585 from orgads/warning-fix
Billy Donahue [Wed, 9 Sep 2015 13:19:40 +0000 (09:19 -0400)]
Merge pull request #585 from orgads/warning-fix

Fix unused static variable warning on Windows

10 years agoFix unused static variable warning on Windows
Orgad Shaneh [Wed, 9 Sep 2015 09:32:57 +0000 (12:32 +0300)]
Fix unused static variable warning on Windows

10 years agoInclude <memory> to use std::unique_ptr.
Billy Donahue [Tue, 8 Sep 2015 06:46:25 +0000 (02:46 -0400)]
Include <memory> to use std::unique_ptr.

10 years agoGooglemock has some tuples containing lvalue refs in its unit tests.
Billy Donahue [Tue, 8 Sep 2015 02:32:56 +0000 (22:32 -0400)]
Googlemock has some tuples containing lvalue refs in its unit tests.
These tuples are created with make_tuple, which is given temporaries.
The make_tuple is in a function argument list.

A possibly overzealous static_assert in libc++'s std::tuple ctor
is firing in our 'Perform(make_tuple("hi"))' calls, so
we can't use its make_tuple here. Instead we will use
explicitly-constructed tuples constructed from non-temporary strings.

Workaround for llvm bug:
    https://llvm.org/bugs/show_bug.cgi?id=20855

An alternative to https://github.com/google/googletest/pull/580 .