remove comments from the like-expressions

Signed-off-by: gal salomon <gal.salomon@gmail.com>
(cherry picked from commit 7c07bad9306f0920d7d17049647437c6fb1409a8)

search for the cause of the valgrind issue; remove the like expression that may cause it

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
(cherry picked from commit 723853fd189fe741b78cac5b4e780158b860d0e8)

s3select: test progress stats

Signed-off-by: Albin Antony <aantony@redhat.com>
(cherry picked from commit a3447c50dfae2fa0ac025397de8a83cc4df3fd97)

s3select: align s3select tests with ceph

Update s3-tests to handle the error-response (return 400, and error-description)

Signed-off-by: Albin Antony <aantony@redhat.com>

check Owner/Initiator fields of ListMultipartUploads response

new test case test_list_multipart_upload_owner() uses two different
users to initiate multipart uploads, then tests that
list_multipart_uploads() shows the correct user ids and display names
for each upload

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 490d0a4c4f91faf2a5213c95c4b92f7c3c94c878)

chore:Removes unused scaffolds

(cherry picked from commit d2a7ed88f169fd4ea9864b7fc640ddfe5518a19c)

rgw/boto3_s3:Adds delete_objects key limit for list-objects-v2

(cherry picked from commit 459e3c870a8b9bed7a47f354390b1343acb32708)

chore:Bump the list-objects to paginator

(cherry picked from commit 20aa9aa071e704020c7fbf1b95f447cb7f33a763)

rgw/s3_boto3:Adds new delete_objects tests for checking key delete limit

(cherry picked from commit 64bdc3beec46bb5e786146629430fa54d417cd36)

rgw/sts: test to use role tag as iam:ResourceTag in
role's trust policy.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit 71266fede99e585875128106c5d319ddbd08d1b4)

rgw/sts: test for s3:ResourceTag in role's permission policy

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit 5dcc3dd689486ac759092a2bd3307c469bf0c7e1)

rgw/sts: adding test for aws:TagKeys that can be used in the
condition element of the role's trust policy and the role's
permission policy.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit bf43a4a10a2eea15ae0c0c06fe9f16c1893d4115)

rgw/sts: adding test for aws:PrincipalTag in role permission
policy.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit 86fecf83b90b247a26e0f69203b7c3844b090af2)

rgw/sts: adding test to check for aws:RequestTag
in the condition element of a role's trust policy.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit 64068d7bf922ee349c9e47b103b17e5ded0a5450)

rgw/sts: adding tests for testing assumerolewithwebidentity
using 'sub' and 'azp' fields in the web token.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit d466b7bd09b94159526164430dde2f3d9bbce1ca)

docs: fix wrong example in README.rst

Run: S3TEST_CONF=your.conf ./virtualenv/bin/nosetests s3tests.functional.test_s3:test_bucket_list_empty

But get an error: "ERROR: Failure: ValueError (No such test test_bucket_list_empty)".

Because test_bucket_list_empty is a test case in s3tests_boto3 directory.

Signed-off-by: Liu Lan <liulan_yewu@cmss.chinamobile.com>
(cherry picked from commit 9ac8aef12bfeb0778a7b410bcf51e26c81565aec)

Merge pull request #390 from mkogan1/multipart-extra-complete

test extra complete_multipart_upload()

object-lock: test changes between retention modes

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8662815ebe2d8b105307edccf56b11ebb7b6824f)

nuke_prefixed_buckets waits up to 60 seconds for object locks to expire

objects locked in GOVERNANCE mode can be removed with
BypassGovernanceRetention, but some tests may leave an object locked in
COMPLIANCE mode, which blocks deletion until the retention period
expires

nuke_prefixed_buckets now checks the retention policy of objects that it
fails to delete with AccessDenied, and will wait up to 60 seconds for
locks to expire before retrying the deletes. if the wait exceeds 60
seconds, it instead throws an error without deleting the bucket

instead of doing this in nuke_prefixed_buckets, we could potentially
have each object-lock test case handle this manually, but that would
add a separate delay to each test case

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9c4f15a47e1ee899a7dc453a4971a164e10521d8)

nuke_prefixed_buckets deletes objects in batches

speed up the cleanup by using delete_objects() with batches of 128

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit bb995c2aeb8fbbf7c5a9547827b0afa9e1ad15ac)

rgw/s3_boto3: Add tests for bucket encryption APIs

Tests are added for GetBucketEncryption, PutBucketEncryption,
and DeleteBucketEncryption APIs.

Related PR: https://github.com/ceph/ceph/pull/42222

Signed-off-by: Rahul Dev Parashar <rahul.dev@flipkart.com>
(cherry picked from commit 44643af0b0e51e6550e508d6854bd576d254141d)

rgw/sts: Addition of new STS tests for testing
session policies alongwith role's permission policy
and bucket policy.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit 245a93326ed9d0c091744d28ffb697ac5ba74544)

rgw/s3_boto3:Adds lifecycle transition test for invalid iso8601 date

(cherry picked from commit ba9525f425f7da4c93d12499fffbb0faaab0ef7c)

Fix: Bucket resource leak when cleanup

In the function of nuke_prefixed_buckets, if some err is thrown when deleting buckets, the left buckets remain uncleaned.
It is kind of resoruce leak on some charged platform. We have to clear them manually.

I know the original code is meant to give the user some hint by rasing error. But the resource leak of left buckets is a little annoying.

This PR would skip the problem point and continue the teardown process. The last client error would be saved and re-raised after the loop completes.

Signed-off-by: Pei <huangp0600@126.com>
Signed-off-by: Pei <phuang1@dev-new-3-3854897.slc07.dev.ebayc3.com>
(cherry picked from commit 713012c178b074539cd80e10a26c115194c8571f)

disable ssl verify by default

Signed-off-by: Ali Maredia <amaredia@redhat.com>
(cherry picked from commit b252638369f56ab171bc88d54d71025ce8b8d6c7)

Add support for disabling SSL certificate verification

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
(cherry picked from commit ea3caaa76bf80094596753cc8abab776f9c50253)

Add tests for issue 47586.

(cherry picked from commit 7fe0304e9c373b993465dc5ac4058821c3b03577)

Add test to check retain date is in iso 8601 format

Signed-off-by: Danny Abukalam <danny@softiron.com>
(cherry picked from commit e229d1aaf6eef5133643454a9643276fe34bd4f7)

sts: test role policy around nonexistent objects

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 7276bee050a971b11ccf6f298436bc893620b190)

test that listed buckets have creation time

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 66ced9af1d1f27cb06754607f8df072e7618d57d)

test multipart upload with bucket policy

Signed-off-by: Or Friedmann <ofriedma@redhat.com>
(cherry picked from commit cfdf914c4bccdb75be2c993921ca86ee18caad24)

modifying tests to be align with change of s3select compare sign( == -> = )

Signed-off-by: gal salomon <gal.salomon@gmail.com>
(cherry picked from commit 1572fbc87b0e0fb1bc1530e368d51659e799e9e1)

tests

Signed-off-by: Albin Antony <aantony@redhat.com>
(cherry picked from commit c6a4ab9d125c074b5aa3ac79180fc93e4cfae6a0)

tests

Signed-off-by: Albin Antony <aantony@redhat.com>
(cherry picked from commit e7102e8cb0b499daceb1d2915591e6c2dd3151a0)

tests

Signed-off-by: Albin Antony <aantony@redhat.com>
(cherry picked from commit 60dd3444b3a68c64d845540e1bffe17ab029e718)

s3select: align s3-tests with new changes in s3select

Fix when then, date functions and NULL, add escape, trim tests

Signed-off-by: Albin Antony <aantony@redhat.com>
(cherry picked from commit 4a86ebbe8b666dbbcf9c5b6b7935129dfd242b28)

test extra complete_multipart_upload()

after the 1st successfull one should also return 200 OK

related tracker issue: https://tracker.ceph.com/issues/50141
related pr: https://github.com/ceph/ceph/pull/40594

Signed-off-by: Mark Kogan <mkogan@redhat.com>

change test_s3select.py permission; add s3select attribute

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
(cherry picked from commit ea7d5fb563351b176d787b744cafd4ae58aa7b71)

reduce object size for test_like_expression, it may cause timeouts in teuthology runs

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

rename charlength and character_length function names

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Add test for head bucket usage headers

Signed-off-by: Or Friedmann <ofriedma@redhat.com>
(cherry picked from commit ef8f65d917877601f0d18f08dd8ae81f03d0ee1c)

Add test for GetUsage api

Signed-off-by: Or Friedmann <ofriedma@redhat.com>
(cherry picked from commit f4f7812efd5b42a3b255148ab67424a4a00ba2fb)

s3select tests for coalesce and case

Signed-off-by: Albin Antony <aantony@redhat.com>

per each new uploaded file(for test), it got unique name(random), and uploaded file is verified for its content

Signed-off-by: gal salomon <gal.salomon@gmail.com>
Signed-off-by: gal salomon <gal.salomon@gmail.com>

s3select predicate tests

Signed-off-by: Albin Antony <aantony@redhat.com>

Webidentity Test addition to test_sts.py

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
Few main changes/additions:
1. Webidentity test addition to test_sts.py.
2. A function named check_webidentity() added to __init__.py in order to check for section presence.
3. Few lines shifted from setup() to get_iam_client() to make them execute only when sts-tests run.
4. Documentation update (for sts section)
5. Changes in s3tests.conf.SAMPLE regarding sts sections

Add test for HeadBucket on a non-existent bucket

n.b., RGW does not send a response document for this operation,
which seems consistent with
https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Check if invalid payload is added after serving errordoc

Signed-off-by: Ilsoo Byun <ilsoobyun@linecorp.com>
(cherry picked from commit c08de72d55202381628737a11bb1a4079257d016)

test bucket recreation with different acls

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit f6218fa1deaa83e802e246cbb3c0936a2cfb833c)

STS issue fix (https://tracker.ceph.com/issues/47588)

This is the fix for the issue reported (https://tracker.ceph.com/issues/47588). The issue was with the argument which was passed to the function. After removing that argument (as it's already an optional argument) the issue is fixed.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
(cherry picked from commit daf9062a225831a420e471ee0459abc799c45439)

add noncurrent version expiration rule w/tag filter

Create 10 object versions (9 noncurrent).  Install a noncurrent
version expiration at 4 days.  Verify that 10 versions exist at
T+20, and only 1 (current) at T+60.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

add lifecycle expiration test mixing 2-tag filter w/versioning

By design this test duplicates test_lifecycle_expiration_tags2,
but enables object versioning on the bucket.

The tests install a rule which requires -2- tags to be matched,
and creates 2 objects, one matching only 1 of the required tags,
the other matching both.  Only the 2nd object should expire.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

add tests for lifecycle expiration w/1 and 2 object tags

Note that the 1-tag case contains a filter prefix--which exposes
an apparent bug parsing Filter when it contains a Prefix element
and a single Tag element (without And).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

fix lifecycle expiration days: 0

In fact test_lifecycle_expiration_days0 is should fail, as 0-day
expiration is permitted for transition rules but not expiration
rules.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

s/test_set_tagging/test_set_bucket_tagging/;

The test exercises bucket tagging, has nothing to do with object
tagging (clarity).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

fix test_lifecycle_expiration_header_{put,head}

Primarily fixes the expiration header() verifier function
check_lifecycle_expiration_header, but also cleans up
prefix handling in setup_lifecycle_expiration().

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

fix and remark on test_lifecycle_expiration_days0

1. fix a python3-related KeyError exception

2. note here:  AWS documentation includes examples of "Days 0"
   in use, but boto3 will not accept them--this is why the days0
   test currently sets Days 1

3. delay increased to 30s, to avoid occasional failures due to
   jitter

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

STS Tests Files and modification in __init__.py

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>

add filter for s3select tests

Signed-off-by: gal salomon <gal.salomon@gmail.com>
(cherry picked from commit fce9a52ef4311c6a89d05452776affe63dfbafe6)

fix comments;remove non-used imports;enable test for projection;using get_client()

(cherry picked from commit 72e251ed69af4cd69de311d39c7f492292528c70)

adding radom-generated tests, one for where clause , the second for prjection. random arithmetical expression is generated and used for building s3-select query; result is compared to python-engine

(cherry picked from commit fb39ac4829816e19a502e7c4d7c4f9f9ab941945)

python linter; replace assert with assert_equal; add complex query test(sum,count,where); add test-schema ;

(cherry picked from commit e006dd47537ba56dfcdad2fcf27f15d21ed209d6)

using config parameters

(cherry picked from commit 1a9d3677f7f77597bc8208232ee0bb4f7ef7322c)

add tests to validate csv-header-info functionalities is correct

(cherry picked from commit 5dc8bc75ab3365d652945c63bd3bceaddb46f825)

adding test cases for processing CSV objects with different CSV definitions; validate null,escape-rules and quotes are processed correctly

(cherry picked from commit 94b19862284f13d351ea4e5164300a3841fbf091)

adding utcnow test

(cherry picked from commit 4c7c279f7017a3510543de5c4b2dff4f15255e65)

adding tests for date-time functionalities

(cherry picked from commit 5925f0fb3f5918fed5c30ff53475c72bf5e13a5a)

add complex expression tests; for nested function calls; and different where-clause which create the same group of values

(cherry picked from commit c1bce6ac705d79a3530c30c2f4d5450570abcd3c)

adding test for detection of cyclic reference to alias

(cherry picked from commit d543619e7162aaedbff58b8f30f4d08da14c5493)

adding aggregation tests

(cherry picked from commit f42872fd53478d5510dff236ee96a5f0559f0096)

adding alias test case

(cherry picked from commit 74daf86fe5e08f9a4dfb945f3e4b538504803dbb)

commit first tests for s3select and initial framework

(cherry picked from commit dac38694ef8897dc5721c0125e3a538aa530b9ae)

fix/restore test_lifecycle_expiration checks

Commit bf956df71e56bcdae7d41b9789d8e8d775f76007 adding
listobvjectsv2 tests inadvertently changed the v1
test_lifecycle_expiration test, which it had copied to
create a v2 version.  Revert this.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

bootstrap,requirements.txt: bump up setuptools and requests

Fixes: https://tracker.ceph.com/issues/45691
Signed-off-by: Kefu Chai <kchai@redhat.com>

bootstrap: remove deprecated virtualenv options

this fails on Ubuntu 20.04:

> virtualenv: error: unrecognized arguments: --no-site-packages --distribute

according to `virtualenv -h`:

>   --no-site-packages    DEPRECATED. Retained only for backward compatibility.
>                         Not having access to global site-packages is now the
>                         default behavior.
>   --distribute          DEPRECATED. Retained only for backward compatibility.
>                         This option has no effect.

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit a0c15c80ad95257d713e7587f070772f416122d6)

Merge pull request #343 from theanalyst/ceph-master-public-buckets-qa

Ceph master public buckets backport

Reviewed-By: Casey Bodley <cbodley@redhat.com>

fix ignore public acls with py3 compatible code

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 4d675235ddc12478a0075fe937e2e4919f0ad5b9)

add tests for ignore public acls

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 3b1571ace6c27a1f8995e42576e1d779848d110f)

add test for block public policy

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit b4516725f28aad87796e442682fec23a4fb7e7e3)

use empty bodies for  canned acl tests with BlockPublicAccess

This should be a temporary workaround until #42208 is fixed

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit d02c1819f67011d6869b86d4497cf6c31fc7be5c)

remove redundant get_client calls

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 4996430709ba3910a7cb8380f25f81c0e3da88a0)

add ability to get svc client for s3config set of apis

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 6d3f574a8ec8e61a2d5591a4c448b5b9e6404598)

add tests for public access configuration

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 1ad38530e07b388e54f4aee93d4b55344b015132)

add a few test cases for public bucket policies

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 3f9d31c6c77ee8e12cb95511898e3c59a6dee62b)

boto3: add bucket policy status checks for public ACLs

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 02b1d50ca7064ced156482b86817b44356683ad2)

Merge pull request #340 from theanalyst/bootstrap-suse

bootstrap: add support for *suse distributions

bootstrap: add support for *suse distributions

Also reformatted the bootstrap script to parse /etc/os-release instead, so that
more distro/pkg manager support could be added at a later point in time and
fixed the error message

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #337 from ceph/wip-python-3-port

Wip python 3 port

remove all non-functional tests and infra

Signed-off-by: Ali Maredia <amaredia@redhat.com>

Port functional tests from python 2 to python 3

Add fails_on_rgw to tests not passing. Some
tests from the master branch do not pass on the
rgw yet. Others waiting on rgw tracker issues to
be resolved.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #314 from theanalyst/iam/user-policy-basic

iam: add a very basic user policy smoke test

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Pritha Srivastava <prsivas@redhat.com>
Reviewed-By: Yuval Lifshitz <yuvalif@yahoo.com>

Merge pull request #311 from theanalyst/encoding-type

list-objects: add basic tests for encoding

Reviewed-By: Casey Bodley <cbodley@redhat.com>

iam: explicitly set a region for the iam client

Avoids region not defined errors

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

iam: add a very basic user policy smoke test

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #331 from yehudasa/wip-which

bootstrap: different packages for 'which'

Merge pull request #321 from romayalon/tags-order-fix

test_put_obj_with_tags

bootstrap: different packages for 'which'

Either debianutils or which.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #330 from yehudasa/wip-bash

bootstrap: switch to bash

bootstrap: switch to bash

Use of declare that is bash specific was introduced in:
d44c923405e22ea8b6cc1ab4316be3cc07f29b5

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #326 from ceph/wip-bootstrap-fix

Minor fix to Centos 8 bootstrap changes