]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Pere Diaz Bou [Thu, 21 Oct 2021 09:14:29 +0000 (11:14 +0200)]
monitoring: ethernet bonding filter in Network Load
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Kefu Chai [Wed, 27 Oct 2021 01:26:05 +0000 (09:26 +0800)]
Merge pull request #43630 from kkang-wr/master
cmake: add support for python 3.10
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 27 Oct 2021 01:09:01 +0000 (09:09 +0800)]
Merge pull request #43648 from rzarzynski/wip-crimson-proper-addrs-for-hbmsgrs
crimson/osd: fix network address selection for hearbeat's messengers.
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Kefu Chai [Wed, 27 Oct 2021 01:04:18 +0000 (09:04 +0800)]
Merge pull request #43671 from javicacheiro/python_data_as_binary
doc/rbd: correct sample code to use byte string for data
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 27 Oct 2021 01:01:44 +0000 (09:01 +0800)]
Merge pull request #43674 from rzarzynski/wip-crimson-net-honor_listen_type
crimson/net: FixedCPUServerSocket::accept() respects the listening addr's type.
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Radoslaw Zarzynski [Tue, 26 Oct 2021 18:03:31 +0000 (18:03 +0000)]
crimson/net: FixedCPUServerSocket::accept() respects the listening addr's type.
For the sake of compliance with the classical OSD where the type
of the listening address is being reflected in the address type
of an accepted connection:
```
int PosixServerSocketImpl::accept(ConnectedSocket *sock, const SocketOptions &opt, entity_addr_t *out, Worker *w) {
// ...
sockaddr_storage ss;
// ...
int sd = accept_cloexec(_fd, (sockaddr*)&ss, &slen);
if (sd < 0) {
return -ceph_sock_errno();
}
// ...
out->set_type(addr_type);
out->set_sockaddr((sockaddr*)&ss);
handler.set_priority(sd, opt.priority, out->get_family());
}
```
In Rook crimson binds explicitly to v2 address:
```
INFO 2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
ERROR 2021-10-26 17:55:08,116 [shard 0] none - Falling back to public interface
INFO 2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Sage Weil [Tue, 26 Oct 2021 17:18:41 +0000 (13:18 -0400)]
Merge PR #43627 into master
* refs/pull/43627/head:
Revert "Merge pull request #42099 from aclamk/wip-bluefs-fine-grain-locking-2"
Reviewed-by: Neha Ojha <nojha@redhat.com>
Javier Cacheiro [Tue, 26 Oct 2021 15:14:15 +0000 (17:14 +0200)]
doc: data must be a byte string
Data must be a byte string in python 3.
Signed-off-by: Javier Cacheiro <javier.cacheiro.lopez@cesga.es>
Sebastian Wagner [Tue, 26 Oct 2021 14:29:42 +0000 (16:29 +0200)]
Merge pull request #43668 from rhcs-dashboard/kube-v1_events-update
mgr/k8sevents: pin the kubernetes version to 11.0.0
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Nizamudeen A [Tue, 26 Oct 2021 11:33:33 +0000 (17:03 +0530)]
mgr/k8sevents: pin the kubernetes version to 11.0.0
Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A <nia@redhat.com>
Ernesto Puerta [Tue, 26 Oct 2021 08:52:13 +0000 (10:52 +0200)]
Merge pull request #43640 from rhcs-dashboard/module-status-guard-error-handling
mgr/dashboard: Proper error handling in module status guard
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Ernesto Puerta [Tue, 26 Oct 2021 08:51:22 +0000 (10:51 +0200)]
Merge pull request #43639 from rhcs-dashboard/angular-11-form-fix
mgr/dashboard: Fix for form inside form closing issue
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Sebastian Wagner [Tue, 26 Oct 2021 08:42:05 +0000 (10:42 +0200)]
Merge pull request #43560 from pcuzner/fix-orch-device-zap
mgr/cephadm: improve validation of orch device zap
Reviewed-by: Sage Weil <sage@newdream.net>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 26 Oct 2021 08:27:24 +0000 (10:27 +0200)]
Merge pull request #43499 from jecluis/wip-cephadm-insecure
cephadm: allow pulling from insecure registries
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 26 Oct 2021 08:26:44 +0000 (10:26 +0200)]
Merge pull request #43502 from adk3798/rm-testing2
mgr/cephadm: remove host addr from agent deps
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 26 Oct 2021 08:24:32 +0000 (10:24 +0200)]
Merge pull request #43579 from sebastian-philipp/cephadm-monitoring-ipv6
mgr/cephadm: Fix IPv6 in monitoring services
Reviewed-by: Adam King <adking@redhat.com>
Samuel Just [Tue, 26 Oct 2021 08:12:07 +0000 (01:12 -0700)]
Merge pull request #43632 from myoungwon/wip-alloc-free-rbm-paddr
seastore: add alloc/free extent for RBM based on paddr_t
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Tue, 26 Oct 2021 07:40:54 +0000 (00:40 -0700)]
Merge pull request #43641 from athanatos/sjust/wip-52805
crimson/os/seastore: fix LBABtree::lower_bound behavior
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Samuel Just [Mon, 25 Oct 2021 22:52:19 +0000 (15:52 -0700)]
Merge pull request #43651 from rzarzynski/wip-crimson-net-fix-nonceportcheck
crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 21:18:03 +0000 (14:18 -0700)]
Merge pull request #43650 from rzarzynski/wip-crimson-improve-dbgs
crimson, monmap: fix / improve miscellaneous debugs
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 21:17:11 +0000 (14:17 -0700)]
Merge pull request #43652 from rzarzynski/wip-crimson-osd-seqmeta
crimson/osd: write object store's meta sequentially.
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 07:47:16 +0000 (07:47 +0000)]
crimson/os/seastore/.../lba_btree: fix min_capacity condition
Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73. At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.
Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 06:26:05 +0000 (06:26 +0000)]
crimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()
Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.
Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.
Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 06:14:08 +0000 (06:14 +0000)]
crimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary
Factor out helper to adjust iterators at_boundary().
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 06:03:33 +0000 (23:03 -0700)]
crimson/os/seastore/lba_manager/lba_btree: add at_boundary helper distinct from is_end
From an external caller, the condition is identical. However, internally
iterators may be at a leaf boundary without being at end(). For those
checks, use at_boundary() instead.
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 05:39:49 +0000 (22:39 -0700)]
crimson/test/seastore/test_btree_lba_manager: shorten tests a bit
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Fri, 22 Oct 2021 06:15:33 +0000 (23:15 -0700)]
test/crimson/seastore/test_btree_lba_manager: add LBABtree level unit tests
Signed-off-by: Samuel Just <sjust@redhat.com>
Mykola Golub [Mon, 25 Oct 2021 15:12:38 +0000 (18:12 +0300)]
Merge pull request #41696 from MrFreezeex/fix-rbd-mirror-remove
rbd-mirror: fix mirror image removal
Reviewed-by: Mykola Golub <mgolub@suse.com>
Yuval Lifshitz [Mon, 25 Oct 2021 14:07:14 +0000 (17:07 +0300)]
Merge pull request #43528 from TRYTOBE8TME/wip-rgw-malformed-url-fix
src/rgw: Fix for malformed url
Mykola Golub [Mon, 25 Oct 2021 13:19:48 +0000 (16:19 +0300)]
Merge pull request #41657 from sunnyku/wip-rbd-50787
librbd/object_map: rbd diff between two snapshots lists entire image content
Reviewed-by: Mykola Golub <mgolub@suse.com>
Radoslaw Zarzynski [Mon, 25 Oct 2021 12:30:39 +0000 (12:30 +0000)]
crimson/osd: write object store's meta sequentially.
We're violating the contract on `ObjectStore::write_meta()' that
requires the method must be called in one-by-one manner.
For instance, the implementation in `BlueStore` does read-modify-
write without any locking. Having multiple in-flight requests
the same time (can happen b/c of the thread pool in `AlienStore`)
may lead to a corruption like the following one:
```
[2021-10-25 13:38:38,725][ceph_volume.process][INFO ] Running command: /home/rzarz/dev/ceph1/build/bin/ceph-bluestore-tool show-label --dev /dev/nvme0n1p3
[2021-10-25 13:38:38,737][ceph_volume.process][INFO ] stdout {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "/dev/nvme0n1p3": {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "osd_uuid": "
a11030f3 -f41f-482c-916c-
98476feaf25f ",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "size":
1022903713792 ,
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "btime": "2021-10-25T12:41:11.938439+0200",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "description": "main",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "bfm_blocks": "
249732352 ",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "bfm_blocks_per_key": "128",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "bfm_bytes_per_block": "4096",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "bfm_size": "
1022903713792 ",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "bluefs": "1",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "ceph_fsid": "
f884fe47 -b307-46f9-b021-
320d7c5a427b ",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "kv_backend": "rocksdb",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout "mkfs_done": "yes"
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.process][INFO ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][ERROR ] device /dev/nvme0n1p3 does not have all BlueStore data needed to be a valid OSD: ['{', ' "/dev/nvme0n1p3": {', ' "osd_uuid": "
a11030f3 -f41f-482c-916c-
98476feaf25f ",', ' "size":
1022903713792 ,', ' "btime": "2021-10-25T12:41:11.938439+0200",', ' "description": "main",', ' "bfm_blocks": "
249732352 ",', ' "bfm_blocks_per_key": "128",', ' "bfm_bytes_per_block": "4096",', ' "bfm_size": "
1022903713792 ",', ' "bluefs": "1",', ' "ceph_fsid": "
f884fe47 -b307-46f9-b021-
320d7c5a427b ",', ' "kv_backend": "rocksdb",', ' "mkfs_done": "yes"', ' }', '}']
'whoami'
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][INFO ] device /dev/nvme0n1p3 does not have BlueStore information
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit
92b2fe955f9cafdf6a9c6adb8eadc5f6a9fb9b8b )
Radoslaw Zarzynski [Thu, 21 Oct 2021 12:51:25 +0000 (12:51 +0000)]
crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Mon, 25 Oct 2021 12:41:02 +0000 (12:41 +0000)]
crimson/osd: fix broken debug in OSD::_write_superblock().
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit
48d5fc45e3e95485e89419bec716fddfb7029a18 )
Radoslaw Zarzynski [Wed, 20 Oct 2021 12:04:36 +0000 (12:04 +0000)]
crimson/osd: improve debugs around heatbeat's binding procedure.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Wed, 20 Oct 2021 11:53:41 +0000 (11:53 +0000)]
crimson/osd: inform about replacing cluster messenger's unknown addresses.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Mon, 11 Oct 2021 19:54:05 +0000 (19:54 +0000)]
crimson, monmap: add more debugs around building initial monmap.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Nizamudeen A [Sat, 23 Oct 2021 19:06:51 +0000 (00:36 +0530)]
mgr/dashboard: Fix for form inside form closing issue
After the angular 11 upgrade the form in form behaviour got broken when
one tries to close that "embedded" form. This commit is to fix that
behaviour.
Fixes: https://tracker.ceph.com/issues/53020
Signed-off-by: Nizamudeen A <nia@redhat.com>
Ernesto Puerta [Mon, 25 Oct 2021 11:12:12 +0000 (13:12 +0200)]
Merge pull request #43642 from rhcs-dashboard/pin-version-req-lint
mgr/dashboard: pin a version for autopep8 and pyfakefs
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Nizamudeen A [Mon, 25 Oct 2021 08:42:57 +0000 (14:12 +0530)]
mgr/dashboard: pin a version for autopep8 and pyfakefs
Fixes: https://tracker.ceph.com/issues/53024
Signed-off-by: Nizamudeen A <nia@redhat.com>
Samuel Just [Fri, 22 Oct 2021 06:14:20 +0000 (23:14 -0700)]
crimson/os/seastore/.../lba_btree_node.h: add operator== for lba_map_val_t
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 20 Oct 2021 06:48:41 +0000 (23:48 -0700)]
crimson/os/seastore/lba_manager/btree: tolerate op_context_t without pins
Simpler to construct unit tests for the LBABTree itself without pins.
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 20 Oct 2021 05:47:44 +0000 (05:47 +0000)]
test/crimson/seastore/test_btree_lba_manager: factor out btree_test_base
We're going to use this to create tests for LBABtree in isolation.
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 25 Oct 2021 04:45:18 +0000 (21:45 -0700)]
crimson/os/seastore/object_data_handler.cc: misc logging improvements
Signed-off-by: Samuel Just <sjust@redhat.com>
Xuehan Xu [Tue, 19 Oct 2021 05:27:59 +0000 (13:27 +0800)]
crimson/os/seastore: debug outputs
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Samuel Just [Mon, 25 Oct 2021 06:51:32 +0000 (23:51 -0700)]
crimson/os/seastore/.../lba_btree: fix logging for LBABtree::handle_split
Signed-off-by: Samuel Just <sjust@redhat.com>
Nizamudeen A [Mon, 25 Oct 2021 07:25:35 +0000 (12:55 +0530)]
mgr/dashboard: Proper error handling in module status guard
I've recently introduced a check that verifies if the orch_backend we need for a feature matches the orch_backend of the cluster. But to verify this I need to call configOpt API and some user's don't have the permission to access it. So it'll show this Access Denied page.
Fixes: https://tracker.ceph.com/issues/53021
Signed-off-by: Nizamudeen A <nia@redhat.com>
Mykola Golub [Sun, 24 Oct 2021 07:44:00 +0000 (10:44 +0300)]
Merge pull request #43633 from ideepika/wip-rbd-full-try-test-fixups
test/librbd: harden RemoveFullTry tests
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Ilya Dryomov [Thu, 14 Oct 2021 19:40:49 +0000 (21:40 +0200)]
qa/suites/rbd: whitelist POOL_FULL due to quota for test_librbd.sh
RemoveFullTry tests fill up the pool and expect EDQUOT.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 14 Oct 2021 18:35:16 +0000 (20:35 +0200)]
test/librbd: don't run RemoveFullTry tests with persistent writeback cache
Persistent writeback cache messes with pool quota enforcement on the
OSD side and we don't always break out of the write zeroes loop:
src/test/librbd/test_librbd.cc:2165: Failure
Value of: off >= quota && off < size
Actual: false
Expected: true
Unfortunately persistent writeback cache doesn't honor FUA [1] so the
workaround for volatile caches from the previous patch doesn't apply.
[1] https://tracker.ceph.com/issues/49715
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sat, 16 Oct 2021 21:12:34 +0000 (23:12 +0200)]
test/librbd: set FUA on writes in remove_full_try()
Work around write-back or write-around cache getting enabled (e.g. if
one runs the tests with rbd_cache_writethrough_until_flush disabled).
Fixes: https://tracker.ceph.com/issues/52883
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
myoungwon oh [Tue, 12 Oct 2021 13:48:17 +0000 (22:48 +0900)]
seastore: add device_id_t in RBM
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
myoungwon oh [Fri, 13 Aug 2021 04:42:52 +0000 (13:42 +0900)]
seastore: add rbm alloc infos when alloc_extent() is called
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
myoungwon oh [Fri, 13 Aug 2021 03:55:17 +0000 (12:55 +0900)]
seastore: free allocated extent if extent is retiered
This commit frees allocated extent when the extent is retired
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
myoungwon oh [Sat, 23 Oct 2021 13:45:16 +0000 (22:45 +0900)]
seastore: make rbm_alloc_delta_t to use pair<paddr_t, size>
This commit makes rbm_alloc_delta_t to use std::pair based on
paddr_t in order that other modules such as cache, which does not
know about RBM, can add free information.
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Samuel Just [Sat, 23 Oct 2021 04:42:44 +0000 (21:42 -0700)]
Merge pull request #43629 from athanatos/sjust/wip-fix-fsdriver
crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Kai Kang [Fri, 22 Oct 2021 06:59:28 +0000 (14:59 +0800)]
cmake: add support for python 3.10
Signed-off-by: Kai Kang <Kai.Kang@windriver.com>
Mykola Golub [Fri, 22 Oct 2021 06:49:12 +0000 (09:49 +0300)]
Merge pull request #43573 from idryomov/wip-create-ioctx-preserve-full-try
librbd: preserve CEPH_OSD_FLAG_FULL_TRY in create_ioctx()
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Mykola Golub [Fri, 22 Oct 2021 06:48:47 +0000 (09:48 +0300)]
Merge pull request #43568 from idryomov/wip-writesame-fua
librbd: honor FUA op flag for write_same() in write-around cache
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Samuel Just [Fri, 22 Oct 2021 06:15:07 +0000 (23:15 -0700)]
crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature
Introduced: e5f7ff
Fixes: https://tracker.ceph.com/issues/53012
Signed-off-by: Samuel Just <sjust@redhat.com>
myoungwon oh [Fri, 22 Oct 2021 06:26:52 +0000 (15:26 +0900)]
seastore: make public interfaces in RBM to use paddr_t
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
myoungwon oh [Tue, 5 Oct 2021 01:37:59 +0000 (10:37 +0900)]
seastore: add blocks_per_segment to use paddr_t in RBM
Seastore exploits paddr_t to represent its address.
However. the term of "segment" in paddr_t generally be used in LFS,
not random block design---"block" is more general term of RBM.
The problem is that seasore already has been tighly coupled with padd_t,
also it does not make sense that there are two differnt address
such as paddr_t and block_paddr_t.
Therefore, to solve this problem, this commit adds blocks_per_segment, which
describes how many blocks a single segment contains to make RBM be compotible
with paddr_t
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
J. Eric Ivancich [Fri, 22 Oct 2021 02:43:24 +0000 (22:43 -0400)]
Merge pull request #42151 from chapche/wip-tracker-51466
rgw: cls_bucket_list_unordered() might return one redundent entry every time is_truncated is true
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Sage Weil [Fri, 22 Oct 2021 02:18:12 +0000 (22:18 -0400)]
Revert "Merge pull request #42099 from aclamk/wip-bluefs-fine-grain-locking-2"
This reverts commit
44e89c613c6b882f3436714fdaa6c9c04b94b62d , reversing
changes made to
552ac6657753f00f039f267e20e5a4c399c2bb10 .
This is causing failures in
ObjectStore/StoreTestSpecificAUSize.SyntheticMatrixCsumVsCompression/2
and ObjectStore/StoreTestSpecificAUSize.SpilloverFixedTest/2
Signed-off-by: Sage Weil <sage@newdream.net>
Radoslaw Zarzynski [Thu, 21 Oct 2021 12:55:19 +0000 (12:55 +0000)]
crimson/osd: fix network address selection for hearbeat's messengers.
Public and cluster messenger instances binds to `INADDR_ANY` and learns
their local addresses later which allows to deal with some exotic network
arrangements.
````
INFO 2021-10-21 12:18:57,740 [shard 0] osd - picked address v2:0.0.0.0:0/0
ERROR 2021-10-21 12:18:57,740 [shard 0] none - Falling back to public interface
INFO 2021-10-21 12:18:57,740 [shard 0] osd - picked address v2:0.0.0.0:0/0
DEBUG 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(cluster) v2:0.0.0.0:6800/
3159356168 ] do_listen: try listen v2:0.0.0.0:6800/
3159356168 ...
DEBUG 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(client) v2:0.0.0.0:6800/
3159356168 ] do_listen: try listen v2:0.0.0.0:6800/
3159356168 ...
INFO 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(cluster) v2:0.0.0.0:6800/
3159356168 ] try_bind: done
INFO 2021-10-21 12:18:57,741 [shard 0] osd - pg_epoch 84 pg[1.c( v 84'194 (0'0,84'194] local-lis/les=82/83 n=1 ec=13/7 lis/c=82/82 les/c/f=83/83/0 sis=82) [0] r=0 lpr=0 crt=84'194 lcod 0'0 mlcod 0'0 unknown exit Initial 0.723432 0 0.000000
INFO 2021-10-21 12:18:57,741 [shard 0] osd - Exiting state: Initial, entered at
1634818737 .017936, 0.0 spent on 0 events
INFO 2021-10-21 12:18:57,741 [shard 0] osd - pg_epoch 84 pg[1.c( v 84'194 (0'0,84'194] local-lis/les=82/83 n=1 ec=13/7 lis/c=82/82 les/c/f=83/83/0 sis=82) [0] r=0 lpr=0 crt=84'194 lcod 0'0 mlcod 0'0 unknown enter Reset
INFO 2021-10-21 12:18:57,741 [shard 0] osd - Entering state: Reset
INFO 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(cluster) v2:0.0.0.0:6800/
3159356168 ] try_bind: done
DEBUG 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(client) v2:0.0.0.0:6801/
3159356168 ] do_listen: try listen v2:0.0.0.0:6801/
3159356168 ...
INFO 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(client) v2:0.0.0.0:6801/
3159356168 ] try_bind: done
INFO 2021-10-21 12:18:57,741 [shard 0] ms - [osd.0(client) v2:0.0.0.0:6801/
3159356168 ] try_bind: done
```
The two messenger instances dedicated to hearbeat should follow this policy.
Unfortunately, crimson -- in contrast to the classical OSD -- uses the public's
and cluster's addresses *learned from clients*.
```
INFO 2021-10-21 12:18:57,747 [shard 0] osd - heartbeat: start front_addrs=v2:172.17.0.1:6801/
3159356168 , back_addrs=v2:172.17.0.1:6800/
3159356168
DEBUG 2021-10-21 12:18:57,748 [shard 0] ms - [osd.0(hb_back) v2:172.17.0.1:6800/
3159356168 ] do_listen: try listen v2:172.17.0.1:6800/
3159356168 ...
DEBUG 2021-10-21 12:18:57,748 [shard 0] ms - [osd.0(hb_front) v2:172.17.0.1:6800/
3159356168 ] do_listen: try listen v2:172.17.0.1:6800/
3159356168 ...
DEBUG 2021-10-21 12:18:57,748 [shard 0] ms - [osd.0(hb_back) v2:172.17.0.1:6801/
3159356168 ] do_listen: try listen v2:172.17.0.1:6801/
3159356168 ...
DEBUG 2021-10-21 12:18:57,748 [shard 0] ms - [osd.0(hb_front) v2:172.17.0.1:6801/
3159356168 ] do_listen: try listen v2:172.17.0.1:6801/
3159356168 ...
```
If a network interface's address is different than the one visible-to and
learned-from clients, all attempts to bind fail with `EADDRNOTAVAIL`
(usually `99` for `errno`).
```
DEBUG 2021-10-21 12:19:13,284 [shard 0] ms - [osd.0(hb_back) v2:172.17.0.1:7550/
3159356168 ] do_listen: try listen v2:172.17.0.1:7550/
3159356168 ...
DEBUG 2021-10-21 12:19:13,284 [shard 0] ms - [osd.0(hb_front) v2:172.17.0.1:7568/
3159356168 ] do_listen: try listen v2:172.17.0.1:7568/
3159356168 ...
INFO 2021-10-21 12:19:13,284 [shard 0] ms - [osd.0(hb_front) v2:172.17.0.1:7568/
3159356168 ] was unable to bind after 3 attempts: generic:99
ERROR 2021-10-21 12:19:13,284 [shard 0] osd - heartbeat messenger bind(v2:172.17.0.1:0/
3159356168 ): generic:99
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Mark Kogan [Thu, 21 Oct 2021 14:35:53 +0000 (17:35 +0300)]
Merge pull request #43503 from mkogan1/wip-fips-md5
rgw: under fips, set flag to allow md5 in select rgw ops
Patrick Donnelly [Thu, 21 Oct 2021 14:26:43 +0000 (10:26 -0400)]
Merge PR #43566 into master
* refs/pull/43566/head:
qa: reduce frag split confs for dir_split counter test
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Daniel Gryniewicz [Thu, 21 Oct 2021 14:21:12 +0000 (10:21 -0400)]
Merge pull request #43600 from smithfarm/wip-52979
rgw/tracing: unify SO version numbers within librgw2 package
Reviewed-by: Casey Bodley <cbodley@redhat.com>
zdover23 [Thu, 21 Oct 2021 11:14:01 +0000 (21:14 +1000)]
Merge pull request #43586 from sebastian-philipp/docs-email-contact
doc/start: documenting-ceph: Remove email to ceph-docs@redhat.com
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Sebastian Wagner [Thu, 21 Oct 2021 11:08:38 +0000 (13:08 +0200)]
Merge pull request #43604 from zdover23/wip-doc-2021-10-21-cephadm-install-typo
doc/cephadm: update typo in install.rst
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Sebastian Wagner [Thu, 21 Oct 2021 10:53:39 +0000 (12:53 +0200)]
Merge pull request #43616 from krafZLorG/fix-cephadm-chooseleaf
cephadm: Fix option name osd_crush_chooseleaf_type
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
krafZLorG [Thu, 21 Oct 2021 07:27:14 +0000 (10:27 +0300)]
Fix option name osd_crush_chooseleaf_type
Signed-off-by: Dmitry Kvashnin <dm.kvashnin@gmail.com>
Patrick Donnelly [Thu, 21 Oct 2021 02:27:40 +0000 (22:27 -0400)]
Merge PR #43508 into master
* refs/pull/43508/head:
mds/FSMap: do not assert allow_standby_replay on old FSMaps
Reviewed-by: Ramana Raja <rraja@redhat.com>
Patrick Donnelly [Thu, 21 Oct 2021 02:26:41 +0000 (22:26 -0400)]
Merge PR #43506 into master
* refs/pull/43506/head:
mon/MDSMonitor: avoid crash when decoding old FSMap epochs
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Patrick Donnelly [Thu, 21 Oct 2021 02:25:58 +0000 (22:25 -0400)]
Merge PR #40183 into master
* refs/pull/40183/head:
client: remove useless mds member in Fh class
client: adjust the Fh class members order
client: switch to use shared_ptr for mds_sessions
client: minor cleanup to Fh related code
client: minor cleanup to MetaRequest class
client: minor cleanup to Client related code
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Patrick Donnelly [Thu, 21 Oct 2021 02:24:32 +0000 (22:24 -0400)]
Merge PR #38752 into master
* refs/pull/38752/head:
qa: enable dynamic debug support to kclient
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sage Weil [Wed, 20 Oct 2021 21:50:21 +0000 (17:50 -0400)]
Merge PR #43138 into master
* refs/pull/43138/head:
mgr/rook: implement `orch device zap` in rook orchestrator
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
J. Eric Ivancich [Wed, 20 Oct 2021 18:38:26 +0000 (14:38 -0400)]
Merge pull request #43594 from ivancich/wip-bucket-fix-pool-actual
rgw: have "bucket check --fix" fix pool ids correctly
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
J. Eric Ivancich [Wed, 20 Oct 2021 17:49:20 +0000 (13:49 -0400)]
Merge pull request #43429 from ivancich/wip-document-rgw_lc_debug_interval
rgw: document rgw_lc_debug_interval configuration option
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
J. Eric Ivancich [Wed, 13 Oct 2021 13:43:59 +0000 (09:43 -0400)]
rgw: clean up a little LC logging
Some of the LC logging does not put whitespace between some values and
the thread identifier. This commit adds the whitespace.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
J. Eric Ivancich [Mon, 11 Oct 2021 20:17:46 +0000 (16:17 -0400)]
rgw: during "bucket check --fix" set index entry pool id correctly
The current code sets the pool id of bucket index entries to the
bucket index pool rather than the data pool. This fixes that.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
J. Eric Ivancich [Wed, 20 Oct 2021 16:58:39 +0000 (12:58 -0400)]
Merge pull request #43553 from ivancich/wip-bucket-fix-pool
rgw: pass "force check filter" through SAL in bucket listing
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Mykola Golub [Wed, 20 Oct 2021 16:05:46 +0000 (19:05 +0300)]
Merge pull request #43535 from Rethan/fix-image-spec
rbd: correct image_spec() output when rbd-nbd Detach/Unmap error
Reviewed-by: Mykola Golub <mgolub@suse.com>
Ronen Friedman [Wed, 20 Oct 2021 15:03:22 +0000 (18:03 +0300)]
Merge pull request #43596 from ronen-fr/wip-rf-test_info
tests: modify osd-scrub-repair to match PR #43239 changes
Reviewed-by: Mykola Golub <mgolub@suse.com>
Zac Dover [Wed, 20 Oct 2021 14:42:02 +0000 (00:42 +1000)]
doc/cephadm: update typo in install.rst
This PR changes the string
use "--log-to-file" option during bootstrap
to
use the "--log-to-file" option during bootstrap
The way that it was written makes it sound like it was
written by a native Russian speaker. But it was written
by me, a native English speaker, so this is on me.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Neha Ojha [Wed, 20 Oct 2021 13:57:06 +0000 (06:57 -0700)]
Merge pull request #43572 from trociny/wip-qa-backfill-toofull-compress
qa/tasks/backfill_toofull: make test work when compression on
Reviewed-by: Neha Ojha <nojha@redhat.com>
J. Eric Ivancich [Tue, 5 Oct 2021 23:27:27 +0000 (19:27 -0400)]
rgw: document rgw_lc_debug_interval configuration option
Updates the yaml describing this config option with a "desc" and a
"long_desc".
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Sebastian Wagner [Tue, 19 Oct 2021 09:08:35 +0000 (11:08 +0200)]
doc/start: documenting-ceph: Remove email to ceph-docs@redhat.com
Instead get in touch with the component lead.
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 19 Oct 2021 09:07:13 +0000 (11:07 +0200)]
doc/start: documenting-ceph: Improve template of commits
by properly linking the corresponding tracker issue.
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 19 Oct 2021 09:00:26 +0000 (11:00 +0200)]
doc/governanace: Fix my email address
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Nathan Cutler [Wed, 20 Oct 2021 10:51:02 +0000 (12:51 +0200)]
rgw/tracing: unify SO version numbers within librgw2 package
The librgw2 package contains several SO files. Two of those - librgw_op_tp.so
and librgw_rados_tp.so - had a different version number than the main librgw.
This was a violation of the openSUSE Shared Library Packaging Policy [1] but it
also seems like a "violation" of common sense.
[1] https://en.opensuse.org/openSUSE:Shared_library_packaging_policy#Package_naming
Fixes: https://tracker.ceph.com/issues/52979
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Sebastian Wagner [Wed, 20 Oct 2021 09:49:33 +0000 (11:49 +0200)]
Merge pull request #42772 from Daniel-Pivonka/cephadm-add-existing-host
mgr/cephadm: update host when adding host that already exists
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 20 Oct 2021 09:48:42 +0000 (11:48 +0200)]
Merge pull request #43354 from adk3798/daemon-failed-agent
mgr/cephadm: update CEPHADM_FAILED_DAEMON after receiving agent metadata
Reviewed-by: Daniel Pivonka <dpivonka@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Sebastian Wagner [Wed, 20 Oct 2021 09:48:09 +0000 (11:48 +0200)]
Merge pull request #43366 from adk3798/log-list-servers
mgr/cephadm: put list_servers output in debug logs
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 20 Oct 2021 09:47:41 +0000 (11:47 +0200)]
Merge pull request #43367 from adk3798/handle-use-agent
mgr/cephadm: move handling of use_agent setting into agent.py
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 20 Oct 2021 09:46:17 +0000 (11:46 +0200)]
Merge pull request #43489 from adk3798/clear-agent-down
mgr/cephadm: update CEPHADM_AGENT_DOWN when agent reports in
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 20 Oct 2021 09:45:29 +0000 (11:45 +0200)]
Merge pull request #43552 from adk3798/dont-log-credentials
cephadm: do not log commands sent to "call" function
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Ronen Friedman [Wed, 20 Oct 2021 06:42:51 +0000 (06:42 +0000)]
tests: modify osd-scrub-repair to match PR #43239 changes
PR #43239 has modified ECBackend::get_hash_info() behavior.
Modified the standalone scrub test to match.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Samuel Just [Wed, 20 Oct 2021 04:55:23 +0000 (21:55 -0700)]
Merge pull request #43592 from rzarzynski/wip-crimson-mount_ertr
crimson: errorate the FuturizedStore::mount() paths.
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Neha Ojha [Tue, 19 Oct 2021 21:55:16 +0000 (14:55 -0700)]
Merge pull request #42839 from giladmaya/wip-on-wire-compression-documentation
doc: Added msgr on-wire-compression
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Neha Ojha [Tue, 19 Oct 2021 21:54:10 +0000 (14:54 -0700)]
Merge pull request #43577 from ThomasLamprecht/docs-glossary-typo
docs: fix case and spelling of Proxmox VE
Reviewed-by: Laura Flores <lflores@redhat.com>