]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
21 months agocrimson/net: misc cleanups to io handler implementations
Yingxin Cheng [Thu, 1 Jun 2023 10:37:41 +0000 (18:37 +0800)]
crimson/net: misc cleanups to io handler implementations

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 8d0f5943aaa91c220011c67fc43a8aa51c1df52b)

21 months agocrimson/net: misc cleanups to protocol v2 implementations
Yingxin Cheng [Thu, 1 Jun 2023 09:05:42 +0000 (17:05 +0800)]
crimson/net: misc cleanups to protocol v2 implementations

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 6658ba17ef1bcc89b8ff5e74bfc7c7c0b8ef8fac)

21 months agocrimson/net: notify and update io_states from io_handler to protocol asynchronously
Yingxin Cheng [Wed, 31 May 2023 08:57:41 +0000 (16:57 +0800)]
crimson/net: notify and update io_states from io_handler to protocol asynchronously

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit d20fb8304085299d8ec434145d77d1d43af5aae3)

21 months agocrimson/net: introduce a simpler reset_peer_state() with cleanups
Yingxin Cheng [Wed, 31 May 2023 09:21:05 +0000 (17:21 +0800)]
crimson/net: introduce a simpler reset_peer_state() with cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 23c13306776229c237395ccad3b6947a328c2519)

21 months agocrimson/net: clear FrameAssemblerV2 at replace
Yingxin Cheng [Wed, 26 Apr 2023 09:37:16 +0000 (17:37 +0800)]
crimson/net: clear FrameAssemblerV2 at replace

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 51636d9954cbbc8c34ed5f0a275ccc08d9899cf1)

21 months agocrimson/net: adjust the IO path in FrameAssemblerV2 with the foreign socket
Yingxin Cheng [Wed, 26 Apr 2023 09:33:58 +0000 (17:33 +0800)]
crimson/net: adjust the IO path in FrameAssemblerV2 with the foreign socket

FrameAssemblerV2 and Socket may in different cores during handshake.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit d1b4323606a7bdf3ab0db6eca444c1c346c11354)

21 months agocrimson/net: allow FrameAssemblerV2 to check and shutdown a foreign socket
Yingxin Cheng [Wed, 26 Apr 2023 09:27:03 +0000 (17:27 +0800)]
crimson/net: allow FrameAssemblerV2 to check and shutdown a foreign socket

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 50bc62a9da8f18fae1cff86ce8c91f6125a96225)

21 months agocrimson/net: check that FrameAssemblerV2 is working in the expected core
Yingxin Cheng [Wed, 26 Apr 2023 09:14:06 +0000 (17:14 +0800)]
crimson/net: check that FrameAssemblerV2 is working in the expected core

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit c47dc1d0e46add1d9f284d41112e9b772b0b36b9)

21 months agocrimson/net: use SocketFRef
Yingxin Cheng [Wed, 26 Apr 2023 09:06:06 +0000 (17:06 +0800)]
crimson/net: use SocketFRef

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 23c7a85084d9934e252c0c94a6bb39bd3534a861)

21 months agocrimson/net: check that Socket only works in its core
Yingxin Cheng [Wed, 26 Apr 2023 08:45:42 +0000 (16:45 +0800)]
crimson/net: check that Socket only works in its core

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit d5a9f0eda34f08e9eadbdd5d5e2e26147d27f759)

21 months agocrimson/net: wrap message with foreign-ptr in the send path
Yingxin Cheng [Wed, 26 Apr 2023 08:33:28 +0000 (16:33 +0800)]
crimson/net: wrap message with foreign-ptr in the send path

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit db07ae9d5cf8e6ac8031eec0689c74a9d5f55aff)

21 months agocrimson/net: change the static IS_FIXED_CPU to runtime
Yingxin Cheng [Wed, 26 Apr 2023 08:13:48 +0000 (16:13 +0800)]
crimson/net: change the static IS_FIXED_CPU to runtime

Otherwise the messenger implementation needs to be templated.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 58491826d54bbbfeeab1543337c8ff327218db74)

21 months agocrimson/net: decouple tests from SocketConnection class
Yingxin Cheng [Mon, 24 Apr 2023 05:47:22 +0000 (13:47 +0800)]
crimson/net: decouple tests from SocketConnection class

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 7797cabe2ab38eea30eca51614398badef8bada1)

21 months agocrimson/net: hide seastar packet and temporary_buffer inside Socket
Yingxin Cheng [Fri, 21 Apr 2023 03:47:36 +0000 (11:47 +0800)]
crimson/net: hide seastar packet and temporary_buffer inside Socket

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 4dab5cf87ae3561fd67d2538b33eb98b6b7d43de)

21 months agocrimson/net: introduce IOHandler::sid and the related assertions
Yingxin Cheng [Mon, 27 Mar 2023 09:00:13 +0000 (17:00 +0800)]
crimson/net: introduce IOHandler::sid and the related assertions

Note that Connection and Messenger may be destructed in any order, so
keep a copy of msgr_sid in SocketConnection.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 3b47c9a632db4ab04d0a185c598e18b2c1219ee5)

21 months agocrimson/net: move socket ownership from SocketConnection to FrameAssemblerV2
Yingxin Cheng [Mon, 27 Mar 2023 08:58:16 +0000 (16:58 +0800)]
crimson/net: move socket ownership from SocketConnection to FrameAssemblerV2

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 53df464f41e6b9c6b97b6a11771bd0de41f2ab8f)

21 months agocrimson/net: make sure Messenger is always called in the same shard
Yingxin Cheng [Mon, 13 Mar 2023 08:29:12 +0000 (16:29 +0800)]
crimson/net: make sure Messenger is always called in the same shard

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit ec510b57d37c6971f6bfcae4d009f40047dbc537)

21 months agocrimson/net/socket: extend the sockets to multiple shards
Yingxin Cheng [Fri, 10 Mar 2023 02:22:56 +0000 (10:22 +0800)]
crimson/net/socket: extend the sockets to multiple shards

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 9eda402ff4345b347f5da2b050e8f6ed87db7f68)

21 months agotest/crimson/test_socket: fix unaligned memory access
Yingxin Cheng [Fri, 10 Mar 2023 01:55:44 +0000 (09:55 +0800)]
test/crimson/test_socket: fix unaligned memory access

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 95f62d9a4565b6b9a181a1eebcbbd0f94d57fc41)

21 months agotest/crimson: cleanup test_socket.cc
Yingxin Cheng [Mon, 20 Feb 2023 06:37:11 +0000 (14:37 +0800)]
test/crimson: cleanup test_socket.cc

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 761110982331ee56c9986e98098a26f966f5c62c)

21 months agocrimson/net: cleanups to Socket.h/cc
Yingxin Cheng [Mon, 20 Feb 2023 01:41:58 +0000 (09:41 +0800)]
crimson/net: cleanups to Socket.h/cc

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit aec42c07b1602f85bbe82ecd570db4f8bafd29be)

21 months agocrimson/net: drop the template from FixedCPUServerSocket::accept()
Yingxin Cheng [Fri, 17 Feb 2023 09:03:02 +0000 (17:03 +0800)]
crimson/net: drop the template from FixedCPUServerSocket::accept()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 91c5ddc7ef06b1eaabddf06efc6ab8ed4859e27d)

21 months agoMerge pull request #53932 from zdover23/wip-doc-2023-10-11-backport-53908-to-reef
zdover23 [Wed, 11 Oct 2023 04:10:34 +0000 (14:10 +1000)]
Merge pull request #53932 from zdover23/wip-doc-2023-10-11-backport-53908-to-reef

reef: doc/rados: edit memory-profiling.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/rados: edit memory-profiling.rst 53932/head
Zac Dover [Tue, 10 Oct 2023 08:26:53 +0000 (18:26 +1000)]
doc/rados: edit memory-profiling.rst

Edit doc/rados/troubleshooting/memory-profiling.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 3be932425e3020085db5abff6f914938015d8590)

21 months agoMerge pull request #53786 from idryomov/wip-63010-reef
Yuri Weinstein [Tue, 10 Oct 2023 23:09:50 +0000 (16:09 -0700)]
Merge pull request #53786 from idryomov/wip-63010-reef

reef: qa/suites/krbd: stress test for recovering from watch errors

Reviewed-by: Mykola Golub <mgolub@suse.com>
21 months agoMerge pull request #53870 from adk3798/wip-63114-reef
Adam King [Tue, 10 Oct 2023 18:51:30 +0000 (14:51 -0400)]
Merge pull request #53870 from adk3798/wip-63114-reef

reef: mgr/cephadm: ceph orch add fails when ipv6 address is surrounded by square brackets.

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge pull request #53866 from adk3798/wip-62801-reef
Adam King [Tue, 10 Oct 2023 18:50:48 +0000 (14:50 -0400)]
Merge pull request #53866 from adk3798/wip-62801-reef

reef: cephadm: run tcmu-runner through script to do restart on failure

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge pull request #53865 from adk3798/wip-62795-reef
Adam King [Tue, 10 Oct 2023 18:50:02 +0000 (14:50 -0400)]
Merge pull request #53865 from adk3798/wip-62795-reef

reef: mgr/cephadm: don't use image tag in orch upgrade ls

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge pull request #53404 from adk3798/reef-tcmu-custom-configs
Adam King [Tue, 10 Oct 2023 18:49:20 +0000 (14:49 -0400)]
Merge pull request #53404 from adk3798/reef-tcmu-custom-configs

reef: cephadm: make custom_configs work for tcmu-runner container

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge pull request #52819 from rishabh-d-dave/wip-62335-reef
Rishabh Dave [Tue, 10 Oct 2023 09:36:12 +0000 (15:06 +0530)]
Merge pull request #52819 from rishabh-d-dave/wip-62335-reef

reef: mds: use variable g_ceph_context directly in MDSAuthCaps

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #53033 from rhcs-dashboard/wip-62025-reef
Juan Miguel Olmo [Tue, 10 Oct 2023 09:04:53 +0000 (11:04 +0200)]
Merge pull request #53033 from rhcs-dashboard/wip-62025-reef

reef: msgr: AsyncMessenger add faulted connections metrics

21 months agoMerge pull request #53897 from zdover23/wip-doc-2023-10-10-backport-53890-to-reef
Anthony D'Atri [Mon, 9 Oct 2023 20:48:06 +0000 (16:48 -0400)]
Merge pull request #53897 from zdover23/wip-doc-2023-10-10-backport-53890-to-reef

reef: doc/rados: edit troubleshooting-mon.rst (4 of x)

21 months agoMerge pull request #53868 from adk3798/wip-62960-reef
Adam King [Mon, 9 Oct 2023 20:06:28 +0000 (16:06 -0400)]
Merge pull request #53868 from adk3798/wip-62960-reef

reef: mgr/cephadm: removing double quotes from the generated nvmeof config

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
21 months agoMerge pull request #53867 from adk3798/wip-62910-reef
Adam King [Mon, 9 Oct 2023 20:05:35 +0000 (16:05 -0400)]
Merge pull request #53867 from adk3798/wip-62910-reef

reef: mgr/cephadm: Adding sort-by support for ceph orch ps

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
21 months agoMerge pull request #53751 from adk3798/reef-haproxy-version
Adam King [Mon, 9 Oct 2023 20:04:33 +0000 (16:04 -0400)]
Merge pull request #53751 from adk3798/reef-haproxy-version

reef: cephadm: fix haproxy version with certain containers

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
21 months agoMerge pull request #53741 from adk3798/wip-63032-reef
Adam King [Mon, 9 Oct 2023 20:03:37 +0000 (16:03 -0400)]
Merge pull request #53741 from adk3798/wip-63032-reef

reef: mgr/cephadm: fix REFRESHED column of orch ps being unpopulated

Reviewed-by: Michael Fritch <mfritch@suse.com>
21 months agoMerge pull request #53159 from ljflores/wip-62590-reef
Adam King [Mon, 9 Oct 2023 20:02:17 +0000 (16:02 -0400)]
Merge pull request #53159 from ljflores/wip-62590-reef

reef: python-common: drive_selection: fix KeyError when osdspec_affinity is not set

Reviewed-by: Adam King <adking@redhat.com>
21 months agodoc/rados: edit troubleshooting-mon.rst (4 of x) 53897/head
Zac Dover [Mon, 9 Oct 2023 08:55:07 +0000 (18:55 +1000)]
doc/rados: edit troubleshooting-mon.rst (4 of x)

Edit doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/53875

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 99e92fb94b2c29e565e3f4e04658e103a09ef125)

21 months agoMerge pull request #53820 from ljflores/wip-63083-reef
Yuri Weinstein [Mon, 9 Oct 2023 15:48:12 +0000 (08:48 -0700)]
Merge pull request #53820 from ljflores/wip-63083-reef

reef: osd: fix read balancer logic to avoid redundant primary assignment

Reviewed-by: Josh Salomon <josh.salomon@gmail.com>
21 months agoMerge pull request #52767 from kamoltat/wip-ksirivad-backport-reef-52633
Yuri Weinstein [Mon, 9 Oct 2023 15:44:55 +0000 (08:44 -0700)]
Merge pull request #52767 from kamoltat/wip-ksirivad-backport-reef-52633

reef: pybind/mgr/pg_autoscaler: Cut back osdmap.get_pools calls

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
21 months agoMerge pull request #52737 from ljflores/wip-62275-reef
Yuri Weinstein [Mon, 9 Oct 2023 15:43:50 +0000 (08:43 -0700)]
Merge pull request #52737 from ljflores/wip-62275-reef

reef: test/TestOSDMap: don't use the deprecated std::random_shuffle method

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
21 months agoMerge pull request #52721 from NitzanMordhai/wip-62251-reef
Yuri Weinstein [Mon, 9 Oct 2023 15:40:20 +0000 (08:40 -0700)]
Merge pull request #52721 from NitzanMordhai/wip-62251-reef

reef: qa/standalone/osd/divergent-prior.sh: Divergent test 3 with pg_autoscale_mode on pick divergent osd

Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
21 months agoMerge pull request #52466 from k0ste/wip-62029-reef
Yuri Weinstein [Mon, 9 Oct 2023 15:39:30 +0000 (08:39 -0700)]
Merge pull request #52466 from k0ste/wip-62029-reef

reef: mon/ConfigMonitor: update crush_location from osd entity

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
21 months agomgr/cephadm: add unit test for _process_ls_output 53741/head
Adam King [Fri, 22 Sep 2023 23:30:26 +0000 (19:30 -0400)]
mgr/cephadm: add unit test for _process_ls_output

This is a weird function to make a unit test for
since it's essentially just moving data from a
list of dicts into a list of DaemonDescriptions,
but wanted to have some coverage to lower the
chance of breaking something again.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 47c8ad452423f4bf78885ec911c3b21a52cd90ae)

Conflicts:
src/pybind/mgr/cephadm/tests/test_cephadm.py

21 months agomgr/cephadm: fix REFRESHED column of orch ps being unpopulated
Adam King [Fri, 22 Sep 2023 22:34:59 +0000 (18:34 -0400)]
mgr/cephadm: fix REFRESHED column of orch ps being unpopulated

The way the daemon ls data was processed was changed in
https://github.com/ceph/ceph/commit/1fd4132c7c03602719f29230732b12c8afa04779
and it seems that commit removed a line that set the
last_refresh field. This commit just adds it back
in the new location after the change.

Without this in "ceph orch ps" the REFRESHED column
for every daemon just reports "-"

Fixes: https://tracker.ceph.com/issues/62954
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 06cf5bb95205965ab6b625b9069a11fa89ed4fb9)

21 months agoMerge pull request #53879 from zdover23/wip-doc-2023-10-08-backport-53875-to-reef
Anthony D'Atri [Sun, 8 Oct 2023 12:53:04 +0000 (08:53 -0400)]
Merge pull request #53879 from zdover23/wip-doc-2023-10-08-backport-53875-to-reef

reef: doc/rados: edit troubleshooting-mon.rst (3 of x)

21 months agoMerge pull request #53881 from zdover23/wip-doc-2023-10-08-backport-53874-to-reef
Anthony D'Atri [Sun, 8 Oct 2023 12:51:57 +0000 (08:51 -0400)]
Merge pull request #53881 from zdover23/wip-doc-2023-10-08-backport-53874-to-reef

reef: doc/rados: edit troubleshooting/community.rst

21 months agodoc/rados: edit troubleshooting/community.rst 53881/head
Zac Dover [Sat, 7 Oct 2023 20:39:23 +0000 (06:39 +1000)]
doc/rados: edit troubleshooting/community.rst

Edit doc/rados/troubleshooting/community.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fabfec273474a85cf3687ddf89183f0607c2ad71)

21 months agodoc/rados: edit troubleshooting-mon.rst (3 of x) 53879/head
Zac Dover [Sat, 7 Oct 2023 21:33:17 +0000 (07:33 +1000)]
doc/rados: edit troubleshooting-mon.rst (3 of x)

Edit doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/52827

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fc45a0c4dd0247f472a940d6c92e7acdb0cdc354)

21 months agoMerge pull request #53877 from zdover23/wip-doc-2023-10-08-backport-53876-to-reef
Anthony D'Atri [Sun, 8 Oct 2023 01:55:25 +0000 (21:55 -0400)]
Merge pull request #53877 from zdover23/wip-doc-2023-10-08-backport-53876-to-reef

reef: doc/architecture: repair RBD sentence

21 months agodoc/architecture: repair RBD sentence 53877/head
Zac Dover [Sat, 7 Oct 2023 21:43:43 +0000 (07:43 +1000)]
doc/architecture: repair RBD sentence

Improve an ambiguous sentence in doc/architecture.rst.

The problem presented by the original sentence is that the phrasal verb
"to provide with" is implicated in one of its possible readings.
Interpreted in that way, the sentence seems to express the incorrect
idea that RBD furnishes block devices with snapshotting and cloning, as
though snapshotting and cloning are being delivered to the block
devices. In fact, snapshotting and cloning are just features of RBD, and
are features that are described on this page:
https://docs.ceph.com/en/quincy/rbd/rbd-snapshot/.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5abd530460e3d5a60142d9350d93544402b6dec4)

21 months agoMerge pull request #53871 from zdover23/wip-doc-2023-10-07-backport-53790-to-reef
zdover23 [Sat, 7 Oct 2023 05:33:19 +0000 (16:33 +1100)]
Merge pull request #53871 from zdover23/wip-doc-2023-10-07-backport-53790-to-reef

reef: doc/architecture: edit "Peering and Sets"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
21 months agodoc/architecture: edit "Peering and Sets" 53871/head
Zac Dover [Tue, 3 Oct 2023 12:11:50 +0000 (22:11 +1000)]
doc/architecture: edit "Peering and Sets"

Edit the English in the section "Peering and Sets" in the file
doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c69b111966f190ac4a1ebd5244a9cf9f61970dd7)

21 months agoMerge pull request #53837 from zdover23/wip-doc-2023-10-05-backport-53819-to-reef
zdover23 [Sat, 7 Oct 2023 01:54:33 +0000 (12:54 +1100)]
Merge pull request #53837 from zdover23/wip-doc-2023-10-05-backport-53819-to-reef

reef: doc/rados: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agoMerge pull request #53869 from adk3798/wip-62973-reef
Anthony D'Atri [Fri, 6 Oct 2023 22:15:58 +0000 (18:15 -0400)]
Merge pull request #53869 from adk3798/wip-62973-reef

reef: mgr/cephadm: add ability to zap OSDs' devices while draining host

21 months agoceph orch add fails when ipv6 address is surrounded by square brackets. 53870/head
Teoman ONAY [Mon, 3 Jul 2023 14:00:20 +0000 (16:00 +0200)]
ceph orch add fails when ipv6 address is surrounded by square brackets.

fixes: https://tracker.ceph.com/issues/61885
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2153448

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 1ea71bee6197ed0357b586498a43d9d726160a43)

21 months agomgr/cephadm: add ability to zap OSDs' devices while draining host 53869/head
Adam King [Mon, 5 Jun 2023 19:05:55 +0000 (15:05 -0400)]
mgr/cephadm: add ability to zap OSDs' devices while draining host

Currently, when cephadm drains a host, it will remove all OSDs on
the host, but provides no option to zap the OSD's devices afterwards.
Given users are draining the host likely to remove it from the cluster,
it makes sense some users would want to clean up the devices on the
host that were being used for OSDs. Cephadm already supports zapping
devices outside of host draining, so it makes shouldn't take much to
add that functionality to the host drain as well.

Fixes: https://tracker.ceph.com/issues/61593
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 85043ff4cee108c152f5aa8af267c85e353c475a)

21 months agomgr/cephadm: removing double quotes from the generated nvmeof config 53868/head
Redouane Kachach [Thu, 21 Sep 2023 08:13:13 +0000 (10:13 +0200)]
mgr/cephadm: removing double quotes from the generated nvmeof config
Fixes: https://tracker.ceph.com/issues/62838
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 6b8187b2ec8a3bf9092da72c7a8b00dc7e5e1ce3)

21 months agoAdding service_name and daemon_type and fixing mypy issues 53867/head
Redouane Kachach [Wed, 13 Sep 2023 11:46:42 +0000 (13:46 +0200)]
Adding service_name and daemon_type and fixing mypy issues

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 72e9345faa725bd2aaba41e06ed34927badd7622)

21 months agomgr/cephadm: Adding sort-by support for ceph orch ps
Redouane Kachach [Thu, 29 Jun 2023 10:02:21 +0000 (12:02 +0200)]
mgr/cephadm: Adding sort-by support for ceph orch ps
Fixes: https://tracker.ceph.com/issues/61856
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit b347106af329e238a927f47436acd54999c4d9af)

21 months agocephadm: run tcmu-runner through script to do restart on failure 53866/head
Adam King [Tue, 13 Jun 2023 23:54:30 +0000 (19:54 -0400)]
cephadm: run tcmu-runner through script to do restart on failure

Currently, cephadm runs tcmu-runner as a background
process inside the unit file deployed for iscsi
(rbd-target-api is the primary process). This means
if tcmu-runner crashes for whatever reason, systemd
will not attempt to restart it. This commits sets
up a script to serve as the container entrypoint
for the tcmu-runner container that will run
tcmu-runner and also restart it on failure
(unless there are too many failures in a short
period, at which point it gives up).

The hope is to eventually drop use of this script
for a better solution in squid onward, but this
should be helpful on older releases (quincy and
pacific at least) where we won't be able to
bring that better solution

Fixes: https://tracker.ceph.com/issues/61667
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 47eb6b3f62afe993073429b02051ae0343d7aea3)

Conflicts:
src/cephadm/tests/test_cephadm.py

21 months agomgr/cephadm: don't use image tag in orch upgrade ls 53865/head
Adam King [Fri, 1 Sep 2023 13:05:04 +0000 (09:05 -0400)]
mgr/cephadm: don't use image tag in orch upgrade ls

Using the tag seems to screw up the auth URL generated
and is unnecessary since we're trying to get a list
of tags for the image anyway.

Fixes: https://tracker.ceph.com/issues/62679
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 0f4426d3a085fc2f5137593029469c3b20ace77e)

21 months agoMerge pull request #53835 from rhcs-dashboard/wip-63074-reef
Nizamudeen A [Fri, 6 Oct 2023 05:38:26 +0000 (11:08 +0530)]
Merge pull request #53835 from rhcs-dashboard/wip-63074-reef

reef: mgr/dashboard: fix the landing page layout issues

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
21 months agoMerge pull request #53853 from zdover23/wip-doc-2023-10-06-backport-53834-to-reef
Anthony D'Atri [Fri, 6 Oct 2023 00:41:26 +0000 (20:41 -0400)]
Merge pull request #53853 from zdover23/wip-doc-2023-10-06-backport-53834-to-reef

reef: doc: remove egg fragment from dev/developer_guide/running-tests-locally

21 months agodoc: remove egg fragment from dev/developer_guide/running-tests-locally 53853/head
Dhairya Parmar [Thu, 5 Oct 2023 08:12:31 +0000 (13:42 +0530)]
doc: remove egg fragment from dev/developer_guide/running-tests-locally

DEPRECATION: git+https://github.com/ceph/teuthology#egg=teuthology
[test] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce
this behaviour change. A possible replacement is to use the req @ url syntax,
and remove the egg fragment. Discussion can be found at
https://github.com/pypa/pip/issues/11617

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 1f78a32a1822fea1a56a88215e452b730b7672c7)

21 months agoMerge pull request #53412 from trociny/wip-62352-reef
Shilpa Jagannath [Thu, 5 Oct 2023 21:02:34 +0000 (17:02 -0400)]
Merge pull request #53412 from trociny/wip-62352-reef

reef: qa: fix keystone in rgw/crypt/barbican.yaml

21 months agodoc/rados: edit troubleshooting.rst 53837/head
Zac Dover [Wed, 4 Oct 2023 11:14:13 +0000 (21:14 +1000)]
doc/rados: edit troubleshooting.rst

Edit doc/rads/troubleshooting.rst to remove some language that sounds
quite close to marketing language.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9d9d92837e44e3af233bc228850be09e8f64eb7c)

21 months agoMerge pull request #53811 from zdover23/wip-doc-2023-10-04-backport-53791-to-reef
zdover23 [Thu, 5 Oct 2023 11:31:56 +0000 (22:31 +1100)]
Merge pull request #53811 from zdover23/wip-doc-2023-10-04-backport-53791-to-reef

reef: doc/rados: edit ops/control.rst (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agomgr/dashboard: fix rgw inventory card and broken shadows 53835/head
Nizamudeen A [Tue, 3 Oct 2023 12:03:13 +0000 (17:33 +0530)]
mgr/dashboard: fix rgw inventory card and broken shadows

Mess up of the dashboard landing page layout fixes PR

Fixes: http://tracker.ceph.com/issues/62961
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 4c6c5787cb338995955b4a30fed9c348337e721c)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.html
  - Accept incoming changes
src/pybind/mgr/dashboard/frontend/src/app/shared/components/card-row/card-row.component.html
  - Accept incoming changes

21 months agomgr/dashboard: fix the landing page layout issues
Nizamudeen A [Tue, 19 Sep 2023 06:42:36 +0000 (12:12 +0530)]
mgr/dashboard: fix the landing page layout issues

We were following a row-col grid layout for the landing page.
First row includes Details, Status and Capacity
Second row for Inventory and Cluster Utilization

So if one of the item in the first row increases, it pushes the entire
second row downwards.

To fix this, I made a col-row grid.

First col has Details and Inventory in two rows.
Second col has Status and Capacity as a col and Cluster Utilization as a
single row

Fixes: https://tracker.ceph.com/issues/62961
Signed-off-by: Nizamudeen A <nia@redhat.com>
Co-authored-by: cloudbehl <cloudbehl@gmail.com>
(cherry picked from commit 3f904b0a658e3759ef00fdd5a95f6ecf5ba76718)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
  - Accept the incoming change

21 months agoMerge pull request #53831 from rhcs-dashboard/wip-62999-reef
Nizamudeen A [Thu, 5 Oct 2023 05:31:52 +0000 (11:01 +0530)]
Merge pull request #53831 from rhcs-dashboard/wip-62999-reef

reef: mgr/dashboard: fix cephfs forms validations

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
21 months agomgr/dashboard: fix cephfs forms validations 53831/head
Nizamudeen A [Fri, 22 Sep 2023 12:37:39 +0000 (18:07 +0530)]
mgr/dashboard: fix cephfs forms validations

1. CephFS Edit Form didnt had any validation for name eventhough the
   create had. So reused the Create form to display the Edit as well

2. Add Name Validations to Subvoume and Subvolume group forms

3. Removed the datePipe from the cephfs list template since we are using
   the relativeDate.

Fixes: https://tracker.ceph.com/issues/62939
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit cd617a3bd28b0aedd03505314509f0c00391bc39)

21 months agoMerge pull request #53818 from aaSharma14/wip-63098-reef
Nizamudeen A [Thu, 5 Oct 2023 03:44:42 +0000 (09:14 +0530)]
Merge pull request #53818 from aaSharma14/wip-63098-reef

reef: mgr/dashboard: Fix user/bucket count in rgw overview dashboard

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
21 months agoMerge pull request #53780 from rhcs-dashboard/wip-63069-reef
Nizamudeen A [Wed, 4 Oct 2023 15:54:54 +0000 (21:24 +0530)]
Merge pull request #53780 from rhcs-dashboard/wip-63069-reef

reef: mgr/dashboard: allow tls 1.2 with a config option

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
21 months agoMerge pull request #53646 from vshankar/wip-61805-reef
Yuri Weinstein [Wed, 4 Oct 2023 15:10:55 +0000 (08:10 -0700)]
Merge pull request #53646 from vshankar/wip-61805-reef

reef: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #53638 from vshankar/wip-62950-reef
Yuri Weinstein [Wed, 4 Oct 2023 15:08:57 +0000 (08:08 -0700)]
Merge pull request #53638 from vshankar/wip-62950-reef

reef: cephfs-mirror: do not run concurrent C_RestartMirroring context

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #53627 from lxbsz/wip-62947
Yuri Weinstein [Wed, 4 Oct 2023 15:07:48 +0000 (08:07 -0700)]
Merge pull request #53627 from lxbsz/wip-62947

reef: qa: descrease pgbench scale factor to 32 for postgresql database test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #52843 from lxbsz/wip-62271
Yuri Weinstein [Wed, 4 Oct 2023 15:06:55 +0000 (08:06 -0700)]
Merge pull request #52843 from lxbsz/wip-62271

reef: xfstests_dev: install extra packages from powertools repo for xfsprogs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge branch 'reef' into wip-doc-2023-10-04-backport-53791-to-reef 53811/head
zdover23 [Wed, 4 Oct 2023 14:34:15 +0000 (01:34 +1100)]
Merge branch 'reef' into wip-doc-2023-10-04-backport-53791-to-reef

Signed-off-by: zdover23 <zac.dover@proton.me>
21 months agoosd: fix read balancer logic to avoid redundant primary assignment 53820/head
Laura Flores [Wed, 13 Sep 2023 19:57:07 +0000 (19:57 +0000)]
osd: fix read balancer logic to avoid redundant primary assignment

Fixes: https://tracker.ceph.com/issues/62833
Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit 47c5ba25ed0db0fd307f0d4a1717ff8418004b8e)

21 months agoMerge pull request #53810 from rhcs-dashboard/wip-63091-reef
Nizamudeen A [Wed, 4 Oct 2023 13:54:23 +0000 (19:24 +0530)]
Merge pull request #53810 from rhcs-dashboard/wip-63091-reef

reef: mgr/dashboard: rbd image hide usage bar when disk usage is not provided

Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agoMerge pull request #53815 from zdover23/wip-doc-2023-10-04-backport-53792-to-reef
Anthony D'Atri [Wed, 4 Oct 2023 13:02:00 +0000 (09:02 -0400)]
Merge pull request #53815 from zdover23/wip-doc-2023-10-04-backport-53792-to-reef

reef: doc/rados: edit ops/control.rst (2 of x)

21 months agomgr/dashboard: Fix user/bucket count in rgw overview dashboard 53818/head
Aashish Sharma [Mon, 25 Sep 2023 08:16:58 +0000 (13:46 +0530)]
mgr/dashboard: Fix user/bucket count in rgw overview dashboard

Donot consider buckets/users count from daemons that have similar realm
name

Fixes: https://tracker.ceph.com/issues/62964
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit bfdcabe9d967ab28040173107bfd3f94235e3921)

21 months agodoc/rados: edit ops/control.rst (2 of x) 53815/head
Zac Dover [Tue, 3 Oct 2023 12:39:23 +0000 (22:39 +1000)]
doc/rados: edit ops/control.rst (2 of x)

Edit doc/rados/operations/control.rst (2 of x).

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 03ed13930661628c10f185af1a3949548bdc8288)

21 months agoMerge pull request #53806 from aaSharma14/wip-63087-reef
Pedro Gonzalez Gomez [Wed, 4 Oct 2023 10:28:58 +0000 (12:28 +0200)]
Merge pull request #53806 from aaSharma14/wip-63087-reef

reef: mgr/dashboard: Rgw Multi-site naming improvements

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agodoc/rados: edit ops/control.rst (1 of x)
Zac Dover [Tue, 3 Oct 2023 12:22:39 +0000 (22:22 +1000)]
doc/rados: edit ops/control.rst (1 of x)

Edit doc/rados/operations/control.rst (1 of x).

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 89c9584f8a1633b5ad1936af09529657d81b7134)

21 months agomgr/dashboard: rbd image hide usage bar when disk usage is not provided 53810/head
Pedro Gonzalez Gomez [Mon, 2 Oct 2023 08:35:08 +0000 (10:35 +0200)]
mgr/dashboard: rbd image hide usage bar when disk usage is not provided

Fixes: https://tracker.ceph.com/issues/63037
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 17d87af98a60471fc72cab4e6d5a53caf1847842)

21 months agoMerge pull request #52662 from rhcs-dashboard/wip-62184-reef
Nizamudeen A [Wed, 4 Oct 2023 09:09:40 +0000 (14:39 +0530)]
Merge pull request #52662 from rhcs-dashboard/wip-62184-reef

reef: mgr/dashboard: upgrade angular v14 and v15

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
21 months agoMerge pull request #53805 from aaSharma14/wip-63079-reef
Pedro Gonzalez Gomez [Wed, 4 Oct 2023 07:28:18 +0000 (09:28 +0200)]
Merge pull request #53805 from aaSharma14/wip-63079-reef

reef: mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agoMerge pull request #53795 from rhcs-dashboard/wip-63077-reef
Nizamudeen A [Wed, 4 Oct 2023 05:31:12 +0000 (11:01 +0530)]
Merge pull request #53795 from rhcs-dashboard/wip-63077-reef

reef: mgr/dashboard: enable protect option if layering enabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agomgr/dashboard: Rgw Multi-site naming improvements 53806/head
Aashish Sharma [Wed, 6 Sep 2023 07:16:49 +0000 (12:46 +0530)]
mgr/dashboard: Rgw Multi-site naming improvements

Fixes: https://tracker.ceph.com/issues/62721
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit e3d8ac03c343f98b43f8a009cb2a26fc913ad12d)

21 months agoMerge pull request #53778 from rhcs-dashboard/wip-63067-reef
Nizamudeen A [Wed, 4 Oct 2023 05:03:41 +0000 (10:33 +0530)]
Merge pull request #53778 from rhcs-dashboard/wip-63067-reef

reef: mgr/dashboard: fix cephfs form validator

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
21 months agomgr/dashboard: show a message to restart the rgw daemons after moving from single... 53805/head
Aashish Sharma [Tue, 26 Sep 2023 12:27:39 +0000 (17:57 +0530)]
mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site

Fixes: https://tracker.ceph.com/issues/62984
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit ab06466aa2bb7ddc97ccc33acb3aa6ce35582f05)

21 months agoMerge pull request #53515 from yuvalif/wip-61642-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:47:41 +0000 (12:47 -0700)]
Merge pull request #53515 from yuvalif/wip-61642-reef

reef: rgw/kafka: make sure that destroy is called after connection is removed

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53599 from idryomov/wip-62711-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:45:28 +0000 (12:45 -0700)]
Merge pull request #53599 from idryomov/wip-62711-reef

reef: qa/suites/{rbd,krbd}: disable POOL_APP_NOT_ENABLED health check

Reviewed-by: Ramana Raja <rraja@redhat.com>
21 months agoMerge pull request #53590 from cbodley/wip-62935-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:44:49 +0000 (12:44 -0700)]
Merge pull request #53590 from cbodley/wip-62935-reef

reef: rgw/crypt: don't deref null manifest_bl

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #53584 from cbodley/wip-62924-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:44:14 +0000 (12:44 -0700)]
Merge pull request #53584 from cbodley/wip-62924-reef

reef: rgw/sal: get_placement_target_names() returns void

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
21 months agoMerge pull request #53514 from yuvalif/wip-61535-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:43:08 +0000 (12:43 -0700)]
Merge pull request #53514 from yuvalif/wip-61535-reef

reef: RGW:notifications: persistent topics are not deleted via radosgw-admin

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #53513 from yuvalif/wip-59496-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:42:38 +0000 (12:42 -0700)]
Merge pull request #53513 from yuvalif/wip-59496-reef

reef: rgw/kafka: failed to reconnect to broker after idle timeout

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #53510 from yuvalif/wip-62803-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:42:03 +0000 (12:42 -0700)]
Merge pull request #53510 from yuvalif/wip-62803-reef

reef: rgw/notifications: allow cross tenant notification management

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>