]>
git.apps.os.sepia.ceph.com Git - ceph-ci.git/log
Guillaume Abrioux [Wed, 8 Sep 2021 11:27:04 +0000 (13:27 +0200)]
Merge pull request #43051 from dsavineau/ceph_volume_lvm_migrate_docs
doc/ceph-volume: add lvm migrate/new-db/new-wal
Guillaume Abrioux [Wed, 8 Sep 2021 11:12:29 +0000 (13:12 +0200)]
Merge pull request #43050 from dsavineau/fix_raw_list_with_lsblk
ceph-volume: fix raw list with logical partition
Ilya Dryomov [Wed, 8 Sep 2021 09:15:18 +0000 (11:15 +0200)]
Merge pull request #43006 from CongMinYin/fix-assert-in-handle_flushed_sync_point
librbd/cache/pwl: don't clear next_sync_point_entry prematurely
Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 8 Sep 2021 08:50:20 +0000 (10:50 +0200)]
Merge pull request #43074 from wangshuaich/rbd-children-crash-fix
librbd: fix use-after-free on ictx in list_descendants()
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Samuel Just [Wed, 8 Sep 2021 02:38:32 +0000 (19:38 -0700)]
Merge pull request #43084 from athanatos/sjust/wip-lba-pin
crimson/seastore: lba pin debugging and fix
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Samuel Just [Wed, 8 Sep 2021 02:38:09 +0000 (19:38 -0700)]
Merge pull request #43083 from athanatos/sjust/wip-52532
crimson/os/seastore/.../lba_btree: fix handle_split internal nodes
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Samuel Just [Wed, 8 Sep 2021 01:25:55 +0000 (18:25 -0700)]
Merge pull request #43066 from rzarzynski/wip-crimson-fatal-reraise
crimson/common: explicitly reraise handled signal in FatalSignal
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Samuel Just [Thu, 2 Sep 2021 23:13:46 +0000 (16:13 -0700)]
crimson/os/seastore/transaction_manager: add logging for invalid pin
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Thu, 2 Sep 2021 23:13:12 +0000 (16:13 -0700)]
crimson/os/seastore/transaction_manager: pin may not match unless paddr does
The same laddr might be reallocated with a different size.
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Tue, 31 Aug 2021 04:14:07 +0000 (21:14 -0700)]
crimson/os/seastore/lba_manager: improve add_pin debugging
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Tue, 7 Sep 2021 22:59:08 +0000 (22:59 +0000)]
crimson/os/seastore/.../lba_btree: fix handle_split internal nodes
Internal node pointers aren't actually allowed to point to end() -- that's
specific to the leaf pointer.
Fixes: https://tracker.ceph.com/issues/52532
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Tue, 7 Sep 2021 23:29:44 +0000 (16:29 -0700)]
crimson/tools/store_nbd/fs_driver: fix FuturizedStore::create() call
Introduced:
8ec97762c4809c25d3b38ac15b942dfd710e3d29
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Tue, 7 Sep 2021 23:01:23 +0000 (16:01 -0700)]
crimson/os/seastore/.../lba_btree: clarify handle_split, find_insertion comments
Signed-off-by: Samuel Just <sjust@redhat.com>
Ilya Dryomov [Tue, 7 Sep 2021 19:01:51 +0000 (21:01 +0200)]
librbd: report correct error for ictx->state->close()
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Wang ShuaiChao [Tue, 7 Sep 2021 08:43:11 +0000 (16:43 +0800)]
librbd: fix use-after-free on ictx in list_descendants()
Ictx is deleted when "ictx->state->open()" and "ictx->state->close()"
fail, and then "lderr(ictx->cct)" crashes.
Fixes: https://tracker.ceph.com/issues/52522
Signed-off-by: Wang ShuaiChao <wangshuaich@chinatelecom.cn>
Ilya Dryomov [Tue, 7 Sep 2021 16:15:14 +0000 (18:15 +0200)]
Merge pull request #43070 from krunerge/fix-children-list-log-text
cls/rbd: fix log text for children list
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Tue, 7 Sep 2021 15:36:37 +0000 (23:36 +0800)]
Merge pull request #43067 from tchaikov/wip-crimson-alien
crimson/osd: use reactor::alien to send message to alien
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Kefu Chai [Tue, 7 Sep 2021 13:54:53 +0000 (21:54 +0800)]
Merge pull request #42933 from p-se/mgr-prom-disable-cache
mgr/prometheus: offer ability to disable cache
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Kefu Chai [Mon, 6 Sep 2021 16:31:27 +0000 (00:31 +0800)]
crimson/osd: use reactor::alien to send message to alien
simpler this way.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Mon, 6 Sep 2021 16:21:26 +0000 (00:21 +0800)]
seastar: pick up change to add reactor::alien()
so we don't need to pass the reference to alien all the way down to
AlienStore.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Guillaume Abrioux [Tue, 7 Sep 2021 13:38:33 +0000 (15:38 +0200)]
ceph-volume: test the lsblk command in list.py
Let's test we use the expected args when we build the `lsblk` command
to list the devices present on the node.
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Dimitri Savineau [Fri, 3 Sep 2021 18:24:48 +0000 (14:24 -0400)]
ceph-volume: fix raw list with logical partition
This is a regression introduced by
9212420 , when the host is using a
logical partition then lsblk reports that partition as a child from the
physical device.
That logical partition is prefixed by the `└─` character.
This leads the `raw list` subcommand to show the lsblk error on the stderr.
```
$ ceph-volume raw list
{}
stderr: lsblk: `-/dev/sda1: not a block device
```
The lsblk command output looks like:
```
$ lsblk --paths --output=NAME --noheadings
/dev/sda
└─/dev/sda1
/dev/sdb
/dev/sdc
/dev/sdd
```
Using the `--list` option with lsblk solves the issue.
```
$ lsblk --list --paths --output=NAME --noheadings
/dev/sda
/dev/sda1
/dev/sdb
/dev/sdc
/dev/sdd
```
Fixes: https://tracker.ceph.com/issues/52504
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
Patrick Donnelly [Tue, 7 Sep 2021 12:56:36 +0000 (08:56 -0400)]
Merge PR #43017 into master
* refs/pull/43017/head:
doc: fix typos
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Guillaume Abrioux [Tue, 7 Sep 2021 11:23:16 +0000 (13:23 +0200)]
Merge pull request #43009 from fengjiankui121/pvs_repair
ceph-volume: pvs --noheadings replace pvs --no-heading
krunerge [Tue, 7 Sep 2021 02:13:28 +0000 (10:13 +0800)]
cls/rbd: fix log text for children list
Signed-off-by: krunerge <krunerge@tencent.com>
Patrick Donnelly [Mon, 6 Sep 2021 18:00:41 +0000 (14:00 -0400)]
Merge PR #42529 into master
* refs/pull/42529/head:
qa: verify rank 0 does not fail during journal repair tests
qa: avoid stopping/restarting mds in journal repair tests
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Kefu Chai [Mon, 6 Sep 2021 15:16:36 +0000 (23:16 +0800)]
Merge pull request #43065 from tchaikov/wip-doc-build
admin/doc-requirements: use funcparserlib from github
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Kefu Chai [Mon, 6 Sep 2021 14:53:25 +0000 (22:53 +0800)]
Merge pull request #42919 from sebastian-philipp/cephadm-async-close-conn
mgr/cephadm: Also make ssh._reset_con async
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Melissa Li <li.melissa.kun@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Kefu Chai [Mon, 6 Sep 2021 14:50:20 +0000 (22:50 +0800)]
Merge pull request #42992 from ifed01/wip-ifed-fix-migrate
os/bluestore: fix bluefs migrate command
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Radoslaw Zarzynski [Mon, 6 Sep 2021 14:39:19 +0000 (14:39 +0000)]
crimson/common: explicitly reraise handled signal in FatalSignal.
Over the current approach where we just reset the handler to
default and allow CPU to re-execute the segfaulting instruction,
the explicit `::reraise()` is:
1. immune to a race condition if muliple threads run into
troubles the same time;
2. easier to understand and similar to the classic OSD.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Mon, 6 Sep 2021 14:37:07 +0000 (14:37 +0000)]
crimson/common: s/sig/signum/ in FatalSignal for better readability.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Mon, 6 Sep 2021 14:45:01 +0000 (22:45 +0800)]
Merge pull request #42965 from ronen-fr/wip-ronenf-split-child
osd: adding missing data to register_and_wake_split_child() logs
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kefu Chai [Mon, 6 Sep 2021 14:39:21 +0000 (22:39 +0800)]
Merge pull request #42953 from ronen-fr/wip-ronenf-handled-objs
osd/scrub: stats_of_handled_objects(): reduce irrelevant logs
Reviewed-by: Amnon Hanuhov <ahanukov@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sebastian Wagner [Mon, 6 Sep 2021 14:32:52 +0000 (16:32 +0200)]
Merge pull request #43061 from sebastian-philipp/cephadm-no-asyncssh
pybind/mgr: tox.ini add nooptional testenv
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Kefu Chai [Mon, 6 Sep 2021 14:30:02 +0000 (22:30 +0800)]
admin/doc-requirements: use funcparserlib from github
funcparserlib is pulled in as a dependency by blockdiag. the latest version of
funcparserlib available on pypi is v0.3.6 which is not compatible with
Python3.8.
in this change, funcparserlib is installed from github instead to
address the build failure like:
File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/41855/lib/python3.8/site-packages/sphinxcontrib/seqdiag.py", line 26, in <module>
import seqdiag.utils.rst.nodes
File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/41855/lib/python3.8/site-packages/seqdiag/utils/rst/nodes.py", line 16, in <module>
from blockdiag.utils.rst import nodes
File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/41855/lib/python3.8/site-packages/blockdiag/utils/rst/nodes.py", line 21, in <module>
import blockdiag.builder
File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/41855/lib/python3.8/site-packages/blockdiag/builder.py", line 16, in <module>
from blockdiag import parser
File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/41855/lib/python3.8/site-packages/blockdiag/parser.py", line 43, in <module>
from funcparserlib.parser import (a, finished, forward_decl, many, maybe, skip,
File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/41855/lib/python3.8/site-packages/funcparserlib/parser.py", line 123
except NoParseError, e:
^
SyntaxError: invalid syntax
once https://github.com/vlasovskikh/funcparserlib/issues/65 is
addressed, we should drop this change.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Patrick Seidensal [Thu, 26 Aug 2021 13:35:49 +0000 (15:35 +0200)]
mgr/prometheus: offer ability to disable cache
Fixes: https://tracker.ceph.com/issues/52414
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Yin Congmin [Wed, 1 Sep 2021 15:56:18 +0000 (15:56 +0000)]
librbd/cache/pwl: don't clear next_sync_point_entry prematurely
In SyncPointLogOperation::clear_earlier_sync_point(),
sync_point->log_entry->next_sync_point_entry was prematurely set to
nullptr in clear_earlier_sync_point(). It is in write op stage, but
next_sync_point_entry is used in writeback stage in
handle_flushed_sync_point().
handle_flushed_sync_point() may pass a nullptr
cause assert in m_work_queue.The solution is to move the statement
that set next_sync_point_entry to nullptr after it is used.
Fixes: https://tracker.ceph.com/issues/52465
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
Kefu Chai [Mon, 6 Sep 2021 14:10:20 +0000 (22:10 +0800)]
Merge pull request #43034 from rubenk/fix-unmapped-bytes-help-text
common/PriorityCache: fix help text for unmapped_bytes metric
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Sebastian Wagner [Mon, 6 Sep 2021 10:26:21 +0000 (12:26 +0200)]
pybind/mgr: tox.ini remove duplicated `tox` env
as this is the same as `py3`. Avoid executing it twice
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Mon, 6 Sep 2021 10:21:58 +0000 (12:21 +0200)]
pybind/mgr: tox.ini add nooptional testenv
To verify cephadm properly works as expected without asyncssh installed
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Mon, 6 Sep 2021 09:58:49 +0000 (11:58 +0200)]
pybind/mgr: tox.ini: norecursedirs instead explicitly list modules
Simplify things by not listing all modules individually.
Also: Fixed two new doctests
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Ilya Dryomov [Mon, 6 Sep 2021 08:07:41 +0000 (10:07 +0200)]
Merge pull request #43047 from idryomov/wip-rbd-mirror-peer-profile-doc
doc: adjust client.rbd-mirror-peer mon cap and add details about site names
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Yuval Lifshitz [Sun, 5 Sep 2021 07:58:10 +0000 (10:58 +0300)]
Merge pull request #42840 from TRYTOBE8TME/wip-rgw-kafka-timeout
Wip rgw kafka timeout
Yuval Lifshitz [Sun, 5 Sep 2021 07:57:15 +0000 (10:57 +0300)]
Merge pull request #42875 from pleiadesian/feature-lua
examples: add elasticsearch and prometheus examples
wangxinyu [Thu, 2 Sep 2021 05:08:21 +0000 (13:08 +0800)]
doc: fix typos
Signed-off-by: wangxinyu <wangxinyu@inspur.com>
Kefu Chai [Sat, 4 Sep 2021 14:02:19 +0000 (22:02 +0800)]
Merge pull request #42870 from ktdreyer/cmake-thread-libs-init
cmake: link Threads::Threads instead of CMAKE_THREAD_LIBS_INIT
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 4 Sep 2021 02:47:50 +0000 (10:47 +0800)]
Merge pull request #42960 from wjwithagen/wjw-fix-cephfs-lock
tools/cephfs_mirror: fix lock declaratie/locking
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 4 Sep 2021 02:46:28 +0000 (10:46 +0800)]
Merge pull request #42962 from tchaikov/wip-cmake-ppc
arch,cmake: compile ppc.c on all powerpc machines
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Kefu Chai [Fri, 3 Sep 2021 22:57:33 +0000 (06:57 +0800)]
Merge pull request #43043 from tchaikov/crimson/os/cleanup
crimson/os: use structured binding in loop
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Dimitri Savineau [Fri, 3 Sep 2021 19:44:39 +0000 (15:44 -0400)]
doc/ceph-volume: add lvm migrate/new-db/new-wal
The inital PR was implementing those new commands only adds the man page
and not the online documentation.
Fixes: https://tracker.ceph.com/issues/51814
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
Ilya Dryomov [Fri, 3 Sep 2021 14:45:26 +0000 (16:45 +0200)]
doc: adjust client.rbd-mirror-peer mon cap
On top of "profile rbd" permissions, "profile rbd-mirror-peer" also
allows getting rbd/mirror and setting rbd/mirror/peer/* config keys.
This is what "rbd mirror pool peer bootstrap create" does.
Fixes: https://tracker.ceph.com/issues/50970
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 3 Sep 2021 16:12:40 +0000 (18:12 +0200)]
doc: add some details about rbd-mirror site names
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Josh Durgin [Fri, 3 Sep 2021 15:27:49 +0000 (08:27 -0700)]
Merge pull request #43035 from zdover23/wip-doc-2021-09-03-rados-bootstrap-options
doc: rados/ceph-conf.rst bootstrap options
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Patrick Donnelly [Fri, 3 Sep 2021 15:20:52 +0000 (11:20 -0400)]
Merge PR #43012 into master
* refs/pull/43012/head:
script: ceph-debug-docker.sh deals with the centos-repos -> centos-linux-repos transition.
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sebastian Wagner [Fri, 3 Sep 2021 15:17:03 +0000 (17:17 +0200)]
Merge pull request #43040 from sebastian-philipp/qa-deadsymlinks
qa/tox.ini: check for dead symlinks
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@newdream.net>
J. Eric Ivancich [Fri, 3 Sep 2021 15:09:28 +0000 (11:09 -0400)]
Merge pull request #42836 from ivancich/wip-fix-bi-test-error
rgw: fix bucket index list test error
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Fri, 3 Sep 2021 14:52:06 +0000 (22:52 +0800)]
crimson/os: use structured binding in loop
also avoid using `map[key] = val` for setting an item in map, as, if
he key does not exist in map, `map[key]` would have to create a value
using its default ctor, and then call the `operator=(bufferlist&&)` to
set it.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Patrick Donnelly [Fri, 3 Sep 2021 14:27:31 +0000 (10:27 -0400)]
Merge PR #43032 into master
* refs/pull/43032/head:
backport-create-issue: set backport priority
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Sebastian Wagner [Fri, 3 Sep 2021 09:44:44 +0000 (11:44 +0200)]
Merge pull request #43039 from sebastian-philipp/rm-kubic
qa/distros: Remove stale kubic distros
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Sebastian Wagner [Fri, 3 Sep 2021 09:44:19 +0000 (11:44 +0200)]
Merge pull request #43021 from sebastian-philipp/rhel_8.3_container_tools_rhel8.yaml
qa/distros/podman: Add rhel_8.3_container_tools_rhel8.yaml
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sebastian Wagner [Fri, 3 Sep 2021 09:38:04 +0000 (11:38 +0200)]
qa/tox.ini: check for dead symlinks
IMO the amount of symlinks we have to manually maintain
is tedious and error prone. Any ideas on improving thing?
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Fri, 3 Sep 2021 08:13:54 +0000 (10:13 +0200)]
qa/distros: Remove stale kubic distros
Cause they're broken
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Thu, 2 Sep 2021 09:48:13 +0000 (11:48 +0200)]
qa/distros/podman: Add rhel_8.rhel_8.4_container_tools_3.0.yaml
mainly for the cephfs suite
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Fri, 3 Sep 2021 07:37:04 +0000 (09:37 +0200)]
Merge pull request #43030 from dsavineau/cephadm_fix_prometheus_spelling
cephadm: fix prometheus namespace spelling
Reviewed-by: Sage Weil <sage@newdream.net>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
FengJiankui [Wed, 1 Sep 2021 09:37:25 +0000 (17:37 +0800)]
ceph-volume: pvs --noheadings replace pvs --no-heading
Fixes: https://tracker.ceph.com/issues/52482
Signed-off-by: FengJiankui <fengjiankui@inspur.com>
Sage Weil [Thu, 2 Sep 2021 21:11:51 +0000 (17:11 -0400)]
Merge PR #42873 into master
* refs/pull/42873/head:
qa/tasks/rook: add OSD creation to Rook QA
Reviewed-by: Sage Weil <sage@redhat.com>
Samuel Just [Thu, 2 Sep 2021 19:34:08 +0000 (12:34 -0700)]
Merge pull request #43018 from cyx1231st/wip-seastore-onode-tree-alloc-hint
crimson/onode-staged-tree: improve laddr hints during allocation
Reviewed-by: Samuel Just <sjust@redhat.com>
Zac Dover [Thu, 2 Sep 2021 19:22:38 +0000 (05:22 +1000)]
doc: rados/ceph-conf.rst bootstrap options
This is the editorial syntax and elegance PR for the "Bootstrap Options"
section in the "Configuring Ceph" chapter of the RADOS Guide.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ruben Kerkhof [Thu, 2 Sep 2021 19:01:14 +0000 (21:01 +0200)]
common/PriorityCache: fix help text for unmapped_bytes metric
Signed-off-by: Ruben Kerkhof <ruben@42on.com>
Samuel Just [Thu, 2 Sep 2021 18:34:07 +0000 (11:34 -0700)]
Merge pull request #43031 from rzarzynski/wip-crimson-watch-reconnect
crimson/osd: fix Watch::connect() behaviour on reconnect.
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Samuel Just [Thu, 2 Sep 2021 18:30:40 +0000 (11:30 -0700)]
Merge pull request #43033 from markhpc/wip-cyanstore-moreops
src/crimson: Add various missing ops to cyanstore
Reviewed-by: Samuel Just <sjust@redhat.com>
Cory Snyder [Thu, 2 Sep 2021 15:23:20 +0000 (11:23 -0400)]
backport-create-issue: set backport priority
Set backport issue priority based upon the priority of the original issue.
Fixes: https://tracker.ceph.com/issues/52387
Signed-off-by: Cory Snyder <csnyder@iland.com>
Radoslaw Zarzynski [Thu, 2 Sep 2021 14:41:38 +0000 (14:41 +0000)]
crimson/osd: fix Watch::connect() behaviour on reconnect.
It's perfectly legal for a client to reconnect to particular `Watch`
using different socket / `Connection` than original one. This shall
include proper handling of the watch timer which is currently broken
as, when reconnecting, we don't cancel the timer. This leaded to the
following crash at Sepia:
```
rzarzynski@teuthology:/home/teuthworker/archive/rzarzynski-2021-09-02_07:44:51-rados-master-distro-basic-smithi/
6372357 $ less ./remote/smithi183/log/ceph-osd.4.log.gz
...
DEBUG 2021-09-02 08:10:45,462 [shard 0] osd - client_request(id=12, detail=m=[osd_op(client.5087.0:93 7.1e 7:
7c7084bd :::repobj:head {watch reconnect cookie
94478891024832 gen 1} snapc 0={} ondisk+write+know
n_if_redirected e40) v8]): got obc lock
...
DEBUG 2021-09-02 08:10:45,462 [shard 0] osd - do_op_watch
INFO 2021-09-02 08:10:45,462 [shard 0] osd - found existing watch by client.5087
DEBUG 2021-09-02 08:10:45,462 [shard 0] osd - do_op_watch_subop_watch
INFO 2021-09-02 08:10:45,462 [shard 0] osd - found existing watch watch(cookie
94478891024832 30s 172.21.15.150:0/
3544196211 ) by client.5087
...
INFO 2021-09-02 08:10:45,462 [shard 0] osd - op_effect: found existing watcher:
94478891024832 ,client.5087
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/
17.0.0-7406-g9d30203c /rpm/el8/BUILD/ceph-
17.0.0-7406-g9d30203c /src/seastar/include/seastar/core/timer.hh:95: void seastar::timer<Clock>::arm_state(seastar::timer<Clock>::time_point, std::optional<typename Clock::duration>) [with Clock = seastar::l
owres_clock; seastar::timer<Clock>::time_point = std::chrono::time_point<seastar::lowres_clock, std::chrono::duration<long int, std::ratio<1, 1000> > >; typename Clock::duration = std::chrono::duration<long
int, std::ratio<1, 1000> >]: Assertion `!_armed' failed.
Aborting on shard 0.
Backtrace:
0# 0x000055CC052CF0B6 in ceph-osd
1# FatalSignal::signaled(int, siginfo_t const&) in ceph-osd
2# FatalSignal::install_oneshot_signal_handler<6>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) in ceph-osd
3# 0x00007FA58349FB20 in /lib64/libpthread.so.0
4# gsignal in /lib64/libc.so.6
5# abort in /lib64/libc.so.6
6# 0x00007FA581A98C89 in /lib64/libc.so.6
7# 0x00007FA581AA6A76 in /lib64/libc.so.6
8# 0x000055CC0BEEE9DD in ceph-osd
9# crimson::osd::Watch::connect(seastar::shared_ptr<crimson::net::Connection>, bool) in ceph-osd
10# 0x000055CC00B1D246 in ceph-osd
11# 0x000055CBFFEF01AE in ceph-osd
...
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Mark Nelson [Thu, 2 Sep 2021 14:46:26 +0000 (14:46 +0000)]
src/crimson: Add various missing ops to cyanstore
Signed-off-by: Mark Nelson <mnelson@redhat.com>
Deepika Upadhyay [Thu, 2 Sep 2021 14:41:01 +0000 (20:11 +0530)]
Merge pull request #43015 from ktdreyer/build-doc-venv
admin/build-doc: use venv module again
Reviewed-by: Kefu Chai <kchai@redhat.com>
Dimitri Savineau [Thu, 2 Sep 2021 14:28:18 +0000 (10:28 -0400)]
cephadm: fix prometheus namespace spelling
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
Kefu Chai [Thu, 2 Sep 2021 13:51:06 +0000 (21:51 +0800)]
Merge pull request #42994 from ceph/wip-crimson-monmap-more-srcs
monmap, crimson: add support for mon_host_override
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Matt Benjamin [Thu, 2 Sep 2021 11:39:49 +0000 (07:39 -0400)]
Merge pull request #39849 from pritha-srivastava/wip-rgw-sts-principal-tags
rgw/sts: adding code for aws:RequestTags as part
Sebastian Wagner [Thu, 2 Sep 2021 10:04:01 +0000 (12:04 +0200)]
Merge pull request #42982 from adk3798/async-mock-py3-8
mgr/cephadm: don't fail unit tests if can't import AsyncMock
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Igor Fedotov [Thu, 2 Sep 2021 09:40:27 +0000 (12:40 +0300)]
Merge pull request #42830 from ifed01/wip-ifed-fix-bluefs-replay-crc
os/bluestore: accept undecodable multi-block bluefs transactions on log
Reviewed-by: Sage Weil <sweil@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Yingxin Cheng [Thu, 2 Sep 2021 04:42:27 +0000 (12:42 +0800)]
crimson/onode-staged-tree: add logs for hint
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 2 Sep 2021 04:39:27 +0000 (12:39 +0800)]
crimson/onode-staged-tree: implement hint based on the splitting node
Instead of the hint from the inserting key.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 2 Sep 2021 03:05:18 +0000 (11:05 +0800)]
crimson/onode-staged-tree: implement hint in NodeImpl::rebuild_extent()
Get the hint from its first key when rebuilding a node extent.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Thu, 2 Sep 2021 01:19:29 +0000 (09:19 +0800)]
Merge pull request #43016 from athanatos/sjust/wip-fix-build
crimson/os/seastore/lba_manager/btree/lba_btree: fix FTBFS on gcc 9
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Samuel Just [Wed, 1 Sep 2021 21:44:14 +0000 (14:44 -0700)]
crimson/os/seastore/lba_manager/btree/lba_btree: fix FTBFS on gcc 9
gcc-9 doesn't seem to consider interator nothrow move constructible with
the default move constructor implementation yielding the following build
failure:
m/el8/BUILD/
ceph-17.0.0-7373-gfc349212 /src/seastar/include/seastar/core/future.hh:584:58: error: static assertion failed: Types must be no-throw move constructible
584 | static_assert(std::is_nothrow_move_constructible<T>::value,
Signed-off-by: Samuel Just <sjust@redhat.com>
Ken Dreyer [Wed, 1 Sep 2021 21:40:35 +0000 (17:40 -0400)]
admin/build-doc: use venv module again
Commit
690ca1c5628af629a25a80611c20e56095f13352 accidentally
re-introduced virtualenv. Switch back to the venv module in stdlib.
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
zdover23 [Wed, 1 Sep 2021 16:17:22 +0000 (02:17 +1000)]
Merge pull request #42942 from zdover23/wip-doc-mgr-progress
doc/mgr: add progress module documentation
Reviewed-by: Neha Ojha <nojha@redhat.com>
Joseph Sawaya [Wed, 18 Aug 2021 15:52:39 +0000 (11:52 -0400)]
qa/tasks/rook: add OSD creation to Rook QA
This commit adds OSD creation to the Rook QA tasks. The Rook task will
explicitly wait for the mgr to start and the CLI to work (instead of
implicitly doing so while waiting for 'ceph osd dump' to work).
Then it will do `ceph orch apply osd --all-available-devices` to create
OSDs on the rest of the PVs.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Radoslaw Zarzynski [Wed, 1 Sep 2021 14:34:15 +0000 (16:34 +0200)]
script: ceph-debug-docker.sh deals with the centos-repos -> centos-linux-repos transition.
See: https://gist.github.com/rzarzynski/
19f11e2180faeb82c42d1787b7e0e8dd .
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Daniel Gryniewicz [Wed, 1 Sep 2021 12:40:04 +0000 (08:40 -0400)]
Merge pull request #42948 from llamerada-jp/fix-radosgw-admin-document
rgw: fix document
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Michael Fritch [Mon, 30 Aug 2021 22:53:07 +0000 (16:53 -0600)]
mgr/cephadm: run coroutines in a new event loop
`asyncio.run` does not exist until python37 or later
Signed-off-by: Michael Fritch <mfritch@suse.com>
Kalpesh Pandya [Wed, 28 Jul 2021 06:23:31 +0000 (11:53 +0530)]
qa/tasks: Addition of new code for session tags in STS
Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
Kalpesh Pandya [Fri, 16 Jul 2021 09:51:53 +0000 (15:21 +0530)]
qa/tasks: Addition of two new parameters for sts-tests
Addition of SUB and AZP parameter for some new sts-tests
Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
Pritha Srivastava [Fri, 20 Aug 2021 09:51:24 +0000 (15:21 +0530)]
rgw/sts: configuration steps to add tags to a user in
Keycloak.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Fri, 30 Jul 2021 10:22:58 +0000 (15:52 +0530)]
rgw/sts: documentation related to tag, list tags
and untag REST APIs for a role.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Mon, 26 Jul 2021 05:30:36 +0000 (11:00 +0530)]
rgw/sts: adding documentation for session tags,
all kinds of tag keys and related examples.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Wed, 14 Jul 2021 10:33:22 +0000 (16:03 +0530)]
rgw/sts: documentation related to supporting all claims
in the JWT in the condition of the trust policy.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Sat, 5 Jun 2021 15:42:02 +0000 (21:12 +0530)]
rgw/sts: code changes to store multi-valued tags
for objects and buckets (to be used as s3:ResourceTags
in Identity and Resource policies).
Test code changes as suggested by Yuval Lifshitz.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Thu, 3 Jun 2021 10:03:03 +0000 (15:33 +0530)]
rgw/sts: code to add role tags as aws:PrincipalTags and
iam:ResourceTags.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Tue, 1 Jun 2021 16:15:37 +0000 (21:45 +0530)]
rgw/sts: added code to tag, untag and list role tags.
The role tags can be used as iam:ResourceTags in AssumeRoleWithWebIdentity
or as aws:PrincipalTags in a session using temporary credentials.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>