]>
git.apps.os.sepia.ceph.com Git - ceph-ci.git/log 
Casey Bodley  [Mon, 13 Mar 2017 18:51:17 +0000  (14:51 -0400)] 
rgw: data sync includes instance in rgw_obj_index_keySigned-off-by: Casey Bodley <cbodley@redhat.com> 
Loic Dachary  [Mon, 13 Mar 2017 14:07:47 +0000  (15:07 +0100)] 
Merge pull request #13722 from dachary/wip-crush-docReviewed-by: Sage Weil <sage@redhat.com> 
Loic Dachary  [Thu, 2 Mar 2017 21:18:37 +0000  (22:18 +0100)] 
crush: document tunables and rule step set_Signed-off-by: Loic Dachary <loic@dachary.org> 
Nathan Cutler  [Mon, 13 Mar 2017 07:34:27 +0000  (08:34 +0100)] 
Merge pull request #13781 from SUSE/wip-19184Reviewed-by: Ken Dreyer <kdreyer@redhat.com> Reviewed-by: Boris Ranto <branto@redhat.com> 
Jason Dillaman  [Sun, 12 Mar 2017 14:51:58 +0000  (10:51 -0400)] 
Merge pull request #13926 from trociny/wip-19260Reviewed-by: Jason Dillaman <dillaman@redhat.com> 
Mykola Golub  [Sat, 11 Mar 2017 19:19:33 +0000  (19:19 +0000)] 
librbd: make build with clangFixes: http://tracker.ceph.com/issues/19260 Signed-off-by: Mykola Golub <mgolub@mirantis.com> 
Mykola Golub  [Sat, 11 Mar 2017 15:05:49 +0000  (17:05 +0200)] 
Merge pull request #13694 from liupan1111/wip-fix-no-error-mapReviewed-by: Jason Dillaman <dillaman@redhat.com> Reviewed-by: Mykola Golub <mgolub@mirantis.com> 
Pan Liu  [Sat, 11 Mar 2017 13:50:00 +0000  (21:50 +0800)] 
rbd-nbd: only try to load nbd module once when open nbd device, during do_map operation.Signed-off-by: Pan Liu <liupan1111@gmail.com> 
Pan Liu  [Sat, 11 Mar 2017 13:48:37 +0000  (21:48 +0800)] 
rbd-nbd: warn when kernel parameters are ignoredFixes: http://tracker.ceph.com/issues/19108 Signed-off-by: Pan Liu <liupan1111@gmail.com> 
Xie Xingguo  [Sat, 11 Mar 2017 01:55:44 +0000  (09:55 +0800)] 
Merge pull request #13801 from xiexingguo/wip-fix-func-nameReviewed-by: Sage Weil <sage@redhat.com> 
Yehuda Sadeh  [Fri, 10 Mar 2017 21:54:23 +0000  (13:54 -0800)] 
Merge pull request #13856 from zhangsw/cleanup-radosgw-admin-tier_typeReviewed-by: Jiaying Ren <mikulely@gmail.com> 
Yehuda Sadeh  [Fri, 10 Mar 2017 19:27:03 +0000  (11:27 -0800)] 
Merge pull request #13920 from cbodley/wip-rgw-fix-cleanup-meta-syncReviewed-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Fri, 10 Mar 2017 19:10:58 +0000  (11:10 -0800)] 
Merge pull request #11586 from cbodley/wip-rgw-fetchallmeta-yield-breakReviewed-by: Yehuda Sadeh <yehuda@redhat.com> 
Sage Weil  [Fri, 10 Mar 2017 16:55:21 +0000  (10:55 -0600)] 
Merge pull request #10407 from yonghengdexin735/wip-zzz-perf-countersReviewed-by: Sage Weil <sage@redhat.com> 
Casey Bodley  [Fri, 10 Mar 2017 16:25:35 +0000  (11:25 -0500)] 
rgw: fix transition from full to incremental meta syncSigned-off-by: Casey Bodley <cbodley@redhat.com> 
Nathan Cutler  [Fri, 3 Mar 2017 22:43:31 +0000  (23:43 +0100)] 
build/ops: extend rpm spec file copyright period to 2017Signed-off-by: Nathan Cutler <ncutler@suse.com> 
Nathan Cutler  [Fri, 3 Mar 2017 14:49:59 +0000  (15:49 +0100)] 
build/ops: make package groups comply with openSUSE guidelinesFixes: http://tracker.ceph.com/issues/19184 Signed-off-by: Nathan Cutler <ncutler@suse.com> 
Mykola Golub  [Fri, 10 Mar 2017 15:00:43 +0000  (17:00 +0200)] 
Merge pull request #13737 from dillaman/wip-19104Reviewed-by: Mykola Golub <mgolub@mirantis.com> 
Jason Dillaman  [Fri, 3 Mar 2017 21:06:25 +0000  (16:06 -0500)] 
rbd-mirror: correct race conditions within leader watcherSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Fri, 3 Mar 2017 17:38:18 +0000  (12:38 -0500)] 
librbd: improve debug log messages for managed lockSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Thu, 2 Mar 2017 17:04:45 +0000  (12:04 -0500)] 
test: potential shutdown race in TestMockImageReplayer.DecodeErrorSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Thu, 2 Mar 2017 15:29:36 +0000  (10:29 -0500)] 
librbd: avoid duplicating librados IoCtx objects if not neededSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Wed, 1 Mar 2017 23:40:05 +0000  (18:40 -0500)] 
test/librados_test_stub: support blacklisting of connectionsSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Wed, 1 Mar 2017 22:27:23 +0000  (17:27 -0500)] 
test/librados_test_stub: watch/notify should be connection-awareSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Wed, 1 Mar 2017 21:21:20 +0000  (16:21 -0500)] 
test/librados_test_stub: separate mock cluster from connectionSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Sage Weil  [Thu, 9 Mar 2017 21:16:19 +0000  (15:16 -0600)] 
Merge pull request #13857 from liupan1111/wip-rename-onack-to-oncommitReviewed-by: Sage Weil <sage@redhat.com> 
Yehuda Sadeh  [Thu, 9 Mar 2017 18:16:48 +0000  (10:16 -0800)] 
Merge pull request #11485 from yehudasa/wip-bucket-cleanupReviewed-by: Casey Bodley <cbodley@redhat.com> 
Mykola Golub  [Thu, 9 Mar 2017 18:15:17 +0000  (20:15 +0200)] 
Merge pull request #13758 from dillaman/wip-18748Reviewed-by: Mykola Golub <mgolub@mirantis.com> 
Yehuda Sadeh  [Wed, 8 Mar 2017 22:52:34 +0000  (14:52 -0800)] 
rgw: fix crash when listing objects via swiftFixes: http://tracker.ceph.com/issues/19249 Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Wed, 8 Mar 2017 22:27:14 +0000  (14:27 -0800)] 
qa/tasks/radosgw_admin: adjust test to new bucket structureSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Sat, 18 Feb 2017 00:37:08 +0000  (16:37 -0800)] 
rgw: more fixes following rebaseSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 9 Jan 2017 21:04:43 +0000  (13:04 -0800)] 
rgw: new rest api to retrieve object layoutSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Thu, 5 Jan 2017 21:15:56 +0000  (13:15 -0800)] 
rgw: get_obj_state() checks for empty oidsSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Tue, 20 Dec 2016 21:32:57 +0000  (13:32 -0800)] 
rgw: metadata put of bucket instance sets bucket_idSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Tue, 20 Dec 2016 21:32:17 +0000  (13:32 -0800)] 
rgw_admin: remove broken checkSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 19 Dec 2016 22:33:18 +0000  (14:33 -0800)] 
mrgw.sh: fix scriptSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 19 Dec 2016 22:15:36 +0000  (14:15 -0800)] 
rgw: fix async cr operationSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Fri, 16 Dec 2016 23:41:23 +0000  (15:41 -0800)] 
rgw: modify default pools to use namespacesSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Fri, 16 Dec 2016 23:43:40 +0000  (15:43 -0800)] 
rgw: handle pools namespaceSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Fri, 16 Dec 2016 02:14:58 +0000  (18:14 -0800)] 
rgw: add namespace to rgw_poolSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Thu, 15 Dec 2016 00:09:13 +0000  (16:09 -0800)] 
rgw: compilation and other fixes following rebaseSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 28 Nov 2016 16:27:41 +0000  (08:27 -0800)] 
rgw: move placement rule out of rgw_bucketSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Tue, 22 Nov 2016 18:36:15 +0000  (10:36 -0800)] 
cls/version: add more useful loggingSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Tue, 22 Nov 2016 18:33:12 +0000  (10:33 -0800)] 
rgw: fix ECANCELED handling in rgw_get_system_obj()Fixes: http://tracker.ceph.com/issues/17996 Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 21 Nov 2016 22:10:21 +0000  (14:10 -0800)] 
rgw: keep rgw_obj key info in rgw_obj_key fieldSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Thu, 17 Nov 2016 23:26:35 +0000  (15:26 -0800)] 
rgw: add rgw_obj_index_key, kill RGWObjEntSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Thu, 17 Nov 2016 00:20:17 +0000  (16:20 -0800)] 
rgw: clean rgw_objSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Wed, 16 Nov 2016 01:14:24 +0000  (17:14 -0800)] 
rgw: fix bucket overwriteSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 31 Oct 2016 22:55:20 +0000  (15:55 -0700)] 
test/rgw: extend obj, manifest unitestsSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 31 Oct 2016 22:56:26 +0000  (15:56 -0700)] 
rgw: implicit rgw_bucket placement, manifest uses rgw_raw_objSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Thu, 13 Oct 2016 22:57:46 +0000  (15:57 -0700)] 
rgw: simple manifest compactionSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Thu, 13 Oct 2016 03:22:01 +0000  (20:22 -0700)] 
rgw: use rgw_raw_obj in manifest codeSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Tue, 11 Oct 2016 22:44:17 +0000  (15:44 -0700)] 
rgw: decode rgw_raw_obj as rgw_obj when it's old objectSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Tue, 11 Oct 2016 22:06:37 +0000  (15:06 -0700)] 
rgw: remove unneeded virtual declarationsSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Mon, 10 Oct 2016 22:09:35 +0000  (15:09 -0700)] 
rgw: more fixes and adjustments following rgw_pool, rgw_raw_objSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Sun, 9 Oct 2016 05:16:18 +0000  (22:16 -0700)] 
rgw: separate RGWObjStateSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Yehuda Sadeh  [Sat, 8 Oct 2016 04:03:32 +0000  (21:03 -0700)] 
rgw: introduce rgw_pool, rgw_raw_objSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Pan Liu  [Thu, 9 Mar 2017 12:58:26 +0000  (20:58 +0800)] 
librados: replace the var name from onact to oncomplete.Signed-off-by: Pan Liu <pan.liu@istuary.com> 
Sage Weil  [Thu, 9 Mar 2017 15:35:29 +0000  (09:35 -0600)] 
Merge pull request #13901 from Adirl/defaultReviewed-by: Sage Weil <sage@redhat.com> 
Casey Bodley  [Thu, 9 Mar 2017 14:53:27 +0000  (09:53 -0500)] 
Merge pull request #13760 from zhangsw/fix-rgw-torrent-uriReviewed-by: Casey Bodley <cbodley@redhat.com> 
Casey Bodley  [Thu, 9 Mar 2017 14:47:29 +0000  (09:47 -0500)] 
Merge pull request #13660 from shashalu/rgw-read-sync-statusReviewed-by: Casey Bodley <cbodley@redhat.com> 
Abhishek L  [Thu, 9 Mar 2017 14:17:12 +0000  (15:17 +0100)] 
Merge pull request #13878 from smithfarm/wip-jewel-release-notes-fixupReviewed-by: Sage Weil <sweil@redhat.com> Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com> 
DanielBar-On  [Wed, 1 Mar 2017 14:58:37 +0000  (14:58 +0000)] 
msg/async/rdma: compile with rdma as defaultSigned-off-by: DanielBar-On <danielbo@mellanox.com> 
Haomai Wang  [Thu, 9 Mar 2017 08:21:35 +0000  (16:21 +0800)] 
Merge pull request #13896 from optimistyzy/39_1Reviewed-by: Haomai Wang <haomai@xsky.com> 
optimistyzy  [Thu, 9 Mar 2017 06:30:33 +0000  (14:30 +0800)] 
Bluestore, NVMeDevice: fix the core id for rte_remote_launchSigned-off-by: optimistyzy <optimistyzy@gmail.com> 
Dan Mick  [Thu, 9 Mar 2017 04:06:16 +0000  (20:06 -0800)] 
Merge pull request #13891 from yehudasa/wip-vstart-not-new
Zhang Shaowen  [Fri, 3 Mar 2017 03:16:22 +0000  (11:16 +0800)] 
rgw: get torrent request's parameter is not the same as amazon s3.Fixes: http://tracker.ceph.com/issues/19136 Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com> 
Haomai Wang  [Thu, 9 Mar 2017 01:49:02 +0000  (09:49 +0800)] 
Merge pull request #13556 from tangwenjun3/wip-fix-coredumpReviewed-by: Haomai Wang <haomai@xsky.com> 
lu.shasha  [Mon, 27 Feb 2017 07:52:43 +0000  (15:52 +0800)] 
rgw: use separate http_manager for read_sync_statusFixes: http://tracker.ceph.com/issues/19236 Signed-off-by: Shasha Lu <lu.shasha@eisoo.com> 
Yuri Weinstein  [Thu, 9 Mar 2017 00:23:26 +0000  (16:23 -0800)] 
Merge pull request #13892 from dmick/wip-19232Reviewed-by: Yuri Weinstein <yweins@redhat.com> 
Dan Mick  [Wed, 8 Mar 2017 22:19:40 +0000  (14:19 -0800)] 
qa/suites/upgrade/kraken-x: do not thrash cluster full during upgrade
Same thing as 
39fdc53fe5f33678fbbd00cf8810b6d523d0040c 
Fixes: http://tracker.ceph.com/issues/19232 
Signed-off-by: Dan Mick <dan.mick@redhat.com> 
Yehuda Sadeh  [Wed, 8 Mar 2017 22:17:00 +0000  (14:17 -0800)] 
vstart: don't create cluster by defaultSigned-off-by: Yehuda Sadeh <yehuda@redhat.com> 
Nathan Cutler  [Wed, 8 Mar 2017 15:29:47 +0000  (16:29 +0100)] 
doc: mention ENXIO change in the 10.2.6 release notesSigned-off-by: Nathan Cutler <ncutler@suse.com> 
Yehuda Sadeh  [Wed, 8 Mar 2017 20:57:31 +0000  (12:57 -0800)] 
Merge pull request #13880 from cbodley/wip-qa-submoduleReviewed-by: Yehuda Sadeh <yehuda@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 19:38:54 +0000  (13:38 -0600)] 
Merge pull request #13217 from liewegas/wip-bluestore-prefer-wal-sizeReviewed-by: Igor Fedotov <ifedotov@mirantis.com> 
Casey Bodley  [Wed, 8 Mar 2017 17:30:05 +0000  (12:30 -0500)] 
build: remove ceph-qa-suite directory
after commit 
3afb889  "qa: add supported distros for ceph-ansible", git
submodule update commands are failing with:
No submodule mapping found in .gitmodules for path 'ceph-qa-suite'
Signed-off-by: Casey Bodley <cbodley@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 17:14:08 +0000  (11:14 -0600)] 
Merge pull request #13785 from liewegas/wip-cleanup-featuresReviewed-by: Haomai Wang <haomai@xsky.com> 
Jason Dillaman  [Fri, 3 Mar 2017 00:58:39 +0000  (19:58 -0500)] 
doc: update RBD mirroring instructions for pool demotion/promotionSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Thu, 16 Feb 2017 13:04:40 +0000  (08:04 -0500)] 
rbd: new rbd mirror pool promote/demote actionsFixes: http://tracker.ceph.com/issues/18748 Signed-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Fri, 3 Feb 2017 18:37:43 +0000  (13:37 -0500)] 
librbd: add aio_mirror_image_* API methodsSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Fri, 3 Feb 2017 16:16:31 +0000  (11:16 -0500)] 
librbd: additional asynchronous mirror state machinesSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Fri, 3 Feb 2017 02:31:54 +0000  (21:31 -0500)] 
librbd: asynchronous journal demote state machineSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Thu, 2 Feb 2017 18:54:13 +0000  (13:54 -0500)] 
librbd: move group and diff API functionsSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Thu, 2 Feb 2017 18:07:49 +0000  (13:07 -0500)] 
librbd: move mirror-related API functionsSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Casey Bodley  [Wed, 8 Mar 2017 16:55:44 +0000  (11:55 -0500)] 
Merge pull request #13078 from zhangsw/fix-rgw-setacl-bugReviewed-by: Casey Bodley <cbodley@redhat.com> 
Jason Dillaman  [Thu, 2 Feb 2017 17:05:47 +0000  (12:05 -0500)] 
librbd: rename parent_spec/parent_info type to match code style specsSigned-off-by: Jason Dillaman <dillaman@redhat.com> 
Josh Durgin  [Wed, 8 Mar 2017 15:47:49 +0000  (07:47 -0800)] 
Merge pull request #13852 from liewegas/wip-19133Reviewed-by: Josh Durgin <jdurgin@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 15:35:50 +0000  (09:35 -0600)] 
Merge pull request #13711 from tmuthamizhan/wip-add-supported-distrosReviewed-by: Yuri Weinstein <yweinstei@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 15:08:16 +0000  (09:08 -0600)] 
Merge pull request #13776 from Liuchang0812/wip-add-override-in-tool-headersReviewed-by: Sage Weil <sage@redhat.com> 
Jason Dillaman  [Wed, 8 Mar 2017 15:07:29 +0000  (10:07 -0500)] 
Merge pull request #13791 from runsisi/wip-rbd-ack-cleanupReviewed-by: Jason Dillaman <dillaman@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 15:06:47 +0000  (09:06 -0600)] 
Merge pull request #13775 from Liuchang0812/wip-add-override-librados-headersReviewed-by: Sage Weil <sage@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 15:06:16 +0000  (09:06 -0600)] 
Merge pull request #13774 from Liuchang0812/wip-add-override-in-common-headersReviewed-by: Sage Weil <sage@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 15:03:20 +0000  (09:03 -0600)] 
Merge pull request #13773 from Liuchang0812/wip-add-override-in-test-headersReviewed-by: Kefu Chai <kchai@redhat.com> 
Sage Weil  [Wed, 8 Mar 2017 15:02:33 +0000  (09:02 -0600)] 
Merge pull request #13771 from Liuchang0812/wip-add-override-in-msg-headersReviewed-by: Kefu Chai <kchai@redhat.com> 
Jason Dillaman  [Wed, 8 Mar 2017 13:42:33 +0000  (08:42 -0500)] 
Merge pull request #13782 from vshankar/wip-19034Reviewed-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Wed, 8 Mar 2017 13:41:44 +0000  (08:41 -0500)] 
Merge pull request #13752 from trociny/wip-19130Reviewed-by: Jason Dillaman <dillaman@redhat.com> 
Loic Dachary  [Wed, 8 Mar 2017 12:16:49 +0000  (13:16 +0100)] 
Merge pull request #13444 from dachary/wip-18943-device-classReviewed-by: Sage Weil <sage@redhat.com> 
Abhishek L  [Wed, 8 Mar 2017 12:14:25 +0000  (13:14 +0100)] 
Merge pull request #13835 from theanalyst/doc/releases/10.2.6Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Loic Dachary <ldachary@redhat.com> 
John Spray  [Wed, 8 Mar 2017 11:56:01 +0000  (11:56 +0000)] 
Merge pull request #13453 from xiaoxichen/drop_mallinfoReviewed-by: John Spray <john.spray@redhat.com> 
John Spray  [Wed, 8 Mar 2017 11:48:53 +0000  (11:48 +0000)] 
Merge pull request #13580 from ukernel/wip-18914Reviewed-by: John Spray <john.spray@redhat.com>