]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
3 days agomon/MonClient: wipe secrets and invalidate tickets on auth epoch change
Patrick Donnelly [Fri, 9 May 2025 18:56:10 +0000 (14:56 -0400)]
mon/MonClient: wipe secrets and invalidate tickets on auth epoch change

* This causes service daemons to drop all known service tickets and request new
  ones from the auth server.

* This causes the clients (and service daemons) to request new tickets from the
  auth server which will include tickets signed with the new service keys.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/AuthMonitor: bump auth epoch when wiping service keys
Patrick Donnelly [Fri, 9 May 2025 18:54:47 +0000 (14:54 -0400)]
mon/AuthMonitor: bump auth epoch when wiping service keys

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/MonmapMonitor: wire up interface to bump auth epoch
Patrick Donnelly [Fri, 9 May 2025 18:19:18 +0000 (14:19 -0400)]
mon/MonmapMonitor: wire up interface to bump auth epoch

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/MonMap: add auth epoch
Patrick Donnelly [Fri, 9 May 2025 18:15:09 +0000 (14:15 -0400)]
mon/MonMap: add auth epoch

This will be used to indicate to clients / service daemons that the auth
service keys have been rotated. Clients and service daemons are expected to
invalidate their tickets and reauth. Service daemons should wipe their service
keys.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/AuthMonitor: add dump-keys and wipe-rotating-service-keys
Patrick Donnelly [Wed, 26 Mar 2025 01:59:34 +0000 (21:59 -0400)]
mon/AuthMonitor: add dump-keys and wipe-rotating-service-keys

`auth dump-keys` allows examining the key types for each entity and also the
rotating session keys. This lets us confirm key upgrades are done as expected.

`wipe-rotating-service-keys` clears out existing non-auth service keys so that we do not
need to wait for the rotating key expiration. It is not disruptive so long as clients
renew their tickets when prompted by the auth epoch change.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/AuthMonitor: add key-type switch
Patrick Donnelly [Fri, 21 Mar 2025 16:56:06 +0000 (12:56 -0400)]
mon/AuthMonitor: add key-type switch

So it's possible to test with various key-types.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agocommon/cmdparse: add another template cmd_getval_or helper
Patrick Donnelly [Fri, 21 Mar 2025 16:57:25 +0000 (12:57 -0400)]
common/cmdparse: add another template cmd_getval_or helper

To mimic the conventional signature where you pass the lvalue you want to set.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/Monitor: perfect forward universal ref of lambda
Patrick Donnelly [Fri, 9 May 2025 18:16:55 +0000 (14:16 -0400)]
mon/Monitor: perfect forward universal ref of lambda

This method doesn't currently work for std::move of a lambda.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon/Monitor: add debugging for monmap handling
Patrick Donnelly [Fri, 9 May 2025 18:19:56 +0000 (14:19 -0400)]
mon/Monitor: add debugging for monmap handling

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agomon: notify_new_monmap via MonmapMonitor::init
Patrick Donnelly [Fri, 13 Jun 2025 19:14:55 +0000 (15:14 -0400)]
mon: notify_new_monmap via MonmapMonitor::init

Otherwise, configurations are not updated during startup.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agodoc/man: document new --key-type option for ceph-authtool
Patrick Donnelly [Thu, 29 May 2025 15:11:43 +0000 (11:11 -0400)]
doc/man: document new --key-type option for ceph-authtool

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agotools/ceph_authtool: add help message for key-type switch
Patrick Donnelly [Fri, 21 Mar 2025 16:54:33 +0000 (12:54 -0400)]
tools/ceph_authtool: add help message for key-type switch

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agocommon/buffer: accept "-" as stdin
Patrick Donnelly [Fri, 21 Mar 2025 16:53:38 +0000 (12:53 -0400)]
common/buffer: accept "-" as stdin

These methods are used for reading files from tools like "authtool". Read from
stdin if the conventional "-" filename is passed.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth/cephx: make some parameters const
Patrick Donnelly [Thu, 29 May 2025 14:01:37 +0000 (10:01 -0400)]
auth/cephx: make some parameters const

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth: cleanup error message formatting
Patrick Donnelly [Tue, 27 May 2025 23:25:42 +0000 (19:25 -0400)]
auth: cleanup error message formatting

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth,mon: lookup ticket ttl at runtime
Patrick Donnelly [Wed, 26 Mar 2025 02:04:20 +0000 (22:04 -0400)]
auth,mon: lookup ticket ttl at runtime

and improve debugging.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth: add API to invalidate all tickets
Patrick Donnelly [Fri, 9 May 2025 18:52:52 +0000 (14:52 -0400)]
auth: add API to invalidate all tickets

This will prompt the client to request new ones from the auth server.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth: add API to wipe rotating secrets
Patrick Donnelly [Fri, 9 May 2025 18:52:13 +0000 (14:52 -0400)]
auth: add API to wipe rotating secrets

This is for the service daemon's store of rotating service secrets.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth/cephx: enforce sorted config keys
Patrick Donnelly [Wed, 26 Mar 2025 01:55:22 +0000 (21:55 -0400)]
auth/cephx: enforce sorted config keys

Makes future additions avoid conflicts.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth/cephx: update get_tracked_keys signature
Patrick Donnelly [Tue, 18 Mar 2025 20:04:02 +0000 (16:04 -0400)]
auth/cephx: update get_tracked_keys signature

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth: fix return type
Patrick Donnelly [Mon, 24 Mar 2025 02:42:53 +0000 (22:42 -0400)]
auth: fix return type

key type is an unsigned.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agocommon: break print template into separate header
Patrick Donnelly [Thu, 29 May 2025 12:58:08 +0000 (08:58 -0400)]
common: break print template into separate header

To avoid pulling in all the debug includes for some primitive headers.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agocommon: remove dead option
Patrick Donnelly [Tue, 3 Jun 2025 15:26:04 +0000 (11:26 -0400)]
common: remove dead option

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agotest: fix compiler error
Patrick Donnelly [Thu, 15 May 2025 17:29:55 +0000 (13:29 -0400)]
test: fix compiler error

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 days agoauth,*: remove conflicting fwd declarations
Matan Breizman [Mon, 9 Jun 2025 16:37:21 +0000 (16:37 +0000)]
auth,*: remove conflicting fwd declarations

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
3 days agoinclude/common_fwd: Include Crypto classes
Matan Breizman [Mon, 9 Jun 2025 12:07:49 +0000 (12:07 +0000)]
include/common_fwd: Include Crypto classes

CryptoManager::cct is now used in CephContext ctor. To provide this
defintion
any ceph_context.cc target must also include Crypto.cc.

crimson-alien-common library which only had ceph_context.cc must now
also include Crypto.cc.
However, the fact that crimson-common also includes Crypto.cc would
cause multiple defintions
to any Crypto classes methods.

To resolve this, let's wrap all Crypto classes with TOPNSPC::common that
would be forwarded using common_fwd logic.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
3 days agocephx: sign messages using hmac_sha256
Yehuda Sadeh [Wed, 28 May 2025 19:51:19 +0000 (15:51 -0400)]
cephx: sign messages using hmac_sha256

if key type is newer than the original AES, calculate message
hash by using HMAC-SHA256.
We cannot use plain aes256k like we do with the aes key because
of the confounder. The other option would be to inject a
confounder, but that would weaken the cipher.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: create slice api for calculating hmac_sha256
Yehuda Sadeh [Wed, 28 May 2025 19:50:15 +0000 (15:50 -0400)]
auth: create slice api for calculating hmac_sha256

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agotest/auth: more aes256krb5 tests
Yehuda Sadeh [Tue, 18 Mar 2025 10:53:44 +0000 (06:53 -0400)]
test/auth: more aes256krb5 tests

 - DecryptNoBl
 - multiple test vectos per each test

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: test slice interface for aes256k
Yehuda Sadeh [Mon, 17 Mar 2025 11:44:30 +0000 (07:44 -0400)]
auth: test slice interface for aes256k

AES256KRB5 uses the default slice encryption implementation, testing that
it works correctly.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agotest/crypto: more aes256krb5 tests
Yehuda Sadeh [Mon, 17 Mar 2025 07:57:42 +0000 (03:57 -0400)]
test/crypto: more aes256krb5 tests

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: add usage param to crypto handler
Yehuda Sadeh [Mon, 17 Mar 2025 07:57:21 +0000 (03:57 -0400)]
auth: add usage param to crypto handler

Allow different usage for crypto handler users. Currently being used
in the crypto unitest to match the test vectors.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: aes256krb5: add confounder config for unitests
Yehuda Sadeh [Mon, 17 Mar 2025 06:56:32 +0000 (02:56 -0400)]
auth: aes256krb5: add confounder config for unitests

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agocephx: add configurable to set allowed ciphers
Yehuda Sadeh [Fri, 7 Mar 2025 21:35:36 +0000 (16:35 -0500)]
cephx: add configurable to set allowed ciphers

cephx allowed ciphers: a list of ciphers that  sets what type
of keys are allowed to be used to authenticate

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: remove unused code
Yehuda Sadeh [Fri, 7 Mar 2025 18:21:44 +0000 (13:21 -0500)]
auth: remove unused code

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: add a configurable to control rotating keys cipher type
Yehuda Sadeh [Fri, 7 Mar 2025 18:20:58 +0000 (13:20 -0500)]
auth: add a configurable to control rotating keys cipher type

auth_service_cipher: a mon configurable that determines what type of cipher
the rotating keys are using. The configurable can change at runtime. Note
that the change does not invalidate existing keys, these would expire
based on their ttl.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth/cephx: session key type is set to client key type
Yehuda Sadeh [Thu, 6 Mar 2025 14:23:34 +0000 (09:23 -0500)]
auth/cephx: session key type is set to client key type

This ensures that the client supports the specific key type.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth/cephx: switch default cipher to AES256KRB5
Yehuda Sadeh [Thu, 27 Feb 2025 22:09:26 +0000 (17:09 -0500)]
auth/cephx: switch default cipher to AES256KRB5

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth/cephx: modify client + server challenges hashing
Yehuda Sadeh [Thu, 27 Feb 2025 21:14:06 +0000 (16:14 -0500)]
auth/cephx: modify client + server challenges hashing

This applies when using ciphers that are not the original
AES-128 one. Use the hmac-sha256 hash now. With AES256KRB5
the original method of encrypting the combined challenges
doesn't work as the confounder randomizes the result.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoceph-authtool: support --key-type param
Yehuda Sadeh [Thu, 27 Feb 2025 16:55:37 +0000 (11:55 -0500)]
ceph-authtool: support --key-type param

Also move the encryption handlers out of the ceph_context.
Handlers are now returned as a shared_ptr, to support the
creation of new handlers with different params (such as
the usage param).

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth/crypto: add support for aes256-hmac384-192
Yehuda Sadeh [Fri, 21 Feb 2025 21:18:58 +0000 (16:18 -0500)]
auth/crypto: add support for aes256-hmac384-192

Using the encryption standard set in RFC 8009. This is the
encryption that is used in Kerberos 5, so naming this variation
as AES256KRB5.

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoauth: propagate ceph context to encrypt/decrypt
Yehuda Sadeh [Mon, 24 Feb 2025 21:31:42 +0000 (16:31 -0500)]
auth: propagate ceph context to encrypt/decrypt

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
3 days agoMerge pull request #66485 from shraddhaag/wip-shraddhaag-74052
Matan Breizman [Mon, 5 Jan 2026 15:46:26 +0000 (17:46 +0200)]
Merge pull request #66485 from shraddhaag/wip-shraddhaag-74052

qa: exclude crimson from random-objectstore

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
3 days agoMerge pull request #66599 from hasan4791/issue-74181
Kefu Chai [Mon, 5 Jan 2026 14:22:14 +0000 (22:22 +0800)]
Merge pull request #66599 from hasan4791/issue-74181

cmake: Define BITS_PER_LONG for ppc64le target

Reviewed-by: Kefu Chai <k.chai@proxmox.com>
4 days agoMerge pull request #66787 from bluikko/wip-doc-remove-pip-sphinxcontrib-seqdiag
bluikko [Mon, 5 Jan 2026 13:02:08 +0000 (20:02 +0700)]
Merge pull request #66787 from bluikko/wip-doc-remove-pip-sphinxcontrib-seqdiag

doc: Remove sphinxcontrib-seqdiag Python package from RTD builds

4 days agoMerge pull request #66195 from rhcs-dashboard/cephfs-mirroring-listing
Nizamudeen A [Mon, 5 Jan 2026 09:47:56 +0000 (15:17 +0530)]
Merge pull request #66195 from rhcs-dashboard/cephfs-mirroring-listing

mgr/dashboard: Cephfs Mirroring Listing

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
4 days agoMerge pull request #66733 from tchaikov/wip-cram
Kefu Chai [Mon, 5 Jan 2026 08:51:02 +0000 (16:51 +0800)]
Merge pull request #66733 from tchaikov/wip-cram

test/run-cli-tests: install wheel before cram to fix build failure

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 days agoMerge pull request #66784 from bluikko/wip-doc-sphinx-warnings-202601
bluikko [Mon, 5 Jan 2026 07:19:40 +0000 (14:19 +0700)]
Merge pull request #66784 from bluikko/wip-doc-sphinx-warnings-202601

doc/dev: Fix Sphinx complaints in msgr2.rst

4 days agoMerge pull request #66785 from bluikko/wip-doc-sphinx-warnings-202601b
bluikko [Mon, 5 Jan 2026 07:18:59 +0000 (14:18 +0700)]
Merge pull request #66785 from bluikko/wip-doc-sphinx-warnings-202601b

doc/rados: Fix Sphinx warnings in troubleshooting/log-and-debug.rst

4 days agodoc: Remove sphinxcontrib-seqdiag Python package from RTD builds
Ville Ojamo [Mon, 5 Jan 2026 06:10:45 +0000 (13:10 +0700)]
doc: Remove sphinxcontrib-seqdiag Python package from RTD builds

This is a proactive PR to avoid breaking docs builds when Setuptools 81
starts to be used in the RTD builds process.

The sphnixcontrib-seqdiag Python package is not compatible with
Setuptools 81 or later due to use of pkg_resources:
https://setuptools.pypa.io/en/latest/pkg_resources.html

Setuptools 81 release should be imminent, with the Python deprecation
warning stating pkg_resources "removal as early as 2025-11-30".

Seqdiag seems to be unmaintained with the latest update at Pypi in
the year 2021 and also no updates to the seqdiag git repo.

There are no seqdiag directives left in the docs after last seqdiags
were removed in PR #52308.

Two other options would exist for fixing the situation (see PR for
discussion) but this seems to be the suitable one.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
4 days agodoc/rados: Fix Sphinx warnings in troubleshooting/log-and-debug.rst
Ville Ojamo [Mon, 5 Jan 2026 05:46:08 +0000 (12:46 +0700)]
doc/rados: Fix Sphinx warnings in troubleshooting/log-and-debug.rst

Possibly controversial Sphinx fixes:

Fix two Sphinx warnings about more than one confval directive.
Remove the dupe confval directives from log-and-debug.rst and leave only
in mon-config-ref.rst because it has the only copy of a related clog
configuration value mon_health_to_clog_tick_interval.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
4 days agodoc/dev: Fix Sphinx complaints in msgr2.rst
Ville Ojamo [Mon, 5 Jan 2026 05:26:58 +0000 (12:26 +0700)]
doc/dev: Fix Sphinx complaints in msgr2.rst

Uncontroversial Sphinx fixes:

Fix Sphinx warning about section title underline too short.
No change in rendering.

Fix Sphinx critical about section title underline at wrong level.
Fixes the title rendering and makes it visible.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
4 days agoMerge pull request #66680 from rhcs-dashboard/dashboard-zonegroup-consistency
Aashish Sharma [Mon, 5 Jan 2026 04:42:30 +0000 (10:12 +0530)]
Merge pull request #66680 from rhcs-dashboard/dashboard-zonegroup-consistency

mgr/dashboard: rename 'Zone Group' labels to 'Zonegroup'

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
7 days agoMerge pull request #66766 from tchaikov/wip-options-log-to-stderr
Kefu Chai [Fri, 2 Jan 2026 01:46:42 +0000 (09:46 +0800)]
Merge pull request #66766 from tchaikov/wip-options-log-to-stderr

common/options: document log_to_stderr's conditional default value

Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 days agocommon/options: document log_to_stderr's conditional default value
Kefu Chai [Wed, 31 Dec 2025 09:01:43 +0000 (17:01 +0800)]
common/options: document log_to_stderr's conditional default value

The default value of `log_to_stderr` varies depending on whether Ceph
runs as a daemon or a library. Previously, this was only documented via
the `default` property, which led to confusion when debugging client
applications.

For example, when debugging a CephFS client, setting `debug <subsystem> = 5`
in the configuration file doesn't produce visible debug logs as expected.
This occurs because `common_preinit()` overrides `log_to_stderr` to `false`
when Ceph runs as a library, preventing logs from appearing on stderr.

This commit adds clarification to the `long_desc` field to document this
conditional behavior and help users understand why debug output may not
appear in client scenarios.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
9 days agomgr/dashboard: Cephfs Mirroring Listing
Pedro Gonzalez Gomez [Thu, 20 Nov 2025 14:09:03 +0000 (15:09 +0100)]
mgr/dashboard: Cephfs Mirroring Listing

Fixes: https://tracker.ceph.com/issues/73781
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
9 days agoMerge pull request #66747 from datdenkikniet/more-docs
Anthony D'Atri [Tue, 30 Dec 2025 22:54:48 +0000 (17:54 -0500)]
Merge pull request #66747 from datdenkikniet/more-docs

doc/dev: improve formatting and clarify documentation

10 days agoMerge pull request #66583 from rhcs-dashboard/fix-74171-main
Aashish Sharma [Tue, 30 Dec 2025 11:12:13 +0000 (16:42 +0530)]
Merge pull request #66583 from rhcs-dashboard/fix-74171-main

mgr/dashboard: carbonise multi-cluster forms

Reviewed-by: Abhishek Desai <abhishek.desai1@ibm.com>
10 days agomgr/dashboard: fix multi-cluster context switcher
Aashish Sharma [Wed, 10 Dec 2025 10:41:50 +0000 (16:11 +0530)]
mgr/dashboard: fix multi-cluster context switcher

The multi-cluster context switcher stopped working because of a
regression caused by this PR https://github.com/ceph/ceph/pull/66034.
This PR tends to fix this issue

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
10 days agomgr/dashboard: carbonise multi-cluster forms
Aashish Sharma [Wed, 10 Dec 2025 07:12:40 +0000 (12:42 +0530)]
mgr/dashboard: carbonise multi-cluster forms

Fixes: https://tracker.ceph.com/issues/74171
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
10 days agoMerge pull request #66755 from anthonyeleven/updateslackinvite
Anthony D'Atri [Tue, 30 Dec 2025 04:20:43 +0000 (23:20 -0500)]
Merge pull request #66755 from anthonyeleven/updateslackinvite

doc/start: Update Slack invite URL in get-involved.rst

10 days agodoc/start: Update Slack invite URL in get-involved.rst
Anthony D'Atri [Mon, 29 Dec 2025 18:43:00 +0000 (13:43 -0500)]
doc/start: Update Slack invite URL in get-involved.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
11 days agoMerge pull request #66713 from rhcs-dashboard/upgrade-angular
Nizamudeen A [Mon, 29 Dec 2025 11:27:23 +0000 (16:57 +0530)]
Merge pull request #66713 from rhcs-dashboard/upgrade-angular

mgr/dashboard: upgrade angular to 19

11 days agoMerge pull request #66638 from afreen23/fix-host-ip
Afreen Misbah [Mon, 29 Dec 2025 11:02:52 +0000 (16:32 +0530)]
Merge pull request #66638 from afreen23/fix-host-ip

mgr/dashboard: Fix display of IP address in host page

Reviewed-by: Nizamudeen A <nia@redhat.com>
11 days ago'mgr/dashboard: Fix display of IP address in host page
Afreen Misbah [Mon, 15 Dec 2025 15:53:44 +0000 (21:23 +0530)]
'mgr/dashboard: Fix display of IP address in host page

- Hosts data is getting merged with hosts' facts which is not sending address hence not getting displayed in UI
- The value is empty hence in the API
- Caused by https://github.com/ceph/ceph/pull/65102

Fixes https://tracker.ceph.com/issues/74222

Signed-off-by: Afreen Misbah <afreen@ibm.com>
11 days agoMerge pull request #66100 from rhcs-dashboard/68263-carbonize-pools-form
Afreen Misbah [Mon, 29 Dec 2025 06:29:53 +0000 (11:59 +0530)]
Merge pull request #66100 from rhcs-dashboard/68263-carbonize-pools-form

mgr/dasboard : Carbonize pools form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 days agomgr/dasboard : Carbonize pools form
Abhishek Desai [Tue, 28 Oct 2025 06:11:36 +0000 (11:41 +0530)]
mgr/dasboard : Carbonize pools form
fixes : https://tracker.ceph.com/issues/68263
Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>
13 days agodoc/dev: clarify CRC generation techniques
Johannes Cornelis Draaijer [Fri, 26 Dec 2025 22:05:42 +0000 (23:05 +0100)]
doc/dev: clarify CRC generation techniques

13 days agodoc/dev: clarify meaning of `late_flags` in msgr2
Johannes Cornelis Draaijer [Fri, 26 Dec 2025 22:02:28 +0000 (23:02 +0100)]
doc/dev: clarify meaning of `late_flags` in msgr2

Signed-off-by: Johannes Cornelis Draaijer <jcdra1@gmail.com>
13 days agodoc/dev: fix headings in msgr2.rst
Johannes Cornelis Draaijer [Fri, 26 Dec 2025 21:58:35 +0000 (22:58 +0100)]
doc/dev: fix headings in msgr2.rst

Signed-off-by: Johannes Cornelis Draaijer <jcdra1@gmail.com>
2 weeks agoMerge pull request #66380 from benhanokh/dedup_high_dup_count
Gabriel Benhanokh [Fri, 26 Dec 2025 08:28:39 +0000 (10:28 +0200)]
Merge pull request #66380 from benhanokh/dedup_high_dup_count

rgw/dedup: Prevent the dup-counter from wrapping around

2 weeks agorgw/dedup: Prevent the dup-counter from wrapping around after it reaches 64K of ident... dedup_high_dup_count_wip_vx
Gabriel BenHanokh [Mon, 24 Nov 2025 08:02:22 +0000 (08:02 +0000)]
rgw/dedup: Prevent the dup-counter from wrapping around after it reaches 64K of identical copies.
Limit dedup from a single SRC to 128 Target copies to prevent OMAP size
from growing out of control
Tests cleanup

Resolves: rhbz#2415656
Resolves: rhbz#2416043

Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>
2 weeks agoMerge pull request #66732 from tchaikov/debian-control-iproute2
Kefu Chai [Thu, 25 Dec 2025 00:01:49 +0000 (08:01 +0800)]
Merge pull request #66732 from tchaikov/debian-control-iproute2

debian/control: add iproute2 to build dependencies

Reviewed-by: David Galloway <david.galloway@ibm.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 weeks agoMerge pull request #66686 from imran-imtiaz/dashboard
Imran Imtiaz [Wed, 24 Dec 2025 10:07:43 +0000 (10:07 +0000)]
Merge pull request #66686 from imran-imtiaz/dashboard

mgr/dashboard: add CRUD API endpoints for consistency group snapshots 1/2

2 weeks agotest/run-cli-tests: install wheel before cram to fix build failure
Kefu Chai [Wed, 24 Dec 2025 08:57:12 +0000 (16:57 +0800)]
test/run-cli-tests: install wheel before cram to fix build failure

Fix the run-cli-tests failure that occurs when installing cram from git.
The error happens because the fresh venv lacks build dependencies, causing
pip to fall back to legacy setup.py install which fails:

  Using legacy 'setup.py install' for cram, since package 'wheel' is not installed.
  Installing collected packages: cram
    Running setup.py install for cram: started
    error: subprocess-exited-with-error

    × Running setup.py install for cram did not run successfully.
    │ exit code: 1
    ╰─> See above for output.

    note: This error originates from a subprocess, and is likely not a problem with pip.
    Running setup.py install for cram: finished with status 'error'
  error: legacy-install-failure

  × Encountered error while trying to install package.
  ╰─> cram

The issue became visible after commit 70880723eaa updated the pip URL
format to the new PEP 440 style, which exposed the missing build tools.

Solution: Upgrade pip, setuptools, and wheel before installing cram to
ensure proper wheel-based installation works correctly with Python 3.13
and modern pip versions.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
2 weeks agodebian/control: add iproute2 to build dependencies
Kefu Chai [Wed, 24 Dec 2025 05:55:26 +0000 (13:55 +0800)]
debian/control: add iproute2 to build dependencies

Test scripts like qa/tasks/cephfs/mount.py expect the ip command to be
available in the container environment. Without it, tests fail with:

```
  /bin/bash: line 1: ip: command not found

  File "/ceph/qa/tasks/cephfs/mount.py", line 96, in cleanup_stale_netnses_and_bridge
    p = remote.run(args=['ip', 'netns', 'list'],
  ...
  teuthology.exceptions.CommandFailedError: Command failed with status 127: 'ip netns list'
```

Add iproute2 to the debian package build dependencies when the
<pkg.ceph.check> build profile is enabled. This ensures the package is
available during container-based builds, since buildcontainer-setup.sh
→ script/run-make.sh → install-deps.sh → debian/control → generated
dependency package chain respects build profiles configured via
`FOR_MAKE_CHECK` and `WITH_CRIMSON` environment variables set in
Dockerfile.build.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
2 weeks agoMerge pull request #65937 from ifed01/wip-ifed-kvstore-tool-cleanup
Igor Fedotov [Tue, 23 Dec 2025 14:36:18 +0000 (17:36 +0300)]
Merge pull request #65937 from ifed01/wip-ifed-kvstore-tool-cleanup

tools/kvstore_tool: reduce BlueStore.h exposure.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 weeks agomgr/dashboard: add CRUD API endpoints for consistency group snapshots
Imran Imtiaz [Mon, 8 Dec 2025 07:59:03 +0000 (07:59 +0000)]
mgr/dashboard: add CRUD API endpoints for consistency group snapshots

Signed-off-by: Imran Imtiaz <imran.imtiaz@uk.ibm.com>
Fixes: https://tracker.ceph.com/issues/74258
Create a set of consistency group dashboard API endpoints to:

- List group snapshots
- Get details about a particular snapshot
- Create a snapshot
- Delete a snapshot

(rollback/update are handled separately)

Signed-off-by: Imran Imtiaz <imran.imtiaz@uk.ibm.com>
2 weeks agomgr/dashboard: rename 'Zone Group' labels to 'Zonegroup'
Sagar Gopale [Thu, 18 Dec 2025 08:22:15 +0000 (13:52 +0530)]
mgr/dashboard: rename 'Zone Group' labels to 'Zonegroup'

Fixes: https://tracker.ceph.com/issues/74249
Signed-off-by: Sagar Gopale <sagar.gopale@ibm.com>
2 weeks agomgr/dashboard: upgrade angular to 19
Nizamudeen A [Mon, 22 Dec 2025 08:49:00 +0000 (14:19 +0530)]
mgr/dashboard: upgrade angular to 19

* bump nodejs to 22.21.1
* remove swagger-ui from the package.json and import the bundled version
  of it which is `swagger-ui-dist`. This removes the dependencies to the
react redux which is bought by the swagger-ui and also reduces the build
assets and build warnings. we really don't need the whole swagger-ui
package to be present here. Also importing the swagger-ui.css inside the
api-docs component lazily.

since our project is now under nx, upgraded using the nx migrate
command. It took care of the changes where it added the `standalone:
false` to all our files since we are still on modular architecture.

Other changes include
- adding `flush()` to fakeAsync mock test
- fixing some complaints raised by tsc linter as per the new typescript
  type checks
- removed `this` from html components
- fixed jest config for newer presets

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 weeks agoMerge pull request #66712 from zdover23/wip-doc-2025-12-22-cephfs-fscrypt
Zac Dover [Mon, 22 Dec 2025 23:43:39 +0000 (09:43 +1000)]
Merge pull request #66712 from zdover23/wip-doc-2025-12-22-cephfs-fscrypt

doc/cephfs: add fscrypt to index.rst

Reviewed-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agodoc/cephfs: add fscrypt to index.rst
Zac Dover [Mon, 22 Dec 2025 05:47:11 +0000 (15:47 +1000)]
doc/cephfs: add fscrypt to index.rst

Suppress the following warning by adding fscrypt to the TOC in
cephfs/index.rst:

   checking consistency... /ceph/doc/cephfs/fscrypt.rst:
   WARNING: document isn't included in any toctree

Signed-off-by: Zac Dover <zac.dover@clyso.com>
2 weeks agoMerge pull request #66697 from bluikko/wip-doc-rados-ops-health-checks-fixes5
bluikko [Mon, 22 Dec 2025 04:53:12 +0000 (11:53 +0700)]
Merge pull request #66697 from bluikko/wip-doc-rados-ops-health-checks-fixes5

doc/rados: Fix minor issues, improvements in health-checks.rst (5 of x)

2 weeks agoMerge pull request #66610 from cbodley/wip-librados-aio-unwatch-enotconn
Ilya Dryomov [Sun, 21 Dec 2025 14:33:10 +0000 (15:33 +0100)]
Merge pull request #66610 from cbodley/wip-librados-aio-unwatch-enotconn

librados: aio_unwatch() delivers ENOTCONN to AioCompletion

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agoMerge pull request #66705 from zdover23/wip-doc-2025-12-20-glossary-CRC
Zac Dover [Sun, 21 Dec 2025 03:13:43 +0000 (13:13 +1000)]
Merge pull request #66705 from zdover23/wip-doc-2025-12-20-glossary-CRC

doc/glossary: Add "CRC" to glossary

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agodoc/glossasry: Add "CRC" to glossary
Zac Dover [Sat, 20 Dec 2025 05:44:31 +0000 (15:44 +1000)]
doc/glossasry: Add "CRC" to glossary

Add "CRC" (Cyclic Redundacy Check) to the glossary.

Signed-off-by: Zac Dover <zac.dover@clyso.com>
2 weeks agoMerge pull request #66700 from rhcs-dashboard/update-teuth-has
David Galloway [Sat, 20 Dec 2025 23:12:49 +0000 (18:12 -0500)]
Merge pull request #66700 from rhcs-dashboard/update-teuth-has

mgr/dashboard: update teuth_ref hash in api test

2 weeks agoMerge pull request #66674 from ceph/GHSA-p433-fp4g-pc2c
Kefu Chai [Sat, 20 Dec 2025 14:18:37 +0000 (22:18 +0800)]
Merge pull request #66674 from ceph/GHSA-p433-fp4g-pc2c

.github/workflows: Fix GHSA-p433-fp4g-pc2c

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Kefu Chai <k.chai@proxmox.com>
2 weeks agoFix GHSA-p433-fp4g-pc2c
David Galloway [Wed, 17 Dec 2025 22:47:06 +0000 (17:47 -0500)]
Fix GHSA-p433-fp4g-pc2c

https://github.com/ceph/ceph/security/advisories/GHSA-p433-fp4g-pc2c

Signed-off-by: David Galloway <david.galloway@ibm.com>
2 weeks agodoc/rados: Fix minor issues, improvements in health-checks.rst (5 of x)
Ville Ojamo [Fri, 19 Dec 2025 09:23:01 +0000 (16:23 +0700)]
doc/rados: Fix minor issues, improvements in health-checks.rst (5 of x)

Remove spaces at the end of lines.

Use confval instead of simple inline literal text for config values.

Use double backticks consistently for literals.

Attempt minor language improvements.

Use "Monitor", "Manager" consistently.

Add a link to stretch mode doc in relevant sections.

Use a privileged prompt for CLI command examples requiring privileges.

Linkify mentions of other sections in the document.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 weeks agoMerge pull request #66687 from cbodley/wip-doc-rgw-admin-account-args
Casey Bodley [Fri, 19 Dec 2025 14:24:53 +0000 (09:24 -0500)]
Merge pull request #66687 from cbodley/wip-doc-rgw-admin-account-args

doc/rgw: POST /admin/account doesn't require id/name

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
3 weeks agomgr/dashboard: update teuth_ref hash in api test
Nizamudeen A [Fri, 19 Dec 2025 12:41:05 +0000 (18:11 +0530)]
mgr/dashboard: update teuth_ref hash in api test

update the hash to the latest commit where Kefu addressed the distutils
error.

Signed-off-by: Nizamudeen A <nia@redhat.com>
3 weeks agoMerge pull request #66681 from bluikko/wip-doc-rados-ops-health-checks-fixes3
bluikko [Fri, 19 Dec 2025 05:16:35 +0000 (12:16 +0700)]
Merge pull request #66681 from bluikko/wip-doc-rados-ops-health-checks-fixes3

doc/rados: Fix minor issues, improvements in health-checks.rst (3 of x)

3 weeks agoMerge pull request #66675 from bluikko/wip-doc-rados-ops-health-checks-fixes2
bluikko [Fri, 19 Dec 2025 05:15:00 +0000 (12:15 +0700)]
Merge pull request #66675 from bluikko/wip-doc-rados-ops-health-checks-fixes2

doc/rados: Fix minor issues and improvements in health-checks.rst (2 of x)

3 weeks agoMerge pull request #66662 from bluikko/wip-doc-rados-ops-health-checks-fixes
bluikko [Fri, 19 Dec 2025 05:14:34 +0000 (12:14 +0700)]
Merge pull request #66662 from bluikko/wip-doc-rados-ops-health-checks-fixes

doc/rados: Fix minor issues and improvements in health-checks.rst

3 weeks agoMerge pull request #66677 from bluikko/wip-doc-cephadm-services-osd-typo
bluikko [Fri, 19 Dec 2025 05:13:53 +0000 (12:13 +0700)]
Merge pull request #66677 from bluikko/wip-doc-cephadm-services-osd-typo

doc/cephadm: Fix formatting errors and improvements in osd.rst

3 weeks agoMerge pull request #66656 from ceph/apt-mirror-main
David Galloway [Fri, 19 Dec 2025 03:48:57 +0000 (22:48 -0500)]
Merge pull request #66656 from ceph/apt-mirror-main

install-deps: Replace apt-mirror

3 weeks agodoc/rgw: POST /admin/account doesn't require id/name
Casey Bodley [Thu, 18 Dec 2025 14:12:51 +0000 (09:12 -0500)]
doc/rgw: POST /admin/account doesn't require id/name

the RGWOp_Account_Create admin op doesn't require id or name

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 weeks agodoc/rados: Fix minor issues, improvements in health-checks.rst (3 of x)
Ville Ojamo [Thu, 18 Dec 2025 08:27:36 +0000 (15:27 +0700)]
doc/rados: Fix minor issues, improvements in health-checks.rst (3 of x)

Also changed in monitoring.rst:
- Add label for link.
- Linkify mention of health checks.

Fix "bluestore bluefs" admin-socket commands after #38437.

Use ":confval:" instead of simple inline literal text for config values.

Use a privileged prompt for CLI command examples requiring privileges.

Trim section title syntax underline.

Use admonition instead of emphasis on the whole paragraph.

Attempt to improve language in a few sentences.

Use double backticks consistently for literals.

Linkify, adding a label in the destination if necessary:
- Muting health checks
- BlueStore migration

Capitalize Ceph, BlueStore, RADOS.

Add paragraph linking to more info on the "ceph df" command.

Use DB or DB device instead of literal db.

Add unordered list formatting to what was being rendered as single paragraph.

Use ":program:" for linking to ceph-bluestore-tool.

Change few last double spaces after full stop to a single space.

Use code-block paragraphs instead of inline literals where appropriate.

Add missing word "is".

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
3 weeks agodoc/cephadm: Fix formatting errors and improvements in osd.rst
Ville Ojamo [Thu, 18 Dec 2025 07:05:29 +0000 (14:05 +0700)]
doc/cephadm: Fix formatting errors and improvements in osd.rst

Use console code-block instead of literal text to avoid highlighting.

Promptify few last CLI commands that were missing prompts.

Remove lone single-item unordered list formatting.

Add missing full stops.

Linkify mentions of other sections.

Use title case consistently in section titles.

Use :confval: consistently instead of literal text.

Use double backticks consistently.

Use "YAML" and "JSON" instead of literal .yaml and .json.

Fix two occurrences of double backticks missing one backtick that lead
to broken rendering.

Use *italic* RST syntax instead of rendered underscores.

Try to improve language in simple sentences.

Remove unnecessary * characters that were rendered in CLI example
commands.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>