Merge pull request #21910 from dillaman/wip-rbd-help

rbd: don't load config overrides from monitor initially

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #21823 from dillaman/wip-24009

rbd-mirror: ensure remote demotion is replayed locally

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #21817 from dillaman/wip-24008

rbd-mirror: fixed potential crashes during shut down

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #21853 from rishabh-d-dave/volclient-keyargs-for-all-exceptions

rados.pyx: make all exceptions accept keyword arguments

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #21886 from jcsp/wip-no-install-hello

cmake: do not install `hello` demo module

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21782 from wido/mgr-telegraf

mgr/telegraf: Telegraf module for Ceph Mgr

Reveiwed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21891 from cbodley/wip-cmake-crypto-plugins

cmake: move crypto_plugins target

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Revert "stop.sh: use --no-mon-config when trying to unmap rbd devices"

This reverts commit 6c722cd5f3f829ccf14280e7e36387bafd819c7a.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #21770 from zy751713126/remove-redundant-code

rbd: add the judgment of resizing the image

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #21914 from cbodley/wip-common-async

common: add a generic async Completion for use with boost::asio

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #21909 from neha-ojha/wip-fix-powercycle

qa/suites: set osd_pg_log_dups_tracked in cfuse_workunit_suites_fsync.yaml

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

common: add an async SharedMutex

Signed-off-by: Casey Bodley <cbodley@redhat.com>

common: forward_handler() for handlers with move-only args

executors will always call the handler's lvalue overload of operator(),
so forward_handler() is required to wrap calls to bind_handler() with
move-only argument types. Completion uses this to forward all of its
CompletionHandlers

Signed-off-by: Casey Bodley <cbodley@redhat.com>

common: add a generic async Completion interface

a generic Completion for storing asio completion handlers for deferred
execution

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #21906 from vshankar/iscsi-target-cli-typo

doc: fix iscsi target name when configuring target

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

rbd: don't load config overrides from monitor initially

The overrides will be loaded when we connect to the cluster via librados
and the current approach prevents running 'rbd help' without a running
cluster.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #20974 from XiangxiangMeng/rgw-policy-keyword-modify

rgw: policy: modify some operation permission keyword

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

doc: fix iscsi target name when configuring target

Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #21788 from cbodley/wip-22914

rgw: bucket sync status improvements, part 1

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #21851 from votdev/improve_error_panel

mgr/dashboard: Improve error panel

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

mgr/telegraf: Telegraf module for Ceph Mgr

Telegraf is a agent for collecting and reporting metrics.

It has multiple inputs and can send data to various outputs like
for example InfluxDB or ElasticSearch.

This module works by using the socket_listener of Telegraf and can
send data over UDP, TCP and a local Unix Socket.

Signed-off-by: Wido den Hollander <wido@42on.com>

rbd-mirror: ensure remote demotion is replayed locally

The bootstrap process cannot immediately quit if it notices the remote
image is not primary. Instead, it needs to continue if the local image is
still chained to the remote.

Fixes: http://tracker.ceph.com/issues/24009
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cmake: move crypto_plugins target

the crypto_plugins target was defined in
src/crypto/isa-l/CMakeLists.txt, but this is only included
if(HAVE_INTEL AND HAVE_BETTER_YASM_ELF64 AND (NOT APPLE))

moving it out of the if() block allows the os target to depend on it
even if no plugins are built

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #21609 from dragonylffly/wip-fix-create-ioctx

librados: return ENOENT if pool_id invalid

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #21882 from sebastian-philipp/dashboard-run-backend-api-request-insecure

mgr/dashboard: Allow insecure HTTPS in run-backend-api-request

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #21820 from tspmelo/wip-ui-error-handling

mgr/dashboard: Add error handling on the frontend

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #21819 from tspmelo/wip-prettier

mgr/dashboard: Add Prettier formatter to the frontend

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Add Prettier formatter to the frontend

This will force the use of prettier on frontend code,
bringing a more consistent formatting to all the code.

The current configuration will apply the prettier formatting,
on all staged files, during the precommit hook.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21643 from s0nea/wip-dashboard-configurations-table

mgr/dashboard: replace configuration html table with cd-table

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #21777 from votdev/proxy_conf_ssl

mgr/dashboard: Use HTTPS in dev proxy configuration and HACKING.rst

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Add error handling on the frontend

Now all error notifications are processed on the api-interceptor-service,
removing the need to handle them on every api request.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21066 from sebastian-philipp/dashboard_error_handling

mgr/dashboard: Improve exception handling

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge PR #21808 into master

* refs/pull/21808/head:
qa: ignore version in auth metadata comp
ceph_volume_client: allow volumes without namespace isolation

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

qa/suites: set osd_pg_log_dups_tracked in cfuse_workunit_suites_fsync.yaml

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #21890 from alfredodeza/wip-rm24036

ceph-volume describe better the options for migrating away from ceph-disk

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

doc/rados add an anchor to reference replacing osds

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/ceph-volume describe the options for migrating away from ceph-disk

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/ceph-volume high-level description of simple activate at index.rst

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge PR #21810 into master

* refs/pull/21810/head:
MDSMonitor: promote standby after fs creation
MDSMonitor: always prints standbys even if no fs

Reviewed-by: John Spray <john.spray@redhat.com>

mgr/dashboard: fix table in order to view boolean values

The table didn't handle boolean values correctly. If a table contained
booleans it resulted in a TypeError because the value can't be converted to
lower case. We need to convert the boolean value to string at first.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Fix duplicate params error

* Remove params, if they use the `{name:regex}` syntax.
* Fixes http://tracker.ceph.com/issues/23823

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Exception handling: browsable API

* Added display of Exceptions
* Fixed missing sub-path
* Added delete-form
* Fixed default arguments

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Exceptions: Added Documentation

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Applied Exception handling to RBDs

* DashboardTestCase: Removed waiter-thread

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

qa: ignore version in auth metadata comp

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

ceph_volume_client: allow volumes without namespace isolation

Fixes: https://tracker.ceph.com/issues/23695
Signed-off-by: Ramana Raja <rraja@redhat.com>

cmake: do not install `hello` demo module

Signed-off-by: John Spray <john.spray@redhat.com>

mgr/dashboard: Change to Status Code 400 by default.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Add task info to exception result

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Improved Exception handling in Tasks

* Set default status code to 400
* Added tests
* Fixed globbing in `test_task.py`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Applied Exception Handling

* Minor changes to CephFS, OSD, Pool, RbdMirroring, Summary and RGW

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Improve exception handling

* Added `dashboard_exception_handler()` to catch our exceptions.
* Changed the behaviour of `ViewCache` to raise exceptions
* Added `RadosReturnError` raised in `send_command()`
* Added unit tests

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Improve error panel

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #21803 from alfredodeza/cv-auto

ceph-volume initial take on auto sub-command

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

mgr/dashboard: run-backend-api-request insecure HTTPS

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: replace configuration html table with cd-table

The configuration documentation page still uses a normal html table.
This commit replaces the table with the cd-table to make use of its
advanced features here.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #21845 from tchaikov/wip-gcc-warnings

mds,messages: silence -Wclass-memaccess warnings

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #21856 from tchaikov/wip-drop-dpdk-submodule

dpdk: drop dpdk submodule

Reviewed-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Merge PR #21712 into master

* refs/pull/21712/head:
qa/tasks/cephfs: add test for renewing stale session
client: invalidate caps and leases when session becomes stale
client: fix race in concurrent readdir

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #21688 into master

* refs/pull/21688/head:
client: change vxattr flags field to unsigned int

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #21668 into master

* refs/pull/21668/head:
mds: include nfiles/nsubdirs of directory inode in MClientCaps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #21858 from yuriw/wip-yuriw-crontab

qa/tests: fixed typo

Merge pull request #21707 from cbodley/wip-qa-upgrade-ragweed

qa/rgw: move ragweed upgrade test into upgrade/luminous-x

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #21794 from rjfd/wip-dashboard-fix-awsauth

mgr/dashboard: awsauth: fix python3 string decode problem

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Lenz Grimmer <LGrimmer@suse.com>

dpdk: drop dpdk submodule

we are using spdk/dpdk for async msgr's dpdk backend since 01a9f178. so
no need to keep dpdk submodule anymore.

Fixes: http://tracker.ceph.com/issues/24032
Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tests: fixed typo

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #21784 from votdev/fix_rgw_backend

mgr/dashboard: Refactor RGW backend

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

rados.pyx: make all exceptions accept keyword arguments

Moving the code that makes exceptions accept keyword arguments from the
exception OSError to Error prevents a crash when exceptions not
inheriting OSError are received.

Fixes: http://tracker.ceph.com/issues/24033
Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #21839 from yuriw/wip-yuriw-crontab

qa/test: Added rados, rbd and fs to run two time a week only

mgr/dashboard: Refactor RGW backend

- Do some polishing in the docs.
- Refactor RgwClient::is_service_online() method. The system is considered as online if the response structure is valid. The response content itself is not validated in this case.
- Relocate NoCredentialsException and derive it from RequestException.

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #21673 from votdev/refactor_perf_counters

mgr/dashboard: Refactor perf counters

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21582 from jan--f/test-case-strtoll-hex

test/strtol: add test case for parsing hex numbers

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Use HTTPS in dev proxy configuration

- After SSL support has been added to Ceph Dashboard via PR #21627, the developer HTTP proxy sample config must be adapted.
- Adapt HACKING.rst to use HTTPS.

Signed-off-by: Volker Theile <vtheile@suse.com>

librados: return ENOENT if pool_id invalid

Signed-off-by: Li Wang <laurence.liwang@gmail.com>

librados: check latest osdmap for pool_get_name

Signed-off-by: Li Wang <laurence.liwang@gmail.com>

test: silence -Wformat-truncation= warnings

this change silences following warnings:

: warning: ‘%s’ directive output may be truncated writing up to 127
bytes into a region of size between 109 and 119 [-W
format-truncation=]
     snprintf(m_id_str, SysTestRunnable::ID_STR_SZ, "process_%d%s",
m_id, extra);
                                                    ^~~~~~~~~~~~~~
~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>

auth: silence -Wparentheses warning

this change silences following warning:

warning: unnecessary parentheses in declaration of ‘os’ [-Wparentheses]
   std::ostringstream(os);
                     ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

mds,messages: silence -Wclass-memaccess warnings

this change silences warnings like:

warning: ‘void* memset(void*, int, size_t)’ writing to an object of
non-trivial type ‘struct uuid_d’; use assignment instead [-Wcla
ss-memaccess]
   memset(&z.cluster_fsid, 1, sizeof(z.cluster_fsid));
                                                    ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21748 from b-ranto/wip-fix-prom-shutdown

prometheus: Fix prometheus shutdown/restart

Reveiwed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #21793 from b-ranto/wip-expose-objects

prometheus: Expose number of degraded/misplaced/unfound objects

Reveiwed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #21837 from tchaikov/wip-gcc-8

cmake,common,filestore: silence gcc-8 warnings/errors

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

qa/test: Added rados, rbd and fs to run two time a week only

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #21827 from yuriw/wip-yuriw-crontab

qa/tests: Added mimic runs, removed large suites (rados, rbd, etc) ru…

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

os/filestore: silence -Wformat-truncation= warning

Signed-off-by: Kefu Chai <kchai@redhat.com>

os/filestore: silence error from libstdc++ in gcc-8

this change silences following error

stl_tree.h:452:21: error: static assertion failed: comparison object
must be invocable with two arguments of key type
static_assert(__is_invocable<_Compare&, const _Key&, const _Key&>{},
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>

messages,mon,osd: silence gcc-8 warnings related to memset()

this silences warnings like:

warning: ‘void* memset(void*, int, size_t)’ writing to an object of
non-trivial type ‘struct uuid_d’; use assignment instead [-Wcl\
ass-memaccess]

uuid_d only contains boost::uuids::uuid, which is "nil" initialized in
uuid_d's ctor. so we don't need to bother with memset() it with 0.
the same applies to entity_inst_t.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common,filestore: silence GCC-8 warnings

should catch polymorphic exceptions by reference. this silences warnings
like:

error: catching polymorphic type ‘class std::RetryException’ by value
[-Werror=catch-value=]
     } catch (std::RetryException) {

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: specify missing settings for dpdk

* after upgrading to gcc-8, seems dpdk requires more settings to compile.
  in which, CONFIG_RTE_MAX_VFIO_GROUPS=64 is copied from config/common_base.
* librte_bus_pci.a depends on librte_pci.a, so reorder the libraries
  in DPDK_LIBRARIES.

Signed-off-by: Kefu Chai <kchai@redhat.com>

rbd-mirror: fix potential race between image sync and shut down

Fixes: http://tracker.ceph.com/issues/24008
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #21637 from ceph/wip-da-SCA-20180423

misc: mark constructors as explicit

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19041 from dragonylffly/wip-list-objects-in-a-pg

tools/rados: allow list objects in a specific pg in a pool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21765 from yunfeiguan/wip-23962

pybind/ceph_daemon: expand the order of magnitude of daemonperf statistics to ZB

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21815 from xiexingguo/wip-23921

crush, osd: handle multiple parents properly when applying pg upmaps

Reviewed-by: huangjun <hjwsm1989@gmail.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #21811 from tchaikov/wip-23627

librados: block MgrClient::start_command until mgrmap

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #21790 from dalgaaf/SCA-override-specifier

misc: mark functions with 'override' specifier

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21829 from tchaikov/wip-qa-cephfs-snap

qa: fix test on "ceph fs set cephfs allow_new_snaps"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa: fix test on "ceph fs set cephfs allow_new_snaps"

snapshot is now enabled for new fs in 81d0554e, so this test should be
updated accordingly.

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tests: Added mimic runs, removed large suites (rados, rbd, etc) runs on luminous

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #21816 from xiexingguo/wip-wrong-unregister-pg

osd/OSD: drop extra/wrong *unregister_pg*

Reviewed-by: Sage Weil <sage@redhat.com>

MDSMonitor: promote standby after fs creation

This avoids unnecessary health warnings. However, the original issue in i23885
still exists because the standbys are not available at fs creation time. If you
create a new file system after these standbys are available, then you will
observe that the promotion works to silence the warnings.

Fixes: http://tracker.ceph.com/issues/23885
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>