mgr/dashboard: remove "This week/month/year" and "Today" time stamps of Grafana in dashboard

Fixes: https://tracker.ceph.com/issues/47049
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #36723 from tchaikov/wip-osd-writesame

crimson/osd: support writesame op

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #36711 into master

* refs/pull/36711/head:
Revert "vstart_runner: rotate logs between testcases"

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Revert "vstart_runner: rotate logs between testcases"

Fixes: https://tracker.ceph.com/issues/47032
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

crimson/osd: write log when sending "osd_failure" msg

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: support writesame op

it is tested by TestIoctx.test_aio_writesame. so let's implement it as
well.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36719 from ofriedma/wip-reshard-logs

rgw: log resharding events at level 1 (formerly 20)

rgw: log resharding events at level 1 (formerly 20)
log resharding events at level 1 (formerly 20)
Signed-off-by: Or Friedmann <ofriedma@redhat.com>

Merge pull request #36381 from dang/wip-dang-zipper-7

Zipper 7 - chop list items

Merge pull request #36703 from tchaikov/wip-crimson-errorator-omap

crimson/osd: errorator omap_get_values() ops

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36702 from tchaikov/wip-doc-crimson

doc/dev/crimson: fix a typo

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36699 from ceph/47008-table-footer-size

mgr/dashboard: restore table footer size

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #36706 from Daniel-Pivonka/cephadm-rootuserdocfix

doc/cephadm: remove ssh user limitation troubleshooting

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

crimson/osd: errorator omap_get_values() ops

* os/alienstore: do not panic if retval is less than 0. instead,
  translate ENOENT to enoent and other erros to input_output_error
* os/FuturizedStore: errorator omap_get_values() variants, so
  they return errorator::future<> instead of plain seastar::future<>
* os/seastore: update accordingly.
* osd/pg_backend: use enodata for OI without omap in it. better
  performance, and better readability this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36531 from tchaikov/wip-alpine

alpine: remove stale Alpine build recipe

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #36688 from coreycb/master

librbd: Align rbd_write_zeroes declarations

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

doc/cephadm: remove ssh user limitation troubleshooting

Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>

Merge PR #35824 into master

* refs/pull/35824/head:
vstart_runner.py: rotate logs between testcases
vstart.sh: write logrotate conf and rotate logs
vstart_runner: run one test method at a time...

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

doc/dev/crimson: fix a typo

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #36533 into master

* refs/pull/36533/head:
mon: store mon updates in ceph context for future MonMap instantiation

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36530 from tchaikov/wip-cmake-python2

cmake: drop WITH_PYTHON2 option

Reviewed-By: Josh Durgin <jdurgin@redhat.com>

Merge pull request #36543 from jschmid1/prevent_path_from_non_data_devices

python-common: ban paths from non-data-devices

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36568 from jschmid1/remove_osd_spec

mgr/orchestrator: remove traces of ceph orch osd spec

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36541 from jschmid1/save_osdspec_affinity_to_store

mgr/cephadm: save osdspec_affinity to dd store

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36584 from jschmid1/get_daemons_by_type

mgr/cephadm: add by_type daemon retrieval method

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: restore table footer size

Fixes: https://tracker.ceph.com/issues/47008
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Zipper - add const accessors for svc and ctl

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #34918 from bk201/wip-45397

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36674 from tchaikov/wip-doc-crimson

doc/dev/crimson: note about script/ceph-debug-docker.sh

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

vstart_runner.py: rotate logs between testcases

Fixes: https://tracker.ceph.com/issues/46059
Signed-off-by: Rishabh Dave <ridave@redhat.com>

vstart.sh: write logrotate conf and rotate logs

Signed-off-by: Rishabh Dave <ridave@redhat.com>

vstart_runner: run one test method at a time...

instead of running entire testsuite at once; this would allow us more
control on the test runner.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #36686 from sebastian-philipp/ceaphdm-upgrade-pytest

mgr/cephadm: Add tests/test_upgrade.py

Reviewed-by: Joshua Schmid <jschmid@suse.de>

Merge pull request #36629 from yison/fix-mem-leak-nvmedevice

blk/spdk/NVMEDevice.cc: fix a memory leak issue

Reviewed-By: Kefu Chai <kchai@redhat.com>

alpine: remove stale Alpine build recipe

alpine build recipe is stale and does not work with the latest Ceph,
also the APKBUILD for Ceph can be found at alphine's aports repo, see
https://gitlab.alpinelinux.org/alpine/aports/-/tree/master/community/ceph.

so instead keeping a stale version, let's drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #36515 into master

* refs/pull/36515/head:
libcephfs: ignore restoring the open files limit
msg: throw a system error when center.init fails

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36525 into master

* refs/pull/36525/head:
client: switch to use ceph_mutex_is_locked_by_me always

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36552 into master

* refs/pull/36552/head:
mds: fix kcephfs parse dirfrag's ndist is always 0

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #36617 into master

* refs/pull/36617/head:
mds: revert the decode version

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Zipper - Make sure to use std::string everywhere

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

RGW - Turn on debug logging for tempest tests

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Fix crash in RGWHandler_REST_S3Website::error_handler

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Fix read_user_manifest_part

Was using Rados directly; use Zipper instead.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Fix retry_raced_bucket_write

Was using Rados directly; use Zipper instead.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Removing getRados() - RGWGetObjLayout

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - convert RGWBulkUploadOp::handle_dir to use create_bucket

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Remove duplicate remove_bucket() code

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Rename get_bi() to get_key()

Provides consistency, and get_bi() wasn't a useful name.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - forward_request_to_master in RGWStore

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Implement Delete op on RGWObject

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Implement Read op on RGWObject

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - implement set_attrs and delete_attrs in RGWObject

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - Implement check_quota in RGWBucket

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper - implement RGWBucket::List

Create a list op for RGWBucket, and use it.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

librbd: Align rbd_write_zeroes declarations

Fixes: https://tracker.ceph.com/issues/46928
Signed-off-by: Corey Bryant <corey.bryant@canonical.com>

Merge pull request #36605 from rhcs-dashboard/fix-46920-master

mgr/dashboard/api: reduce amount of daemon logs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36312 from ishanrai05/bug-1

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/cephadm: also mock `ceph vesions`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: add test_upgrade.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm/tests: move with_service to fixtures.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

pybind/mgr: Also mock the config store in pytest

This will be used to dry-run mgr/cephadm/upgrade.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36476 from ceph/42072-landing-page

mgr/dashboard: Landing Page improvements

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36669 from smithfarm/wip-nautilus-11

doc/releases: add Nautilus 14.2.11 to timeline

Reviewed-By: Kefu Chai <kchai@redhat.com>
Reviewed-By: Zac Dover <zac.dover@gmail.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #36508 from mgfritch/cephadm-nfs-rados-pool

mgr/cephadm: check existence of the RADOS pool

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

mgr/dashboard: clear Jest cache before testing

Jest seems to not detect removed files correctly. Let's clean the cache
before performing frontend unit tests in CI.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

mgr/dashboard: leverage features set from orchestrator

Orchestrator provides a list of supported functions. Using
this list to provide better UX and guard for unsupported
features.

- Backend: return 503 if required orchestrator features are
  missing, rather than calling non-implemented methods
  in orchestrator.
- Frontend:
  - Remove information modal when Orchestrator is not available.
  - Disable table action buttons if Orchestrator is not available
    or features are not supported.

Fixes: https://tracker.ceph.com/issues/45397
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

Merge pull request #36228 from vosdev/doc-mgr-crash-typo

doc/mgr/crash: Add missing command in rm example

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36623 from cheese/master

common: document the current semantics of bl::append(std::istream)

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36418 from changchengx/osd_map

osd/OSDMap: corret osd_info_t last_clean comment

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/dev/crimson: note about script/ceph-debug-docker.sh

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36642 from tchaikov/wip-crimson-silence-warnings

crimson: silence warnings from clang++

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: do not capture unused variables

this change silences warnings like

src/crimson/osd/pg_backend.cc:232:34: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
        [&os, &osd_op, &extents, this](auto&& bl) -> read_errorator::future<> {

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os: do not return a value for non-reachable branch

for silencing a warning like

btree/btree_lba_manager.cc:177:12: warning: binding dereferenced null pointer to reference has undefined behavior [-Wnull-dereference]
    return *static_cast<btree_range_pin_t*>(nullptr);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

ceph_abort_msg() is marked [[noreturn]], so we can just use it here
without worrying about complains from compiler.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/releases: add Nautilus 14.2.11 to timeline

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #36479 from dillaman/wip-46669

test/rbd-mirror: pool watcher registration error might result in race

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #36639 from tchaikov/wip-crimson-build-push-op

crimson/osd: clear data_included if fiemap fails

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36505 from rzarzynski/wip-crimson-bump-up-seastar

crimson: bump up seastar version to freshest master

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36529 from tchaikov/wip-crimson-dts-9

ceph.spec.in: use devtoolset-9 for building crimson

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

install-deps.sh: add tchaikov's copr repo for crimson build on el8

we need it before the updated version of gcc-toolset9 addressing
https://bugzilla.redhat.com/show_bug.cgi?id=1853900 is available in
RHEL8/CentOS8.

see https://copr.fedorainfracloud.org/coprs/tchaikov/gcc-toolset-9

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph.spec.in: use gcc-toolset-9 for building crimson

since seastar dropped support from C++14, we have to move to a compiler
with a decent C++17 support.

in this change, gcc-toolset-9 is used for compiling ceph if seastar is
enabled. use version >= 9.2.1-2.2, because of
https://bugzilla.redhat.com/show_bug.cgi?id=1853900

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: clear data_included if read fails

* extract read_object_for_push_op() out of build_push_op().
  build_push_op() is composed of multiple steps. would be better
  if we can split and extract them into separated method for better
  readability
* clear push_op->data_included() if fiemap fails. before this change,
  a local copy of `copy_subset` is cleared if fiemap fails, but
  push_op->data_included is not updated in this case. we should
  clear the latter if no data is returned in push_op->data. so,
  in this change, push_op->data_included is cleared if fiemap
  fails. the same applies to other cases where no data is returned in
  push_op
* add comments to outline the steps in read_object_for_push_op().

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: print detailed info of object being recovered

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: remove stale comment

CyanStore supports readv() now, so remove this comment.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: do not use __func__ in a lambda

otherwise we would have logging messages like

operator(): returning obc ...

Signed-off-by: Kefu Chai <kchai@redhat.com>

blk/spdk/NVMEDevice.cc: fix a memory leak issue

Signed-off-by: Yuan Lu <yuan.y.lu@intel.com>

Merge pull request #36618 from tspmelo/wip-backport-jq

script/ceph-backport.sh: Check if jq is installed

Merge pull request #36609 from tspmelo/wip-doc-browsers

mgr/dashboard: Update list of supported browsers

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36624 from lixiaoy1/fix_config

rbd/rwl: fix the config issue

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36466 from lixiaoy1/rbd_image_info_br

rbd/status: get image cache state

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36422 from orozery/object_dispatch_assert_version_write

librbd: support writing with version assertion on object dispatch

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36366 from runsisi/wip-fix-free

librbd: fix possible use after free error while shuting down exclusive lock

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36561 from lixiaoy1/fix_queue

rbd/rwl: fix the construction of ContextWQ

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mgr/dashboard: Update list of supported browsers

Fixes: https://tracker.ceph.com/issues/46923
Signed-off-by: Tiago Melo <tmelo@suse.com>

rbd/rwl: fix the config issue

Include acconfig.h to the librbd/cache/Util.h.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>

script/ceph-backport.sh: Check if jq is installed

If you tried to setup ceph-backport.sh without having 'jq' installed, you would
get a totally unrelated error message and it was hard to figure out the problem.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36604 from tspmelo/wip-favicon-circle

mgr/dashboard: Fix favicon white circle

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36602 from tspmelo/wip-spell-check

mgr/dashboard: Fix spell errors

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #36585 from votdev/proper_format_portals

mgr/dashboard: Proper format iSCSI target portals

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36566 from votdev/issue_46900_autocomplete

mgr/dashboard: Strange iSCSI discovery auth behavior

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36567 from votdev/issue_46901_hide_limit_action_field

mgr/dashboard: Hide table action input field if limit=0

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>