qa/suites/krbd: add legacy+rxbounce and crc+rxbounce coverage

For basic, rbd and rbd-nomount subsuites, replace legacy and crc
facets with "legacy or legacy+rxbounce" and "crc or crc+rxbounce"
facets (chosen at random).

For fsx, singleton and thrash subsuites, add legacy+rxbounce and
crc+rxbounce facets and drop prefer-crc facet.  The expected behaviour
of the latter depends on cluster configuration and should be tested
separately.

The total number of jobs remains the same.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa: krbd rxbounce test

Lives in its own directory since ms_mode doesn't need to be permuted
here.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: recognize rxbounce map option

Fixes: https://tracker.ceph.com/issues/54063
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #44833 from fstachura/wip-doc-more-pdf-links

doc: Fix links to CRUSH, RADOS and DSP research papers

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc: Fix links to CRUSH, RADOS and DSP research papers.

Signed-off-by: Franciszek Stachura <fbstachura@gmail.com>

Merge pull request #44707 from liumiaomiaoIntel/qatdoc

doc/radosgw: update QAT acceleration to specify the configuration

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

doc/radosgw: update QAT acceleration to specify the configuration

add and change the configuration steps to enable latest version of QAT
driver on QAT based encryption and compression

Signed-off-by: Miaomiao Liu <miaomiao.liu@intel.com>

Merge pull request #44816 from cbodley/wip-rgw-cmake-system

cmake/rgw: src/rgw and src/rgw/services are not system headers

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #44801 from sebastian-philipp/doc-cephadm-count-per-host

doc/cephadm: Co-location of daemons

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by:Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #44823 from andriytk/fix-install-deps2

install-deps.sh: fix cortx-motr installation condition

install-deps.sh: fix cortx-motr installation condition

Don't try to install cortx-motr if it is already installed
or not needed. (Currently, it installs on any run from an
interactive terminal session).

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>

Merge pull request #44711 from zdover23/wip-doc-2022-01-21-rados-bluestore-cache-autotune-interval-rewrite-2

src/rados: rewrite bs cache autotune instructions

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #44703 from phlogistonjohn/jjm-issue46773

cephadm: validate that the constructed YumDnf baseurl is usable

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44517 from adk3798/agent-cache

mgr/cephadm: store agent metadata in its own cache

Reviewed-By: Sebastian Wagner <sewagner@redhat.com>

cmake/rgw: src/rgw and src/rgw/services are not system headers

include these with -I instead of -isystem so we don't hide their
compiler warnings

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #44719 from zdover23/wip-doc-2021-01-22-man-page-radosgw-multitenancy-remove-double-quotes

doc/radosgw: replace double quotes with single

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #44379 from andriytk/add-motr-rgw-sal

rgw: add CORTX Motr SAL implementation

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>

Merge pull request #44654 from rhcs-dashboard/page-title-feature

mgr/dashboard: Page title should indicate current location

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #44793 from anthonyeleven/anthonyeleven/cephfs-mirroring

doc/cephfs: Clean up mirroring

Reviewed-by: Venky Shankar <vshankar@redhat.com>

rgw: add CORTX Motr SAL implementation

To build with Motr backend, use -DWITH_RADOSGW_MOTR=YES cmake
option. cortx-motr-devel rpm should be installed beforehand.

To connect to Motr cluster, add the following configuration
parameters to ceph.conf:

    [client]
            ...
            rgw backend store = motr
            motr profile fid  = 0x7000000000000001:0x4f
            motr ha endpoint  = inet:tcp:10.0.0.1@2001
    ...
    [client.rgw.8000]
            ...
            motr my endpoint  = inet:tcp:10.0.0.1@5001
            motr my fid       = 0x7200000000000001:0x29

The correct values for the Motr connection parameters can be
taken from `hctl status` cmd output after Motr cluster is
bootstrapped. In the example above, the values were taken from
the following output:

    Profile:
        0x7000000000000001:0x4f
    Services:
        centos8n1
        [started] hax       0x7200000000000001:0x6  inet:tcp:10.0.0.1@5001
        ...
        [unknown] m0_client 0x7200000000000001:0x29 inet:tcp:10.0.0.1@5001

Motr pkgs for the build/run can be taken from
https://github.com/Seagate/cortx-motr/releases/tag/2.0.0-rgw.

Co-authored-by: Sining Wu <sining.wu@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>

mgr/dashboard: Page title should indicate current location

Added titleService to BreadcrumbsComponent.

Fixes: https://tracker.ceph.com/issues/36587
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>

doc/cephadm: Co-location of daemons

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44693 from rhcs-dashboard/configuration-test

mgr/dashboard: navigation page e2e fix

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44748 from cyx1231st/wip-crimson-improve-log-tm

crimson/os/seastore/transaction_manager: cleanups and logs

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #44760 from mgfritch/fixup-asyncssh-mypy

mgr/cephadm: improve asyncssh type checking

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Melissa Li <melissali@redhat.com>

Merge pull request #44792 from Matan-B/wip-matanb-email-contact

mailmap: Add Matan Breizman

Reviewed-by: Neha Ojha <nojha@redhat.com>

doc/cephfs: Clean up mirroring

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>

mailmap: Add Matan Breizman

Add Matan Breizman to mailmap.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #44304 from guits/guits-fix-cv-batch-mpath

ceph-volume: improve mpath devices support

Merge pull request #44782 from liu-chunmei/crimson-fix-content-corrupt

crimson: fix qa/RadosModel content corrupt

reviewed by: Samuel Just <sjust@redhat.com>

Merge pull request #44718 from liu-chunmei/crimson-fix-split_pin_right-assert

crimson: fix split_pin_left assert_aligned

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

crimson: fix qa/RadosModel content corrupt

RadosModel test read more length than object size, if truncate
not append zero to bufferlist, RadosMode will read more data and
it will check if there is content after the object size. So append
zero after truncate size to end of extent.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

crimson: eliminate warning for unused variable

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

crimson: fix split_pin_left assert_aligned

hint passed to lba alloc_extent may not be block size aligned
in a certain case, this hint insert lba tree as key, so make
laddr in lba tree is not aligned.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

ceph-volume: fix typo in tests

This fixes 2 typo in ceph-volume tests.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

doc/ceph-volume: fix a typo

This fixes a typo in ceph-volume documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: add a test `test_mpath_device_is_device`

This test checks that Device.is_device() returns True for a mpath device.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: improve mpath devices support

ee8887f4c0ff4f91117f31b621b95c8d08019130 was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with `ceph-volume raw`

Fixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44549 from melissa-kun-li/remove-iscsi

mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44682 from sebastian-philipp/cephadm-ipv6-parse-ipv6-addr-wo-route

cephadm: _parse_ipv6_route: Fix parsing ifs w/o route

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

mgr/cephadm: improve asyncssh type checking

asyncssh 2.9.0 introduces additional type hints

Fixes: https://tracker.ceph.com/issues/54003
Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44735 from neha-ojha/wip-reduce-cephadm

qa/suites/rados: reduce the number of cephadm tests

Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #44662 from guits/cv-shared_ceph_folder

cephadm: add shared_ceph_folder opt to ceph-volume subcommand

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44695 from liewegas/fix-cephadm-pretty-timedelta

pybind/mgr/mgr_util: fix to_pretty_timedelta()

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44459 from adk3798/misc-args

mgr/cephadm: allow miscellaneous container args at service level

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44192 from liuqinfei/docfix

doc: typo fixes in ceph-volume and install

cephadm: add shared_ceph_folder opt to ceph-volume subcommand

This commit adds the `--shared_ceph_folder` option to `ceph-volume`
subcommand, just like `shell` and `bootstrap` subcommands.

Fixes: https://tracker.ceph.com/issues/53931
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44282 from orozery/qa-qemu-nbd-ide-interface

qa/tasks/qemu: switch nbd devices from virtio to ide

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #44066 from guits/guits-fix-rollback-osd

ceph-volume: zap osds in rollback_osd()

Merge pull request #44755 from ronen-fr/wip-rf-be2-clang1

osd/scrub: fix ceph::mutex usage

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #44740 from liu-chunmei/crimson-fix-remove_from_lru-assert

crimson: fix remove_from_lru assert

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>

Merge pull request #44653 from cyx1231st/wip-crimson-osd-empty-transaction

crimson/osd: ShardServices::dispatch_context_transaction to flush

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/transaction_manager: consolidate logs in levels

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/transaction_manager: abort when error

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/transaction_manager: drop the extent metrics

These metrics won't distinguish extent operations from invalidated and
successful transactions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

cephadm: fully replace agent files when writing them

otherwise, if the new file is shorter than the old one
we will end up with a malformed file retaining the end bit
of the old version

Signed-off-by: Adam King <adking@redhat.com>

mgr/cephadm: store agent metadata in its own cache

To avoid having the host cache getting too big
due to having to store this additional info

Fixes: https://tracker.ceph.com/issues/53624
Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #44761 from mgfritch/cephadm-asyncssh-2_8

mgr/cephadm: require asyncssh 2.8

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Melissa Li <melissali@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: require asyncssh 2.8

Fixes: https://tracker.ceph.com/issues/54003
Signed-off-by: Michael Fritch <mfritch@suse.com>

osd/scrub: fix clang compilation issues

Issues created by the scrub-backend refactoring PR.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44737 from adamemerson/wip-wrong-modelines

cleanup: Change incorrect modelines

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

crimson: fix remove_from_lru assert

RETIRED_PLACEHOLDER extent also put into retired set, when do
commit_retire_extent need check if it is RETIRED_PLACEHOLDER,
otherwise will cause remove_from_lru assert.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

Merge PR #44574 into master

* refs/pull/44574/head:
qa: Add syslog ignore list

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #44714 from idryomov/wip-rbd-mirror-delprop-races

rbd-mirror: fix races in snapshot-based mirroring deletion propagation

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>

mgr/dashboard: navigation page e2e fix

Looks like the newly added relative position for the sidebar is
causing cypress to verify that the sidebar is hidden from the user view.

Fixes: https://tracker.ceph.com/issues/53960
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #42993 from ronen-fr/wip-ronenf-scrub-be2

osd/scrub: extracting scrub "backend" functionality

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #44744 from ronen-fr/wip-rf-lost-update

scrub/osd: add a missing 'publish stats to osd'

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>

crimson/os/seastore: suppress verbose onode info logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #44649 from cyx1231st/wip-crimson-improve-log-cache

crimson/os/seastore: consolidate seastore_t and seastore_cache logs

Reviewed-by: Samuel Just <sjust@redhat.com>

qa/run_xfstests_qemu.sh: disable 251, 260 and 288

All three are skipped with virtio disks:

251  [not run] FITRIM not supported on /dev/vdc
260  [not run] FITRIM not supported on /dev/vdc
288  [not run] FITRIM not supported on /dev/vdc

But 260 and 288 fail with ide disks, where discard defaults to on.  The
ancient kernel in our ubuntu-12.04.qcow2 doesn't support virtio discard
anyway so let's just disable them for consistency.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

scrub/osd: add a missing 'publish stats to osd'

to publish the last scrub status report.
The change is needed following the merge of
PR #42735.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44572 from 5cs/fix-spdk-cmake

cmake/modules/BuildSPDK.cmake: link whole-archive

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

qa/run_xfstests_qemu.sh: fall back to ide disks if needed

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

osd/scrub: change missing_digest fix-list type

...allowing for efficient creation and, more important,
direct consumption by the function performing the
actual I/O.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: scrub components embedded documentation

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: add to PgScrubber a local ref to next-scrub's details

The owner is still the PG.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: removing PgScrubber's ref to the primary scrub map

as caching this reference (to an object that is owned by the
scrubber backend) creates a dangling-pointer risk.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44669 from idryomov/wip-rbd-switch-arguments-fix

rbd: add missing switch arguments for recognition by get_command_spec()

Reviewed-by: Mykola Golub <mgolub@suse.com>

osd/scrub: minor fixes split from main "scrub backend" commit

Reformatting, minor compiler warnings, etc.
Split from "osd/scrub: extract scrub backend code into separate classes"

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: extract scrub backend code into separate classes

A refactoring of the scrub backend code (all Scrub related code
that checks/manipulates objects' (meta)data).

Part of the refactoring was breaking long chunks of code into
separate functions. In order to avoid passing endless lists
of state parameters from/to these new methods, the scrub backend
state is now maintained within its own objects.

a change to note:
Instead of two scrub-map collections - one that holds all
incoming maps, and one that holds pointers to all of those incoming
plus the one we (the Primary) manage - just use one collection
for both incoming and our own.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Split from "osd/scrub: minor fixes split from main "scrub backend" commit"

Split from "osd/scrub: scrub components embedded documentation"

fix

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: fix the scrubber backend to include all PR #42735

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44736 from adamemerson/wip-no-using-namespace-std

src: Remove some 'using namespace std' lines that crept back into headers

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

neorados: Remove using namespace std::literals from header

We don't actually need it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mgr: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

test: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

{osd,crimson}: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Remove straggling `using namespace std` from headers

A few crept back in.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

cleanup: Change incorrect modelines

Change C modelines to C++ for C++ files.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #44734 from anthonyeleven/anthonyeleven/cephfs-pool-recs

doc/cephfs: Clarify CephFS pool guidance

Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #44509 from rzarzynski/wip-crimson-alienstore-drop-constant

crimson/alienstore: drop unused constant from AlienStore.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

qa/suites/rados: reduce the number of cephadm tests

Currently, every rados run of ~400 jobs is running ~150 cephadm tests,
which is unnecessary and redundant. With this change, we will run some
basic cephadm tests within the rados suite. The following seems to be
a good start.

qa/suites/rados/cephadm/osds
qa/suites/rados/cephadm/smoke
qa/suites/rados/cephadm/smoke-singlehost
qa/suites/rados/cephadm/workunits

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44646 from neha-ojha/wip-backport-q

script: backport updates for quincy

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44265 from KellenRenshaw/WIP-replay_alloc

test/allocator_replay_test: Add replay_alloc option

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>

Merge pull request #44705 from ceph/wip-yuriw-build-script

script/build-integration-branch: add quincy to the list of releases

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/cephfs: Clarify CephFS pool guidance

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #44674 from adamemerson/wip-53941

rgw: Report empty endpoints as error instead of crashing

Reviewed-By: Casey Bodley <cbodley@redhat.com>

Merge pull request #44706 from rzarzynski/wip-tests-bl-fix-rebuild

test/bufferlist: ensure rebuild_aligned_size_and_memory() always rebuilds.

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44717 from zdover23/wip-doc-2021-01-22-man-page-radosgw-admin-missing-apostrophe

doc/man: radosgw-admin.rst: missing apostrophe

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc/radosgw: replace double quotes with single

This changes the string
  "tenant$<user>"
to
  'tenant$<user>'
in order to avoid users running into confusing
shell expansion behavior.

Hat tip to IcePic.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/man: radosgw-admin.rst: missing apostrophe

This commit adds two missing apostrophes to two
different strings.

Hat tip to IcePic.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #44694 from alimaredia/wip-rgw-kmip-teuthology-test

qa: move certificates for kmip task into /etc/ceph

Reviewed-by: Al Maredia <amaredia@redhat.com>

test/rbd_mirror: drop redundant MockJournaler instances

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>