Merge PR #28300 into master

* refs/pull/28300/head:
doc: cephfs: add section on fsync error reporting to posix.rst

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28146 from smanjara/wip-39551

rgw/multisite:RGWListBucketIndexesCR for data full sync pagination

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #26915 from dvanders/dvanders_doc_heap

doc: describe metadata_heap cleanup

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #28359 from tchaikov/wip-split-ceph-dencoder

tools/ceph-dencoder: split types.h into smaller pieces

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc: describe metadata_heap cleanup

Fixes: http://tracker.ceph.com/issues/18174
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>

Merge pull request #28305 from rzarzynski/wip-bug-38827

qa/valgrind.supp: generalize the whiterule for aes-128-gcm to help rgw suite.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #25498 from cbodley/wip-27217

rgw: parse_copy_location defers url-decode

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #16659 from rzarzynski/wip-rgw-20797

rgw: TempURL should not allow PUTs with the X-Object-Manifest.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #12709 from rzarzynski/wip-rgw-18364-dbgs

rgw: improve debugs on the path of RGWRados::cls_bucket_head.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #12470 from rzarzynski/wip-rgw-18241

rgw: dump s3_code as the Code response element in RGWDeleteMultiObj_ObjStore_S3

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #28339 from tchaikov/wip-cmake-asan

cmake/modules: replace ";" with " " in compile flags

Reviewed-by: Yingxin Cheng <yingxincheng@gmail.com>

tools/ceph-dencoder: split types.h into smaller pieces

instead of putting all types in a single compilation unit, split them
into smaller groups, in hope to reduce the memory footprint of compiler
when compiling ceph_dencoder.cc.

sometimes, GCC just fails to compile this source file.

Fixes: http://tracker.ceph.com/issues/39595
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #28354 into master

* refs/pull/28354/head:
doc: Add warning that the root directory cannot be fragmented

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

doc: Add warning that the root directory cannot be fragmented

Documents: #39704

Signed-off-by: Nathan Fish <lordcirth@gmail.com>

Merge PR #28199 into master

* refs/pull/28199/head:
qa/tasks: upgrade the check for -c sudo option in vstart_runner.py

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #28108 from linuxbox2/wip-rgwfile-reqid

Wip rgwfile reqid:  absorbs rgw_file: allocate new id for continued request #25664

Merge pull request #28135 from dillaman/wip-39946

qa/workunits/rbd: remove 'fast-diff' from dynamic features test

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #28295 from dillaman/wip-39952

librbd: do not unblock IO prior to growing object map during resize

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #28296 from mcv21/doc-profile-rbd

doc: note explicitly that "profile rbd" allows blacklisting

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

cmake/modules: replace ";" with " " in compile flags

as the flags should be a string, not a list

tested using

cmake -DCMAKE_LINKER=gold -DWITH_ASAN=ON -DWITH_ASAN_LEAK=ON \
-DCMAKE_BUILD_TYPE=Debug

on ubuntu xenial

without this change, cmake will fail with following warning:

CMake Error at src/CMakeLists.txt:112 (message):
  The compiler /usr/bin/c++ has no C++17 support.

-- Configuring incomplete, errors occurred!

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28328 from tchaikov/wip-fix-ceph-helper-test

qa/standalone/ceph-helpers: resurrect all OSD before waiting for health

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28338 from Jing-Scott/dev/modify-scrub-comments

osd: update comment as sub_op_scrub_map has been removed

Reviewed-by: Kefu Chai <kchai@redhat.com>

osd: the sub_op_scrub_map has been removed
sub_op_scrub_map replaced by do_replica_scrub_map, sync the comments.

Signed-off-by: Jing Wenjun <jingwenjun@cmss.chinamobile.com>

Merge pull request #25099 from Thingee/master

doc: Adding US-Mid-West Mirror to docs

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #25530 into master

* refs/pull/25530/head:
mgr/diskprediction: Add diskprediction local plugin dependencies

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Dan Mick <dmick@redhat.com>

doc/install/mirrors: Adding US-Mid-West Mirror to docs

Signed-off-by: Mike Perez <thingee@gmail.com>

Merge pull request #27898 from alimaredia/wip-rgw-thread-yield-context-get-bucket-info

Thread optional yield context through  get_bucket_info call path

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge PR #27957 into master

* refs/pull/27957/head:
json: JSONDecoder::err inherits from std::runtime_error
rgw: RGWXMLDecoder::err inherits from std::runtime_error

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #28317 from tchaikov/wip-crimson-net-remove-redundant-move

crimson/net: remove redundant std::move()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #28289 from tchaikov/wip-kill-gcc-9-warnings

common,os: address string truncated warnings from GCC-9

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #28055 from SUSE/wip-fix-39662

mgr/PyModuleRegistry: log error if we can't find any modules to load

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

qa/standalone/ceph-helpers: resurrect all OSD before waiting for health

address the regression introduced by e62cfceb
in e62cfceb, we wanted to test the newly introduced TOO_FEW_OSDS
warning, so we increased the number of OSD to the size of pool, so if
the number of OSD is less than pool size, monitor will send a warning
message.

but we need to bring all OSDs back if we are expecting a healthy
cluster. in this change, all OSDs are resurrect before
`wait_for_health_ok`.

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/run-standalone.sh: s/Makefile/CMakeCache.txt/

as we could use a generator other than Make, for instance ninja.

Signed-off-by: Kefu Chai <kchai@redhat.com>

librbd: do not unblock IO prior to growing object map during resize

This could result in a small race condition where IO is able to write
beyond the current extent of the object map, resulting in an assertion
failure.

Fixes: http://tracker.ceph.com/issues/39952
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rgw: parse_copy_location defers url-decode

don't url-decode until after we search for the ?, or we'll truncate
object names that contain a url-encoded ?

Fixes: http://tracker.ceph.com/issues/27217
Signed-off-by: Casey Bodley <cbodley@redhat.com>

crimson/net: remove redundant std::move()

see https://en.cppreference.com/w/cpp/language/copy_elision

it also silences warning like:

src/crimson/net/ProtocolV2.cc:146:26: warning: redundant move in return
statement [-Wredundant-move]
  146 |       return std::move(bl);
      |                          ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #27806 from ashitakasam/add-osd-alarm

osd: Better error message when OSD count is less than osd_pool_default_size

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #28278 from tchaikov/wip-buffer-remove-advance-size_t

buffer.h: remove list::iterator_impl::advance(size_t)

Reviewed-by: James Page <james.page@ubuntu.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #28251 from xiexingguo/wip-balancer-new-osd-weight

mgr/balancer: fix initial weight-set value for newly created osds

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28107 from ifed01/wip-ifed-add-devices

os/bluestore: show device name in "osd metadata output"

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28277 from javacruft/32bit-compat-fixes

common: avoid use of size_t in options

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28250 from tchaikov/wip-silence-warnings

mon,test: silence warnings from GCC and test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25729 from the78mole/wip-32-bit-arm-fixes

cmake: boost fixes for ARM 32 bit

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28255 from tchaikov/wip-convenience

common: no need to include ceph_assert.h

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28270 from NTmatter/patch-2

blobhash.h: remove extra [[fallthrough]]

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Revert "qa: remove mon valgrind check in rgw verfiy suite"

This reverts commit d25d6ee0af0c85715e0ef8ce377f0b78a91f7ad7.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

qa/valgrind.supp: fix the name for aes-128-gcm whiterules.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

qa/valgrind.supp: generalize the whiterule for aes-128-gcm.

Fixes: http://tracker.ceph.com/issues/38827
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #27799 into master

* refs/pull/27799/head:
common/utime: don't pass %z to utime if there is a 'Z'
test: test json encode/decode of utime_t
mgr/ssh: parse new datetime
mgr/devicehealth: parse new datetime
mgr/crash: parse both old and new timestamp formats
mgr/telemetry: use cluster-provided timestamp unmolested
mon/MonMap: dump timestamps in UTC
qa/tasks/ceph: tolerate 'T' or ' ' as date and time separator
PendingReleaseNotes: note about change to ISO 8601 throughout
test/cli: update regexs for timestamps
log/LogClock: render timestamp in ISO 8601 format
common/ceph_time: stringify in ISO 8601 format
unittest_utime: add tests
common/utime: make parse() handle (our) ISO 8601 output
include/utime: make default string rendering ISO 8601 conformant
include/utime: remove unused s[n]printf methods
include/utime: make gmtime() output conformant ISO 8601

Reviewed-by: Kanika Murarka <kmurarka@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

common/utime: don't pass %z to utime if there is a 'Z'

This fails on centos 7 for some reason.

If it's UTC, we don't need to parse the tz portion, so avoid the issue by
leaving the %z out of the fmt string.

Signed-off-by: Sage Weil <sage@redhat.com>

test: test json encode/decode of utime_t

Signed-off-by: Casey Bodley <cbodley@redhat.com>

mgr/ssh: parse new datetime

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: parse new datetime

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/crash: parse both old and new timestamp formats

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/telemetry: use cluster-provided timestamp unmolested

The cluster stamp is now ISO 8601; just use that.

(The isoformat() puts a : in +hh:mm the timezone offset, which is slightly
different than what Ceph does; just pass Ceph's value through for
consistency.)

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MonMap: dump timestamps in UTC

Signed-off-by: Sage Weil <sage@redhat.com>

qa/tasks/ceph: tolerate 'T' or ' ' as date and time separator

Signed-off-by: Sage Weil <sage@redhat.com>

PendingReleaseNotes: note about change to ISO 8601 throughout

Signed-off-by: Sage Weil <sage@redhat.com>

test/cli: update regexs for timestamps

Signed-off-by: Sage Weil <sage@redhat.com>

log/LogClock: render timestamp in ISO 8601 format

Signed-off-by: Sage Weil <sage@redhat.com>

common/ceph_time: stringify in ISO 8601 format

Signed-off-by: Sage Weil <sage@redhat.com>

unittest_utime: add tests

Signed-off-by: Sage Weil <sage@redhat.com>

common/utime: make parse() handle (our) ISO 8601 output

- optional subsecond values
- optional timezone offset

Signed-off-by: Sage Weil <sage@redhat.com>

include/utime: make default string rendering ISO 8601 conformant

- use T separator
- include TZ offset

Signed-off-by: Sage Weil <sage@redhat.com>

include/utime: remove unused s[n]printf methods

Signed-off-by: Sage Weil <sage@redhat.com>

include/utime: make gmtime() output conformant ISO 8601

Use 'T' separated instead of ' '.

Signed-off-by: Sage Weil <sage@redhat.com>

doc: cephfs: add section on fsync error reporting to posix.rst

Fixes: http://tracker.ceph.com/issues/24641
Signed-off-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #28271 from yuriw/wip-yuriw-crontab-master

qa/tests: removed filters for client-upgrade-* suites

Merge pull request #28170 from marxin/disable-lto-in-spec-file

rpm: Disable LTO in spec when being used.

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

buffer.h: remove list::iterator_impl::advance(size_t)

quote from Radoslaw's comment

> In general we could remove it as the `buffer` library tends to
> disrespects `size_t` – `list::_len` and `ptr::_len` are both
`unsigned`.
> There are some exceptions like `size_t buffer::ptr::get_offset()`
(used
> altogether with `::advance` in `denc.h`) but they deserve rework as
> well.

and in this very case, we simply cast `size_t` to `unsigned`. so we
could silently trim a 64bits integer to 32bit on 64bits architecture.

so for better portability, we can just remove it. also, this function is
inlined, so the ABI is not changed.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Fix NFS clients squash/access_type default values (#28235)

mgr/dashboard: Fix NFS clients squash/access_type default values

Reviewed-by: Ricardo Marques <rimarques@suse.com>

blobhash.h: Remove extra fallthrough annotation

Remove the [[fallthrough]] annotation at the end of the switch statement
for Clang compatibility.

Fixes: https://tracker.ceph.com/issues/40052
Signed-off-by: Thomas Johnson <NTmatter@gmail.com>

Merge pull request #28211 from tspmelo/wip-service-root

mgr/dashboard: Change the provider of services to root

Merge pull request #28118 from tspmelo/wip-on-push

mgr/dashboard: Reduce the number of renders on the tables

mgr/dashboard: Add multi root support in CRUSH map (#28047)

mgr/dashboard: Add multi root support in CRUSH map

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #28179 from trociny/wip-39980

rbd-mirror: don't overwrite status error returned by replay

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28240 from trociny/wip-journal-overflow

journal: optimize object overflow detection

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28275 from tchaikov/wip-cmake-asan

ceph.in: do not preload libasan if it is found

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #28269 from NTmatter/patch-1

install-deps.sh: fix typo for krb5 on FreeBSD

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #27978 from votdev/add_snmp_oids_to_prometheus_alerts

monitoring: SNMP OID per every Prometheus alert rule

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>

doc: note explicitly that "profile rbd" allows blacklisting

The Luminous release notes tell users to ensure that rbd clients have
the ability to blacklist other client users; this is provided by
"profile rbd", which this change now documents explicitly in the user
management documentation.

Signed-off-by: Matthew Vernon <mv3@sanger.ac.uk>

Merge pull request #28225 from sebastian-philipp/script-run-mypy-sort-groups

script/run_mypy: Sort groups

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>

rpm: Disable LTO in spec when being used

Fixes: http://tracker.ceph.com/issues/39974
Works around: https://tracker.ceph.com/issues/40060

Signed-off-by: Martin Liška <Martin.Liska@suse.com>

Merge pull request #28002 from smithfarm/wip-39323-ext

pybind/tox: handle possible WITH_PYTHON3 values other than "3"

Reviewed-by: Stephan Müller <smueller@suse.com>

cmake: boost fixes for ARM 32 bit

see https://github.com/boostorg/context/pull/94

we should drop this change once ceph uses boost 1.70 or up

Signed-off-by: Daniel Glaser <me@the78mole.de>

mgr/dashboard: Change the provider of services to root

It looks like that even if we provide a service only in 1 module, there are
still situations where angular will create multiple instances of that service.

By setting root as its providers, this no longer happens.

Fixes: http://tracker.ceph.com/issues/39996
Signed-off-by: Tiago Melo <tmelo@suse.com>

os/filestore: always always add `\0' after strncpy()

see also f35fa1c58cf24275458cb83097c57bdfd1184cf8

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/blkdev.c: check retval of snprintf()

as snprintf()'ed string could be truncated, to properly use this
function, we need to check its return value.

to silence warning like

../src/common/blkdev.cc: In member function ‘int64_t
BlkDev::get_string_property(blkdev_prop_t, char*, size_t) const’:
../src/common/blkdev.cc:165:15: warning: ‘%s’ directive output may be
truncated writing up to 4095 bytes into a region of size between 4085
and 4089 [-Wformat-truncation=]
  165 |     "%s/block/%s/%s", sysfsdir(), dev, propstr);
      |               ^~
In file included from /usr/include/stdio.h:873,
                 from /usr/include/c++/9/cstdio:42,
                 from /usr/include/c++/9/ext/string_conversions.h:43,
                 from /usr/include/c++/9/bits/basic_string.h:6493,
                 from /usr/include/c++/9/string:55,
                 from /usr/include/c++/9/bits/locale_classes.h:40,
                 from /usr/include/c++/9/bits/ios_base.h:41,
                 from /usr/include/c++/9/ios:42,
                 from /usr/include/c++/9/ostream:38,
                 from /usr/include/c++/9/iterator:64,
                 from
/opt/ceph/include/boost/iterator/iterator_traits.hpp:10,
                 from
/opt/ceph/include/boost/range/iterator_range_core.hpp:26,
                 from
/opt/ceph/include/boost/algorithm/string/replace.hpp:16,
                 from ../src/common/blkdev.cc:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:35: note:
‘__builtin___snprintf_chk’ output 9 or more bytes (assuming 4108) into a
destination of size 4096
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL
- 1,
      |
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Use serial RGW Admin OPS API calls (#28223)

mgr/dashboard: Use serial RGW Admin OPS API calls

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #28174 from votdev/issue_39964

mgr/dashboard: Fix RGW user/bucket quota issues

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #28168 from votdev/fix_create_key_title

mgr/dashboard: Display correct dialog title

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: PG scrub configuration (#27072)

mgr/dashboard: PG scrub configuration

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

common: avoid use of size_t in options

On 32 bit architectures size_t is not a 64 bit type
which causes comparison/assignment mismatch failures
during compilation - specifically in the handling of
legacy configuration values with boost::variant
records where size_t is not supported.

Signed-off-by: James Page <james.page@ubuntu.com>

ceph.in: do not preload libasan if it is not found

before this change, `asan_lib_path` could be `None` when we check it to
see if it ends with `NOTFOUND`. this happens if WITH_SEASTAR=OFF or
WITH_ASAN=OFF, as in that case, find_package(Sanitizers) is not called,
hence `ASAN_LIBRARY` won't be set.

in this change, libasan is only preloaded if

- (WITH_SEASTAR=ON and CMAKE_BUILD_TYPE=Debug and ASAN_LIBRARY is found)
  or
- (WITH_ASAN)

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tests: removed filters for client-upgrade-* suites

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

install-deps.sh: Typo for krb5 on FreeBSD

The FreeBSD dependency install specifies devel/kbr5 instead of devel/krb5

Fixes: https://tracker.ceph.com/issues/40050
Signed-off-by: Thomas Johnson <NTmatter@gmail.com>

Merge PR #28058 into master

* refs/pull/28058/head:
mgr/zabbix: Fix raw_bytes_used key name

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26967 from qwren/qat-accel-doc

doc: QAT Acceleration for Encryption and Compression

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #28099 from tchaikov/wip-blobhash

blobhash: do not use cast for unaligned access

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #28247 from tchaikov/wip-disable-asan-if-notfound

ceph.in: disable ASAN if libasan is not found

Reviewed-by: Casey Bodley <cbodley@redhat.com>