]> git-server-git.apps.pok.os.sepia.ceph.com Git - s3-tests.git/log
s3-tests.git
14 years agoAdd close to check for file sizes atomic-read
Stephon Striplin [Thu, 25 Aug 2011 22:02:58 +0000 (15:02 -0700)]
Add close to check for file sizes

14 years agoAdd atomic read tests
Stephon Striplin [Thu, 25 Aug 2011 21:32:45 +0000 (14:32 -0700)]
Add atomic read tests

14 years agoAdd raw GET tests
Stephon Striplin [Thu, 25 Aug 2011 15:07:58 +0000 (08:07 -0700)]
Add raw GET tests

14 years agoAdd dependency on isodate.
Tommi Virtanen [Mon, 15 Aug 2011 21:46:03 +0000 (14:46 -0700)]
Add dependency on isodate.

Commit ea3f73ef904d899ed28449bdc5d2bd5d7ff489f8 made
s3tests use isodate, but did not depend on it.

14 years agoadd bucket list data vs object data comparison tests
Stephon Striplin [Thu, 11 Aug 2011 22:56:41 +0000 (15:56 -0700)]
add bucket list data vs object data comparison tests

* test_bucket_list_return_data
* test_bucket_list_object_time

14 years agoremove superfluous code in test_bucket_list_maxkeys_zero
Stephon Striplin [Thu, 11 Aug 2011 22:52:16 +0000 (15:52 -0700)]
remove superfluous code in test_bucket_list_maxkeys_zero

14 years agoremove fails_on_dho on passing tests
Stephon Striplin [Thu, 11 Aug 2011 20:42:10 +0000 (13:42 -0700)]
remove fails_on_dho on passing tests

* test_object_set_get_metadata_empty_to_unreadable_prefix
* test_object_set_get_metadata_empty_to_unreadable_suffix
* test_object_set_get_metadata_empty_to_unreadable_infix
* test_object_set_get_metadata_overwrite_to_unreadable_prefix
* test_object_set_get_metadata_overwrite_to_unreadable_suffix
* test_object_set_get_metadata_overwrite_to_unreadable_infix

14 years agoSwitch test_bucket_list_maxkeys_unreadble to use '\n' instead of '\a'.
Stephon Striplin [Thu, 11 Aug 2011 18:23:43 +0000 (11:23 -0700)]
Switch test_bucket_list_maxkeys_unreadble to use '\n' instead of '\a'.

This avoids the SAX parser error. It also gave a different error code
from Amazon.

14 years agoSwitch tests using '\a' to '\n'
Stephon Striplin [Thu, 11 Aug 2011 18:21:17 +0000 (11:21 -0700)]
Switch tests using '\a' to '\n'

As noted in ce3d448d64aeb3228305863b4b2d35dd8f2aaec6, This will avoid
SAX parser errors.

14 years agoremove contentlength zero header test
Stephon Striplin [Thu, 11 Aug 2011 18:01:56 +0000 (11:01 -0700)]
remove contentlength zero header test

This test effectively tells the server that this request will contain no
data and any data in the body should be interpreted to be part of the
next request. By luck, we close the tcp connection beforehand so we
don't see this additional data. However, the issues caused here would
not be at the rgw/dho level.

14 years agoFlag test_object_create_bad_contenttype_unreadable as failing on both RGW and DHO.
Tommi Virtanen [Thu, 11 Aug 2011 16:35:06 +0000 (09:35 -0700)]
Flag test_object_create_bad_contenttype_unreadable as failing on both RGW and DHO.

14 years agoDHO does not support bucket logging currently.
Tommi Virtanen [Thu, 11 Aug 2011 16:31:20 +0000 (09:31 -0700)]
DHO does not support bucket logging currently.

14 years agoSwitch test_object_create_unreadable to use '\n' instead of '\a'.
Tommi Virtanen [Thu, 11 Aug 2011 16:30:26 +0000 (09:30 -0700)]
Switch test_object_create_unreadable to use '\n' instead of '\a'.

This avoids a SAX/boto interaction bug that is not of much interest,
yet still seems "evil" enough that it fulfills the original intent
of the test.

Add a link to the relevant bug report.

14 years agoFlag test_bucket_list_maxkeys_unreadable as failing on dho & rgw.
Tommi Virtanen [Thu, 11 Aug 2011 16:28:48 +0000 (09:28 -0700)]
Flag test_bucket_list_maxkeys_unreadable as failing on dho & rgw.

14 years agoFlag some fails_on_dho tests as fails_on_rgw too.
Tommi Virtanen [Thu, 11 Aug 2011 15:47:25 +0000 (08:47 -0700)]
Flag some fails_on_dho tests as fails_on_rgw too.

14 years agoTest that S3 object write replaces the metadata.
Tommi Virtanen [Wed, 10 Aug 2011 22:04:19 +0000 (15:04 -0700)]
Test that S3 object write replaces the metadata.

See http://tracker.newdream.net/issues/1352

14 years agoTest S3 api for handling of Content-MD5 that does not match.
Tommi Virtanen [Wed, 10 Aug 2011 21:55:34 +0000 (14:55 -0700)]
Test S3 api for handling of Content-MD5 that does not match.

The existing test_object_create_bad_md5_invalid is not valid
base64, and hence triggers a different code path. This time,
submit valid base64, but have the result not match the expected
md5sum.

14 years agorefactor/add additional prefix/delimiter bucket list tests
Stephon Striplin [Wed, 10 Aug 2011 18:40:46 +0000 (11:40 -0700)]
refactor/add additional prefix/delimiter bucket list tests

14 years agoadd marker bucket list tests
Stephon Striplin [Wed, 10 Aug 2011 01:42:06 +0000 (18:42 -0700)]
add marker bucket list tests

14 years agoadd maxkeys bucket list tests
Stephon Striplin [Wed, 10 Aug 2011 01:35:18 +0000 (18:35 -0700)]
add maxkeys bucket list tests

14 years agoadd test for no bucket list delimiter
Stephon Striplin [Tue, 9 Aug 2011 22:02:54 +0000 (15:02 -0700)]
add test for no bucket list delimiter

14 years agoadd test for checking bucket list with no prefix
Stephon Striplin [Tue, 9 Aug 2011 00:39:02 +0000 (17:39 -0700)]
add test for checking bucket list with no prefix

14 years agoadd non-existant prefix bucket list test
Stephon Striplin [Tue, 9 Aug 2011 00:24:40 +0000 (17:24 -0700)]
add non-existant prefix bucket list test

14 years agoremove fails_on_dho/rgw on test_bucket_list_many
Stephon Striplin [Mon, 8 Aug 2011 23:39:29 +0000 (16:39 -0700)]
remove fails_on_dho/rgw on test_bucket_list_many

14 years agocreate additional parameterized bucket list tests
Stephon Striplin [Mon, 8 Aug 2011 22:14:31 +0000 (15:14 -0700)]
create additional parameterized bucket list tests

* Test on prefix and delimiter, including slash and non-slash
  delimiters.

14 years agoadd Authorization header tests
Stephon Striplin [Wed, 27 Jul 2011 03:13:44 +0000 (20:13 -0700)]
add Authorization header tests

14 years agorefactor header update logic
Stephon Striplin [Thu, 28 Jul 2011 18:34:52 +0000 (11:34 -0700)]
refactor header update logic

14 years agoDemonstrate rgw bucket listing bug.
Tommi Virtanen [Thu, 28 Jul 2011 18:00:47 +0000 (11:00 -0700)]
Demonstrate rgw bucket listing bug.

Discovered by stumbling on the "deleted_cnt" workaround
in s3tests.common.

TODO: Add tests for rest of the functionality in
http://docs.amazonwebservices.com/AmazonS3/latest/API/index.html?RESTBucketGET.html

14 years agoRandomContentFile.start_time is never used, remove.
Tommi Virtanen [Thu, 28 Jul 2011 17:20:47 +0000 (10:20 -0700)]
RandomContentFile.start_time is never used, remove.

14 years agosupport multiple boto versions for header writing
Stephon Striplin [Thu, 28 Jul 2011 03:01:21 +0000 (20:01 -0700)]
support multiple boto versions for header writing

Depending on the version of boto, different methods are necessary for
manipulating headers. We now support 2.0rc1 and 2.0 by sub-classing
boto.s3.connection.S3Connection and overloading
boto.connection.HTTPRequest.authorize, respectfully.

14 years agos3-tests: Object download response code test
Kyle Marsh [Tue, 26 Jul 2011 23:58:15 +0000 (16:58 -0700)]
s3-tests: Object download response code test

If a client specifies a range when requesting an object the server should
respond with 206 Partial Content when answering a request to get an object,
not 200 OK.  It should also respond with only those bytes requested.

This commit introduces a test, test_ranged_request_response_code, that
checks those criteria.

14 years agochange utf8 -> unreadable on header tests
Stephon Striplin [Wed, 27 Jul 2011 18:48:49 +0000 (11:48 -0700)]
change utf8 -> unreadable on header tests

14 years agoMeasure and record duration of write and read stages in roundtrip test.
Tommi Virtanen [Wed, 27 Jul 2011 18:31:00 +0000 (11:31 -0700)]
Measure and record duration of write and read stages in roundtrip test.

14 years agoadd Date header tests
Stephon Striplin [Wed, 27 Jul 2011 03:12:48 +0000 (20:12 -0700)]
add Date header tests

14 years agoadd a Content-Type header test
Stephon Striplin [Wed, 27 Jul 2011 03:07:19 +0000 (20:07 -0700)]
add a Content-Type header test

14 years agoupdate Content-Length header tests
Stephon Striplin [Wed, 27 Jul 2011 03:01:15 +0000 (20:01 -0700)]
update Content-Length header tests

* Add more tests
* Add nose.with_setup on some tests

14 years agoadd another Expect header test
Stephon Striplin [Wed, 27 Jul 2011 02:59:41 +0000 (19:59 -0700)]
add another Expect header test

14 years agoupdate MD5 header tests
Stephon Striplin [Wed, 27 Jul 2011 02:45:48 +0000 (19:45 -0700)]
update MD5 header tests

* Rename a test
* Add more tests

14 years agoadd User-Agent header tests
Stephon Striplin [Wed, 27 Jul 2011 02:39:29 +0000 (19:39 -0700)]
add User-Agent header tests

14 years agosubclass S3Connection class for headers
Stephon Striplin [Tue, 26 Jul 2011 01:37:08 +0000 (18:37 -0700)]
subclass S3Connection  class for headers

This makes it possible to overwrite all headers

14 years agoRemove dead code.
Tommi Virtanen [Tue, 26 Jul 2011 23:29:16 +0000 (16:29 -0700)]
Remove dead code.

14 years agoConvert s3tests.common back to a module.
Tommi Virtanen [Tue, 26 Jul 2011 23:26:51 +0000 (16:26 -0700)]
Convert s3tests.common back to a module.

Code in __init__.py is evil.

14 years agoRemove dead code.
Tommi Virtanen [Tue, 26 Jul 2011 23:26:09 +0000 (16:26 -0700)]
Remove dead code.

14 years agoRewrite roundtrip test based on the readwrite one.
Tommi Virtanen [Tue, 26 Jul 2011 23:22:40 +0000 (16:22 -0700)]
Rewrite roundtrip test based on the readwrite one.

They probably should share more code in the future, but it's only
200 lines of python, so I'm not all that worried.

14 years agoLet config file control random number generator seeds in detail.
Tommi Virtanen [Tue, 26 Jul 2011 22:17:35 +0000 (15:17 -0700)]
Let config file control random number generator seeds in detail.

14 years agoNo shebang lines for setup.py-managed scripts.
Tommi Virtanen [Tue, 26 Jul 2011 21:26:28 +0000 (14:26 -0700)]
No shebang lines for setup.py-managed scripts.

14 years agoMake readwrite test not use unittest setup/teardown logic.
Tommi Virtanen [Tue, 26 Jul 2011 21:13:11 +0000 (14:13 -0700)]
Make readwrite test not use unittest setup/teardown logic.

14 years agoRefactor bucket nuking in cleanup.
Tommi Virtanen [Tue, 26 Jul 2011 20:37:27 +0000 (13:37 -0700)]
Refactor bucket nuking in cleanup.

14 years agoRefactor S3 connection opening.
Tommi Virtanen [Tue, 26 Jul 2011 20:37:17 +0000 (13:37 -0700)]
Refactor S3 connection opening.

14 years agoRefactor config file reading.
Tommi Virtanen [Tue, 26 Jul 2011 20:16:34 +0000 (13:16 -0700)]
Refactor config file reading.

14 years agoRename rand_readwrite to readwrite.
Tommi Virtanen [Tue, 26 Jul 2011 16:51:06 +0000 (09:51 -0700)]
Rename rand_readwrite to readwrite.

Simpler, and all the benchmarks are pretty much as pseudorandom,
in the end; that's not a relevant characteristic. The mix of read
and write operations is.

Re-run ./bootstrap to get the s3tests-test-readwrite script
regenerated to refer to the new module name.

14 years agoSay ".yaml" not ".yml". This is not MS-DOS, and YML is a Yahoo XML dialect.
Tommi Virtanen [Tue, 26 Jul 2011 16:47:06 +0000 (09:47 -0700)]
Say ".yaml" not ".yml". This is not MS-DOS, and YML is a Yahoo XML dialect.

14 years agoDon't bother with fractional nanoseconds.
Tommi Virtanen [Tue, 26 Jul 2011 16:43:56 +0000 (09:43 -0700)]
Don't bother with fractional nanoseconds.

<1 nanosecond is well below the threshold we can measure,
everything becomes simpler with integers, and they're easier
to skim.

14 years agoUse a constant for nanoseconds-in-a-second.
Tommi Virtanen [Tue, 26 Jul 2011 16:41:48 +0000 (09:41 -0700)]
Use a constant for nanoseconds-in-a-second.

State it in terms of 1e9 (as int not float). My eyes get
blurry from that many zeros.

14 years agoRemove unused import.
Tommi Virtanen [Tue, 26 Jul 2011 16:36:48 +0000 (09:36 -0700)]
Remove unused import.

14 years agoAvoid built-in "file" as variable name.
Tommi Virtanen [Tue, 26 Jul 2011 16:35:17 +0000 (09:35 -0700)]
Avoid built-in "file" as variable name.

14 years agoRevert "adding max_amount to realistic.names generator"
Tommi Virtanen [Tue, 26 Jul 2011 16:33:47 +0000 (09:33 -0700)]
Revert "adding max_amount to realistic.names generator"

This is now unused code.

This reverts commit 52ba1d4fbf9b3547f8fd27199cf2c4f2c59dbd45.

14 years agoUse itertools.islice instead of special-casing generator slicing.
Tommi Virtanen [Tue, 26 Jul 2011 16:33:40 +0000 (09:33 -0700)]
Use itertools.islice instead of special-casing generator slicing.

14 years agoimprove comment wording in sample config
Steven Berler [Fri, 22 Jul 2011 23:56:11 +0000 (16:56 -0700)]
improve comment wording in sample config

14 years agoadded sample yaml config for readwrite tool
Steven Berler [Fri, 22 Jul 2011 23:51:23 +0000 (16:51 -0700)]
added sample yaml config for readwrite tool

14 years agomoved most readwrite tool command-line opts to config file
Steven Berler [Fri, 22 Jul 2011 23:31:54 +0000 (16:31 -0700)]
moved most readwrite tool command-line opts to config file

The only remaining command-line options are setting the random seed
and --no-cleanup.

14 years agoremove extraneous #TODO
Steven Berler [Fri, 22 Jul 2011 22:08:33 +0000 (15:08 -0700)]
remove extraneous #TODO

14 years agouse stderr for non-yml output in readwrite tool
Steven Berler [Fri, 22 Jul 2011 21:18:09 +0000 (14:18 -0700)]
use stderr for non-yml output in readwrite tool

stdout should now only contain the yml output.

14 years agofix yml format in readwrite tool
Steven Berler [Fri, 22 Jul 2011 20:38:05 +0000 (13:38 -0700)]
fix yml format in readwrite tool

Now will print the chunks out one line per chunk instead of splitting
them accross multiple lines.

14 years agoadding chunks to readwrite tool output
Steven Berler [Fri, 22 Jul 2011 20:17:25 +0000 (13:17 -0700)]
adding chunks to readwrite tool output

14 years agofix readwrite tool file sizes
Steven Berler [Fri, 22 Jul 2011 20:10:28 +0000 (13:10 -0700)]
fix readwrite tool file sizes

Makes the file sizes specified correctly in KB instead of B

14 years agoreadwrite tool improvements
Steven Berler [Fri, 22 Jul 2011 18:54:19 +0000 (11:54 -0700)]
readwrite tool improvements

Now generates a list of filenames to use duing the setup, and passes this
list to the workers rather than having the workers list the bucket contents
or generate file names themselves.

Added a "warmup" stage that first writes out all the files so that content
exists for each filename.

Added setting the random seed as a command line parameter and uses this seed
for both generating the file names and the file content generator.

14 years agoadding max_amount to realistic.names generator
Steven Berler [Fri, 22 Jul 2011 17:55:58 +0000 (10:55 -0700)]
adding max_amount to realistic.names generator

Set max_amount to limit the number of names yeilded by the generator.

14 years agoadd Content-Type object tests
Stephon Striplin [Mon, 25 Jul 2011 21:12:50 +0000 (14:12 -0700)]
add Content-Type object tests

14 years agoadd header-manipulation tests
Stephon Striplin [Fri, 22 Jul 2011 23:57:26 +0000 (16:57 -0700)]
add header-manipulation tests

These tests are based on explicitly modifying headers in some way.

14 years agoadd test_object_create_unreadable
Stephon Striplin [Mon, 25 Jul 2011 17:57:34 +0000 (10:57 -0700)]
add test_object_create_unreadable

15 years agotest consistency of bucket acls, exercises cache
Yehuda Sadeh [Thu, 21 Jul 2011 21:09:21 +0000 (14:09 -0700)]
test consistency of bucket acls, exercises cache

15 years agoadd test_bucket_acl_no_grants
Stephon Striplin [Wed, 20 Jul 2011 19:30:23 +0000 (12:30 -0700)]
add test_bucket_acl_no_grants

When the owner has no grants on their bucket, they should not be able to
write to it, but still read and write the ACL. Amazon allows users to
read the bucket, and our behavior is consistent with this.

15 years agoHandle and report errors in readwrite test workers.
Tommi Virtanen [Wed, 20 Jul 2011 18:32:52 +0000 (11:32 -0700)]
Handle and report errors in readwrite test workers.

15 years agoSay "worker_id" instead of name, as I keep confusing it with filenames.
Tommi Virtanen [Wed, 20 Jul 2011 18:15:06 +0000 (11:15 -0700)]
Say "worker_id" instead of name, as I keep confusing it with filenames.

15 years agoLink worker greenlets to parent, so we abort if they have an unhandled exception.
Tommi Virtanen [Wed, 20 Jul 2011 18:04:32 +0000 (11:04 -0700)]
Link worker greenlets to parent, so we abort if they have an unhandled exception.

15 years agoCode layout cleanup.
Tommi Virtanen [Wed, 20 Jul 2011 17:54:17 +0000 (10:54 -0700)]
Code layout cleanup.

15 years agoMake readwrite test put objects one by one, so it can report keys.
Tommi Virtanen [Wed, 20 Jul 2011 17:40:20 +0000 (10:40 -0700)]
Make readwrite test put objects one by one, so it can report keys.

15 years agoRemove the concept of batches from readwrite test.
Tommi Virtanen [Wed, 20 Jul 2011 17:36:56 +0000 (10:36 -0700)]
Remove the concept of batches from readwrite test.

That's an internal implementation detail caused by
the generate_objects api.

15 years agoDon't eat exceptions, that's a bad habit.
Tommi Virtanen [Wed, 20 Jul 2011 17:30:51 +0000 (10:30 -0700)]
Don't eat exceptions, that's a bad habit.

15 years agoLog readwrite test results in yaml.
Tommi Virtanen [Wed, 20 Jul 2011 17:30:16 +0000 (10:30 -0700)]
Log readwrite test results in yaml.

This temporarily removes the statistics calculation; that
belongs somewhere else anyway, so it can be run on aggregated
results etc.

15 years agoUse more idiomatic Python.
Tommi Virtanen [Wed, 20 Jul 2011 16:53:59 +0000 (09:53 -0700)]
Use more idiomatic Python.

15 years agoMake queue and name arguments not optional; they're always passed in anyway.
Tommi Virtanen [Wed, 20 Jul 2011 16:53:26 +0000 (09:53 -0700)]
Make queue and name arguments not optional; they're always passed in anyway.

15 years agoMove end test logic out of individual workers.
Tommi Virtanen [Wed, 20 Jul 2011 16:50:10 +0000 (09:50 -0700)]
Move end test logic out of individual workers.

Parent waits for the duration anyway, just make it unconditionally
kill the workers. They already had timeouts aborting them; they may
be in the middle of an operation, but we really don't care, time's up.

This also avoids oddities with the queue where there may be items
after the StopIteration.

This also avoids workers potentially not exiting within the 1-second
timeout the old code had.

15 years agoUse gevent Groups to manage groups of workers.
Tommi Virtanen [Wed, 20 Jul 2011 16:42:39 +0000 (09:42 -0700)]
Use gevent Groups to manage groups of workers.

This mostly adds convenience functions, but it's nice to have.

15 years agorefactor and fix some acl_grant tests
Stephon Striplin [Tue, 19 Jul 2011 17:38:55 +0000 (10:38 -0700)]
refactor and fix some acl_grant tests

15 years agopep8 cleanup.
Tommi Virtanen [Tue, 19 Jul 2011 16:09:51 +0000 (09:09 -0700)]
pep8 cleanup.

15 years agoPyflakes cleanup.
Tommi Virtanen [Tue, 19 Jul 2011 16:05:05 +0000 (09:05 -0700)]
Pyflakes cleanup.

15 years agoRemove dead code.
Tommi Virtanen [Tue, 19 Jul 2011 16:04:20 +0000 (09:04 -0700)]
Remove dead code.

15 years agoMerge branch 'roundtrip'
Tommi Virtanen [Tue, 19 Jul 2011 16:00:44 +0000 (09:00 -0700)]
Merge branch 'roundtrip'

15 years agoRevert "Add assert to RandomContentFile, ensure size >= digest_size"
Tommi Virtanen [Tue, 19 Jul 2011 15:56:17 +0000 (08:56 -0700)]
Revert "Add assert to RandomContentFile, ensure size >= digest_size"

This reverts commit fb8f110e690e68d6c37a76b5bc9e261ae3d7c50b.

realistic.files was meant to work just fine with short files. Commit
91c4f88860efa5f7d11d9cd6436ab30d78a83ab1 has a fix for the verifying
side, to support short files.

Conflicts:

s3tests/realistic.py

15 years agoSwap stdout/stderr -- debug messages then go to stderr, and yaml data to stdout
Wesley Spikes [Tue, 19 Jul 2011 00:04:36 +0000 (17:04 -0700)]
Swap stdout/stderr -- debug messages then go to stderr, and yaml data to stdout

15 years agoNow that we no longer have the need to retry, get rid of that logic.
Wesley Spikes [Mon, 18 Jul 2011 23:09:13 +0000 (16:09 -0700)]
Now that we no longer have the need to retry, get rid of that logic.

Also fix a typo -- s/neads_first_read/needs_first_read/

15 years agoResolve the random AssertionError
Wesley Spikes [Mon, 18 Jul 2011 22:34:06 +0000 (15:34 -0700)]
Resolve the random AssertionError

By doing a copy-new on the key, it seems to work around the random
AssertionError's I've been seeing. Here's hoping this fully
resolves it.

15 years agoAdding unlimited=bool to files_varied -- if set to true, it will never issue StopIter...
Wesley Spikes [Mon, 18 Jul 2011 22:26:03 +0000 (15:26 -0700)]
Adding unlimited=bool to files_varied -- if set to true, it will never issue StopIteration

15 years agoCleanup output just a little bit more.
Wesley Spikes [Mon, 18 Jul 2011 20:13:08 +0000 (13:13 -0700)]
Cleanup output just a little bit more.

15 years agoRefactor/cleanup TransferResults class. Also cleans the output to be in the format...
Wesley Spikes [Fri, 15 Jul 2011 21:19:58 +0000 (14:19 -0700)]
Refactor/cleanup TransferResults class. Also cleans the output to be in the format TV seems to want.

15 years agoUpdate roundtrip._main -- while loop should auto-replenish all pools,
Wesley Spikes [Fri, 15 Jul 2011 20:20:50 +0000 (13:20 -0700)]
Update roundtrip._main -- while loop should auto-replenish all pools,
and not ones so named.

15 years agoAdd assert to RandomContentFile, ensure size >= digest_size
Wesley Spikes [Fri, 15 Jul 2011 20:19:01 +0000 (13:19 -0700)]
Add assert to RandomContentFile, ensure size >= digest_size

It clearly will not work to have the size smaller than the digest
size, so we shouldn't allow it.

15 years agoRename _call_doit to _real_run -- it's a bit more clear that way, IMHO
Wesley Spikes [Fri, 15 Jul 2011 20:18:21 +0000 (13:18 -0700)]
Rename _call_doit to _real_run -- it's a bit more clear that way, IMHO