]>
git.apps.os.sepia.ceph.com Git - ceph-build.git/log
Alfredo Deza [Fri, 17 Jul 2015 21:22:47 +0000 (17:22 -0400)]
slave files should be at the top
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 17 Jul 2015 21:22:20 +0000 (17:22 -0400)]
move the ansible-jenkins to the roles dir
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 17 Jul 2015 21:21:55 +0000 (17:21 -0400)]
move the playbook files to the top dir
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 17 Jul 2015 20:03:36 +0000 (16:03 -0400)]
add the jenkins-build public key
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 17 Jul 2015 20:02:05 +0000 (16:02 -0400)]
document the init yml file
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 17 Jul 2015 20:01:42 +0000 (16:01 -0400)]
use lineinfile to get jenkins-build permissions
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 9 Jul 2015 13:17:57 +0000 (09:17 -0400)]
move the init module to the top level
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 9 Jul 2015 13:07:54 +0000 (09:07 -0400)]
normalize in lower case for triggering handlers
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 9 Jul 2015 13:07:41 +0000 (09:07 -0400)]
include nginx module when setting up jenkins
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 9 Jul 2015 13:07:14 +0000 (09:07 -0400)]
enabling nginx means started, not restarted
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 9 Jul 2015 13:06:45 +0000 (09:06 -0400)]
create the jenkins-build user
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 9 Jul 2015 13:06:09 +0000 (09:06 -0400)]
add github oauth plugin
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 19:16:45 +0000 (15:16 -0400)]
install jdk and git in slaves
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 14:17:53 +0000 (10:17 -0400)]
remove cli.yml - ported to config.yml
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 14:17:19 +0000 (10:17 -0400)]
move cli.yml into config.yml
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 13:25:51 +0000 (09:25 -0400)]
add a task for nginx
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 13:25:23 +0000 (09:25 -0400)]
add the handlers to bounce nginx
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 13:23:39 +0000 (09:23 -0400)]
templates for nginx
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 12:42:38 +0000 (08:42 -0400)]
fix xml errors in jenkins job builder xml
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 7 Jul 2015 12:33:12 +0000 (08:33 -0400)]
use a non standard port for master.yml
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Mon, 6 Jul 2015 20:29:44 +0000 (16:29 -0400)]
create an init.yml for initial setup of a public master
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 1 Jul 2015 16:27:02 +0000 (12:27 -0400)]
define the default location for jobs
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 1 Jul 2015 16:26:34 +0000 (12:26 -0400)]
add ansible_managed to the jjb config file
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 1 Jul 2015 15:41:44 +0000 (11:41 -0400)]
add the one job we need for the master: jenkins-job-builder
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Travis Rhoden [Tue, 14 Jul 2015 17:59:24 +0000 (10:59 -0700)]
Merge pull request #100 from ceph/basedir
fix some issues with `$WORKSPACE` being overwritten
Alfredo Deza [Tue, 14 Jul 2015 17:53:59 +0000 (13:53 -0400)]
use basedir to avoid overwriting the WORKSPACE
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 14 Jul 2015 17:51:21 +0000 (13:51 -0400)]
remove the need for REPO_CACHE and cloning in a script
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Ken Dreyer [Mon, 13 Jul 2015 14:24:14 +0000 (08:24 -0600)]
Merge pull request #99 from ceph/extra-repos
try to get multiple repos for ceph-deploy-pull-requests
Alfredo Deza [Sat, 11 Jul 2015 21:30:45 +0000 (17:30 -0400)]
Merge pull request #97 from ktdreyer/ceph-deploy-whitelist-updates
update user whitelist for ceph-deploy PRs
Alfredo Deza [Sat, 11 Jul 2015 13:05:23 +0000 (09:05 -0400)]
try to get multiple repos for ceph-deploy-pull-requests
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Sage Weil [Thu, 9 Jul 2015 19:47:30 +0000 (15:47 -0400)]
teach how to generate a jessie version string
Signed-off-by: Sage Weil <sage@redhat.com>
Alfredo Deza [Wed, 8 Jul 2015 19:00:50 +0000 (15:00 -0400)]
Merge pull request #98 from ktdreyer/rm-green-balls-plugin
ansible: rm green balls plugin
Ken Dreyer [Wed, 8 Jul 2015 18:29:51 +0000 (12:29 -0600)]
ansible: rm green balls plugin
This plugin is not color-blind friendly. It is possible to turn it off
on a per-user setting, but that requires logging into Jenkins. Let's
just turn it off entirely so we're fully accessible for people who
aren't logged in.
Ken Dreyer [Tue, 7 Jul 2015 16:36:51 +0000 (10:36 -0600)]
update user whitelist for ceph-deploy PRs
These users have contributed patches to ceph-deploy. Whitelist their PRs
going forward so we don't have to manually approve testing each one.
mbroz: Milan Broz <mbroz@redhat.com>
ddiss: David Disseldorp <ddiss@suse.de>
osynge: Owen Synge <osynge@suse.com>
Andrew Schoen [Tue, 7 Jul 2015 16:38:45 +0000 (11:38 -0500)]
Merge pull request #96 from ktdreyer/add-ivotron-teuthology-prs
whitelist Ivo for teuthology PRs
Ken Dreyer [Tue, 7 Jul 2015 16:33:05 +0000 (10:33 -0600)]
whitelist Ivo for teuthology PRs
Ivo Jimenez <ivo.jimenez@gmail.com> is a Red Hat intern working on
teuthology. Whitelist his account so we don't have to manually approve
testing his PRs.
Alfredo Deza [Mon, 6 Jul 2015 18:10:19 +0000 (14:10 -0400)]
Merge pull request #95 from ktdreyer/rm-toplevel-jenkins-dir
rm top-level "jenkins" directory
Ken Dreyer [Mon, 6 Jul 2015 16:52:49 +0000 (10:52 -0600)]
rm top-level "jenkins" directory
Prior to the introduction of Jenkins Job Builder for configuring our
jobs, we stored each of Ceph's build instructions in a "jenkins"
directory. This was a first crude step towards versioning our build
instructions.
These "jenkins/*" scripts are no longer necessary because the JJB job
definitions contain the same steps (and these scripts are no longer
used). Clean them up.
Andrew Schoen [Tue, 30 Jun 2015 21:16:18 +0000 (16:16 -0500)]
Merge pull request #93 from ceph/master-ansible
initial work for a master jenkins role for centos
Alfredo Deza [Tue, 30 Jun 2015 21:01:45 +0000 (17:01 -0400)]
formatting for cli.yml
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 20:40:56 +0000 (16:40 -0400)]
include ansible_managed on files
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 20:36:05 +0000 (16:36 -0400)]
format nicely the args in cli.yml
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 15:10:38 +0000 (11:10 -0400)]
after installing the dependencies start nginx
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 15:10:13 +0000 (11:10 -0400)]
add a handler to restart nginx
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 15:00:58 +0000 (11:00 -0400)]
epel is required for installing nginx
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 14:00:14 +0000 (10:00 -0400)]
we require nginx to proxy jenkins
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 30 Jun 2015 13:59:59 +0000 (09:59 -0400)]
add the master playbook
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Zack Cerza [Mon, 29 Jun 2015 22:27:53 +0000 (16:27 -0600)]
Merge pull request #94 from ceph/wip-teuthology-pr-setup
teuthology-pull-requests: pass the 'install' command to ./bootstrap
Andrew Schoen [Mon, 29 Jun 2015 22:24:49 +0000 (17:24 -0500)]
teuthology-pull-requests: pass the 'install' command to ./bootstrap
This is a flag used to tell the bootstrap script to install any missing
packages it finds needed for the bootstrap process.
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Alfredo Deza [Mon, 29 Jun 2015 20:49:25 +0000 (16:49 -0400)]
initial work for a master jenkins role
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Mon, 29 Jun 2015 19:18:00 +0000 (15:18 -0400)]
Merge pull request #92 from ceph/wip-teuthology-pr-setup
teuthology-pull-requests: wipe workspace on each run
Andrew Schoen [Mon, 29 Jun 2015 19:15:03 +0000 (14:15 -0500)]
teuthology-pull-requests: wipe workspace on each run
If we don't do this pip breaks. See:
http://jenkins.ceph.com/job/teuthology-pull-requests/1560/console
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Alfredo Deza [Mon, 29 Jun 2015 18:08:06 +0000 (14:08 -0400)]
Merge pull request #91 from ceph/wip-teuthology-pr-setup
teuthology-pull-requests: run the teuthology bootstrap on setup
Andrew Schoen [Mon, 29 Jun 2015 18:04:35 +0000 (13:04 -0500)]
teuthology-pull-requests: run the teuthology bootstrap on setup
This will setup the jenkins slaves properly to successfully run the tox
tests on pull requests.
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Alfredo Deza [Thu, 25 Jun 2015 21:36:57 +0000 (17:36 -0400)]
Merge pull request #90 from ktdreyer/ceph-setup-wipe-workspace
ceph-setup: wipe workspace
Ken Dreyer [Thu, 25 Jun 2015 20:32:47 +0000 (14:32 -0600)]
ceph-setup: wipe workspace
The ceph-setup task occasionally gets weird errors that can only be
fixed by wiping the workspace.
The latest example:
tardir=ceph-0.94.1.3 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c >ceph-0.94.1.3.tar.gz
tar: ceph-0.94.1.3/src/gmock/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: file name is too long (max 99); not dumped
tar: ceph-0.94.1.3/src/test/ubuntu-12.04/debian: File removed before we read it
tar: ceph-0.94.1.3/src/test/ubuntu-14.04/debian: File removed before we read it
tar: ceph-0.94.1.3/src/test/debian-jessie/debian: File removed before we read it
tar: Exiting with failure status due to previous errors
... btw, <3 the comment in this job's description, "The clear workspace
before checkout box for the git plugin is used."
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Alfredo Deza [Thu, 25 Jun 2015 15:31:59 +0000 (11:31 -0400)]
Merge pull request #89 from ktdreyer/prs-rm-cron
pull requests: rm "cron" settings
Ken Dreyer [Thu, 25 Jun 2015 14:40:30 +0000 (08:40 -0600)]
pull requests: rm "cron" settings
From the Jenkins GitHub Pull Requests plugin docs on "useGitHubHooks":
Checking this option will disable regular polling (cron) for changes
in GitHub and will try to create a GitHub hook. Creating a GitHub hook
requires that the user which is specified in the GitHub Pull Request
Builder configuration has admin rights to the specified repository.
Based on the documentation above, since our PR jobs have "github-hooks:
true", the "cron" values have no effect and can be removed.
Ken Dreyer [Wed, 24 Jun 2015 21:16:54 +0000 (15:16 -0600)]
Merge pull request #88 from ceph/slaves
push a work-in-progress for setting up slaves with ansible
Alfredo Deza [Wed, 24 Jun 2015 20:41:34 +0000 (16:41 -0400)]
push a work-in-progress for setting up slaves with ansible
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 17:52:15 +0000 (13:52 -0400)]
use new item syntax
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 17:43:27 +0000 (13:43 -0400)]
is update_cache not update-cache
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 17:30:20 +0000 (13:30 -0400)]
ignore if file exist when installing with pip from cache
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 17:21:59 +0000 (13:21 -0400)]
Merge pull request #87 from ceph/requirement-support
Requirement support
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 16:20:53 +0000 (12:20 -0400)]
configure the job so it uses the new setup for builds
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 16:20:35 +0000 (12:20 -0400)]
rename build to setup script
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 24 Jun 2015 16:18:46 +0000 (12:18 -0400)]
initial take on supporting declarative requirements per job
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 23 Jun 2015 14:33:29 +0000 (10:33 -0400)]
Merge pull request #86 from ceph/wip-trigger-phrase
teuthology-pull-requests: remove empty trigger-phrase
Andrew Schoen [Tue, 23 Jun 2015 14:10:56 +0000 (09:10 -0500)]
teuthology-pull-requests: remove empty trigger-phrase
This should be defaulted by the plugin and is unneeded here.
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Alfredo Deza [Tue, 23 Jun 2015 12:56:32 +0000 (08:56 -0400)]
Merge pull request #85 from ceph/wip-teuthology-pr-testing
Ports the teuthology-pull-requests job to JJB
Andrew Schoen [Mon, 22 Jun 2015 20:27:56 +0000 (15:27 -0500)]
Ports the teuthology-pull-requests job to JJB
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Ken Dreyer [Tue, 9 Jun 2015 18:59:32 +0000 (12:59 -0600)]
Merge pull request #84 from ceph/cdep-deps
Install ceph-deploy dependencies.
Alfredo Deza [Tue, 2 Jun 2015 17:23:25 +0000 (13:23 -0400)]
use the new setup script in the config
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 2 Jun 2015 17:22:31 +0000 (13:22 -0400)]
create a setup script to install rpm deps
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 9 Jun 2015 16:16:12 +0000 (12:16 -0400)]
Merge pull request #80 from ktdreyer/ceph-build-better-suse-detection
ceph-build: better SUSE detection
Ken Dreyer [Mon, 8 Jun 2015 20:21:40 +0000 (14:21 -0600)]
Merge pull request #82 from ceph/rm-386
remove wheezy i386 builds
Alfredo Deza [Mon, 8 Jun 2015 19:40:16 +0000 (15:40 -0400)]
remove wheezy i386 builds
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Ken Dreyer [Mon, 8 Jun 2015 17:19:59 +0000 (11:19 -0600)]
Merge pull request #81 from ceph/cd-dir
cd to $WORKSPACE
Alfredo Deza [Mon, 8 Jun 2015 14:11:44 +0000 (10:11 -0400)]
cd to $WORKSPACE
Otherwise we will fail to be in the right directory to copy the
artifacts
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Ken Dreyer [Fri, 5 Jun 2015 23:31:43 +0000 (17:31 -0600)]
ceph-build: better SUSE detection
As was done in
18890d5a0351ffe4fc495e0d47e3a86e0a9cb7ad for
radosgw-agent, update ceph-build's SUSE detection so we check for the
"zypper" file directly on-disk.
Ken Dreyer [Fri, 5 Jun 2015 23:25:34 +0000 (17:25 -0600)]
jjb: poll GitHub more slowly
I've enabled the "Jenkins (Git plugin)" service / hook. GitHub should
now send a signal to http://jenkins.ceph.com/git/notifyCommit that new
commits have been pushed to the repo.
Accordin to the documentation this allows us to poll more slowly (or not
at all, eventually?)
Ken Dreyer [Fri, 5 Jun 2015 23:21:50 +0000 (17:21 -0600)]
radosgw-agent: better SUSE detection
We might have mis-understood the use of "hash". "hash zypper" can return
nothing if zypper has never been run. Tested on
itbuilder-cdep-rpm-sles11sp2-amd64-basic.
Just test the presence of /usr/bin/zypper.
Ken Dreyer [Fri, 5 Jun 2015 23:09:46 +0000 (17:09 -0600)]
radosgw-agent: update RPM conditional for RHEL or SUSE
We want to check *either* RHEL *or* SUSE.
Prior to this change, neither system was succeeding builds.
Ken Dreyer [Fri, 5 Jun 2015 23:05:36 +0000 (17:05 -0600)]
radosgw-agent: fix rhel conditional
Commit
b0d187aaf22eb01804a27ddf6688a1fca1f9f96a changed the OS-type
derivation logic from "based on hostname" to a heuristic based on the
files on the system itself.
The conditional for detecting RHEL was inverted. If we *do* have a
/etc/redhat-release file, we want to build RPMs. Update the conditional
to reflect this.
Ken Dreyer [Fri, 5 Jun 2015 23:04:48 +0000 (17:04 -0600)]
radosgw-agent: remove "date" command
No need to print the date out; this is recorded elsewhere in Jenkins.
Ken Dreyer [Fri, 5 Jun 2015 23:03:54 +0000 (17:03 -0600)]
skip-tag in all git scm jobs
It would be nice if this mis-feature was off by default :(
Ken Dreyer [Fri, 5 Jun 2015 22:48:04 +0000 (16:48 -0600)]
radosgw-agent: remove dependency on host naming scheme
Don't use the hostname to determine the type of OS or build (Deb/RPM) to
do.
Instead, determine the OS type using the same code that we're using in
ceph-build.
Ken Dreyer [Fri, 5 Jun 2015 22:36:46 +0000 (16:36 -0600)]
radosgw-agent: rm squeeze from matrix
In commit
57823f809a2fd1bfb7052cf5f7f82577580b5165 we removed squeeze
from the build matrix for simplicity. Do the same for radosgw-agent.
Ken Dreyer [Fri, 5 Jun 2015 22:25:54 +0000 (16:25 -0600)]
Merge pull request #79 from ktdreyer/rm-precise-dreamcompute
switch "precise" jobs to build on trusty
Ken Dreyer [Fri, 5 Jun 2015 22:18:54 +0000 (16:18 -0600)]
switch "precise" jobs to build on trusty
The DreamCompute builders (including the Precise builder) are no longer
available to us.
Switch the jobs that used the DreamCompute Precise builder to use the
trusty label instead.
Alfredo Deza [Fri, 5 Jun 2015 20:40:47 +0000 (16:40 -0400)]
Merge pull request #76 from ktdreyer/ceph-setup-rm-exit-code-checking
ceph-setup: rm exit code checking
Ken Dreyer [Fri, 5 Jun 2015 19:07:53 +0000 (13:07 -0600)]
ceph-setup: rm exit code checking
Now that we "set -e" in ceph-setup, we can drop the bits that check exit
codes "$?" throughout the ceph-setup task.
Ken Dreyer [Fri, 5 Jun 2015 20:37:50 +0000 (14:37 -0600)]
Merge pull request #78 from ceph/ceph-setup-fix
port release_tarballs.sh to ceph-setup/build/build
Ken Dreyer [Fri, 5 Jun 2015 20:37:27 +0000 (14:37 -0600)]
Merge pull request #77 from ceph/is-suse-fix
use -eq to really tell if this is suse
Alfredo Deza [Fri, 5 Jun 2015 20:36:29 +0000 (16:36 -0400)]
port release_tarballs.sh to ceph-setup/build/build
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 5 Jun 2015 20:24:15 +0000 (16:24 -0400)]
use -eq to really tell if this is suse
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Fri, 5 Jun 2015 18:54:15 +0000 (14:54 -0400)]
Merge pull request #75 from ktdreyer/ceph-setup-shebang
ceph-setup: use bash, not sh
Ken Dreyer [Fri, 5 Jun 2015 18:51:29 +0000 (12:51 -0600)]
ceph-setup: use bash, not sh
/bin/sh is dash on Ubuntu/Debian. Switch to bash for uniformity with RPM
systems.
Alfredo Deza [Fri, 5 Jun 2015 18:51:22 +0000 (14:51 -0400)]
Merge pull request #74 from ceph/wip-fix-ceph-setup-script
Three fixes to ceph-setup/build/build:
Dan Mick [Fri, 29 May 2015 05:51:16 +0000 (22:51 -0700)]
Three fixes to ceph-setup/build/build:
1) invoke sh with -ex for verbosity and exit-on-error
2) fix syntax error with [] (missing space before ])
3) restore commented-out mv before dpkg-source -b.
I'm not sure why the copy copies to release/$vers and then
later moves to ceph-$vers, but something has to put it in
ceph-$vers.
Signed-off-by: Dan Mick <dan.mick@redhat.com>