]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/log
ceph-ansible.git
7 months agocephadm-adopt: fix ssl condition in rgw placement task mergify/bp/stable-7.0/pr-7637 7642/head
Teoman ONAY [Fri, 24 Jan 2025 12:56:41 +0000 (13:56 +0100)]
cephadm-adopt: fix ssl condition in rgw placement task

rgw daemons fail to start as they were looking for
ssl certificates while none were available.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit bf76bded4c3760a6610284cc477f642c8635f06d)

8 months agodoc: CI readthedocs job fails
Teoman ONAY [Fri, 24 Jan 2025 13:05:51 +0000 (14:05 +0100)]
doc: CI readthedocs job fails

Deprecation of projects using Sphinx without an explicit configuration file

[1] https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/

Signed-off-by: Teoman ONAY <tonay@ibm.com>
11 months agopytest: python-version typo
Teoman ONAY [Wed, 16 Oct 2024 13:07:46 +0000 (15:07 +0200)]
pytest: python-version typo

Fixes python-version

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit c9ffb2e70cc0cffe82344865c3aca4011c7ade77)

11 months agoephadm-adopt: Alertmanager placement count missing
Teoman ONAY [Wed, 2 Oct 2024 14:43:39 +0000 (16:43 +0200)]
ephadm-adopt: Alertmanager placement count missing

Regression from #7576. Alertmanager placement count was missing
after migration to ceph_orch_apply module

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 31be49506118ece75371d0c86af794caee8bc051)

11 months agocephadm-adopt: custom prometheus port lost after adoption
Teoman ONAY [Wed, 2 Oct 2024 14:36:31 +0000 (16:36 +0200)]
cephadm-adopt: custom prometheus port lost after adoption

If a custom Prometheus port was used before adoption, it was not
taken into account and default 9095 was set instead. Now custom
port is re-applied.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2242346
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit b41b7bf869982a82d9ddddcef714a672c530b6f7)

# Conflicts:
# infrastructure-playbooks/cephadm-adopt.yml

12 months agocommon: configure epel repository (rockylinux)
Guillaume Abrioux [Tue, 19 Mar 2024 17:36:21 +0000 (18:36 +0100)]
common: configure epel repository (rockylinux)

this is needed in order to make some libraries available when
running on RockyLinux

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 867be7c35c1f10080f842c3c6bdd51062cfd788a)

13 months agoceph_orch_apply: fix yaml error when multiple rgw deployed
Teoman ONAY [Wed, 21 Aug 2024 15:33:19 +0000 (17:33 +0200)]
ceph_orch_apply: fix yaml error when multiple rgw deployed

ceph orch ls rgw --format=yaml returns multiple documents
when multiple rgw are installed, this was not handled
correctly.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 823700bc1bc1f477cd58c61cded977a706a5c308)

13 months agodoc: ansible version dependency for stable-7.0 is changed to 2.15
bugwz [Wed, 21 Aug 2024 15:21:52 +0000 (23:21 +0800)]
doc: ansible version dependency for stable-7.0 is changed to 2.15

The ansible version dependency in the stable-7.0 branch has been
upgraded to 2.15, and the ansible version dependency in the main branch
has also been upgraded to >=2.15,so update the documentation accordingly.

Close issue: https://github.com/ceph/ceph-ansible/issues/7594

Signed-off-by: bugwz <xbugwz@gmail.com>
13 months agocephadm-adopt: fix "Update the placement of radosgw hosts" task
Teoman ONAY [Mon, 12 Aug 2024 13:24:06 +0000 (15:24 +0200)]
cephadm-adopt: fix "Update the placement of radosgw hosts" task

networks was at the wrong level in the spec file. Failed with
"got an unexpected keyword argument 'networks'"

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 2c88ecc7847d3c746fb7c324414d098470c54289)

13 months agocephadm-adopt: fix "Update the placement of radosgw hosts" task
Teoman ONAY [Fri, 5 Jul 2024 09:40:17 +0000 (11:40 +0200)]
cephadm-adopt: fix "Update the placement of radosgw hosts" task

spec file template conditions were incorrect

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit e85060cb6713b05757f87f5bda3368416aa6e64e)

13 months agocephadm-adopt: Fixes binding network for alertmanager
Teoman ONAY [Thu, 11 Jul 2024 09:35:22 +0000 (11:35 +0200)]
cephadm-adopt: Fixes binding network for alertmanager

Alertmanager was bind to default * network instead of grafana_server_addr
as it was before. Now on if grafana_server_addr is defined, it will be
bind to that network.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 0bf3398774dda6683f74a48f0ff3b26be6acec5a)

13 months agovagrant-box atomic-host -> stream9
Teoman ONAY [Tue, 16 Jul 2024 12:54:37 +0000 (14:54 +0200)]
vagrant-box atomic-host -> stream9

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit f1b67bd4d94f3e40c01bd1fdac5b7dd96f06a020)

15 months agoceph_orch_apply: fix idempotency
Teoman ONAY [Tue, 28 May 2024 12:06:03 +0000 (14:06 +0200)]
ceph_orch_apply: fix idempotency

As is idempotency does not work as the ceph orch
output does contain more attributes than the expected
spec.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 5a44fbeaa69273260f42257524df2e211b65c3ce)

16 months agoceph_orch_spec: Add ceph orch apply spec feature
Teoman ONAY [Wed, 24 Apr 2024 19:32:39 +0000 (21:32 +0200)]
ceph_orch_spec: Add ceph orch apply spec feature

Add new module ceph_orch_spec which applies ceph spec files.
This feature was needed to bind extra mount points to the RGW
container (/etc/pki/ca-trust/).

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2262133
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit f6fd034e7ee167ea31a382c30432972aeb7adba5)

16 months agoFix cephadm-adopt test scenario
Teoman ONAY [Wed, 15 May 2024 14:04:04 +0000 (16:04 +0200)]
Fix cephadm-adopt test scenario

Fixes cephadm-adopt test scenario by configuring rbd application
on test and test2 pools. Otherwise cephadm-adopt failed at task
"Check pools have an application enabled"

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit ca191fad2ab45d4c4217251078efcfe965898d6a)

18 months agocontainer-common: drop image fetching logic
Guillaume Abrioux [Fri, 4 Aug 2023 07:57:32 +0000 (09:57 +0200)]
container-common: drop image fetching logic

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 1a97696d9be2f186e297a118d48dfaf2000ddff8)

18 months agotests: various fixes in tox.ini
Guillaume Abrioux [Fri, 8 Mar 2024 15:52:29 +0000 (16:52 +0100)]
tests: various fixes in tox.ini

- the collection path isn't right
- vagrant_up.sh fails because the path isn't passed down
- increase the number of retries and delay for pytest

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agoceph-handler: remove tempdir when all handlers are done
Seena Fallah [Fri, 16 Feb 2024 10:30:07 +0000 (11:30 +0100)]
ceph-handler: remove tempdir when all handlers are done

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
18 months agoceph-handler: restart existed rgw daemons
Seena Fallah [Fri, 16 Feb 2024 13:58:10 +0000 (14:58 +0100)]
ceph-handler: restart existed rgw daemons

This is needed for new instances are the restart might trigger before the deployment

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 7142321bc3b69283d75d798956aa6597b74a5985)

18 months agopytest-infra: fix failures
Teoman ONAY [Mon, 15 Jan 2024 21:27:17 +0000 (22:27 +0100)]
pytest-infra: fix failures

pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures
(https://github.com/pytest-dev/pytest-testinfra/pull/724)
Starting of now all groups the host is part of and not only the direct parent groups are
returned by get_variables()

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 37a82225f765eeca24dc76a804e292b5f711944d)

18 months agotests: do not use dev rpms in rbd-mirror scenario
Guillaume Abrioux [Sat, 9 Mar 2024 08:00:56 +0000 (09:00 +0100)]
tests: do not use dev rpms in rbd-mirror scenario

this makes the scenario use devel rpms which is wrong.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agolibrary/ceph_crush_rule: module refactor
Guillaume Abrioux [Fri, 2 Jun 2023 19:00:35 +0000 (21:00 +0200)]
library/ceph_crush_rule: module refactor

This refactor makes the 'name' argument not mandatory because when
'state' is 'info' we shouldn't need to pass it.

The second change is just a duplicate code removal.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit e433d2b955f8a52a869a192f415a1db55269bc72)

18 months agoDo not pass NoneType as argument to ceph_crush_rule
Dmitriy Rabotyagov [Wed, 25 Oct 2023 11:47:19 +0000 (13:47 +0200)]
Do not pass NoneType as argument to ceph_crush_rule

With ansible-core 2.15 it is not possible to pass argument of unexpected
type, as otherwise module will fail with:
`'None' is not a string and conversion is not allowed`

With that we want to only get all existing crush rules, so we can simply
supply an empty string as a name argument, which would satisfy
requirements and have same behaviour for previous ansible versions.

Alternative approach would be to stop making `name` as a required
argument to the module and use empty string as default value
when info state is used.

Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
(cherry picked from commit b6102975549d8f870b0c20a01edda59d6ceac422)

18 months agotests: do not use ceph@main rpm
Guillaume Abrioux [Fri, 8 Mar 2024 20:55:32 +0000 (21:55 +0100)]
tests: do not use ceph@main rpm

rbd-mirror tests are using devel packages while it should
use quincy.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agocore: bump to ansible 2.15
Guillaume Abrioux [Fri, 8 Mar 2024 15:51:10 +0000 (16:51 +0100)]
core: bump to ansible 2.15

2.12 is EOL since May 2023.

Let's bump to 2.15.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agolinter: only report errors
Guillaume Abrioux [Fri, 8 Mar 2024 16:30:36 +0000 (17:30 +0100)]
linter: only report errors

this is a dirty and temporary hack so we just list error and make
this job success anyway.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agolinter: address syntax errors
Guillaume Abrioux [Fri, 8 Mar 2024 16:10:43 +0000 (17:10 +0100)]
linter: address syntax errors

This fixes the following error:
```
syntax-check[specific]: The field 'hosts' has an invalid value, which
includes an undefined variable.
```

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agolinter: bump to 6.16.0
Guillaume Abrioux [Fri, 8 Mar 2024 16:01:37 +0000 (17:01 +0100)]
linter: bump to 6.16.0

typical error:

```
Error:     raise NotImplementedError('an AnsibleCollectionFinder has not been installed in this process')
NotImplementedError: an AnsibleCollectionFinder has not been installed in this process
```

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agotests: bump to py3.10
Guillaume Abrioux [Tue, 13 Feb 2024 09:53:16 +0000 (10:53 +0100)]
tests: bump to py3.10

let's bump the python version to 3.10 in python-based
github actions.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 66337a361b0c6f5a780bbbef7e69f081ce6cded8)

19 months agoVagrantfile: support CEPH_*_SUBNET env vars
Guillaume Abrioux [Sat, 17 Feb 2024 09:08:16 +0000 (10:08 +0100)]
Vagrantfile: support CEPH_*_SUBNET env vars

support passing `CEPH_PUBLIC_SUBNET` and `CEPH_CLUSTER_SUBNET`
environment variables.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
19 months agotests: run vagrant_up.sh from dirname
Guillaume Abrioux [Fri, 16 Feb 2024 21:59:09 +0000 (22:59 +0100)]
tests: run vagrant_up.sh from dirname

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
23 months agodashboad: rgw frontends entries in ceph.conf are incorrect
Teoman ONAY [Tue, 5 Sep 2023 10:39:15 +0000 (12:39 +0200)]
dashboad: rgw frontends entries in ceph.conf are incorrect

There was multiple rgw frontends entries while there was just one
rgw instance on each host. The other entries were the details from
the other rgw hosts in the cluster

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2232282
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 490ca79ccc5b1cf7270032a70be41500578f3ae8)

23 months agoSpeed up the some facts settings by running them once
Teoman ONAY [Tue, 5 Sep 2023 10:32:53 +0000 (12:32 +0200)]
Speed up the some facts settings by running them once

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 72d4d207a0cc3b5ec5f8b4538b8e4bc9771bf451)

2 years agodo not use update debian cache or try to install packages when package-install is...
insatomcat [Wed, 16 Aug 2023 13:51:03 +0000 (15:51 +0200)]
do not use update debian cache or try to install packages when package-install is disabled

When deploying with --skip-tags=package-install (when there is no access to a repository), the playbook is still trying to update the package cache, or to install ceph-mgr packages, which makes the playbook fail.
This change prevents the playbook to try to update the cache or install ceph-mgr packages when the package-install tag is skipped.

Signed-off-by: Florent CARLI <florent.carli@rte-france.com>
(cherry picked from commit 271fd8294296efe42f4e4d98032b4f8aac8ff654)

2 years agocephadm-adopt: Fixes hosts addition to be managed by cephadm
Teoman ONAY [Wed, 16 Aug 2023 14:02:29 +0000 (16:02 +0200)]
cephadm-adopt: Fixes hosts addition to be managed by cephadm

The tasks "manage nodes with cephadm - ipv4/6" are skipped when
cephadm_mgmt_network contains more than one ip network which prevent
cephadm from managing the host.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit db2f3e42dc23d72cfae85ec942b6b2f43e482e81)

2 years agolibrary: ceph_crush: set containerized param to false to respect docstrings
Konstantin Shalygin [Fri, 19 Feb 2021 14:49:25 +0000 (17:49 +0300)]
library: ceph_crush: set containerized param to false to respect docstrings

Signed-off-by: Konstantin Shalygin <k0ste@k0ste.ru>
(cherry picked from commit d1f85f5ad3515076629e64eddec66c27987f88c8)

2 years agoUpdate zonegroup test.
Nathan Hoad [Wed, 28 Jun 2023 20:28:45 +0000 (16:28 -0400)]
Update zonegroup test.

Signed-off-by: Nathan Hoad <nhoad@bloomberg.net>
(cherry picked from commit dad116b4456862d94edebf00b006d6dda2aaaacf)

2 years agoSpecify the zone when requesting zonegroup information.
Nathan Hoad [Thu, 8 Jun 2023 17:41:53 +0000 (13:41 -0400)]
Specify the zone when requesting zonegroup information.

Signed-off-by: Nathan Hoad <nhoad@bloomberg.net>
(cherry picked from commit 8923931df441da1181f38ecdcd4e7d0d5394336d)

2 years agocephadm-adopt: Fixes rbd-mirror regression
Teoman ONAY [Fri, 4 Aug 2023 12:37:39 +0000 (14:37 +0200)]
cephadm-adopt: Fixes rbd-mirror regression

779523f86f4659283441ece8af2d4a4dbe8140b4 introduced a regression
related to rbdmirrors tasks. They were executed while
ceph_rbd_mirror_remot_* variables were not set.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 18cd35bad53231b9afdde8aec35c2b8a46c928e4)

2 years agocephadm-adopt: Add --networks parameter support to ceph orch apply rgw
Teoman ONAY [Fri, 4 Aug 2023 09:17:44 +0000 (11:17 +0200)]
cephadm-adopt: Add --networks parameter support to ceph orch apply rgw

When radosgw_address_block was defined, it was not taken into account
during rgw adoption process

depends on: https://tracker.ceph.com/issues/62185
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2224351

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit bc54290718b9303c9eadc1f6c4e7c0e79e54e41c)

2 years agoAdd ipv6 libvirt support scenario in vagrant
Teoman ONAY [Wed, 7 Jun 2023 15:10:52 +0000 (17:10 +0200)]
Add ipv6 libvirt support scenario in vagrant

Addition of ipv6 support in vagrant/libvirt and an all_daemons_ipv6 scenario.
Some typo fixes

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 8f3bdd855989b9d89cc89d764647cdeb97adaf8e)

2 years agoceph-config: drop osd_memory_target from ceph_conf_overrides
Seena Fallah [Mon, 22 May 2023 20:44:46 +0000 (22:44 +0200)]
ceph-config: drop osd_memory_target from ceph_conf_overrides

As it's always being set in ceph.conf template, it leads to having duplicated osd_memory_target keys in rendered ceph conf while defining one in ceph_conf_overrides.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit f90d5d8b4c01b1f7e398bbdc59adcfc00d12ed19)

2 years agoNew RELEASE-NOTE for stable-7.0
Teoman ONAY [Thu, 1 Jun 2023 08:48:39 +0000 (10:48 +0200)]
New RELEASE-NOTE for stable-7.0

Signed-off-by: Teoman ONAY <tonay@ibm.com>
2 years agoFixes failing centos-non_container-rbdmirror test
Teoman ONAY [Tue, 2 May 2023 10:22:45 +0000 (12:22 +0200)]
Fixes failing centos-non_container-rbdmirror test

Signed-off-by: Teoman ONAY <tonay@ibm.com>
2 years agoReplace ip_version check with ansible test
Lukas Bezdicka [Wed, 19 Apr 2023 11:16:49 +0000 (13:16 +0200)]
Replace ip_version check with ansible test

Instead of checking ip_version variable we should check the input
address for ip version and select code path based on that.

This solves ceph adoption with mixed ipv6 and ipv4 networks.

Resolves: rhbz#2186226
Signed-off-by: Lukas Bezdicka <lbezdick@redhat.com>
(cherry picked from commit 5622a033a9f8a5c32fdd9429f40599d6b37cd7ac)

2 years agotests: force rpm pkg upgrade
Guillaume Abrioux [Wed, 22 Mar 2023 15:29:46 +0000 (16:29 +0100)]
tests: force rpm pkg upgrade

Due to a bug with the rpm version present in the current stream8 vagrant image,
we have to make sure it is first upgraded to the latest version.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 years agotests: disable internal repos
Guillaume Abrioux [Thu, 16 Mar 2023 16:43:03 +0000 (17:43 +0100)]
tests: disable internal repos

they are broken at the moment.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 99573c4bba5ec2def0cb76e62558a7f664025544)

2 years agoceph-config: exclude already counted osds by lvm_volumes
Seena Fallah [Sun, 26 Feb 2023 14:11:26 +0000 (15:11 +0100)]
ceph-config: exclude already counted osds by lvm_volumes

Exclude lvm_volumes defined disks from existing osds while it has been counted by the "count number of osds for lvm scenario" task.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 225ae38ee2f74165e7d265817597fe451df3e919)

2 years agodevices: allow using lvm_volumes with devices
Seena Fallah [Sun, 26 Feb 2023 14:08:09 +0000 (15:08 +0100)]
devices: allow using lvm_volumes with devices

* Exclude device from lvm_volumes while osd_auto_discovery is true
* Sum num_osds on both lvm_volumes and devices list

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 80b1ed9d4a3b133cb54fb13783071674baa856e5)

2 years agodevices: exclude db disks on osd_auto_discovery enabled
Seena Fallah [Mon, 13 Feb 2023 16:12:41 +0000 (17:12 +0100)]
devices: exclude db disks on osd_auto_discovery enabled

Exclude disks were defined in dedicated_devices and bluestore_wal_devices on osd_auto_discovery enabled.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 32b56785116eb47297df282bab1543507fc62b43)

2 years agodevices: remove duplicated disks after the readlink resolve
Seena Fallah [Mon, 13 Feb 2023 17:07:25 +0000 (18:07 +0100)]
devices: remove duplicated disks after the readlink resolve

If a disk has a symlink it will be re-added to the devices lists one with resolved path and the other with a defined path.
We can rebuild the list from the readlink output cause readlink always return the correct path for all disks.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 1f7b3ac5a387485b0e36994cb00c28eac8ee7572)

2 years agoceph-mgr: Fix reference to copy_admin_key variable
René Højbjerg Larsen [Fri, 3 Mar 2023 14:15:16 +0000 (15:15 +0100)]
ceph-mgr: Fix reference to copy_admin_key variable

Enabling installation of the admin key to mgr nodes by setting
"copy_admin_key: true" is broken. This is because the variable is not
referenced correctly (using inline Jinja2 templating).

Signed-off-by: René Højbjerg Larsen <rhl@jfm.dk>
(cherry picked from commit 09590c0683f3bff21a1b06de7f4378a2f8447e99)

2 years agoUses a more recent version of the CentOS stream 8 box
Teoman ONAY [Tue, 7 Feb 2023 13:30:52 +0000 (14:30 +0100)]
Uses a more recent version of the CentOS stream 8 box

Uses the latest centos/streamX image available.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
2 years agoFix selinux label issues
Teoman ONAY [Tue, 14 Mar 2023 11:26:56 +0000 (12:26 +0100)]
Fix selinux label issues

Add --security-opt label=disable to all containers
accessing /var/lib/ceph. podman selinux relabeling behavious changed
since version podman-3:4.2.0-1 which prevent some containers to access
files in these subdirectories.

Signed-off-by: Teoman ONAY <tonay@ibm.com>
2 years agoFixes selinux relabeling issue for nfs container
Teoman ONAY [Thu, 2 Mar 2023 22:01:48 +0000 (23:01 +0100)]
Fixes selinux relabeling issue for nfs container

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit c1b541f69e02f0d6d5cedfc706d332bf017f16eb)

2 years agotests: use pacific image instead of quincy for initial deployment
Guillaume Abrioux [Wed, 22 Feb 2023 11:50:56 +0000 (12:50 +0100)]
tests: use pacific image instead of quincy for initial deployment

update scenario should upgrade from pacific to quincy.
It is currently upgrading from quincy to quincy.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2 years agoCollocated mgr with mon fails to start on RHEL 8.7
Teoman ONAY [Tue, 7 Feb 2023 13:53:39 +0000 (14:53 +0100)]
Collocated mgr with mon fails to start on RHEL 8.7

With podman version podman-3:4.2.0-4.module+el8.7.0+17064+3b31f55c and
later, when mgr fails to start if mon is already running.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2169767
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 637ca81c9cf801e4d1d125dc8a2492b90fd78eea)

2 years agomgr: fix a typo
Lorenz Bausch [Thu, 9 Mar 2023 10:18:48 +0000 (11:18 +0100)]
mgr: fix a typo

This commit fixes a typo in `roles/ceph-mgr/defaults/main.yml`
(s/mpdules/modules)

Signed-off-by: Lorenz Bausch <info@lorenzbausch.de>
(cherry picked from commit 2f5e21b631107df87eea3529716ec55803aa9341)

2 years agoceph-config: make sure rgw_instances is set
Guillaume Abrioux [Tue, 7 Feb 2023 00:52:43 +0000 (01:52 +0100)]
ceph-config: make sure rgw_instances is set

We need to make sure `rgw_instances` is set before `ceph.conf` is
rendered. Otherwise, the `ceph-crash` play in the main playbook updates
(via ceph-handler) the `ceph.conf` on rgw nodes and removes rgw instances
sections.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2141604
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit e47288ef6c23820c4fa50835574169233cd06b12)

2 years agoInitialize rbd pool at pool creation
Teoman ONAY [Tue, 29 Nov 2022 08:47:58 +0000 (09:47 +0100)]
Initialize rbd pool at pool creation

When creating a RBD pool it needs to be initialized as per documentation[1]
Modified (pre_)generate_ceph_cmd to make it usable with any command with
the same parameters as the ceph command

[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool

Signed-off-by: Teoman ONAY <tonay@redhat.com>
(cherry picked from commit c39bbc3deaf7a02d36daa39d752e91e94afb3c3e)

2 years agotests: use quay.io instead of quay.ceph.io
Guillaume Abrioux [Tue, 6 Dec 2022 12:14:07 +0000 (13:14 +0100)]
tests: use quay.io instead of quay.ceph.io

This makes the CI use quay.io instead of quay.ceph.io

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit e55ca0188190173320ca77c62d2a908e9e8f5c61)

2 years agoCheck first the OSD storage file rather than after created
Mario Codeniera [Tue, 6 Dec 2022 08:18:03 +0000 (21:18 +1300)]
Check first the OSD storage file rather than after created

Signed-off-by: Mario Codeniera <M.Codeniera@massey.ac.nz>
(cherry picked from commit e5ad1953dccf7463507b932b04a00a17f3c8d81e)

2 years agocephadm-adopt: fix rbd-mirror adoption
Guillaume Abrioux [Mon, 14 Nov 2022 11:29:37 +0000 (12:29 +0100)]
cephadm-adopt: fix rbd-mirror adoption

The recent rbdmirror refactor introduced a regression in the
cephadm-adopt playbook.
Given that the rbd-mirror peer addition is now done by using the monitor
config-key store method during the cluster deployment, we can drop this
play from the cephadm-adopt.yml playbook.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2140569
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit c3fae04b8d234c84e4a5c7ca4a390ecfa3d1c1d5)

2 years agoSetting fact _radosgw_address fail when RGW is on a different network
Teoman ONAY [Tue, 18 Oct 2022 13:28:54 +0000 (15:28 +0200)]
Setting fact _radosgw_address fail when RGW is on a different network

Changed the when condition to only execute that fact setting on RGW
nodes while before it was run on all nodes and failed if the node
was not on the same network range as the RGW.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2131150
Signed-off-by: Teoman ONAY <tonay@redhat.com>
(cherry picked from commit 590e57cc1b9a79ced7a9208db8bf8eaf43d3f320)

2 years agodashboard: support --limit execution with rgw
Guillaume Abrioux [Wed, 13 Apr 2022 08:42:47 +0000 (10:42 +0200)]
dashboard: support --limit execution with rgw

When the following conditions are met:

- rgw is deployed,
- dashboard is deployed,
- playbook is called with --limit,
- a node being processed is collocated on either a mon or mgr.

The playbook fails because `rgw_instances` is undefined.
The idea here is to make sure this variable is always defined.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2063029
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 45c2f0a90a330332202a8abdca52fa45bb7e4ebd)

2 years agofacts: follow up on aa0cc93
Guillaume Abrioux [Thu, 21 Apr 2022 08:06:56 +0000 (10:06 +0200)]
facts: follow up on aa0cc93

when these variables are defined in the inventory host file,
all tasks are skipped then because the node being played isn't
aware about the values from the rgw nodes.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2063029
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 93df3e53ab02eb112468b7c896db10d97b754cf3)

2 years agoswitch-to-containers: ignore errors when stopping service
Guillaume Abrioux [Mon, 17 Oct 2022 08:20:21 +0000 (10:20 +0200)]
switch-to-containers: ignore errors when stopping service

There might be cases where it can break idempotency.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit a158d0d53bf8758c5c0fbbd269a3c885615b5461)

2 years agoswitch-to-containers: fix rbd-mirror migration
Guillaume Abrioux [Fri, 14 Oct 2022 17:33:26 +0000 (19:33 +0200)]
switch-to-containers: fix rbd-mirror migration

`--state=enabled` isn't a valid filter so the unit from the packaging
never gets removed.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2134917
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 7664da58da56d871a9304ea6bec8d0e30ba9b02a)

2 years agoceph-osd: remove unused ceph config set for osd_memory_target
Seena Fallah [Sat, 24 Sep 2022 17:49:09 +0000 (19:49 +0200)]
ceph-osd: remove unused ceph config set for osd_memory_target

As the conf is always being set in the config file there is no need to set it in with `ceph config`.
Also this will make it hard to run the playbook with the `ceph_update_config` tag as it won't run and will create an inconsistency between the config managements of the cluster

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 8b983cfdbf77a8aada81b32dcbd2881025b0bfdb)

2 years agoceph-config: fix overriding osd_memory_target
Seena Fallah [Sat, 24 Sep 2022 17:46:20 +0000 (19:46 +0200)]
ceph-config: fix overriding osd_memory_target

When the value is overriding in `ceph_conf_overrides`, there is no need to calculate and set `osd_memory_target` again as we wanted to override the conf by our desired value.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 613773b2a3efcf7e9ccd562969bf8bca8c242377)

2 years agoceph-config: don't check for devices on existing osds
Seena Fallah [Sat, 24 Sep 2022 17:21:41 +0000 (19:21 +0200)]
ceph-config: don't check for devices on existing osds

When osd_auto_discovery is true the `devices` var will be empty (as the disks have holders).
Also in general there is no need to check for devices to list the devices with ceph-volume as we have `default({})` on the stdout in `num_osds` set fact in the next task

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 57b0890aff91412fbdccbe0ec250ec06f4015f80)

2 years agoceph-config: always set _osd_memory_target
Seena Fallah [Sat, 24 Sep 2022 17:07:36 +0000 (19:07 +0200)]
ceph-config: always set _osd_memory_target

this should be set when rolling_update is true as well, otherwise, it will reset to default on the upgrade

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit ac4dfa7526eccdf05b8019ee761538d9b5b0642b)

2 years agolibrary/radosgw_user.py: fix user update
John Karasev [Wed, 28 Sep 2022 18:57:41 +0000 (11:57 -0700)]
library/radosgw_user.py: fix user update

Removes the case when display_name was defined prevously but
was not provided when modifying. Without this change the module
will change display_name to name even if display_name was not name
originally. See #7296

Signed-off-by: John Karasev <john.karasev@intel.com>
(cherry picked from commit 72ff93f685ee7a11490b1c9cce15aba564fb10d0)