crimson(WIP): Put a log before taking exclusive lock of object_context_loader

Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>

Merge pull request #65441 from linuxbox2/wip-72915

rgw: fix policy enforcement for GetObjectAttributes

Merge pull request #65633 from adk3798/cephadm-pin-cheroot

pybind/mgr: pin cheroot version in requirements-required.txt

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65198 from xxhdx1985126/wip-72701

crimson/os/seastore/cache: clear extents_index when the booting is done

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65234 from xxhdx1985126/wip-72706

crimson/osd/recovery_backend: interrupt all recovery_waiter unconditionally when cleaning up the recovery backend

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65283 from xxhdx1985126/wip-72763

crimson/osd/osd_operations/client_request: rely on the checks in PG::do_recover_missing() to determine whether to recover clone objects

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65317 from xxhdx1985126/wip-72790

crimson/osd/pg_backend: tolerate enoent for both head and clone when doing rollback

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65353 from xxhdx1985126/wip-72844

crimson/osd/pg: tolerate NULL PG::pglog_based_recovery_op when cancelling pglog based recovery

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65197 from myoungwon/wip-fix-allocator-alloc-handling

crimson/os/seastore/rbm: handle no-space case properly

Reviewed-by: Samuel Just <sjust@redhat.com>

pybind/mgr: pin cheroot version in requirements-required.txt

With python 3.10 (didn't seem to happen with python 3.12) the
pybind/mgr/cephadm/tests/test_node_proxy.py test times out.
This appears to be related to a new release of the cheroot
package and a github issues describing the same problem
we're seeing has been opened by another user
https://github.com/cherrypy/cheroot/issues/769

It is worth noting that the workaround described in that
issue does also work for us. If you add

```
import cheroot
cheroot.server.HTTPServer._serve_unservicable = lambda: None
```

after the existing imports in test_node_proxy.py the
test hanging issue also disappears. Also worth noting the
particular pin of

cheroot~=10.0

was chosen as it matches the existing pin being used
in pybind/mgr/dashboard/constraints.txt

Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #65204 from ifed01/wip-ifed-fix-ec-contiguous

erasure-code: make bufferlist contiguous in ErasureCode::encode_prepare

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>

Merge pull request #65566 from rhcs-dashboard/fix-73077-main

mgr/dashboard: Allow FQDN in Connect Cluster form -> Cluster API URL

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65579 from rhcs-dashboard/fix-73105-main

mgr/dashboard: fix zone update API forcing STANDARD storage class

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65613 from cybozu/doc-fix-osd-min-size

doc: fix osd min size

doc: fix osd min size

Exact 5 GiB block devices are also considered
as an available device.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Merge pull request #65489 from shraddhaag/wip-shraddhaag-availability-format

mon/OSDMonitor.cc: optionally display availability status in json

Reviewed-by: Nitzan Mordhai<nmordech@ibm.com>

Merge pull request #65527 from chanyoung/fix-coll-refs

crimson/.../store-bench: fix coll_refs index error

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65484 from ronen-fr/wip-rf-oneauth

osd/scrub: modify repair_object() to accept a single auth peer

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #62887 from clwluvw/copy-obj-remote

rgw: report copy obj progress from the frontend CR

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #65415 from kchheda3/wip-re-create-bucket

rgw/create-bucket: Do not re-create the bucket instance & bucket index shard object if if bucket already exist..

Merge pull request #64152 from cbodley/wip-63323

rgw: support S3 Object Ownership controls to disable object ACLs

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge PR #65392 into main

* refs/pull/65392/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

mgr/dashboard: fix zone update API forcing STANDARD storage class

The zone update REST API (`edit_zone`) always attempted to configure a
placement target for the `STANDARD` storage class, even when the request
was intended for a different storage class name.
This caused failures in deployments where `STANDARD` is not defined.

Changes:
Club add placement target and add storage class methods into one single
add_placement_targets_storage_class_zone method which takes the storage
class as a param as well alongside the rest of the placement params.

Fixes: https://tracker.ceph.com/issues/73105
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge PR #65577 into main

* refs/pull/65577/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64893 from zer0def/bug-57939

cephadm: pass wal/db slot count to ceph-volume

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #63170 from adk3798/cephadm-nvmeof-stray

mgr/cephadm: don't mark nvmeof daemons without pool and group in name as stray

Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65548 from EncoreTechnologies/cephadmin-vir-ip-networks-interfaces-check

mgr/cephadm: Add check for virtual_interface_networks

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65373 from phlogistonjohn/jjm-cephadm-build-ensure-byte-comp

cephadm: fail the script if byte-compile step fails

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65155 from phlogistonjohn/jjm-py-common-fmt-black

python-common: enable consistent code formatting with 'black'

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #63962 from adk3798/cephadm-signal-containerized-daemon

cephadm: add command to send signals to daemons

Reviewed-by: John Mulligan <jmulligan@redhat.com>

cephfs-journal-tool:: Don't reset the journal trim position

If the fs had to go through journal recovery and reset,
the cephfs-journal-tool resets the journal trim position
because of which the old unused journal objects just stay
forever in the metadata pool. The patch fixes the issue.
Now, the old stale journal objects are trimmed during the
regular trimming cycle helping to recover space in the
metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Validate cephfs-journal-tool reset trim

Validates that the cephfs-journal-tool reset
doesn't reset the trim position so that the
journal trim takes care of trimming the older
unused journal objects helping to recover the
space in metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #65510 from anthonyeleven/eugen

src/cephadm/cephadmlib/daemons: Fix typos in ceph.py and elsewhere

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65322 from ShwetaBhosale1/fix_issue_72345_set_healthwarning_for_ssh_timeout_during_refresh

mgr/cephadm: set health warning for host SSH timeout

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65291 from ShwetaBhosale1/fix_issue_72774_spec_reapply_causing_osd_to_apply_in_every_serve_loop

mgr/cephadm: After reapplying the osd spec, the OSD services are continuously applied in each serve loop iteration

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65149 from ShwetaBhosale1/fix_issue_72652_max_num_of_osds_to_upgrade_in_single_iteration

mgr/cephadm: Config parameter to set the max number of OSDs to upgrade in single iteration

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #64642 from ShwetaBhosale1/fix_issue_72206_Allow_registry_credentials_to_define_multiple_container_registries

mgr/cephadm: Allow registry credentials to define multiple container registries

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65398 from smanjara/wip-fix-zg-api-name

rgw/multisite: update api_name during a zonegroup rename

Merge pull request #64018 from 9401adarsh/wip-adashoka-71677

rgw/notifications: add support for sharded persistent bucket notifications

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #65366 from cbodley/wip-72847

rgw/admin: allow listing account's root users

Reviewed-by: Adam Emerson <aemerson@redhat.com>

doc: add format option in docs

Fixes: https://tracker.ceph.com/issues/71546
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>

Merge pull request #65528 from mkogan1/wip-d4n-odsync

rgw/d4n: change cache write ::open() flags

Merge pull request #65166 from myoungwon/wip-fix-rbm-mergeable-block

crimson/os/seastore: correct possible mergeable size for ool extents

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #59608 from VallariAg/wip-nvmeof-teuthology-v7-upgrade

qa/suites/nvmeof: add upgrade sub-suite

Merge pull request #65565 from salieri11/igolikov-bug-73053

mds: remove unused enum values for subvolume metrics

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #65394 from athanatos/sjust/wip-seastore-cleanups-2025-08

seastore: misc cleanups, coroutine conversions

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65399 from anthonyeleven/improve-global-yml

src/common/options: Improve global.yaml.in

Merge pull request #65372 from adamemerson/wip-70916-bis

test/neorados: Catch timeouts in Watch/Poll test

Merge pull request #65532 from phlogistonjohn/jjm-jenk-hint

github: add a note reminding to use one command per comment

Merge pull request #65553 from ceph/pr-checklist-fix

.github/workflows/pr-checklist.yml: Update

test/.../test_cbjournal: destroy CircularBoundedJournal instance prior to reactor shutdown

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: inline do_submit_record into submit_record

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: add journal submission metrics

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: convert do_submit_record to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: convert submit_record to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../transaction_manager: convert do_submit_transaction to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../extent_placement_manager: convert BackgroundProcess::run() to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #64978 from athanatos/sjust/wip-mclock-cleanup

mclock: avoid using config keys for profiles, remove MonClient from MclockConfig

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>

cephadm: add command to send signals to daemons

This command figures out the container id for the
daemon based on the given name and then uses
a docker/podman to send that signal to the container

Signed-off-by: Adam King <adking@redhat.com>

qa: Add nvmeof:upgrade suite

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

mgr/dashboard: Allow FQDN in Connect Cluster form -> Cluster API URL

Allow the user to enter URL with FQDN in the Cluster API URL filed in
the Connect Cluster form inside Multi-cluster tab.

Fixes: https://tracker.ceph.com/issues/73077
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge PR #65516 into main

* refs/pull/65516/head:
common: remove unused attribute

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #65559 from nbalacha/wip-nbalacha-cleanup-1

rgw/bucket-logging: minor code cleanup

mds: remove unused enum values for subvolume metrics

Signed-off-by: Igor Golikov <igolikov@redhat.com>
Fixes: https://tracker.ceph.com/issues/73053

mgr/cephadm: set a healthwarning for host SSH timeout

Fixes: https://tracker.ceph.com/issues/72345
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

Merge pull request #63089 from smanjara/wip-fix-object-lock-rule

rgw/multisite: sync put-object-lock-configuration

Merge pull request #64428 from sungjoon-koh/add-wildcard-support-cond-read

rgw: add wildcard "*" support for conditional read

rgw/bucket-logging: minor code cleanup

Fixes a typo in a variable name and the placement
of a comment.

Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>

Merge pull request #65481 from rhcs-dashboard/snapshot-schdule-interval

mgr/dashboard: fix missing schedule interval in rbd API

.github/workflows/pr-checklist.yml: Update

This newer version of the action does not fail mysteriously if a contributer
removes the example Jenkins commands from the end of the PR description.

Signed-off-by: Zack Cerza <zack@cerza.org>

Merge pull request #62469 from igomon-bloomberg/wip-timestamp-ver-epoch

rgw: implements timestamp-based epochs for versioned objects

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #64917 from aainscow/ec_fixpack3_pr

EC fixpack 3

Merge pull request #65370 from kchheda3/wip-fixed-acl-account-migration

rgw/account: bucket acls are not completely migrated once the user is migrated to an account

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/cephadm: Change spec to ingress_spec

Changed from using spec to ingress_spec to be consistent with the function and fix the spec errors.

Fixes: https://tracker.ceph.com/issues/66874
Signed-off-by: Bradley Bishop <bishopbm1@gmail.com>

rgw: implement timestamp-based epochs.

Signed-off-by: Igor Gomon <igomon@bloomberg.net>

mgr/cephadm: Add check for virtual_interface_networks

Added an additional look up for if a match with the ceph networks is not found it will check the virtual_interface_networks list from the config that will enable matching to those networks, enabling dummy IP usage as described in the docs: https://docs.ceph.com/en/reef/cephadm/services/rgw/#selecting-network-interfaces-for-the-virtual-ip.

Fixes: https://tracker.ceph.com/issues/66874
Signed-off-by: Bradley Bishop <bishopbm1@gmail.com>

Merge pull request #65536 from bluikko/doc-services-mon-improvements-cephadm

doc/cephadm: Fix errors and improvements in services/monitoring.rst

Merge pull request #65498 from adamemerson/wip-rgw-weekly-baseline-prio-subset

qa: Run fewer RGW jobs at higher priority every week

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #65530 from rkachach/fix_issue_73025

doc: fixing starting release of mgmt-gateway/oauth2-proxy services

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64771 from Matan-B/wip-matanb-crimson-seastore-coro

crimson/os/seastore/segment_manager: Check segments prior to mkfs

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/.../store-bench: fix coll_refs index error

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

Merge pull request #64970 from edwinzrodriguez/ceph-wip-72479

crush/mapper: Mark pushed variable as maybe unused

Merge pull request #65227 from tchaikov/wip-generate-brace-init

src: replace push_back(T{}) with emplace_back()

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/cephadm: Fix errors and small improvements in services/monitoring.rst

Add that certmgr is new in version Tentacle.

Fix broken links with formatting rendered as text.

Capitalize consistently in text HTTP, YAML, URL, Alertmanager, Grafana,
centralized logging; Prometheus or use inline preformat with lower case
when referring to the module name.

Use inline preformat consistently for CLI commands within text
paragraphs.

Use title case in section titles.

Trim section title underline syntax.

Use consistently pre-formatted blocks bash prompt, YAML.

Start all block formatting paragraphs at the left margin instead of
indenting.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

doc: github: add a note reminding to use one command per comment

When I started using ceph I also thought it would be natural to issue >1
command per comment, but it doesn't work. I saw someone else doing it
recently and thought it would be good to have this reminder in the PR
template.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

src/common/options: Improve global.yaml.in

Improve and correct option descriptions. Filestore options are marked deprecated to stress that Filestore should no longer be used.

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #65514 from phlogistonjohn/jjm-bwc-arg-grouping

build-with-container: add argument groups to organize options

build-with-container: add argument groups to organize options

Use the argparse add_argument_group feature to organize the mass of
arguments into more sensible categories. Hopefully, someone reading
over the `--help` output can now more easily see options that
are useful rather than being overwhelmed by a wall of text.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

doc: fixing starting release of mgmt-gateway/oauth2-proxy services

Fixes: https://tracker.ceph.com/issues/73025
Signed-off-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65456 from yuvalif/wip-yuval-72940

rgw/logging: rollover objects when conf changes

src/cephadm/cephadmlib/daemons: Fix typos in ceph.py and Dashboard messages

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

python-common/tox.ini: enable black formatting

Initially this is only for a few smaller packages/files that I don't
need to wrestle with to make it work with black.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

python-common/fs: reformat earmarking.py with black

Use the black formatter (with a single manual tweak) to reformat
the earmarking.py file. This formatting will be enforced by a future
change.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

python-common: reformat utils.py with black

Use the black formatter (with a single manual tweak) to reformat
the utils.py file. This formatting will be enforced by a future
change.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

python-common/cephadm: reformat images.py with black

Use the black formatter (with a single manual tweak) to reformat
the images.py file. This formatting will be enforced by a future
change.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65521 from shraddhaag/wip-shraddhaag-availability-release-notes

doc: update data availability release notes

Merge pull request #64728 from rhcs-dashboard/wip-aashish-log-promtail-main

mgr/dashboard: Migrate from promtail to grafana alloy

Reviewed-by: Adam King <adking@redhat.com>

rgw/d4n: change cache write ::open() flags

changing the default flags to O_DSYNC
a small performance improvement is observable

Signed-off-by: Mark Kogan <mkogan@ibm.com>

mon/OSDMonitor.cc: optionally display availability status in json

This commit enables users to specify the format option for the
data availability feature. Now if the users specific json-pretty,
output will be displayed in the given format.

Fixes: https://tracker.ceph.com/issues/71546
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>

Merge pull request #65170 from rhcs-dashboard/tiering-tracker-72569

[mgr/dashboard]: Mismatch in the object size observed in Advance section in Tiering.

Reviewed-by: Naman Munet <nmunet@redhat.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>