]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
2 months agoqa/standalone: osd-scrub-dump.sh: additional tests wip-rf-eofread
Ronen Friedman [Sat, 22 Nov 2025 14:48:46 +0000 (08:48 -0600)]
qa/standalone: osd-scrub-dump.sh: additional tests

Also - adding stride override parameter to the existing
large-object scrub test. And: improving the output format
of the test results.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd/scrub: extract the 'read object data' functionality
Ronen Friedman [Fri, 21 Nov 2025 13:39:29 +0000 (07:39 -0600)]
osd/scrub: extract the 'read object data' functionality

from be_deep_scrub() into a separate function,
ReplicatedBackend::be_deep_scrub_read().

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd/scrub: do not attempt to read past the end of an object
Ronen Friedman [Thu, 20 Nov 2025 13:54:20 +0000 (07:54 -0600)]
osd/scrub: do not attempt to read past the end of an object

When performing deep scrubs, the scrubber reads object data
in strides. Existing code uses a short read to detect the end
of the object (and if the object size is a multiple of the
stride - an extra read is performed, which returns 0 bytes).

The proposed change is to avoid such extra read attempts,
by using our knowledge of the object size.

Also - some minor code cleanups in the relevant function.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd: provide fmtlib formatter for ScrubMapBuilder
Ronen Friedman [Sat, 22 Nov 2025 14:55:58 +0000 (08:55 -0600)]
osd: provide fmtlib formatter for ScrubMapBuilder

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoMerge pull request #66230 from ronen-fr/wip-rf-larger-stride
Ronen Friedman [Sun, 30 Nov 2025 06:59:25 +0000 (08:59 +0200)]
Merge pull request #66230 from ronen-fr/wip-rf-larger-stride

osd/scrub: increasing the default data-read stride

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>
Reviewed-by: Jon Bailey <jonathan.bailey1@ibm.com>
2 months agoMerge pull request #64248 from zhuwei127/fix-doublefree
Kefu Chai [Fri, 28 Nov 2025 13:35:46 +0000 (21:35 +0800)]
Merge pull request #64248 from zhuwei127/fix-doublefree

examples/librados: fix memory pointed to by 'rs' is freed twice.

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
3 months agocommon/options: document osd_deep_scrub_stride wip-rf-larger-stride
Ronen Friedman [Sun, 23 Nov 2025 14:02:04 +0000 (16:02 +0200)]
common/options: document osd_deep_scrub_stride

default value change (from 0.5MB to 4MB)

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 months agoqa/standalone: osd-scrub-dump.sh: test large object scrubs
Ronen Friedman [Thu, 13 Nov 2025 13:12:03 +0000 (07:12 -0600)]
qa/standalone: osd-scrub-dump.sh: test large object scrubs

following a change to the default stride size for deep scrubs,
adding a standalone test to verify that scrubs of large objects
work correctly (and to perform some minimal performance
measurements).

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 months agoosd/scrub: increasing the default data-read stride
Ronen Friedman [Thu, 13 Nov 2025 13:01:12 +0000 (07:01 -0600)]
osd/scrub: increasing the default data-read stride

When performing deep scrubs, the scrubber reads object
data in strides, to avoid monopolizing the OSD's I/O capacity.
The default stride was set to 0.5MB, which is too low for
modern storage devices. This commit increases the default
stride to 4MB.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>