Revert "RGW: multi object delete op; skip olh update for all deletes but the last one"

This reverts commit 9bb170104446bfea0ad87b34244f3a3d47962fcc.

Merge pull request #64727 from bluikko/doc-mount-ceph-formatting-man

doc/man/8: Fix small errors and small improvements in mount.ceph.rst

Merge pull request #65134 from xxhdx1985126/wip-seastore-clone-range-latest

crimson/os/seastore: OP_CLONERANGE2 support ---- another approach

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65479 from smanjara/wip-fix-object-sync-trace

rgw/multisite: fix sync requests on existing objects

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #65459 from rhcs-dashboard/72944-hide-suppresed-alerts-on-dashboard

mgr/dashboard : Hide suppressed  alert on landing page

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65700 from a16bitsysop/crimson-systemd

crimson: fix building without systemd

Merge pull request #65612 from Hezko/nvmeof-cli-fix-aliases-help

mgr/dashboard: fix command alias help message

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65610 from Hezko/nvmeof-cli-ns-list-nsid-param

mgr/dashboard: add nsid param to ns list command

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge PR #59676 into main

* refs/pull/59676/head:

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #65232 into main

* refs/pull/65232/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>

Merge pull request #65410 from anthonyeleven/ec-overwrite

doc/rados/operations: Clarify overwrites in erasure-code.rst

Merge pull request #65501 from anthonyeleven/ceph-osd-df

doc: Enhance the ceph df and ceph osd commands

Merge PR #65483 into main

* refs/pull/65483/head:

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #61173 into main

* refs/pull/61173/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>

Merge pull request #64830 from AliMasarweh/wip-alimasa-conditional

RGW | fix conditional MultiWrite

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #65403 from MaxKellermann/Formatter__split

common/Formatter: move {JSON,Table,XML}Formatter to separate files

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Tested-by: anrao19

Merge pull request #64912 from cloudbehl/Cephadm-daemon-status-metric

prometheus: Add Cephadm orch ps output metric to prometheus

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Reviewed-by: Anmol Babu <anmolbudugutta@gmail.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #64562 from adam-lj/ceph_test_rados_io_sequence_copy_from

test/osd: Extend ceph_test_rados_io_sequence to support copy operations

Merge pull request #65649 from nbalacha/wip-nbalacha-cleanup-2

rgw/bucket-logging: fix typos

Merge pull request #64467 from ceph/fix-mtu-alert

monitoring: fix MTU Mismatch alert rule and expr

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65669 from rhcs-dashboard/inline-edit-fixes

mgr/dashboard: fix duplicated editing of cell

Reviewed-by: Afreen Misbah <afreen@ibm.com>

monitoring: fix MTU Mismatch alert rule and expr

Fixes: https://tracker.ceph.com/issues/73290
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: fix duplicated editing of cell

form control is applied with unique identifier. In the table where the
issue is present, let's support adding the `unique_identifier`.

Fixes: https://tracker.ceph.com/issues/73250
Signed-off-by: Nizamudeen A <nia@redhat.com>

crimson: fix building without systemd

Use BOOL WITH_SYSTEMD guard before including Jounald.cc in sources for crimson-common

Fixes: https://tracker.ceph.com/issues/73148
Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>

qa/suites/crimson-rados/thrash_simple: enable osd down

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

test/crimson/seastore/test_seastore: add the clone_range UT case

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore: support OP_CLONERANGE2

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore/lba_manager: allow cloning part of the mapping

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore: do "copy_on_write" if the to-be-modified object
needs it

At present, only clone objects may need COW, as HEAD objects won't be
sharing any direct lba mapping with other objects in non-recovery
scenarios.

Although the HEAD object may share its direct mappings with the temp
object that's going to be recovered and replace it, it won't be
accepting any modifications at that time.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/osd/osd_meta: change osd_superblock to be a head object

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore/object_data_handler: we don't have to maintain the
symmetric indirect lba relationship at the time of clone

OP_CLONE is done in the following way:
1. First, swap the layout of the head onode and the clone onode, so that
   clone onode's object_data, omap_root, xattr_root and log_root all
   point to the head onode's corresponding fields;
2. Do SeaStore::_clone() from the clone onode to the head onode, which
   is exactly what rollback is done.

This makes the code of ObjectDataHandler::clone() and
ObjectDataHandler::copy_on_write() even simpler, and can facilitate the
clone/rollback scenarios when the "128-bit" lba key layout is involved.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore/onode: add the interface for swapping onode layouts

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore/onode: add the "need_cow" field to indicate whether
the onode's object data space needs to do clone before modification

At present, it's only when the onode's object data space is sharing its
own direct lba mappings with other onodes that the "need_cow" field
would be true.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

mgr/dashboard: fix command alias help message

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>

Merge pull request #65586 from dang/wip-dang-posix-cleanup

RGW - POSIXDriver - Cleanup vstart

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #65643 from dang/wip-dang-dedup

RGW - Fix dedup build

Reviewed by: Casey Bodley <cbodley@redhat.com>

Merge pull request #65593 from smanjara/wip-fix-period-pull

rgw/multisite: fix period pull command

Merge pull request #65631 from phlogistonjohn/jjm-fix-71992

mgr/smb: fix error handling for fundamental resource parsing

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #65309 from joscollin/wip-72683-peer-add-deprecate

cephfs_mirror: deprecate peer_add command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #65567 from rkachach/fix_issue_certs_migration

mgr/cephadm: cleaning up old migration logic and improving upgrade handling with certmgr

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65599 from bachmanity1/cephadm-support-custom-distro

cephadm: support custom distros by falling back to `ID_LIKE`

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65469 from Kushal-deb/remove-unreachable-code-path

mgr/rgw: fix unreachable code path

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #64194 from ShwetaBhosale1/fix_issue_71707_allow_ingress_matrics_via_https

mgr/cephadm: Allow Ingress service to expose the metrics via HTTPS

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

prometheus: Add Cephadm orch ps output metric to prometheus

Fixes: https://tracker.ceph.com/issues/72496
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #65652 from rhcs-dashboard/storage-capacity-fix

mgr/dashboard: Blank entry for Storage Capacity in dashboard under Cluster > Expand Cluster > Review

Reviewed-by: Afreen Misbah <afreen@ibm.com>

doc: added a note for damaged hard links in scrub documentation

Fixes: https://tracker.ceph.com/issues/69345
Signed-off-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io>

qa: add a test to verify that a damage hard link id detected during scrub

Also update ignorelist with the expected cluster warning.

Fixes: https://tracker.ceph.com/issues/69345
Signed-off-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io>

mds: identify damaged hard links during scrub

For a remote link, try to open the dentry (this part of code
is copied from the mds path_traversal) which internally pushes
the dir_frag in the damage list if applicable.

Fixes: https://tracker.ceph.com/issues/69345
Signed-off-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io>

Merge pull request #65443 from dmick/pip-vcs

various: update pip+https URLs to new form.

mgr/cephadm: Fixed stats frontend to always enable health url

Fixes: https://tracker.ceph.com/issues/71707
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

mgr/cephadm: Allow Ingress service to expose the metrics via HTTPS also add fields in spec to accept monitor ips/ monitor networks

Fixes: https://tracker.ceph.com/issues/71707
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

mgr/cephadm: Adding genric cert/key name support for get certificates

Fixes: https://tracker.ceph.com/issues/71707
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

RGW - Fix dedup build

Dedup is RadosStore specific, so move it to driver/rados, and only start
it if radosstore is being built.

Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>

mgr/cephadm: Remove Grafana self-signed certificate migration logic

Remove the code used to migrate Grafana self-signed certificates, as
it is no longer needed. The certmgr logic now handles generating new
certificates during the upgrade, eliminating the need for any migration
code or logic.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

mgr/cephadm: Remove SSL RGW migration logic

Remove the special-case code used for RGW service migration, as it is no
longer needed. The certmgr logic now handles populating the certstore
with the corresponding certificate and key entries by reading their values
directly from the spec. During RGW service redeployment as part of the
upgrade, certmgr will ensure the certstore is updated accordingly.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

mgr/cephadm: Fix RGW spec validation for deprecated rgw cert field

Starting from Tentacle, the rgw_frontend_ssl_certificate field has been
deprecated in favor of the new ssl_cert and ssl_key fields. Update the
validation logic to run after this field is automatically transformed into
the new fields, ensuring proper validation of RGW specs.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

mgr/cephadm: Include mgmt-gateway/oauth2-proxy in upgrade process

Add the new mgmt-gateway and oauth2-proxy services to the list of
services upgraded by cephadm, ensuring they are updated alongside the
rest of the cephadm-managed services.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65354 from sunyuechi/main

inline_memory: optimize mem_is_zero for riscv using RISC-V Vector (RVV) intrinsics

mgr/smb: fix error handling for fundamental resource parsing

When an smb resource is input to the smb mgr module in YAML or JSON the
fundamental parsing/deserialization is handled by resourcelib. This
module tries to be largely independent of smb mgr module and defines a
few basic exception types. When these exception types were raised the
`ceph` command line would print out a long traceback. Avoid printing
a traceback by catching these errors with a new contextmanager
(decorator) that is automatically called when using the smb ceph
mgr command api.

Fixes: https://tracker.ceph.com/issues/71992
Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65551 from adk3798/cephadm-migration-logging

mgr/cephadm: fix migrations logging

Reviewed-by: Redouane Kachach <rkachach@ibm.com>

mgr/dashboard: add nsid param to ns list command

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>

Implement further review feedback for CopyFrom changes to ceph_test_rados_io_sequence

Signed-off-by: Adam Lyon-Jones <adamlyon@uk.ibm.com>

Merge pull request #65424 from xxhdx1985126/wip-72902

crimson/os/seastore/transaction_manager: read_pin_by_type read the whole extent if it's not fully loaded

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64755 from cloudbehl/grafana-rate-irate-fix

ceph-mixin: Update monitoring mixin

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: SuperQ <superq@gmail.com>

Merge pull request #65243 from myoungwon/wip-corouint-state-device

crimson/os/seastore/rbm: switch to coroutine in state_device

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65503 from Hezko/nvmeof-cli-ns-add-nsid-param

mgr/dashboard: add nsid param to ns add command

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65504 from Hezko/nvmeof-cli-fix-subsys-group-add

mgr/dashboard: --no-group-append default value to False, aligned with old cli

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65646 from zmc/pr-checklist

.github/workflows/pr-checklist.yml: Update

Merge pull request #65396 from ceph/wip-uadk-main-fix

uadk: Build with ceph fork (for FORTIFY_SOURCE fix)

.github/workflows/pr-checklist.yml: Update

To pull in these changes:
https://github.com/ceph/ceph-pr-checklist-action/pull/5
https://github.com/ceph/ceph-pr-checklist-action/pull/6

Signed-off-by: Zack Cerza <zack@cerza.org>

Merge pull request #65634 from ljflores/wip-tracker-71182

qa: suppress OpenSSL valgrind leaks

Merge pull request #65268 from rhcs-dashboard/fix-multiple-user-deletion

mgr/dashboard: add multiple ceph users deletion

Reviewed-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard : Hide suppressed  alert on landing page
fixes : https://tracker.ceph.com/issues/72944

Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>

Merge pull request #65119 from rhcs-dashboard/72635-skip-secure-monitoring-stack

mgr/dashboard : Skip calls until secure_monitoring_stack is enabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65600 from rhcs-dashboard/nfs-command

mgr/dashboard: FS - Attach Command showing undefined for MountData

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #65561 from rhcs-dashboard/fix-72810-main

monitoring: fix "In" OSDs in Cluster-Advanced grafana panel. Also change units from decbytes to bytes wherever used in the panel

Merge pull request #65409 from rhcs-dashboard/pool-configuration-new

 mgr/dashboard: Handle pool creation in tiering local storage class creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

mgr/dashboard: Blank entry for Storage Capacity in dashboard under Cluster > Expand Cluster > Review

https://tracker.ceph.com/issues/73220

Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65519 from Hezko/fix-force-param-in-ns-add-host

mgr/dashboard: fix None force param handling in ns add_host so it won't raise exceptions

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65487 from rhcs-dashboard/72989-notification-form

mgr/dashboard: Form retains old data when switching from edit to create mode

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

rgw/bucket-logging: fix typos

Fixes typos in error messages.

Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>

Merge pull request #65265 from UtkarshBhatthere/fix/cephfsmir/mgrclireq

pybind/mgr/mirroring: modifies the cli command type to read

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa: suppress OpenSSL valgrind leaks

These leaks started happening when OpenSSL v3.5.0
was released. We determined they are safe to suppress.

Fixes: https://tracker.ceph.com/issues/71182
Signed-off-by: Laura Flores <lflores@ibm.com>

Merge pull request #65576 from rhcs-dashboard/smb-bugfixes

mgr/dashboard: fix smb button and table column

Merge pull request #64933 from soumyakoduri/wip-skoduri-restore-progress

rgw/restore: Persistently store the restore state for cloud-s3 tier

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge PR #65569 into main

* refs/pull/65569/head:
script/redmine-upkeep: do not try to update status if open subtasks exist

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #65547 into main

* refs/pull/65547/head:
.github/workflows/redmine-upkeep: remove concurrency limit

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #65555 into main

* refs/pull/65555/head:
script/redmine-upkeep: include each issue changed in summary
.github/workflows/redmine-upkeep: use smaller limit for testing push

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

pybind/mgr/mirroring: modifies the cli command type to read

The command fs snapshot mirror ls is used to present state data to
client. This does not require Write semantics.

Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>

Merge pull request #65412 from rhcs-dashboard/fix-72893-main

mgr/progress: expose API from CLI

Merge pull request #65537 from rhcs-dashboard/total-capacity-fix

mgr/dashboard: fix total capacity value in dashboard

Merge pull request #64858 from rhcs-dashboard/edit-nfs-export

mgr/dashboard:[NFS] Missing Subvolume Groups and Subvolumes on Edit NFS Export.

Reviewed-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #64559 from rhcs-dashboard/inline-table-edit

mgr/dashboard: support inline edit for datatable

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

Merge pull request #65441 from linuxbox2/wip-72915

rgw: fix policy enforcement for GetObjectAttributes

mgr/dashboard: Local storage class creation via dashboard doesn't handle creation of pool.

Fixes: https://tracker.ceph.com/issues/72569
Signed-off-by: Dnyaneshwari <dtalweka@redhat.com>
mgr/dashboard: handle creation of new pool

Commit includes:
1) Provide link to create a new pool
2) Refactored validation on ACL mapping, removed required validator as default
3) fixed runtime error on console due to ACL length due to which the details section was not opening
4) Used rxjs operators to make API calls and making form ready once all data is available, fixing the form patch issues
5) Refactored some part of code to improve the performance
6) Added zone and pool information in details section for local storage class

Fixes: https://tracker.ceph.com/issues/72569
Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65633 from adk3798/cephadm-pin-cheroot

pybind/mgr: pin cheroot version in requirements-required.txt

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65198 from xxhdx1985126/wip-72701

crimson/os/seastore/cache: clear extents_index when the booting is done

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65234 from xxhdx1985126/wip-72706

crimson/osd/recovery_backend: interrupt all recovery_waiter unconditionally when cleaning up the recovery backend

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65283 from xxhdx1985126/wip-72763

crimson/osd/osd_operations/client_request: rely on the checks in PG::do_recover_missing() to determine whether to recover clone objects

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65317 from xxhdx1985126/wip-72790

crimson/osd/pg_backend: tolerate enoent for both head and clone when doing rollback

Reviewed-by: Matan Breizman <mbreizma@redhat.com>