Merge PR #64324 into wip-vshankar-testing-20250829.190601-debug

* refs/pull/64324/head:

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #64627 into wip-vshankar-testing-20250829.190601-debug

* refs/pull/64627/head:

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #65285 from rhcs-dashboard/table-actions

mgr/dashboard: add customizations to table-actions

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65246 from afreen23/remove-old-dash

Drop support for older version of dashboard

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #63641 from anushruti10116/add-bucket-notification-dashboard

mgr/dashboard: Adding RGW Bucket Notification Dashboard for Grafana

Merge pull request #65284 from pritha-srivastava/wip-rgw-d4n-centos9-build-failure

rgw/d4n: removing fmt related code as it is

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: Update release notes and doc

-  for removal of old dashoard support

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65176 from phlogistonjohn/jjm-cephadm-build-el10rpm

cephadm: fix building rpm-sourced cephadm zippapp on el10

Reviewed-by: Adam King <adking@redhat.com>

rgw/d4n: removing fmt related code as it is
causing centos 9 build failure and is debug
only code.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

mgr/dashboard: add customizations to table-actions

https://tracker.ceph.com/issues/72764

Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65029 from guits/drop-udevadm-subprocess-calls

ceph-volume: drop udevadm subprocess calls

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #64955 from rhcs-dashboard/bug-2314829-about-panel

mgr/dashboard: About panel showing other icons in background while open

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>

Merge pull request #65146 from rhcs-dashboard/fix-72656-main

mgr/dashboard: Fix duplicate selection on multi-select in table component

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65247 from afreen23/optimize-css

mgr/dashboard: Optimize css styles.css bundle

Reviewed-by: Nizamudeen A <nia@redhat.com>com>
Reviewed-by: Abhishek Desai <abhishek.desai1@ibm.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

Merge pull request #65050 from zmc/osd-method-passing

cephadm: Use specified method for osd.default

Merge PR #65266 into main

* refs/pull/65266/head:
script/redmine-upkeep: filter by one status_id at a time
script/redmine-upkeep: add more statuses and organize
script/redmine-upkeep: break out of filters on limit threshold
.github/workflows/redmine-upkeep: bump limit

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

script/redmine-upkeep: filter by one status_id at a time

The API, unlike the www browser, does not actually allow filtering multiple
status IDs. We have to filter for each status we want to look at.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: add more statuses and organize

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: break out of filters on limit threshold

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows/redmine-upkeep: bump limit

Now that this no longer hits the github API in general, it's safer to process
many more issues. This is generally good as it's not possible to construct a
specific search that will process issues that have had their corresponding PR
merged. (We do have merge triggers however.)  Additionally, process more issues
but only every 12 hours.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64973 from edwinzrodriguez/ceph-wip-72482

test/osd: Suppress subobject-linkage warning in SelectMappingAndLayers

Merge pull request #64742 from cbodley/wip-72315

rgw/s3: support paginated ListBuckets

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

mgr/dashboard: Optimize css styles.css bundle

-  compresses the css bundle before sending to browser
-  this improves LCP value value as well

Fixes https://tracker.ceph.com/issues/72742

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: use border:0 for clipboard css

- Sets border-width: 0
- Completely removes the border
- More memory efficient than `border: none` which occupies some browser memory
- Higher priority in border conflicts

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: Drop support for older version of dashboard

Fixes https://tracker.ceph.com/issues/72739

- remove the code for previous version of dashboard
- popover css was globally added in infocard component which needs to be removed now. So include css in respective components- dashboard and upgrade.

Signed-off-by: Afreen Misbah <afreen@ibm.com>

cephadm: Use specified method for osd.default

When creating the first OSD in a cluster, the method requested was being
ignored - meaning an LVM OSD would be created in all cases. If a given cluster
couldn't support LVM, it could not be deployed. If we relay the method value
requested by the cephadm invocation, we can create OSDs as expected.

Fixes: https://tracker.ceph.com/issues/72381
Signed-off-by: Zack Cerza <zack@cerza.org>

test/osd: Suppress subobject-linkage warning in SelectMappingAndLayers class

Change SelectMapping and SelectLayers definitions to use non-static arrays of strings.

SelectMappingAndLayers::sma and SelectMappingAndLayers::sly have internal storage
duration, because it is a non-template, non-inline, non-extern const-qualified variable.

As a consequence, in each translation unit sma and sly is a different object.
And because ProgramOptionSelector takes a reference as template argument, then
ProgramOptionSelector<...> are different specializations of ProgramOptionSelector
in different translation units, because the template parameter references different objects in each.

Then, if you include the header in two different translation units, the program will
have undefined behavior, because the definitions of SelectMapping violates the one-definition
rule as they are, roughly said, not semantically identical. The compiler has no way to
decide whether SelectMapping is supposed to have ProgramOptionSelector<value1> or
ProgramOptionSelector<value2> as base class (where value1 and value2 are invented names
for the two instances of io_sequence::tester::lrc::mapping_layer_array_sizes in the
different translation units).

Fixes: https://tracker.ceph.com/issues/72482
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>

Merge pull request #65222 from dmick/make-debs-remove-git-clean

Remove git clean -fdx

mgr/dashboard: minor fixes

- purge css got added by mistake while testing in pr https://github.com/ceph/ceph/pull/65019/
- updated helath snaphost schema to include num_hosts

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: Add localization for nx based production builds

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #63921 from pritha-srivastava/wip-rgw-d4n-iterate-connpool-pipeline

rgw/d4n: Integration of optimization in iterate, connection pool and pipelining

Merge pull request #65130 from cbodley/wip-72643

rpm: default to gcc-toolset-13, not just for crimson

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65169 from afreen23/nfs-fix

mgr/dashboard: Dashboard nfs export editor rejects ipv6 addresses

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65230 from anthonyeleven/bs-slow-op-alert

doc/rados/operations: Improve health-checks.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/rados/operations: Improve health-checks.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

Merge pull request #65019 from afreen23/ceph-status-api

Add /health/snapshot api

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Fix duplicate selection on multi-select in table component

Fixes: https://tracker.ceph.com/issues/72656
Signed-off-by: Aashish Sharma <Aashish.Sharma1@ibm.com>

Merge pull request #65208 from rhcs-dashboard/72717-test-host-tc-failing

mgr/dashboard: Fix test_host.py test case

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

rgw/d4n: comment to suppress false positive
flagged by coverity

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: fix for rgw user create hanging when vstart
cluster starts when there is data in cache.

the cleaning thread sleeps when the entry for cleaning
has not expired, therefore radosgw-admin user create hangs
when vstart cluster comes up.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: changes to integrate pipelining with connection pool.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: add pipelining to PUT in write-cache
and read cache for data blocks directory entries

introduced a pipelined version of set command.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: use boost::generic::response for bucket list operation.

1. test case to explore pipelining using boost::redis::generic_response

2. introduced a get method based on redis::generic_response
and used the same for Bucket::list.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

the current connection setup is single and shared connection, the strand on that single connection may cause a serialization.
it should be noted that per s3-request there are several redis-operation that may run on co-routine.
the redis-connection pool implement the guarded acquire/release APIs.

adding configuration : rgw_redis_connection_pool_size.
re-factor of redis-exec* function.

shared pointer for Redis connection pool

adding branch predication optimization for redis-pool/single-shared-connection condition

adding a warning-report-method for the case there is a blocking state upon empty connection pool.

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Remove git clean -fdx

either
1) a source tarball is supplied, in which case the local dir is
   irrelevant, or
2) make-debs calls make-dist, which doesn't care about a dirty cwd

so it just punishes the unaware by removing things that they may
have wanted to keep.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #64681 from athanatos/sjust/wip-rocky-10

rocky 10 build error fixes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge PR #65217 into main

* refs/pull/65217/head:
.github: pass GITHUB_TOKEN to redmine-upkeep
.github/workflows: remove unnecessary permissions for leaving PR comments
script/redmine-upkeep: pass token to auth
script/redmine-upkeep: cleanup formatting for github comment

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

.github: pass GITHUB_TOKEN to redmine-upkeep

This was the actual problem preventing the script from leaving comments.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows: remove unnecessary permissions for leaving PR comments

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#permissions

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: pass token to auth

I believe I structured it this way originally because I had copied from
ptl-tool.py which used a personal github token.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: cleanup formatting for github comment

Manually breaking the lines screws up the formatting of the comment in github.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #65190 from dmick/make-debs-no-tar-chown

make-debs.sh: invoke tar with --no-same-owner

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: David Galloway <david.galloway@ibm.com>

Merge pull request #65180 from qiuxinyidian/doc

doc/dev:update blkin.rst doc for lttng trace

mgr/dashboard: Fix test_host.py test case
fixes: https://tracker.ceph.com/issues/72717

Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>

Merge pull request #64659 from anthonyeleven/fix-mds-units

Update CephFS option descriptions

Merge pull request #64074 from nh2/docs-config-more-commands

doc/rados/configuration: Mention show-with-defaults and ceph-conf

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #64969 from edwinzrodriguez/ceph-wip-72478

common/async:: Update delete operator in CompletionImpl

Merge pull request #64827 from rhcs-dashboard/72408-rgw-crypt-kmip-addr-format-change

mgr/dashboard: rgw_crypt_kmip_addr in SSE-KMS kmip address input field validation updated

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #64440 from cbodley/wip-21128

rgw/s3: remove 'aws-chunked' from Content-Encoding response

Reviewed-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #64993 from xxhdx1985126/wip-72539

crimson/os/seastore/object_data_handler: remove redundant indirect mappings at the end of ObjectDataHandler::clone()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64951 from rhcs-dashboard/72522-remove-service-instances

mgr/dashboard : 72522 - Remove service instances column to imporve API perf

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65102 from rhcs-dashboard/72608-optimize-host-api

mgr/dashboard : Optimized /host API to minimum resp

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Add /health/snapshot api

Fixes https://tracker.ceph.com/issues/72609

- The current minimal API relies on fetching data from osdmap and pgmap.
- These commands produce large, detailed payloads that become a performance bottleneck and impact scalability, especially in large clusters.
- To address this, we propose switching to the ceph snapshot API using ceph status command, which retrieves essential information directly from the cluster map.
- ceph status is significantly more lightweight compared to osdmap/pgmap, reducing payload sizes and processing overhead.
- This change ensures faster response times, improves system efficiency in large deployments, and minimizes unnecessary data transfer.
- update tests

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: Dashboard nfs export editor rejects ipv6 addresses

Fixes https://tracker.ceph.com/issues/72660

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65165 from amathuria/wip-amat-splitting-fixes

crimson/osd: pg splitting fixes

Merge pull request #65185 from zdover23/wip-doc-2025-08-22-cephfs-troubleshooting

doc/cephfs: edit troubleshooting.rst (Slow MDS)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #65154 from chanyoung/fix-cbjournal-boundary-check

crimson/.../circular_journal_space: fix boundary check

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65027 from Hezko/nvmeof-cli-71983-fix

mgr/dashboard: fix missing gw group error

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65108 from zhscn/fix-assert

crimson/os/seastore/CBJournal: correct needs_roll condition

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>

Merge pull request #65070 from chanyoung/remove-redundant-memset

crimson/.../rbm_device: remove unnecessary zero fill in anonymous mmap

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>

Merge pull request #65028 from Hezko/nvmeof-cli-72060-fix

mgr/dashboard: catch broader exception to show relevant cli output

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #64807 from myoungwon/wip-fix-report-rbm-block-size

crimson/os/seastore/rbm: fix incorrect reporting block size

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65007 from Matan-B/wip-matanb-crimson-docs-aug25

crimson: Simplify first time deployments

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

crimson/os/seastore/object_data_handler: remove redundant indirect
mappings at the end of ObjectDataHandler::clone()

Fixes: https://tracker.ceph.com/issues/72539
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore/lba_manager: add the interface method to remove
indirect mapping without touching the corresponding direct one

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #65161 from dmick/uadk-arm64-date-time

uadk: remove __DATE__ and __TIME__ from compilation

make-debs.sh: invoke tar with --no-same-owner

When running as a normal user, tar does not attempt to preserve
owners set on the tar content files.  When running as root, it does.
Containerized builds are running as root.  Stop make-debs.sh from
trying to set other owners for files, and leaving files in the
host system with mapped UIDs other than the user running the container
(which causes jenkins to be unable to clear the workspace).

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #64987 from aainscow/ceph-objectstore-tool-pgid-fix

tools: ceph-objectstore-tool check for invalid pgid

Merge pull request #65177 from idryomov/wip-72692

mon/MonClient: post version request completions outside of monc_lock

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #65178 from dmick/make-debs-keep-debug-pkgs

make-debs.sh: make "skip debug packages" conditional

Reviewed-by: John Mulligan <jmulligan@redhat.com>

rgw/d4n: modified update method to optionally take a bool
for dirty flag, such that when a flag is not set, then the method
re-uses the old value of dirty flag using in-memory data structure.
This is helpful in eliminating a call to directory to fetch the
'dirty' flag in the flush() method.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: avoid reading head block (attrs) from cache,
if they have already been read while reading permissions
for an object.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: reading from local cache first in iterate()
method instead of checking directory first for existence
of cache blocks.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: optimizing iterate method to align
last block also with max_chunk_size(object size
or rgw_max_chunk_size) and to perform checks
based on object size.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

crimson/os/seastore/transaction_manager: rewrite remove_mappings_in_range with coroutine

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

Merge pull request #63910 from tchaikov/wip-generate-test-instances

src: Fix memory leaks in generate_test_instance() by returning values instead of pointers

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #65151 from ronen-fr/wip-rf-eccalc

osd/scrub: calculate EC digest map size only once

Reviewed-by: Jon Bailey <jonathan.bailey1@ibm.com>

doc/cephfs: edit troubleshooting.rst (Slow MDS)

Move the "Slow requests (MDS)" section immediately after the first
section in this document ("Slow/Stuck Operations"), because the first
procedure on the page directs the reader to undertake the operation in
"Slow requests (MDS)" before trying anything else.

Signed-off-by: Zac Dover <zac.dover@proton.me>

doc/dev:update blkin.rst doc for lttng trace
fixes:https://tracker.ceph.com/issues/72059

Signed-off-by: lizhipeng <qiuxinyidian@gmail.com>

Merge pull request #64726 from anthonyeleven/funkycat

doc/man/8: Improve mount.ceph.rst

Merge pull request #65018 from athanatos/sjust/wip-store-bench-2

crimson/tool/crimson-store-bench: rework command line parsing, other fixes

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Update CephFS option descriptions and unit

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #62017 from anthonyeleven/pg-target

src/common/options: Clarify mon_target_pg_per_osd in mgr.yaml.in

Merge pull request #65052 from anthonyeleven/pending

doc: Improve PendingReleaseNotes

Merge pull request #63858 from anthonyeleven/crimsoneye

src/crimson: Improve message

Merge pull request #64053 from anthonyeleven/oompaloompa

doc: Improve central config log documentation