teuthology: pass integer as "tries" to safe_while()

in Python3, `a / b` could return a float, and `safe_while()` uses
`itertools.islice()` under the hood, where `stop` should be None or an
integer. so let's use `a // b` instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1439 from tchaikov/wip-StringIO-py3

teuthology: s/cStringIO.StringIO/six.StringIO/

Reviewed-by: Vasu Kulkarni <vasu@redhat.com>

teuthology/task: decode str returned from PIPE

which is bytes, and should be decoded before calling `split(a_str)`

Signed-off-by: Kefu Chai <kchai@redhat.com>

teuthology: s/sh/run/

to avoid using StringIO directly

Signed-off-by: Kefu Chai <kchai@redhat.com>

teuthology: s/cStringIO.StringIO/six.StringIO/

to be py3 compatible. this addresses the failure of
```
2020-04-05T12:35:02.036 INFO:teuthology.run_tasks:Running task ssh_keys...
2020-04-05T12:35:02.050 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_py3/teuthology/run_tasks.py", line 86, in run_tasks
    manager = run_one_task(taskname, ctx=ctx, config=config)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_py3/teuthology/run_tasks.py", line 64, in run_one_task
    task = get_task(taskname)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_py3/teuthology/run_tasks.py", line 28, in get_task
    module = _import('tasks', module_name, task_name, fail_on_import_error=True)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_py3/teuthology/run_tasks.py", line 52, in _import
    0,
ImportError: No module named 'tasks.ssh_keys'
```

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1437 from tchaikov/wip-keys-py3

teuthology, tasks: fix dict related py3 compatibility issues

task/background_exec.py: s/itervalues/values/

to by python3 compatible

Signed-off-by: Kefu Chai <kchai@redhat.com>

teuthology: use next(iter(..)) for accessing first element in a view

in python2, dict.values() and dict.keys() return lists. but in python3,
they return views, which cannot be indexed directly using an integer
index.

there are three use cases when we access these views in python3:

1. get the first element
2. get all the elements and then *might* want to access them by index
3. get the first element assuming there is only a single element in
   the view
4. iterate thru the view

in the 1st case, we cannot assume the number of elements, so to be
python3 compatible, we should use `next(iter(a_dict))` instead.

in the 2nd case, in this change, the view is materialized using
`list(a_dict)`.

in the 3rd case, we can just continue using the short hand of
```py
(first_element,) = a_dict.keys()
```
to unpack the view. this works in both python2 and python3.

in the 4th case, the existing code works in both python2 and python3, as
both list and view can be iterated using `iter`, and `len` works as
well.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1178 from Vicente-Cheng/wip-url-to-dirname-improvement

repo_utils: improve the handling about another git ssh expression

test_repo_utils: add another url type to url_to_dirname test

Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>

repo_utils: improve the handling about another git ssh expression

Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>

Merge pull request #1426 from tchaikov/wip-remote-ensure-online

orchestra/remote.py: raise if ensure_online() fails

Reviewed-by: Vasu Kulkarni <vasu@redhat.com>

Merge pull request #1418 from rosinL/wip-clock-timeout

teuthology/task: add timeout for clock task

Merge pull request #1433 from lxbsz/mount

requirements,setup: add ipy module for cephfs mount.py

Merge pull request #1434 from ceph/wiptestsmithi

ceph_ansible: Remove unnecessary package install/removal

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

requirements,setup: add ipy module for cephfs mount.py

The IPy module is a tool for handling of IPv4 and IPv6 addresses and
networks, the cephfs mount.py will use it to manage the IP addresses
to isolate the netns for each mount, which could let us get ride of
using ipmi command to hard shutdown the client node for some test cases.

Signed-off-by: Xiubo Li <xiubli@redhat.com>

ceph_ansible: Remove unnecessary package install/removal

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #1423 from ishanrai05/bootsrap-linuxmint

Add bootstrap support for LinuxMint

Add bootstrap support for LinuxMint

Signed-off-by: ishanrai05 <ishanrai05@gmail.com>

Merge pull request #1429 from hualongfeng/master

orchestra: add ed25519key keytype to connection

Merge pull request #1428 from ceph/debug-mgr

suite: debug mgr by default

Merge pull request #1431 from kshtsk/fix-kernel-args

task/kernel.py: should pass args with name 2

Reviewed-by: Kefu Chai <kchai@redhat.com>

task/kernel.py: should pass args with name 2

There is leftover, there should be remote.sh used instead of remote.run

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Merge pull request #1430 from tchaikov/wip-run-with-args

task/kernel.py: should pass args with name

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>

task/kernel.py: should pass args with name

to address the failure of

```
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 86, in run_tasks
    manager = run_one_task(taskname, ctx=ctx, config=config)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 65, in run_one_task
    return task(**kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 1326, in task
    install_and_reboot(ctx, need_install)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 505, in install_and_reboot
    install_kernel(role_remote, remote_pkg_path(role_remote))
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 834, in install_kernel
    version = get_image_version(remote, path)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 1013, in get_image_version
    files = remote.run(['rpm', '-qlp', path])
TypeError: run() takes exactly 1 argument (2 given)
```

Signed-off-by: Kefu Chai <kchai@redhat.com>

orchestra: add ed25519key keytype to connection

Signed-off-by: Feng Hualong <hualong.feng@intel.com>

Merge pull request #1362 from kshtsk/wip-py3-compat

py3 compatibility

Reviewed-by: Vasu Kulkarni <vasu@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

suite: debug mgr by default

Like we do the mon and osd.

Signed-off-by: Sage Weil <sage@redhat.com>

orchestra/remote.py: use ensure_online() helper in run()

for better readability, and to have better errors when we fail to
connect to remote. before this change, we could have following
backtrace:

2020-03-25T09:00:47.022 INFO:teuthology.lock.ops:Checking smithi088.front.sepia.ceph.com
2020-03-25T09:00:47.023 INFO:teuthology.lock.ops:New key found. Updating...
2020-03-25T09:00:47.044 INFO:teuthology.lock.ops:Updating [smithi088.front.sepia.ceph.com]: set os type and version on server
2020-03-25T09:00:47.044 INFO:teuthology.orchestra.remote:Trying to reconnect to host
2020-03-25T09:00:47.045 DEBUG:teuthology.orchestra.connection:{'username': 'ubuntu', 'hostname': 'smithi088.front.sepia.ceph.com', 'timeout': 60}
2020-03-25T09:00:47.046 DEBUG:teuthology.orchestra.remote:[Errno None] Unable to connect to port 22 on 172.21.15.88
2020-03-25T09:00:47.046 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 89, in run_tasks
    manager.__enter__()
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/internal/lock_machines.py", line 78, in lock_machines
    os_version, arch)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/lock/ops.py", line 147, in lock_many
    update_nodes(reimaged)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/lock/ops.py", line 33, in update_nodes
    inventory_info = remote.inventory_info
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 475, in inventory_info
    node['arch'] = self.arch
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 459, in arch
    self._arch = self.sh('uname -m').strip()
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 242, in sh
    proc=self.run(**kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 198, in run
    r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 412, in run
    transport = client.get_transport()
AttributeError: 'NoneType' object has no attribute 'get_transport'

Signed-off-by: Kefu Chai <kchai@redhat.com>

orchestra/remote.py: raise if ensure_online() fails

to ensure that we fail early if we cannot ensure an online remote.

Signed-off-by: Kefu Chai <kchai@redhat.com>

orchestra/remote.py: check underlying Transport also

if the underlying Transport object is not available, consider this
remote is not online yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>

orchestra/run: fix string handling

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Merge pull request #1425 from ceph/avx

valgrind: disable openssl's use of avx instructions

valgrind: set OPENSSL_ia32cap to ~0x1000000000000000

This disables AVX instructions, which confuse valgrinda nd openssl.

https://tracker.ceph.com/issues/44362

Signed-off-by: Sage Weil <sage@redhat.com>

suite/util: add debug log for sha1s response

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

py3: get rid of cStringIO

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

py3: fix teuthology version banner for py3

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

task/kernel: get rid of cStringIO for py3

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

tox: enable py3

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

tox: enable flake8-py3

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

task/ansible: fix mock issue in test_ansible

Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

misc: get_file must use mode='rb' for py3

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

orchestra/daemon/systemd: get rid of cStringIO for py3

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

bootstrap: use python version based required packages

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

packaging: make sure _get_repo returns str

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>

Merge pull request #1419 from toabctl/drop-coverage-cmd

Drop teuthology-coverage command

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1421 from kshtsk/wip-cluster-sh

orchestra/cluster: add sh() method

Merge pull request #1420 from kshtsk/wip-pump-markupsafe

requirements: bump up markupsafe to 1.1.1

Reviewed-by: Kefu Chai <kchai@redhat.com>

requirements: bump up markupsafe to 1.1.1

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

orchestra/cluster: add sh() method

For simplified outputs processing it might be usefull
to have a function will return all captured log from
all remote hosts in the given sequence.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Drop teuthology-coverage command

It seems to be unused and there was no change in the last 6 years. I
guess it's not used and not needed so drop it to remove the dead
code.

Signed-off-by: Thomas Bechtold <tbechtold@suse.com>

teuthology/misc: pass --vgdb=yes to valgrind

This lets us attach to the process later.

Signed-off-by: Sage Weil <sage@redhat.com>

teuthology/task: add timeout for clock task

when ntp is not config correctly, the clock task will be blocked

Signed-off-by: chuqifang <chuqifang@hisilicon.com>

Merge pull request #1372 from ryg-/wip-suse-hw-provisioning

provision: add Pelagos support

provision: add Pelagos support

Add provisioning support via Pelagos provisioner
https://github.com/SUSE/pelagos/

Pelagos is pxe boot and provisioning system which created especially
for connecting bare metal nodes to ceph/teuthology testing system.
Integration tests here pelagos/test_pelagos_teuthology/test_pelagos.py
because depends on executed Pelagios service

For enabling pelagos you need add section to teuthology configuration:
    pelagos:
      endpoint: http://your.server.host:5000/
      machine_types: ['type1', 'type2', 'type3']

provision/pelagos.py: added support of Pelagos provisioning project,
                      interface is compatible with FOG provisioner
provision/__init.py: added processing of pelagos section in teuthology
                     configuration and provisioner instantiation
lock/*: added Pelagos provisioner instantiation
nuke/__init__.py: added call to pelagos module for nodes, which are
                   controlled by pelagos, for booting to live images.

Signed-off-by: Roman Grigorev <rgrigorev@suse.de>

Merge pull request #1404 from gekios/wip-libcloud_update

use libcloud 2.8.0 version

use libloud 2.8.0 version

Suggesting using 2.8.0 version of apache-libcloud that introduces
a fix on openstack driver.
(https://github.com/apache/libcloud/pull/1367 is fixing issue
https://github.com/apache/libcloud/issues/1365)

Signed-off-by: Georgios Kyratsas <gkyratsas@suse.com>

Merge pull request #1415 from smithfarm/wip-install-shaman-suse

packaging: remove zypper repo kludge

packaging: remove zypper repo kludge

Now that https://github.com/ceph/chacra/pull/275 has been merged and
deployed, we can write this code without any kludge.

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #1413 from smithfarm/wip-44187

task/kernel: after reboot, do not try to reconnect immediately

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>

Merge pull request #1412 from smithfarm/wip-43655

packaging: add Shaman repo correctly on opensuse

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>

Merge pull request #1411 from smithfarm/wip-opensuse-kernel-distro-2

kernel.py: fix -k distro for opensuse/sle (part 2)

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Luis Henriques <lhenriques@suse.com>

Merge pull request #1410 from badone/wip-smithi-lvm-scratch-disks

task/ceph_ansible: Work with LVM scratch devices

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

task/kernel: after reboot, do not try to reconnect immediately

Do not try to reconnect immediately after triggering the reboot,
because the reboot sequence might not have started yet (!)

Fixes: https://tracker.ceph.com/issues/44187
Signed-off-by: Nathan Cutler <ncutler@suse.com>

packaging: add Shaman repo correctly on opensuse

Fixes: https://tracker.ceph.com/issues/43655
Works Around: https://tracker.ceph.com/issues/44183
Signed-off-by: Nathan Cutler <ncutler@suse.com>

kernel.py: fix -k distro for opensuse/sle (part 2)

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #1408 from smithfarm/wip-kernel-distro-opensuse

task/kernel.py: fix -k distro for opensuse/sle (part 1)

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>

task/ceph_ansible: Work with LVM scratch devices

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

task/kernel.py: fix -k distro for opensuse/sle

Part one - this does not get us all the way, but it's a start!

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #1409 from kshtsk/wip-pump-six

requirements: pip-compile -P six

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1407 from kshtsk/wip-archive-dir

worker_start: allow ARCHIVE variable override

requirements: pip-compile -P six

We need to pump six to the latest 1.14.0 so we have
six.ensure_str() is available

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

worker_start: allow ARCHIVE variable override

The worker_start.sh script is using archive directory inside
the worker user home which cannot be changed, this patches
allows override ARCHIVE environment variable to address
this issue.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Merge pull request #1405 from rzarzynski/wip-hammer-sh-do-not-nuke

hammer.sh: don't do teuthology-nuke anymore.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

hammer.sh: don't do teuthology-nuke anymore.

Apparently `hammer.sh` is pretty old. It calls `teuthology-nuke`
expecting the further call to `teuhology` will be able to still
reach the nodes. However, it doesn't seem that anybody is turning
them back these days.

The commit just drops the `teuthology-nuke` call.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #1403 from badone/wip-ceph-ansible-cryptography-incompatible

ceph_ansible: Make sure cryptography version is compatible

Merge pull request #1402 from badone/wip-ceph-ansible-virtualenv-force-python3

ceph_ansible: Enforce python3 for virtualenv

Merge pull request #1401 from badone/wip-ceph-ansible-args-attribute-error

ceph_ansible: Make ceph_installer.run args consistent

ceph_ansible: Make sure cryptography version is compatible

Fixes: https://tracker.ceph.com/issues/43843
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

ceph_ansible: Enforce python3 for virtualenv

Fixes: https://tracker.ceph.com/issues/43799
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

ceph_ansible: Make ceph_installer.run args consistent

Fixes: https://tracker.ceph.com/issues/43798
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

Merge PR #1400 into master

* refs/pull/1400/head:
selinux: use text processing for audit.log

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

selinux: use text processing for audit.log

We ran into some odd grep bug treating the audit.log as binary and
wrongly returning a match result.

Fixes: https://tracker.ceph.com/issues/43797
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #1369 from ryg-/wip-fix-opensuse-provisioning

Fix opensuse provisioning support

Merge pull request #1398 from smithfarm/wip-teuthology-branch-sha1

suite/run.py: provide teuthology hash along with branch

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>

Merge pull request #1399 from ceph/fix-cephadm-logs

orchestra/daemon/cephadmunit: use journalctl to monitor stdout/err

orchestra/daemon/cephadmunit: use journalctl to monitor stdout/err

Using 'podman logs' is racy because the command may start before the
container starts, or even after it start and exits.

Signed-off-by: Sage Weil <sage@redhat.com>

Fix opensuse provisioning support

task/selinux.py, orchestra/remote.py:
    disable SELinux for opensuse/suse distros

nuke/actions.py:
    added support for sle/opensuse distros

Signed-off-by: Roman Grigorev <rgrigorev@suse.de>

suite/run.py: provide teuthology hash along with branch

When running teuthology-suite with -t option, I see:

teuthology branch: wip-fix-opensuse-provisioning
ceph branch: wip-foo eb2fd5065c6e489ca8dd9282ba62ab231f144f7a

In other words, the ceph branch message has the SHA1 but the
teuthology branch message does not. This commit adds it.

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #1396 from tchaikov/wip-podman-selinux

task/selinux: ignore SElinux denials caused by podman

Reviewed-by: Sage Weil <sage@redhat.com>

task/selinux: ignore SElinux denials caused by podman

it's a workaround of https://tracker.ceph.com/issues/43635

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1394 from SUSE/bootstrap-setuptools-44

bootstrap: install setuptools 44

Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1395 from ceph/fix-sysctl-core

tasks/internal: put kernel.core_pattern in sysctl.conf too

tasks/internal: put kernel.core_pattern in sysctl.conf too

This way if systemd restarts  or is reinstalled (as it is on el8 at the
moment) we won't lose this setting.

Signed-off-by: Sage Weil <sage@redhat.com>

bootstrap: install setuptools 44

With setuptools 45 python2 support was dropped.

Fixes: https://tracker.ceph.com/issues/43606
Signed-off-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #1383 from toabctl/worker-drop-dead-code

worker: Drop dead code handling old releases

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1391 from batrick/i43396

task/selinux: ignore recent rhel8 selinux denials

Reviewed-by: Kefu Chai <kchai@redhat.com>

task/selinux: ignore recent rhel8 selinux denials

Fixes: https://tracker.ceph.com/issues/43396
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #1390 from ceph/wip-centos8

orchestra/daemon/cephadmunit: implement kill, wait

orchestra/daemon/cephadmunit: implement kill, wait

These are both needed by thrashosds.

Signed-off-by: Sage Weil <sage@redhat.com>