]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
7 years agoradosgw: fix awsv4 header line sort order. 18080/head
Matt Benjamin [Mon, 2 Oct 2017 15:49:05 +0000 (11:49 -0400)]
radosgw: fix awsv4 header line sort order.

The awsv4 signature calculation includes a list of header lines, which
are supposed to be sorted.  The existing code sorts by header name, but
it appears that in fact it is necessary to sort the whole header *line*,
not just the field name.  Sorting by just the field name usually works,
but not always.  The s3-tests teuthology suite includes
s3tests.functional.test_s3.test_object_header_acl_grants
s3tests.functional.test_s3.test_bucket_header_acl_grants
which include the following header lines,

x-amz-grant-read-acp:id=56789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01234
x-amz-grant-read:id=56789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01234
x-amz-grant-write-acp:id=56789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01234
x-amz-grant-write:id=56789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01234

in this case, note that ':' needs to sort after '-'.

Fixes: http://tracker.ceph.com/issues/21607
Signed-off-by: Marcus Watts <mwatts@redhat.com>
(cherry picked from commit c11485e1b3a58631628644152816d9b22a17d8bd)

7 years agoMerge pull request #18027 from ceph/wip-yuriw-fix-clients-jewel
Yuri Weinstein [Fri, 29 Sep 2017 17:19:25 +0000 (10:19 -0700)]
Merge pull request #18027 from ceph/wip-yuriw-fix-clients-jewel

tests - Added suit to test upgraded clients against jewel ceph clusters

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
7 years agotests - Added suit to test upgraded clients against jewel ceph clusters 18027/head
Yuri Weinstein [Thu, 28 Sep 2017 21:37:03 +0000 (14:37 -0700)]
tests - Added suit to test upgraded clients against jewel ceph clusters

Replaces https://github.com/ceph/ceph/pull/17981
We need to run this suite using suite-branch option in
order to use jewel workloads agains ceph cluster luminous+ branches

Added 'libcephfs1' to exclude_packages in upgrade_workload

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
7 years agoMerge pull request #17892 from smithfarm/wip-p2p-s3-test
Nathan Cutler [Fri, 22 Sep 2017 20:23:51 +0000 (22:23 +0200)]
Merge pull request #17892 from smithfarm/wip-p2p-s3-test

jewel: tests: fix upgrade/jewel-x/point-to-point-x

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
7 years agoqa: point-to-point-x: upgrade client.1 to -x along with cluster nodes 17892/head
Nathan Cutler [Thu, 21 Sep 2017 20:50:06 +0000 (22:50 +0200)]
qa: point-to-point-x: upgrade client.1 to -x along with cluster nodes

The client.1 rgw in workload_x had not been upgraded to -x.

Fixes: http://tracker.ceph.com/issues/21499
Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit afc5a7d3208071b65c0d76d124bfc47a099a446c)

7 years agotests: use special branch of ceph/s3-tests with pre-10.2.10
Nathan Cutler [Thu, 21 Sep 2017 15:50:28 +0000 (17:50 +0200)]
tests: use special branch of ceph/s3-tests with pre-10.2.10

Jewel v10.2.10 introduces a fix for S3 ACL code, for which a new test was added
to ceph/s3-tests.git (ceph-jewel branch). Since the jewel point-to-point-x
upgrade test runs s3-tests on 10.2.7, modify the test to use a special
ceph/s3-tests branch (ceph-jewel-10-2-7) that omits the new test.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
7 years agoMerge pull request #17780 from smithfarm/wip-rh-74-jewel 17804/head
Yuri Weinstein [Wed, 20 Sep 2017 01:03:29 +0000 (18:03 -0700)]
Merge pull request #17780 from smithfarm/wip-rh-74-jewel

tests: CentOS 7.4 is now the latest

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
7 years agoMerge pull request #16297 from smithfarm/wip-20518-jewel
Nathan Cutler [Tue, 19 Sep 2017 12:22:52 +0000 (14:22 +0200)]
Merge pull request #16297 from smithfarm/wip-20518-jewel

jewel: rbd: cli: map with cephx disabled results in error message

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
7 years agoMerge pull request #17781 from smithfarm/wip-drop-11429
Nathan Cutler [Tue, 19 Sep 2017 11:33:42 +0000 (13:33 +0200)]
Merge pull request #17781 from smithfarm/wip-drop-11429

tests: Removed 11429 config

Reviewed-by: Kefu Chai <kchai@redhat.com>
7 years agotests: Removed 11429 config 17781/head
Yuri Weinstein [Wed, 21 Sep 2016 16:14:09 +0000 (09:14 -0700)]
tests: Removed 11429 config

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
(cherry picked from fde4d3bb96abc0c0ca5bca213a0a2423f95e91a2)

Conflicts:
    Cherry-picked manually because, nowadays, we have the entire ceph-qa-suite
    under qa/ in ceph/ceph.git

7 years agotests: CentOS 7.4 is now the latest 17780/head
Nathan Cutler [Mon, 18 Sep 2017 16:01:17 +0000 (18:01 +0200)]
tests: CentOS 7.4 is now the latest

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 2311b64025cdb6131035aaf01e7c97486da12e15)

Conflicts
    qa/distros/supported/centos_latest.yaml (renamed from centos_7.3.yaml)

7 years agoMerge pull request #16473 from smithfarm/wip-20723-jewel
Josh Durgin [Mon, 18 Sep 2017 18:05:28 +0000 (11:05 -0700)]
Merge pull request #16473 from smithfarm/wip-20723-jewel

jewel: osd: rados ls on pool with no access returns no error

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
7 years agoMerge pull request #17626 from badone/wip-jewel-ceph-osd-flush-segfault
Josh Durgin [Mon, 18 Sep 2017 18:04:46 +0000 (11:04 -0700)]
Merge pull request #17626 from badone/wip-jewel-ceph-osd-flush-segfault

jewel: core: kv: let ceph_logger destructed after db reset

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoMerge pull request #17677 from mslovy/wip-disable-kstore-test
Sage Weil [Tue, 12 Sep 2017 20:50:42 +0000 (15:50 -0500)]
Merge pull request #17677 from mslovy/wip-disable-kstore-test

jewel: qa: disable kstore to fix false positive case

Reviewed-by: Sage Weil <sage@redhat.com>
7 years agoMerge pull request #17597 from smithfarm/wip-21186-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:12:13 +0000 (22:12 +0200)]
Merge pull request #17597 from smithfarm/wip-21186-jewel

jewel: rgw: rgw_file:  incorrect lane lock behavior in evict_block()

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17287 from smithfarm/wip-21109-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:11:33 +0000 (22:11 +0200)]
Merge pull request #17287 from smithfarm/wip-21109-jewel

jewel: rgw: send data-log list infinitely

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17285 from smithfarm/wip-20820-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:10:42 +0000 (22:10 +0200)]
Merge pull request #17285 from smithfarm/wip-20820-jewel

jewel: rgw: Segmentation fault when exporting rgw bucket in nfs-ganesha

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17281 from smithfarm/wip-20818-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:09:25 +0000 (22:09 +0200)]
Merge pull request #17281 from smithfarm/wip-20818-jewel

jewel: rgw hangs in RGWRealmReloader::reload on SIGHUP

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17280 from smithfarm/wip-20815-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:08:36 +0000 (22:08 +0200)]
Merge pull request #17280 from smithfarm/wip-20815-jewel

jewel: rgw: uninitialized memory is accessed during creation of bucket's metadata

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17279 from smithfarm/wip-20813-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:07:48 +0000 (22:07 +0200)]
Merge pull request #17279 from smithfarm/wip-20813-jewel

jewel: rgw: usage logging on tenated buckets causes invalid memory reads

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17277 from smithfarm/wip-20726-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:06:55 +0000 (22:06 +0200)]
Merge pull request #17277 from smithfarm/wip-20726-jewel

jewel: rgw: user quota did not work well on multipart upload

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
7 years agoMerge pull request #17649 from dillaman/wip-21346
Jason Dillaman [Tue, 12 Sep 2017 20:05:16 +0000 (16:05 -0400)]
Merge pull request #17649 from dillaman/wip-21346

jewel: qa/workunits/rbd: relax greps to support upgrade formatting change

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
7 years agoMerge pull request #17166 from smithfarm/wip-20719-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:04:20 +0000 (22:04 +0200)]
Merge pull request #17166 from smithfarm/wip-20719-jewel

jewel: rgw: Truncated objects

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17165 from smithfarm/wip-20715-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:03:30 +0000 (22:03 +0200)]
Merge pull request #17165 from smithfarm/wip-20715-jewel

jewel: rgw: radosgw-admin data sync run crash

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17164 from smithfarm/wip-20712-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:02:29 +0000 (22:02 +0200)]
Merge pull request #17164 from smithfarm/wip-20712-jewel

jewel: rgw: not initialized pointer cause rgw crash with ec data pool

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17159 from smithfarm/wip-20709-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:01:38 +0000 (22:01 +0200)]
Merge pull request #17159 from smithfarm/wip-20709-jewel

jewel: rgw: radosgw-admin: bucket rm with --bypass-gc and without --purge-data doesn't throw error message

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17156 from smithfarm/wip-20673-jewel
Nathan Cutler [Tue, 12 Sep 2017 20:00:54 +0000 (22:00 +0200)]
Merge pull request #17156 from smithfarm/wip-20673-jewel

jewel: rgw: multisite: RGWRadosRemoveOmapKeysCR::request_complete return val is wrong

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17148 from smithfarm/wip-20292-jewel
Nathan Cutler [Tue, 12 Sep 2017 19:58:54 +0000 (21:58 +0200)]
Merge pull request #17148 from smithfarm/wip-20292-jewel

jewel: rgw: multisite: log_meta on secondary zone causes continuous loop of metadata sync

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17147 from smithfarm/wip-20290-jewel
Nathan Cutler [Tue, 12 Sep 2017 19:56:44 +0000 (21:56 +0200)]
Merge pull request #17147 from smithfarm/wip-20290-jewel

jewel: rgw: rgw_file: prevent conflict of mkdir between restarts

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #16856 from prallabh/wip-20895
Nathan Cutler [Tue, 12 Sep 2017 19:55:14 +0000 (21:55 +0200)]
Merge pull request #16856 from prallabh/wip-20895

jewel: rgw: bucket index check in radosgw-admin removes valid index

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #16767 from linuxbox2/jewel-rgw-mpart-race
Nathan Cutler [Tue, 12 Sep 2017 19:53:38 +0000 (21:53 +0200)]
Merge pull request #16767 from linuxbox2/jewel-rgw-mpart-race

jewel: rgw : fix race in RGWCompleteMultipart

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoqa: disable kstore to fix false positive case 17677/head
Ning Yao [Tue, 12 Sep 2017 18:16:29 +0000 (18:16 +0000)]
qa: disable kstore to fix false positive case

Signed-off-by: Ning Yao <yaoning@unitedstack.com>
7 years agoMerge pull request #17574 from smithfarm/wip-21297-jewel
Nathan Cutler [Tue, 12 Sep 2017 16:18:40 +0000 (18:18 +0200)]
Merge pull request #17574 from smithfarm/wip-21297-jewel

jewel: libradosstriper processes arbitrary printf placeholders in user input

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agorgw: fix radosgw-admin data sync run crash 17165/head
lu.shasha [Tue, 27 Jun 2017 02:53:30 +0000 (10:53 +0800)]
rgw: fix radosgw-admin data sync run crash

If sync thread have run before, then run data sync init. sync_status is still remain in rados pool. so no matter sync_status exists or not, if state is StateInit, sync_status.sync_info.num_shards should be updated.

Fixes: http://tracker.ceph.com/issues/20423
Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
(cherry picked from commit c307910d7131fc290f00bb8e33876e667afb72ec)

Conflicts:
    src/rgw/rgw_data_sync.cc (no data_sync_module or instance_id in jewel)

7 years agoMerge pull request #16299 from smithfarm/wip-20262-jewel
Nathan Cutler [Tue, 12 Sep 2017 07:36:50 +0000 (09:36 +0200)]
Merge pull request #16299 from smithfarm/wip-20262-jewel

jewel: rgw: datalog trim can't work as expected

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17167 from smithfarm/wip-20720-jewel
Nathan Cutler [Tue, 12 Sep 2017 07:34:36 +0000 (09:34 +0200)]
Merge pull request #17167 from smithfarm/wip-20720-jewel

jewel: multisite: RGWPeriodPuller does not call RGWPeriod::reflect() on new period

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agotests: use XFS explicitly in singleton-nomsgr/pool-access.yaml 16473/head
Nathan Cutler [Tue, 12 Sep 2017 07:30:37 +0000 (09:30 +0200)]
tests: use XFS explicitly in singleton-nomsgr/pool-access.yaml

Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
7 years agoqa/suites/rados/singleton-nomsgr: fix syntax
Sage Weil [Wed, 24 May 2017 20:46:00 +0000 (16:46 -0400)]
qa/suites/rados/singleton-nomsgr: fix syntax

This parsed out as

  tasks:
  - install: null
  - ceph:
      conf:
        osd: osd max object name len = 400 osd max object namespace len = 64
  - workunit:
      clients:
        all:
        - rados/test_health_warnings.sh

which is clearly not correct.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from 85e2f3f31d25dbfd9770cc3b1f232025df53b628)

Conflicts:
    applied changes to pool-access.yaml instead of health-warnings.yaml

7 years agoMerge pull request #15556 from cbodley/wip-19847
Nathan Cutler [Tue, 12 Sep 2017 07:25:22 +0000 (09:25 +0200)]
Merge pull request #15556 from cbodley/wip-19847

jewel: rgw: multisite: fixes for meta sync across periods

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17155 from smithfarm/wip-20641-jewel
Nathan Cutler [Tue, 12 Sep 2017 07:24:34 +0000 (09:24 +0200)]
Merge pull request #17155 from smithfarm/wip-20641-jewel

jewel: rgw: multisite: lock is not released when RGWMetaSyncShardCR::full_sync() fails to write marker

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #17278 from smithfarm/wip-20728-jewel
Nathan Cutler [Tue, 12 Sep 2017 07:23:43 +0000 (09:23 +0200)]
Merge pull request #17278 from smithfarm/wip-20728-jewel

jewel: rgw: multipart parts on versioned bucket create versioned bucket index entries

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agorgw: we no longer use log_meta 17148/head
Orit Wasserman [Thu, 22 Jun 2017 10:06:13 +0000 (13:06 +0300)]
rgw: we no longer use log_meta

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit ac8b0077c1f53ff0037c4163489b838eebf8c247)

7 years agorgw: is_single_zonegroup doesn't use store or cct
Orit Wasserman [Thu, 22 Jun 2017 07:17:37 +0000 (10:17 +0300)]
rgw: is_single_zonegroup doesn't use store or cct

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 0b0090cee249c5380efa4bb416d724a7e2dbfc08)

7 years agorgw: log_meta only for more than one zone
Orit Wasserman [Wed, 21 Jun 2017 09:37:21 +0000 (12:37 +0300)]
rgw: log_meta only for more than one zone

Fixes: http://tracker.ceph.com/issues/20357
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 088dba03ccc65609ef1c51306389ebcf1126ec8c)

7 years agorgw: only log metadata on metadata master zone
Casey Bodley [Sat, 10 Jun 2017 22:12:52 +0000 (18:12 -0400)]
rgw: only log metadata on metadata master zone

Fixes: http://tracker.ceph.com/issues/20244
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b8272f3607074a2f7cbfd08f7bbc82f22cf120ba)

7 years agoMerge pull request #16296 from smithfarm/wip-20267-jewel
Nathan Cutler [Mon, 11 Sep 2017 21:05:04 +0000 (23:05 +0200)]
Merge pull request #16296 from smithfarm/wip-20267-jewel

jewel: rbd: api: is_exclusive_lock_owner shouldn't return -EBUSY

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
7 years agoMerge pull request #17385 from dillaman/wip-19957
Nathan Cutler [Mon, 11 Sep 2017 21:04:09 +0000 (23:04 +0200)]
Merge pull request #17385 from dillaman/wip-19957

jewel: librbd: reacquire lock should update lock owner client id

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
7 years agoMerge pull request #17402 from dillaman/wip-20515
Nathan Cutler [Mon, 11 Sep 2017 21:03:29 +0000 (23:03 +0200)]
Merge pull request #17402 from dillaman/wip-20515

jewel: librbd: fail IO request when exclusive lock cannot be obtained

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
7 years agoMerge pull request #17412 from dillaman/wip-18704
Nathan Cutler [Mon, 11 Sep 2017 21:02:49 +0000 (23:02 +0200)]
Merge pull request #17412 from dillaman/wip-18704

jewel: librbd: prevent self-blacklisting during break lock

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
7 years agoqa/workunits/rbd: relax greps to support upgrade formatting change 17649/head
Jason Dillaman [Thu, 7 Sep 2017 12:55:27 +0000 (08:55 -0400)]
qa/workunits/rbd: relax greps to support upgrade formatting change

Fixes: http://tracker.ceph.com/issues/21181
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 273c84578b06905229a7c6eae7b1a12bbe60de95)

Conflicts:
qa/workunits/rbd/import_export.sh: trivial resolution

7 years agoqa/suites/rados/singleton-nomsgr/pool-access: behave on ext4
Sage Weil [Mon, 22 May 2017 16:53:51 +0000 (12:53 -0400)]
qa/suites/rados/singleton-nomsgr/pool-access: behave on ext4

We may land on an ext4 root partition.

Fixes: http://tracker.ceph.com/issues/20043
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from 657453d34914832f6e8012fbd69200e9680bd9ff)

Conflicts:
    applied the changes to pool-access.yaml instead of health-warnings.yaml
    to address a specific test failure in the jewel branch

7 years agotasks/ceph: construct CephManager earlier
Kefu Chai [Mon, 11 Sep 2017 04:13:35 +0000 (12:13 +0800)]
tasks/ceph: construct CephManager earlier

Previously, if errors occurred during healthy(), then
the finally block would invoke osd_scrub_pgs, which relies
on CephManager being constructed, and it would die, hiding
the original exception.

Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit c444db12d455a1901da8041e92f5eff1a9875170)

Conflicts:
qa/tasks/ceph.py: the `tasks` directory was moved into
`qa` after the cherry-picked change was merged.
so apply the change manually to the ceph.py
under `qa` directory.
(cherry picked from commit bc71dabb4e311bd2461489e98e9b95d5b635effc)

7 years agokv: let ceph_logger destructed after db reset 17626/head
wumingqiao [Tue, 25 Jul 2017 06:45:09 +0000 (14:45 +0800)]
kv: let ceph_logger destructed after db reset

if ceph_logger is deleted earlier than db, it may still be used by db, which cause a segment fault.

Signed-off-by: wumingqiao <wumingqiao@inspur.com>
(cherry picked from commit a5cd03c643d6cb9074dfd2952cde83435de1b9dd)

7 years agoMerge pull request #15189 from mslovy/wip-19996-jewel
Nathan Cutler [Sun, 10 Sep 2017 19:38:15 +0000 (21:38 +0200)]
Merge pull request #15189 from mslovy/wip-19996-jewel

jewel: osd: fix infinite loops in fiemap

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoMerge pull request #16711 from cbodley/wip-20346
Nathan Cutler [Sun, 10 Sep 2017 19:15:35 +0000 (21:15 +0200)]
Merge pull request #16711 from cbodley/wip-20346

jewel: rgw: meta sync thread crash at RGWMetaSyncShardCR

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #17552 from dillaman/wip-21279
Jason Dillaman [Fri, 8 Sep 2017 18:05:18 +0000 (14:05 -0400)]
Merge pull request #17552 from dillaman/wip-21279

jewel: test/cls_rbd: mask newer feature bits to support upgrade tests

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
7 years agorgw_file: fix LRU lane lock in evict_block() 17597/head
Matt Benjamin [Fri, 25 Aug 2017 21:55:11 +0000 (17:55 -0400)]
rgw_file:  fix LRU lane lock in evict_block()

Found by "Supriti Singh" <Supriti.Singh@suse.com>.

Fixes http://tracker.ceph.com/issues/21141

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 3301596734adcbda1e8e76a742935efdeb7518fd)

7 years agoMerge pull request #17514 from smithfarm/wip-21232-jewel
Nathan Cutler [Thu, 7 Sep 2017 16:54:17 +0000 (18:54 +0200)]
Merge pull request #17514 from smithfarm/wip-21232-jewel

jewel: core: interval_set: optimize intersect_of insert operations

Reviewed-by: Sage Weil <sage@redhat.com>
7 years agoMerge pull request #16293 from smithfarm/wip-20460-jewel
Nathan Cutler [Thu, 7 Sep 2017 16:39:58 +0000 (18:39 +0200)]
Merge pull request #16293 from smithfarm/wip-20460-jewel

jewel: core: test_envlibrados_for_rocksdb.yaml fails on crypto restart

Reviewed-by: Kefu Chai <kchai@redhat.com>
7 years agoqa/suites/rbd: fixed cache override 17402/head
Jason Dillaman [Tue, 5 Sep 2017 20:20:26 +0000 (16:20 -0400)]
qa/suites/rbd: fixed cache override

Fixes: http://tracker.ceph.com/issues/21251
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 98061bb3d7ce6309ddb04ea4d7e9d44a7ecd09c6)

7 years agolibradosstriper: remove format injection vulnerability 17574/head
Jesse Williamson [Tue, 13 Jun 2017 19:31:16 +0000 (12:31 -0700)]
libradosstriper: remove format injection vulnerability

Fixes: http://tracker.ceph.com/issues/20240
Signed-off-by: Stan K <redrampage@selectel.ru>
(cherry picked from commit e94d3b9661d287e500cdf4e6c102d2e3bb04475e)

7 years agoMerge pull request #17084 from badone/wip-ceph-disk-dmcrypt-key-jewel
Nathan Cutler [Thu, 7 Sep 2017 15:41:58 +0000 (17:41 +0200)]
Merge pull request #17084 from badone/wip-ceph-disk-dmcrypt-key-jewel

jewel: ceph-disk: Use stdin for 'config-key put' command

Reviewed-by: Kefu Chai <kchai@redhat.com>
7 years agoMerge pull request #17008 from asheplyakov/19182-bp-jewel
Nathan Cutler [Thu, 7 Sep 2017 15:40:34 +0000 (17:40 +0200)]
Merge pull request #17008 from asheplyakov/19182-bp-jewel

jewel: mon: fix force_pg_create pg stuck in creating bug

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoosd: Reverse order of op_has_sufficient_caps and do_pg_op
Brad Hubbard [Mon, 29 May 2017 09:25:43 +0000 (19:25 +1000)]
osd: Reverse order of op_has_sufficient_caps and do_pg_op

Fixes: http://tracker.ceph.com/issues/19790
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit a921882e7c676d68ed67b54301b49fd9bed42945)

Conflicts:
        qa/suites/rados/singleton-nomsgr/all/pool-access.yaml - drop mgr.x
            role, which is not needed in jewel and might even cause the test to
            fail
        src/osd/PrimaryLogPG.cc - this file doesn't exist in jewel, so apply
            the change manually to ReplicatedPG.cc (i.e., by moving the
            op->includes_pg_op() conditional below the
            !op_has_sufficient_caps(op) conditional)

7 years agoMerge pull request #17133 from smithfarm/wip-21035-jewel
Kefu Chai [Thu, 7 Sep 2017 14:51:10 +0000 (22:51 +0800)]
Merge pull request #17133 from smithfarm/wip-21035-jewel

jewel: ceph-disk: systemd unit timesout too quickly

Reviewed-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>
7 years agoMerge pull request #16316 from smithfarm/wip-20362-jewel
Nathan Cutler [Thu, 7 Sep 2017 14:33:08 +0000 (16:33 +0200)]
Merge pull request #16316 from smithfarm/wip-20362-jewel

jewel: rgw: VersionIdMarker and NextVersionIdMarker are not returned when listing object versions

Reviewed-by: Casey Bodley <cbodley@redhat.com>
7 years agoceph_test_objectstore: disable filestore_fiemap 15189/head
Sage Weil [Thu, 15 Sep 2016 21:29:45 +0000 (17:29 -0400)]
ceph_test_objectstore: disable filestore_fiemap

This very reliably triggers a test failure for
ObjectStore/StoreTest.Synthetic/1.

FIEMAP is bad!  Do not use it!

Signed-off-by: Sage Weil <sage@redhat.com>
7 years agotest/cls_rbd: mask newer feature bits to support upgrade tests 17552/head
Jason Dillaman [Wed, 6 Sep 2017 01:37:16 +0000 (21:37 -0400)]
test/cls_rbd: mask newer feature bits to support upgrade tests

Fixes: http://tracker.ceph.com/issues/21217
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit aeb8f29d21625f3570e2f3e6dd26594d1a6df810)

7 years agoMerge pull request #16703 from ddiss/wip-20837-jewel
Nathan Cutler [Thu, 7 Sep 2017 08:21:10 +0000 (10:21 +0200)]
Merge pull request #16703 from ddiss/wip-20837-jewel

jewel: ceph-disk: don't activate suppressed journal devices

Reviewed-by: Nathan Cutler <ncutler@suse.com>
7 years agoMerge pull request #17396 from smithfarm/wip-21113-jewel
Nathan Cutler [Thu, 7 Sep 2017 07:47:41 +0000 (09:47 +0200)]
Merge pull request #17396 from smithfarm/wip-21113-jewel

jewel: cephfs: get_quota_root sends lookupname op for every buffered write

Reviewed-by: Yan, Zheng <zyan@redhat.com>
7 years agoMerge pull request #17009 from dreamhost/wip-16463-jewel
Nathan Cutler [Thu, 7 Sep 2017 07:46:00 +0000 (09:46 +0200)]
Merge pull request #17009 from dreamhost/wip-16463-jewel

jewel: rgw: aws4: add rgw_s3_auth_aws4_force_boto2_compat conf option

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #16963 from smithfarm/wip-20972-jewel
Nathan Cutler [Thu, 7 Sep 2017 07:42:54 +0000 (09:42 +0200)]
Merge pull request #16963 from smithfarm/wip-20972-jewel

jewel: cephfs: ceph-fuse segfaults at mount time, assert in ceph::log::Log::stop

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
7 years agoMerge pull request #16952 from dreamhost/wip-20966-jewel
Nathan Cutler [Thu, 7 Sep 2017 07:41:19 +0000 (09:41 +0200)]
Merge pull request #16952 from dreamhost/wip-20966-jewel

jewel: rgw: radosgw-admin: fix bucket limit check argparse, div(0)

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
7 years agoMerge pull request #16951 from linuxbox2/jewel-aws4-plus
Nathan Cutler [Thu, 7 Sep 2017 07:34:52 +0000 (09:34 +0200)]
Merge pull request #16951 from linuxbox2/jewel-aws4-plus

jewel: rgw: replace '+' with "%20" in canonical query string for s3 v4 auth

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #16880 from linuxbox2/jewel-rgw-dir-suggest
Nathan Cutler [Thu, 7 Sep 2017 07:33:25 +0000 (09:33 +0200)]
Merge pull request #16880 from linuxbox2/jewel-rgw-dir-suggest

jewel: rgw: Fix up to 1000 entries at a time in check_bad_index_multipart

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #16720 from prallabh/wip-jewel-20821
Nathan Cutler [Thu, 7 Sep 2017 07:28:03 +0000 (09:28 +0200)]
Merge pull request #16720 from prallabh/wip-jewel-20821

jewel: rgw: Do not decrement stats cache when the cache values are zero

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agointerval_set: optimize intersect_of for identical spans 17514/head
Zac Medico [Sun, 27 Aug 2017 12:25:01 +0000 (05:25 -0700)]
interval_set: optimize intersect_of for identical spans

Optimize comparisons for identical spans of intervals.
When this patch is combined with the previous map insert
optimization, a benchmark using 400000 identical
intervals shows a 7 times performance improvement in
comparison to without the patches.

Signed-off-by: Zac Medico <zmedico@gmail.com>
(cherry picked from commit b6a035666c2765f8895ee9991348dbc025613ed7)

7 years agointerval_set: optimize intersect_of insert operations
Zac Medico [Fri, 25 Aug 2017 16:41:07 +0000 (09:41 -0700)]
interval_set: optimize intersect_of insert operations

Use the std::map insert method with hint iterator to optimize
inserts. This increases performance more than 3.5 times for
large numbers of intervals. This will help performance
especially in the PGPool::update method, where profiling data
has shown that intersection operations are a hot spot. The
following benchmark data is for 400000 intervals:

    4 +-+--+----+----+----+----+----+----+----+----+--+-+
P     +    +    +    +    +    +    +    +  *************
E     |                             ********            |
R 3.5 +-+                       ****                  +-+
F     |                   ******                        |
O     |                 **                              |
R   3 +-+           ****                              +-+
M     |          ***                                    |
A     |        **                                       |
N 2.5 +-+     *                                       +-+
C     |     **                                          |
E     |     *                                           |
    2 +-+ **                                          +-+
R     |  **                                             |
A     | **                                              |
T 1.5 +**                                             +-+
I     |**                                               |
O     +*   +    +    +    +    +    +    +    +    +    +
    1 +*+--+----+----+----+----+----+----+----+----+--+-+
      0   0.1  0.2  0.3  0.4  0.5  0.6  0.7  0.8  0.9

                        SET SIZE RATIO

The above chart was generated using benchmark results
from the following program:

#include <iostream>
#include <sys/timeb.h>
#include "include/interval_set.h"

int main(int argc, char *argv[])
{
  const int interval_count = std::stoi(argv[1]);
  const int interval_distance = 4;
  const int interval_size = 2;
  const int sample_count = 8;
  const int max_offset = interval_count * interval_distance;
  interval_set<int> a, b, intersection;

  for (int i = 0; i < max_offset; i+=interval_distance) {
    a.insert(i, interval_size);
  }

  for (int m = 1; m < 100; m++) {
    float ratio = 1 / float(m);

    for (int i = 0; i < max_offset; i+=interval_distance*m) {
      b.insert(i, interval_size);
    }

    struct timeb start, end;
    int ms = 0;
    for (int i = 0; i < sample_count; i++) {
      ftime(&start);
      intersection.intersection_of(a, b);
      ftime(&end);
      ms += (int) (1000.0 * (end.time - start.time)
        + (end.millitm - start.millitm));
      intersection.clear();
    }
    b.clear();

    std::cout << ratio << "\t" << ms << std::endl << std::flush;
  }
}

Signed-off-by: Zac Medico <zmedico@gmail.com>
(cherry picked from commit 32bc0430f70b057d1bba623252e92ab9f279028d)

7 years agoMerge pull request #15966 from prallabh/jewel
Nathan Cutler [Wed, 6 Sep 2017 07:36:13 +0000 (09:36 +0200)]
Merge pull request #15966 from prallabh/jewel

jewel: rgw: Custom data header support

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #16144 from smithfarm/wip-20364-jewel
Nathan Cutler [Wed, 6 Sep 2017 07:03:50 +0000 (09:03 +0200)]
Merge pull request #16144 from smithfarm/wip-20364-jewel

jewel: mon: osd crush set crushmap need sanity check

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoosdc/Objecter: release message if it is not handled 16293/head
Kefu Chai [Fri, 23 Jun 2017 16:50:40 +0000 (00:50 +0800)]
osdc/Objecter: release message if it is not handled

Fixes: http://tracker.ceph.com/issues/19741
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 5c2774234c20d809d56d005b4db34070f3029684)

Conflicts:
   src/osdc/Objecter.h (in master, ms_fast_dispatch function declaration has an
                       "override" specifier; in jewel, this specifier is missing)

7 years agocrypto: allow PK11 module to load even if it's already initialized
Kefu Chai [Wed, 21 Jun 2017 06:25:01 +0000 (14:25 +0800)]
crypto: allow PK11 module to load even if it's already initialized

there is chance that other pieces of application loads PK11 module
already and does not finalize it before calling common_init_finish().

also, upon fork, PK11 module resets its entire status including `nsc_init`,
by which PK11 module tell if it is initialized or not. so the behavior
of NSS_InitContext() could be different before and after fork. that's
another reason to ignore CKR_CRYPTOKI_ALREADY_INITIALIZED error (see
NSS_GetError()).

Fixes: http://tracker.ceph.com/issues/19741
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit fcc3effd8b447ef0c54b4c806b8f6e996d7467dd)

7 years agoMerge pull request #17210 from dzafman/wip-20730-jewel
Josh Durgin [Tue, 5 Sep 2017 18:13:53 +0000 (11:13 -0700)]
Merge pull request #17210 from dzafman/wip-20730-jewel

jewel: core: disable skewed utilization warning by default

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoMerge pull request #16405 from dzafman/wip-20041-jewel
Josh Durgin [Tue, 5 Sep 2017 18:12:23 +0000 (11:12 -0700)]
Merge pull request #16405 from dzafman/wip-20041-jewel

jewel: osd: scrub_to specifies clone ver, but transaction include head write ver

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoMerge pull request #16169 from Vicente-Cheng/wip-20511-jewel
Josh Durgin [Tue, 5 Sep 2017 18:11:21 +0000 (11:11 -0700)]
Merge pull request #16169 from Vicente-Cheng/wip-20511-jewel

jewel: osd: ReplicatedPG: solve cache tier osd high memory consumption

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoMerge pull request #16167 from Vicente-Cheng/wip-20492-jewel
Josh Durgin [Tue, 5 Sep 2017 17:55:32 +0000 (10:55 -0700)]
Merge pull request #16167 from Vicente-Cheng/wip-20492-jewel

jewel: osd: omap threadpool heartbeat is only reset every 100 values

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
7 years agoMerge pull request #16151 from Vicente-Cheng/wip-20349-jewel
Nathan Cutler [Mon, 4 Sep 2017 19:10:57 +0000 (21:10 +0200)]
Merge pull request #16151 from Vicente-Cheng/wip-20349-jewel

jewel: cephfs: df reports negative disk "used" value when quota exceed

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
7 years agoMerge pull request #16150 from Vicente-Cheng/wip-20403-jewel
Nathan Cutler [Mon, 4 Sep 2017 19:09:55 +0000 (21:09 +0200)]
Merge pull request #16150 from Vicente-Cheng/wip-20403-jewel

jewel: mds: save  projected path into inode_t::stray_prior_path

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
7 years agoMerge pull request #16141 from smithfarm/wip-20270-jewel
Nathan Cutler [Mon, 4 Sep 2017 10:54:34 +0000 (12:54 +0200)]
Merge pull request #16141 from smithfarm/wip-20270-jewel

jewel: tests: LibRadosMiscConnectFailure.ConnectFailure hang

Reviewed-by: Kefu Chai <kchai@redhat.com>
7 years agoMerge pull request #16285 from smithfarm/wip-18137-jewel
Nathan Cutler [Sat, 2 Sep 2017 15:16:57 +0000 (17:16 +0200)]
Merge pull request #16285 from smithfarm/wip-18137-jewel

jewel: rbd-mirror: image sync should send NOCACHE advise flag

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@mirantis.com>
7 years agoMerge pull request #16295 from smithfarm/wip-20265-jewel
Nathan Cutler [Sat, 2 Sep 2017 15:16:08 +0000 (17:16 +0200)]
Merge pull request #16295 from smithfarm/wip-20265-jewel

jewel: rbd: cli: ensure positional arguments exist before casting

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
7 years agoMerge pull request #16276 from smithfarm/wip-19563-jewel
Nathan Cutler [Sat, 2 Sep 2017 11:12:17 +0000 (13:12 +0200)]
Merge pull request #16276 from smithfarm/wip-19563-jewel

jewel: rgw: folders starting with _ underscore are not in bucket index

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #16268 from cbodley/wip-16072-jewel
Nathan Cutler [Sat, 2 Sep 2017 11:09:46 +0000 (13:09 +0200)]
Merge pull request #16268 from cbodley/wip-16072-jewel

jewel: rgw: rgw_common.cc: modify the end check in RGWHTTPArgs::sys_get

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
7 years agoMerge pull request #16266 from cbodley/wip-20408
Nathan Cutler [Sat, 2 Sep 2017 11:08:21 +0000 (13:08 +0200)]
Merge pull request #16266 from cbodley/wip-20408

jewel: rgw: multipart copy-part remove '/' for s3 java sdk request header

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
7 years agoMerge pull request #15988 from cbodley/wip-jewel-15983
Nathan Cutler [Sat, 2 Sep 2017 10:50:50 +0000 (12:50 +0200)]
Merge pull request #15988 from cbodley/wip-jewel-15983

jewel: rgw: fix infinite loop in rest api for log list

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
7 years agoMerge pull request #15449 from smithfarm/wip-19720-jewel
Nathan Cutler [Sat, 2 Sep 2017 10:48:00 +0000 (12:48 +0200)]
Merge pull request #15449 from smithfarm/wip-19720-jewel

jewel: rgw: rgw_file: fix size and (c|m)time unix attrs in write_finish

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
7 years agoMerge pull request #17351 from liewegas/wip-prune-past-intervals-jewel
Sage Weil [Fri, 1 Sep 2017 19:27:31 +0000 (14:27 -0500)]
Merge pull request #17351 from liewegas/wip-prune-past-intervals-jewel

osd: add osd_hack_prune_past_intervals

Reviewed-by: Kefu Chai <kchai@redhat.com>
7 years agolibrbd: prevent self-blacklisting during break lock 17412/head
Jason Dillaman [Fri, 1 Sep 2017 01:30:47 +0000 (21:30 -0400)]
librbd: prevent self-blacklisting during break lock

(derived from commit 5c590acaec4dd66a9a8c3aa0ec8ab904dd350216)

Fixes: http://tracker.ceph.com/issues/18704
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
7 years agomon: osd crush set crushmap need sanity check 16144/head
Loic Dachary [Sat, 18 Mar 2017 09:04:20 +0000 (10:04 +0100)]
mon: osd crush set crushmap need sanity check

The sanity check verifying the new crushmap does not remove crush rules
that are in use is not exclusive to ceph setcrushmap.

Fixes: http://tracker.ceph.com/issues/19302
Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit ed760457bf154c10adf75c6df046eecab7eb8e4b)

7 years ago crush: when take place the crush map should consider the rule is in used
songbaisen [Thu, 31 Mar 2016 03:39:44 +0000 (11:39 +0800)]
 crush: when take place the crush map should consider the rule is in used

Signed-off-by: song baisen song.baisen@zte.com.cn
(cherry picked from commit 09bf6f2858d09c8c314a8c242a9c70d2834718dc)