See the following comment:
```
Tentacle is the last release that needs dedicated Crimson builds,
Later releases are able to use Crimson with the default build.
As the "Crimson flavor" is no longer available, we need a *temporary* way
to be able build Crimson for tentacle.
Note: This could be removed once Crimson we have Umbrella release builds.
```
Matan Breizman [Sun, 23 Nov 2025 12:18:11 +0000 (14:18 +0200)]
Cleanup "crimson" flavor
With https://github.com/ceph/ceph/pull/66229 merged,
Crimson is now included (though not used) by default in our RPM builds.
This means the existing default flavor can also be used for Crimson testing
by selecting Crimson as the default OSD package.
Notes:
* The previous workaround related to DWITH_STATIC_LIBSTDCXX is no longer
relevant for Crimson (it was tied to older compiler issues).
* The crimson-only branch name selection is also cleaned up,
as centos9-only can now be used instead.
* This change breaks Crimson Tentacle CI builds:
The packaging update that includes Crimson in RPM builds was not backported to Tentacle.
Tentacle builds would still require a dedicated flavor that enables WITH_CRIMSON
However, since Crimson changes have not been backported to Tentacle (since the first RCA),
there is no strong reason to keep building and testing the same Crimson HEAD.
So we can use this opprtuinity to stop nightly Crimson/Tentacle builds and tests.
See last Crimson tentacle run, (which is not expected to change):
https://pulpito.ceph.com/teuthology-2025-11-22_22:56:11-crimson-rados-tentacle-distro-crimson-debug-smithi/
Matan Breizman [Sun, 23 Nov 2025 11:41:42 +0000 (13:41 +0200)]
Introduce "debug" flavor
Currently, the only flavor used for testing is "default".
While this ensures that the tested flavor matches the released flavor, it can also be a limitation.
Introducing a debug flavor would allow us to test branches that require additional or more thorough validation.
The main difference is that built-in assertions would be compiled in.
The reasons for this change are:
a) The Crimson suite uses a crimson-debug flavor for project PR gating.
The next commit will clean up the Crimson flavor entirely,
and the new debug flavor introduced here could be used as its replacement.
b) Good practice: having an additional build with debug enabled is useful
when retesting or performing extra checks.
Initially, the new debug flavor will only apply to centos9 builds.
If it proves valuable, we can expand support to other distros.
Note: The current way to schedule debug builds is by using a *-debug branch name.
Having a dedicated flavor seems more straightforward.