Return non-zero when gatherkeys fails

Immediately abort and exit when a needed key cannot be found
on the list of given hosts.

Define a new exception, KeyNotFoundError, and raise that from
gatherkeys() when the requested file does not exist on any of
the given hosts to try.  Since we now raise an exception on
error, there is no longer any need to return a value from
gatherkeys().

Fixes: 10043
Signed-off-by: Travis Rhoden <trhoden@redhat.com>

Import from ceph_deploy package instead of . in gatherkeys.py

Signed-off-by: Travis Rhoden <trhoden@redhat.com>

Merge pull request #252 from trhoden/10137

default to giant when installing

default to giant when installing

Fixes: 10137
Signed-off-by: Travis Rhoden <trhoden@redhat.com>

Merge pull request #253 from trhoden/doc

Point to ceph-deploy tracker instead of devops

Point to ceph-deploy tracker instead of devops

Modify README and docs to point to the ceph-deploy bug tracker
now that it is its own project instead of within devops.

Signed-off-by: Travis Rhoden <trhoden@redhat.com>

Merge pull request #251 from trhoden/10133

Fix string compare for distro during EPEL install

Fix string compare for distro during EPEL install

Use distro.normalized_name instead of
distro.name.lower

Signed-off-by: Travis Rhoden <trhoden@redhat.com>

1.5.20

Bump version

Signed-off-by: Travis Rhoden <trhoden@redhat.com>

Update changelog

Signed-off-by: Travis Rhoden <trhoden@redhat.com>

remove commented out cruft in scripts/

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

build packages are on parent dir

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

there is no need to move the repo builds

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

jenkins: remove build directory cd

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

bump the remoto requirement to 0.0.23

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.19

update the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

bump the version

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #249 from alfredodeza/9530

create the temporary file in /etc/ceph so that SELinux is happy

create the temporary file in /etc/ceph so that SELinux is happy

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add a title to the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.18

bump the version

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

update the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.18

Merge pull request #248 from alfredodeza/9662

create a `{cluster}.mon.keyring` file if it doesn't exist

create a mon keyring if not found when deploying a mon

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

create a mon keyring in a helper function

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

create a utility to read and return file contents

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #247 from thesues/master

Put distro.conn.exit to the end of function

Put distro.conn.exit to the end of function

system.enable_service(distro.conn) is still needing the connection.

Signed-off-by: Dongmao Zhang <deanraccoon@gmail.com>

1.5.17

bump the version for init

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

update the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #246 from alfredodeza/9645

ensure priorities for custom repos as well

ensure priorities for custom repos as well

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #245 from alfredodeza/9629

don't prompt twice for passwords

do not detect sudo when attempting to copy ssh keys

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

allow to pass detect_sudo to get()

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.16

bump the version

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

bump the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #244 from alfredodeza/9624

handle the weirdness we do for `sid` releases of debian

fallback to 0 for text garbage

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

test the fix for text versions

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #243 from alfredodeza/9319

set priority on apt distros

add a remote helper to pin repos

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

when installing in debian, pin/prioritize the repo

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

pass detect_sudo for local connections

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #242 from tolbkni/epel

install epel-release package from CentOS Extras repository

install epel-release package from CentOS Extras repository

detail information:
[CentOS-announce] The epel-release package is now available via Extras
http://lists.centos.org/pipermail/centos-announce/2014-September/020526.html

Merge pull request #241 from alfredodeza/9565

smarter sudo detection

bump remoto requirement

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

remove the sudo checks in ceph-deploy

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

use the new sudo detection magic from remoto

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #240 from alfredodeza/9090

explicitly enable services in `el` distros

pass in the distro module to create_mds

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add tests for the grep utilities in remotes

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

enable the ceph service when creating an osd

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

enable the ceph service when creating an mds

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

create grep functions for remote hosts

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

when creating monitors, enable the service on el-like distros

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add a helper for checking el-like distros

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

create a is_systemd helper

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.15

bump the version

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

update the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #239 from alfredodeza/9265

conditionally install wget if not present

conditionally install wget if not present

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #238 from alfredodeza/6142

warn against too many OSDs per host

fix the connection mock that extends the path

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add a few tests for the new check

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

implement a check for dangerous number of OSDs per host

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

remove commented out cruft

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.14

bump the version to 1.5.14

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

update the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

bump requirement for remoto

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

bump the requirement for remoto v 0.0.20

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

1.5.13

bump the version to 1.5.13

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

update the changelog

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

Merge pull request #237 from alfredodeza/9138

fedora should get the yum priorities plugin installed

properly import the pkg_managers

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

use the new utility properly in fedora

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

remove the utility for yum plugin priorities

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add tests for the modifications of the utility

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

move the yum priority utility to hosts/util

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

move a generic test utility to its own module

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Closes #233

add tests to ensure we do the right thing with per subnet validation

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

host validation ip should be done per subnet, not per ip

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

This is absolutely TERRIBLE

we have to now patch like mad people all these methods. These
old tests should burn in the fire of the parent suns of the galaxy.

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

prefer the public network IP if --public-network is used

which will connect to the remote node, fetch all the IPs and
pick the one that matches the subnet

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add example to docstring for ip_addresses

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

create a new.rst file for the new subcommand

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

add new.rst to the contents toc tree

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

remove docs referencing 'new' from index

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>