Travis Rhoden [Tue, 31 Mar 2015 20:32:05 +0000 (16:32 -0400)]
Remove pruning of not-present test dir from MANIFEST
At one time we pruned the test dir, but then it got renamed to tests
and we've been including it ever since. Other packagers expect to
see the test, so remove the pointless line
Owen Synge [Tue, 17 Mar 2015 13:09:42 +0000 (14:09 +0100)]
Fix: keyring permissions where world readable
Reported in https://bugzilla.suse.com/show_bug.cgi?id=920926
by Andreas Stieger <astieger@suse.com>
Before thsi fix to umask for keyring handling, After execution
of ceph-deploy, all keyrings have mode 644.
The documented ceph-deploy procedure by creating a dedicated
admin user, and keys will be readable to all other (non-admin)
users as well, thus leaking authentication credentials.
The fix uses umask to resolve the writing of keyfiles.
Vicente Cheng [Fri, 20 Mar 2015 02:14:41 +0000 (10:14 +0800)]
Add new unit tests for get_mon_initial_members().
Add the unit tests for new abstracted function.
Detail as below:
1. Test Mon value is None and
error_on_empty is True.
2. Test Mon value is None and
error_on_empty is False.
3. Test Mon value is single item.
4. Test Mon value is multiple item.
If you have any questions, feel free to let me know.
Thanks!
Vicente Cheng [Fri, 20 Mar 2015 02:08:06 +0000 (10:08 +0800)]
Add abstracted function about get monitor initial members.
To get monitor members feature will be reuse serval
times in mon.py and osd.py. Due to this reason, I
rewrite the helper function for this feature.
1. Add get_mon_initial_members that can handle
monitor member featching and configuration
input.
2. Let all works about monitor featching of
mon.py and osd.py to use this abstracted function.
If you have any questions, feel free to let me know.
Thanks!
Travis Rhoden [Thu, 19 Mar 2015 19:52:23 +0000 (15:52 -0400)]
Change nesting of changelog
The list of sections in the TOC was getting very long.
Since we use a max-depth of 2 for the TOC tree, aggregate all the
major.minor versions under a single section for each. Makes the
index and TOCs look a lot cleaner.
Travis Rhoden [Mon, 16 Feb 2015 14:42:48 +0000 (09:42 -0500)]
Add support for RHEL host module
When "use_rhceph" is set in cephdeploy.conf, no longer use
the centos host module as a stand-in for RHEL, use a new
rhel host module that is designed to be used for the Red Hat
distributed Red Hat Ceph product.
Right now this means not using Yum priorities, and installing
two new packages of ceph-mon and ceph-osd. Eventually ceph-deploy
needs to be smarter of only installing ceph-mon or ceph-osd when a
host needs it, but for now just install both.
Travis Rhoden [Thu, 19 Feb 2015 03:52:18 +0000 (22:52 -0500)]
Enable check_obsoletes for CentOS and RHEL
We previously enabled this Yum plugin config flag for Fedora, but
recent changes in the EPEL packaging make it necessary for CentOS
and RHEL (when using upstream packages) as well.
Ken Dreyer [Fri, 30 Jan 2015 22:45:32 +0000 (15:45 -0700)]
ceph-deploy.spec: remove %{pyver} references
The %{pyver} RPM macro is not present on Red Hat-based systems. It was
removed for SUSE as a part of commit 83070c14f1682e3b6eb7f45f43ba6afda6f026a4. Remove it for RHEL also.
This fixes a problem where "rpm -qp --requires
ceph-deploy-1.5.21-0.noarch.rpm" would show that the binary RPM
literally required "python >= %{pyver}".
Travis Rhoden [Fri, 9 Jan 2015 16:19:24 +0000 (16:19 +0000)]
Enable check_obsoletes in Fedora
Since Fedora ships downstream RPMs that obsolete
python-ceph, those RPMs will be pulled in to resolve
dependencies instead of those hosted by ceph.com, leading
to package errors.
To prevent this, enable check_obsoletes in the Yum
priorities plugin.
More information from rpmlint's "-I" (help) command:
$ rpmlint -I macro-in-comment
macro-in-comment:
There is a unescaped macro after a shell style comment in the
specfile. Macros are expanded everywhere, so check if it can cause a
problem in this case and escape the macro with another leading % if
appropriate.
Ken Dreyer [Fri, 2 Jan 2015 22:54:31 +0000 (15:54 -0700)]
ceph-deploy.spec: use spaces instead of tabs
This fixes the following rpmlint warning:
ceph-deploy.spec:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15,
tab: line 13)
More information from rpmlint's "-I" (help) command:
$ rpmlint -I mixed-use-of-spaces-and-tabs
mixed-use-of-spaces-and-tabs:
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance. Use either spaces or tabs for indentation, not
both.
Travis Rhoden [Fri, 2 Jan 2015 17:38:22 +0000 (12:38 -0500)]
doc: update README to not install from ceph-extras
Update doc to remove reference to ceph-extras for RPM and DEB
repos. ceph-deploy is no longer pushed to the ceph-extras repo
and hasn't been for some time. If users are not installing from
PyPI, they should be using either the testing or release repo
of their choice for ceph.
Travis Rhoden [Tue, 18 Nov 2014 20:21:37 +0000 (20:21 +0000)]
Return non-zero when gatherkeys fails
Immediately abort and exit when a needed key cannot be found
on the list of given hosts.
Define a new exception, KeyNotFoundError, and raise that from
gatherkeys() when the requested file does not exist on any of
the given hosts to try. Since we now raise an exception on
error, there is no longer any need to return a value from
gatherkeys().