]>
git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-deploy.git/log
Sage Weil [Fri, 18 Sep 2015 15:27:43 +0000 (11:27 -0400)]
https for download.ceph.com
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Tue, 29 Sep 2015 21:42:39 +0000 (17:42 -0400)]
hosts/debian/install: install apt-transport-https
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Thu, 17 Sep 2015 18:37:59 +0000 (14:37 -0400)]
install: go direct to download.ceph.com
Ceph.com does redirects, but this is faster.
Signed-off-by: Sage Weil <sage@redhat.com>
Travis Rhoden [Thu, 10 Sep 2015 23:13:03 +0000 (16:13 -0700)]
Merge pull request #353 from ceph/wip-jessie
jessie support
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Sage Weil [Thu, 10 Sep 2015 23:10:54 +0000 (19:10 -0400)]
debian/ubuntu: add systemd support
Prefer systemd over upstart if present (for newer ubuntu)
Signed-off-by: Sage Weil <sage@redhat.com>
Alfredo Deza [Wed, 9 Sep 2015 17:15:10 +0000 (13:15 -0400)]
Merge pull request #352 from trhoden/RM-12999
[RM-12999] remove bootstrap-rgw key via forgetkeys
Travis Rhoden [Tue, 8 Sep 2015 23:01:56 +0000 (16:01 -0700)]
[RM-12999] remove bootstrap-rgw key via forgetkeys
Fixes: #12999
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 8 Sep 2015 20:36:19 +0000 (13:36 -0700)]
Merge pull request #351 from ceph/wip-osd-create
osd: enable ceph on osd create
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Sage Weil [Tue, 8 Sep 2015 20:28:02 +0000 (16:28 -0400)]
osd: enable ceph on osd create
Fixes: #12557
Signed-off-by: Sage Weil <sage@redhat.com>
Travis Rhoden [Wed, 2 Sep 2015 21:19:28 +0000 (14:19 -0700)]
Merge pull request #350 from ceph/wip-test
install: add --test install option to install ceph-test package
Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Sage Weil [Wed, 2 Sep 2015 20:11:11 +0000 (16:11 -0400)]
install: add --test install option to install ceph-test package
We need this for the teuthology tests.
Don't include it in --all, since any normal person does not want it.
Signed-off-by: Sage Weil <sage@redhat.com>
Travis Rhoden [Sat, 29 Aug 2015 17:20:30 +0000 (10:20 -0700)]
Merge pull request #348 from ceph/wip-dev-commit
install: add support for --dev-commit <sha1>
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Sage Weil [Sat, 29 Aug 2015 14:27:00 +0000 (10:27 -0400)]
install: add support for --dev-commit <sha1>
Adjusted centos, debian, fedora.
suse and rhel don't seem to pay attention to version_kind... :/
Signed-off-by: Sage Weil <sage@redhat.com>
Jenkins [Wed, 26 Aug 2015 18:25:16 +0000 (11:25 -0700)]
1.5.28
Travis Rhoden [Wed, 26 Aug 2015 17:43:36 +0000 (10:43 -0700)]
Bump version
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 26 Aug 2015 17:42:18 +0000 (10:42 -0700)]
Update changelog
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Ken Dreyer [Fri, 14 Aug 2015 23:17:33 +0000 (17:17 -0600)]
Merge pull request #347 from trhoden/RM-12699
use hosts.get() instead of get_connection for mon create-initial
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Travis Rhoden [Fri, 14 Aug 2015 22:54:54 +0000 (15:54 -0700)]
[RM-12699] formatting tweak
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 14 Aug 2015 22:51:42 +0000 (15:51 -0700)]
[RM-12699] Use hosts.get() in mon_create_initial()
That way we can pass callbacks
Fixes: #12699
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Reported-by: Bill Lubanovic <blubanovic@penguincomputing.com>
Travis Rhoden [Fri, 14 Aug 2015 02:21:33 +0000 (19:21 -0700)]
Merge pull request #345 from ceph/RM-11115
check if ceph is installed
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Thu, 13 Aug 2015 12:22:49 +0000 (08:22 -0400)]
[RM-11115] allow a list of callbacks when creating a connection
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 12 Aug 2015 12:50:15 +0000 (08:50 -0400)]
[RM-11115] tests for the Ceph package module
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 11 Aug 2015 22:19:35 +0000 (18:19 -0400)]
[RM-11115] prevent osd actions if ceph is not installed
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 11 Aug 2015 21:15:59 +0000 (17:15 -0400)]
[RM-11115] check if ceph is installed before mon actions
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 11 Aug 2015 18:19:40 +0000 (14:19 -0400)]
[RM-11115] use the new class for normalized versions
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 11 Aug 2015 18:19:52 +0000 (14:19 -0400)]
[RM-11115] make a class for normalized versions
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Thu, 13 Aug 2015 12:29:46 +0000 (08:29 -0400)]
[RM-11115] add a callback for checking if ceph is installed
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Wed, 12 Aug 2015 20:00:30 +0000 (16:00 -0400)]
Merge pull request #341 from trhoden/RM-12649
mon add: start new mon without calling 'ceph mon add'
Travis Rhoden [Wed, 12 Aug 2015 17:33:29 +0000 (10:33 -0700)]
[RM-12649] No need to call "ceph mon add"
ceph mon add is not needed - merely starting the ceph-mon
daemon will cause it to join the cluster when all the other
steps have been done properly.
Calling "ceph mon add" as we were doing leads to hangs when
moving from 1 to 2 monitors.
Fixes: #12649
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 12 Aug 2015 17:31:41 +0000 (10:31 -0700)]
Merge pull request #344 from mbroz/systemd
Detect and support both systemd and sysvinit on Fedora, RHEL and CentOS
Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Tue, 11 Aug 2015 17:58:36 +0000 (13:58 -0400)]
[RM-11115] initial take on a Ceph package object
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Alfredo Deza [Tue, 11 Aug 2015 14:34:16 +0000 (10:34 -0400)]
Merge pull request #343 from trhoden/RM-12663
use 'rpm --import', not 'rpmkeys --import'
Milan Broz [Tue, 11 Aug 2015 07:05:04 +0000 (09:05 +0200)]
Detect and support both systemd and sysvinit on Fedora, RHEL and CentOS
To properly install systemd-enabled and old (sysvinit) Ceph packages
we need to properly detect when systemd target is used.
This cannot be done just by checking distro version, it depends
on Ceph package content (sysvinit can be used on systemd distro as well).
Let's check ceph.target existence and enable systemd only in this case.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Travis Rhoden [Mon, 10 Aug 2015 22:15:01 +0000 (15:15 -0700)]
[RM-12663] use 'rpm --import', not 'rpmkeys --import'
for EL6 compatibility
Fixes: #12663
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Mon, 10 Aug 2015 18:51:55 +0000 (14:51 -0400)]
Merge pull request #342 from trhoden/RM-12644
Remove duplicate package management code
Travis Rhoden [Fri, 7 Aug 2015 22:01:51 +0000 (15:01 -0700)]
[RM-12644] Kill duplicate pkg mgmt code
Ah, payoff! Feels nice.
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 7 Aug 2015 22:22:19 +0000 (15:22 -0700)]
[RM-12644] Kill TestRPM
pkg_managers.rpm() is unused in the codebase.
There are places that *could* use it, but I'd rather roll that into
pkg_managers.RPMBaseManager at some point
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 7 Aug 2015 21:55:31 +0000 (14:55 -0700)]
[RM-12644] Add tests for DNF package manager
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 7 Aug 2015 21:52:11 +0000 (14:52 -0700)]
[RM-12644] Convert Yum/Apt/Zypper tests to use new classes
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 7 Aug 2015 21:25:43 +0000 (14:25 -0700)]
[RM-12644] Use distro.packager in 'calamari connect'
Refs: #12644
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 7 Aug 2015 21:23:49 +0000 (14:23 -0700)]
[RM-12644] Use distro.packager for "ceph-deploy pkg"
Refs: #12644
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Thu, 6 Aug 2015 16:46:30 +0000 (09:46 -0700)]
Merge pull request #339 from mbroz/systemd
Do not enable non-existing ceph service on systemd managed EL distros.
Reviewed-By: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Thu, 6 Aug 2015 16:37:54 +0000 (09:37 -0700)]
Merge pull request #340 from ceph/RM-12631
[RM-12631] catch syntax errors in tox runs
Milan Broz [Thu, 6 Aug 2015 11:20:27 +0000 (13:20 +0200)]
Do not enable non-existing ceph service on systemd managed distros.
Once systemd integration is ready, "systemctl enable ceph" fails
because there is no longer such service (OSD units arte generated).
Enable ceph.target instead.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Alfredo Deza [Thu, 6 Aug 2015 12:57:17 +0000 (08:57 -0400)]
[RM-12631] catch syntax errors in tox runs
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Jenkins [Wed, 5 Aug 2015 22:51:53 +0000 (15:51 -0700)]
1.5.27
Travis Rhoden [Wed, 5 Aug 2015 22:48:45 +0000 (15:48 -0700)]
Merge pull request #338 from trhoden/RM-12626
new release prep
Travis Rhoden [Wed, 5 Aug 2015 22:12:57 +0000 (15:12 -0700)]
[RM-12626] Bump version number
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 22:12:06 +0000 (15:12 -0700)]
[RM-12626] Add docs for repo command
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 21:45:03 +0000 (14:45 -0700)]
[RM-12626] Update changelog
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Wed, 5 Aug 2015 20:46:23 +0000 (16:46 -0400)]
Merge pull request #337 from trhoden/RM-12480
Allow package upgrades with DNF
Travis Rhoden [Wed, 5 Aug 2015 18:15:41 +0000 (11:15 -0700)]
[RM-12480] debian: use extra_remove_flags instead of purge flag
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 17:29:53 +0000 (10:29 -0700)]
[RM-12480] Allow kwargs and extra_remove_flags for remove()
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 00:02:14 +0000 (17:02 -0700)]
[RM-12480] debian: Pass extra install args consistently
I should be using **kw more to handle these optional items.
Make Apt consistent with RPM now.
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 17:40:45 +0000 (10:40 -0700)]
[RM-12480] Use "dnf install --best" so that upgrades happen
Fixes: #12480
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 17:39:24 +0000 (10:39 -0700)]
[RM-12480] Allow kwargs and extra_install_flags for install()
Refs: #12480
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 23:43:29 +0000 (16:43 -0700)]
[RM-12480] fedora: don't set repo priority twice
For dev mode installs, fedora install() calls centos.mirror_install(),
and both these methods were setting yum repo priorities.
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Wed, 5 Aug 2015 18:47:09 +0000 (14:47 -0400)]
Merge pull request #336 from trhoden/RM-12477
Only install priorities plugin when using Yum
Travis Rhoden [Tue, 4 Aug 2015 21:08:04 +0000 (14:08 -0700)]
[RM-12477] kill install_priorities_plugin()
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 21:06:36 +0000 (14:06 -0700)]
[RM-12477] centos: more selective install of yum-plugin-priorities
Only install plugin if using Yum for repo_install and mirror_install.
This is needed because Fedora re-uses these methods
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 20:59:04 +0000 (13:59 -0700)]
[RM-12477] fedora: priorities plugin only on Yum
Fixes: #12477
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Wed, 5 Aug 2015 16:19:14 +0000 (09:19 -0700)]
[RM-12477] Add 'name' attribute to pkg manager classes
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Tue, 4 Aug 2015 20:53:17 +0000 (16:53 -0400)]
Merge pull request #335 from trhoden/RM-12553
Add "ceph-deploy repo" command
Travis Rhoden [Tue, 4 Aug 2015 20:07:47 +0000 (13:07 -0700)]
[RM-12553] remote write_file - remove file first if it exists
This way a new file mode can be applied if it has changed.
Since we are always writing the whole file (mode 'w') rather than
appending, we aren't losing anything by doing this.
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 19:25:59 +0000 (12:25 -0700)]
[RM-12553] Apt repo file mode 0600 when URL has pw
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 19:21:51 +0000 (12:21 -0700)]
[RM-12553] Allow a file mode when writing apt repo
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 18:34:17 +0000 (11:34 -0700)]
[RM-12553] repo: Allow URLs to be passed by env var
This is more secure if the repo URL contains a user:pass combo
Refs: #12553
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 18:30:56 +0000 (11:30 -0700)]
[RM-12553] Clarify comments when writing repo files
These comments get printed to the console, and were a bit
misleading/ambiguous.
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 18:27:57 +0000 (11:27 -0700)]
[RM-12553] Add Apt package pinning after repo add
Refs: #12553
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 05:22:03 +0000 (22:22 -0700)]
[RM-12553] Remove beginning newline from Yum repo template
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 05:03:24 +0000 (22:03 -0700)]
[RM-12553] Call add_repo() to create repo file
Refs: #12553
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 05:02:31 +0000 (22:02 -0700)]
[RM-12553] RPM: write out repo file
Refs: #12553
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 04:14:22 +0000 (21:14 -0700)]
[RM-12553] Add ability to delete a repo file
Refs: #12553
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Tue, 4 Aug 2015 18:08:18 +0000 (11:08 -0700)]
Merge pull request #332 from ceph/wip-systemd
systemd changes for F22
Reviewed-By: Travis Rhoden <trhoden@redhat.com>
Alfredo Deza [Mon, 3 Aug 2015 23:10:05 +0000 (19:10 -0400)]
Merge pull request #334 from trhoden/RM-12439
Use package manager classes for remaining distros
Travis Rhoden [Sat, 1 Aug 2015 03:15:22 +0000 (20:15 -0700)]
[RM-12439] suse: Use Zypper Class pkg manager
Refs: #12439
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Sat, 1 Aug 2015 02:45:15 +0000 (19:45 -0700)]
[RM-12439] Add Zypper Class for pkg management
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 23:58:53 +0000 (16:58 -0700)]
[RM-12439] debian: use Apt Class pkg manager
Refs: #12439
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 23:46:00 +0000 (16:46 -0700)]
[RM-12439] Add Apt Class for pkg management
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 22:55:38 +0000 (15:55 -0700)]
[RM-12439] rhel: use Yum Class package manager
Refs: #12439
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Thu, 30 Jul 2015 16:54:52 +0000 (09:54 -0700)]
[RM-12439] centos: use Yum Class package manager
Refs: #12439
Alfredo Deza [Mon, 3 Aug 2015 20:45:11 +0000 (16:45 -0400)]
Merge pull request #333 from trhoden/RM-12543
Only install requested packages for Debian, CentOS, Fedora
Travis Rhoden [Mon, 3 Aug 2015 20:25:47 +0000 (13:25 -0700)]
[RM-12543] suse: use common map_components()
Update the SUSE tests to use the right pieces as well.
Removed the "invalid" test because the common map_components()
does not have a whitelist of packages (though it could). It
doesn't police what package names go through it, it just modifies
specific ones that you ask it to.
Refs: #12543
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 19:23:55 +0000 (12:23 -0700)]
[RM-12543] fedora: only install requested packages
Refs: #12543
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 19:12:30 +0000 (12:12 -0700)]
[RM-12543] centos: only install requested packages
Refs: #12543
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 18:56:39 +0000 (11:56 -0700)]
[RM-12543] debian: only install requested packages
Refs: #12543
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Mon, 3 Aug 2015 20:03:52 +0000 (13:03 -0700)]
[RM-12543] Add map_components() for sorting out split pkgs
Refs: #12543
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Sage Weil [Fri, 31 Jul 2015 19:44:41 +0000 (15:44 -0400)]
rgw: fix systemd creation
Analogous changes to mds create.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 31 Jul 2015 19:33:57 +0000 (15:33 -0400)]
mds: fix create on systemd
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 31 Jul 2015 19:33:42 +0000 (15:33 -0400)]
fedora: use systemd
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 31 Jul 2015 19:30:44 +0000 (15:30 -0400)]
rgw: enable appropriate ceph-radosgw@ if systemd
Note that this still doesn't work quite right... perhaps the pass in init
is not systemd?
Signed-off-by: Sage Weil <sage@redhat.com>
Alfredo Deza [Fri, 31 Jul 2015 19:25:41 +0000 (15:25 -0400)]
Merge pull request #331 from trhoden/RM-12541
Drop explicit gdisk in debian/install
Travis Rhoden [Fri, 31 Jul 2015 18:37:38 +0000 (11:37 -0700)]
[RM-12541] Drop explicit gdisk in debian/install
gdisk has been a proper dependency in Ceph packages since before
Firefly. There is no need to install it directly.
Fixes: #12541
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 31 Jul 2015 18:14:17 +0000 (11:14 -0700)]
Merge pull request #330 from trhoden/RM-12083-argparse-cleanup
More help/argparse cleanup
Reviewed-By: Dan Mick <dmick@redhat.com>
Sage Weil [Tue, 28 Jul 2015 19:09:44 +0000 (15:09 -0400)]
mon: fix create on fedora to use systemd
Signed-off-by: Sage Weil <sage@redhat.com>
Travis Rhoden [Fri, 19 Jun 2015 21:25:24 +0000 (14:25 -0700)]
[RM-12083] Remove unused code re: argparse "prog"
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Fri, 19 Jun 2015 21:06:43 +0000 (14:06 -0700)]
[RM-12083] "Ceph" Should be capitalized in help output
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Jenkins [Mon, 20 Jul 2015 18:09:38 +0000 (11:09 -0700)]
1.5.26
Travis Rhoden [Mon, 20 Jul 2015 17:45:02 +0000 (10:45 -0700)]
[RM-12414] Bump version
Signed-off-by: Travis Rhoden <trhoden@redhat.com>
Travis Rhoden [Mon, 20 Jul 2015 17:43:36 +0000 (10:43 -0700)]
[RM-12414] Update changelog
Signed-off-by: Travis Rhoden <trhoden@redhat.com>