Add test_versioning_concurrent_multi_object_delete

Tests that concurrent multi-object delete requests which specify
the same versioned object instances return successful object
responses within response body.

relates to: https://tracker.ceph.com/issues/56646

Signed-off-by: Cory Snyder <csnyder@iland.com>

Merge pull request #506 from galsalomon66/json_s3tests

Json s3tests

Merge pull request #505 from cbodley/wip-59218

test_sse_s3_default_multipart_upload verifies encryption header

progress nessage is sent back upon processing the object, the change make sure it stay with the max result

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

modifying of the run_s3select routine; to handle the different statuses (progress,stats,end)

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #501 from mkogan1/wip-chunked-trans-enc

Test object PUT with chunked transfer encoding

upon removing the payload tag, the response index should be changed also

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #503 from cbodley/wip-multi-delete

boto3: multi-object-delete tests use client.delete_objects()

test_sse_s3_default_multipart_upload verifies encryption header

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #502 from cbodley/wip-58960

s3website: collections.Container removed from python3.10

Merge pull request #495 from cbodley/wip-get-object-torrent

add test_get_object_torrent

boto3: multi-object-delete tests use client.delete_objects()

when the tests were converted from boto2, they were rewritten as loops
over client.delete_object(). switch back to multi-delete

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3website: collections.Container removed from python3.10

Fixes: https://tracker.ceph.com/issues/58960
Signed-off-by: Casey Bodley <cbodley@redhat.com>

add test_get_object_torrent

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #500 from soumyakoduri/wip-skoduri-lifecycle

lifecycle: Fix test_lifecycle_expiration_header_* testcases

test object PUT with chunked transfer enconding

Before the RGW fix PR was responding with 411 instead of 200

RGW fix PR: https://github.com/ceph/ceph/pull/50235

Signed-off-by: Mark Kogan <mkogan@redhat.com>

lifecycle: Fix test_lifecycle_expiration_header_* testcases

Few checks were incorrectly mapped when switched to 'assert'. This
commit fixes the same.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #499 from soumyakoduri/wip-bz58916

dbstore: add back missing 'fails_on_dbstore' tag

Merge pull request #490 from cbodley/wip-489

boto3: list_versions() omits empty KeyMarker/VersionIdMarker

dbstore: add back missing 'fails_on_dbstore' tag

Mark testcase "test_lifecycle_expiration_header_and_tags_head" as
fails_on_dbstore

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #498 from m-ildefons/wip/tox-ini-fixes

QoL: Fix tox.ini syntax and other minor things

QoL: Fix tox.ini syntax and other minor things

- Fix tox.ini syntax

Modern tox versions require the expected environment variables to be
listed one by one on separate lines in tox.ini

- Add `venv` to list of ignored names for git

This is a common name for a local Python virtual environment. Less
typing than `virtualenv`

- Add `tox` to requirements.txt

Installing `tox` via `pip` has the advantage of including it in the
virtual environment, thus avoiding trouble on operating systems shipping
by default with python3.6 or older. It's also nice that `pip install -r
requirements.txt` is now sufficient to set up the testing environment,
after initializing the virtual environment with a moder-enough python
version.

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>

Merge pull request #496 from cbodley/wip-58762

iam: add back missing fails_on_dbstore tags

iam: add back missing fails_on_dbstore tags

Fixes: https://tracker.ceph.com/issues/58762
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #484 from yuvalif/fix-sts-error-handling

better error handling in the STS tests

Merge pull request #487 from robbat2/rgw_post_content_length

test_post_object_upload_size_below_minimum_rgw_max_chunk_size: new testcase for size validation bug

Reviewed-by: Casey Bodley <cbodley@redhat.com>

test_post_object_upload_size_rgw_chunk_size_bug: new testcase

`ERR_TOO_SMALL` is wrongly returned if all of the following are true,
- the get_data returns multiple items (chunks)
- the length of the last item is smaller than the POST Policy's min
  value for content-length-range.

The check should be `(ofs < min_len)` instead of `(len < min_len)`

This is further confirmed by the next line of `s->obj_size = ofs`

Move the `int len` scope inside loop to try and prevent the bug in
future.

The bug was refactored in 2016, but was introduced in Oct 2012, when
this functionality was first added to RGW in commit 7bb3504d3f0974e9863f536e9af0ce8889d6888f.

Reference: https://github.com/ceph/ceph/blob/933a42f9af349b3b222270e7f19f1fe151d89e8e/src/rgw/rgw_op.cc#L4474-L4513
Reference: https://github.com/ceph/ceph/commit/7bb3504d3f0974e9863f536e9af0ce8889d6888f
Signed-off-by: Robin H. Johnson <rjohnson@digitalocean.com>

boto3: list_versions() omits empty KeyMarker/VersionIdMarker

Signed-off-by: Casey Bodley <cbodley@redhat.com>

better error handling in the STS tests

also, give more accurate instruction on how to run the tests

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

s3select: json output serialization

Signed-off-by: Albin Antony <aantony@redhat.com>

Merge pull request #486 from cbodley/wip-58365

test_s3: remove test_user_policy()

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>

test_s3: remove test_user_policy()

this has been failing consistently in local testing. test_sts.py has
lots of user policy test coverage, so this test case in test_s3.py is
superfluous

Fixes: https://tracker.ceph.com/issues/58365
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #482 from cbodley/wip-tox-pytest

replace deprecated nose with pytest

test_headers: add custom marks for auth_common/aws2/aws4

Signed-off-by: Casey Bodley <cbodley@redhat.com>

remove boostrap

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cleanup duplicate lines

Signed-off-by: Casey Bodley <cbodley@redhat.com>

remove nose dependency from requirements.txt

Signed-off-by: Casey Bodley <cbodley@redhat.com>

nose: remove nose attrs and imports

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: replace nose eq() with assert ==

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: replace nose SkipTest with pytest.skip()

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: replace @nose.with_setup with fixtures

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: add custom marks for each nose @attr

and register them in pytest.ini

Signed-off-by: Casey Bodley <cbodley@redhat.com>

remove tests tagged fails_strict_rfc2616

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: add global configfile and autouse teardown fixtures

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: add tox.ini to run pytest, update README

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #476 from cbodley/wip-botocore-sigv2

pin botocore to resolve v2 signature failures

pin botocore to resolve v2 signature failures

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #472 from galsalomon66/fixes_related_to_new_csv_parser_2

new CSV parser has some impact on engine results

remove comment

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #473 from cbodley/wip-copyobj-tails

add test_object_copy_16m to test refcounting of tail objects

add test_object_copy_16m to test refcounting of tail objects

i don't think any of our CopyObj test cases were large enough to have
tail objects, so weren't exercising our tail object ref counting
strategy

Signed-off-by: Casey Bodley <cbodley@redhat.com>

the use of std::to_string change the double presentation(not accuracy)

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

the upgraded CSV parser has some impact on engine result. (redundant comma, quote behavior)

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #471 from soumyakoduri/wip-skoduri-cloud

cloud-transition: Adjust lc wait time

cloud-transition: Adjust lc wait time

Fixes: https://tracker.ceph.com/issues/57401
Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #439 from zalsader/patch-1

Add support for rocky linux in bootstrap

Merge pull request #469 from soumyakoduri/dbstore_test_master

dbstore: Update the tests marked 'fails_on_dbstore'

dbstore: Update the tests marked 'fails_on_dbstore'

Tag/Untag testcases failing on dbstore as per latest run against main

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #461 from ifed01/origin/wip-ifed-fix-s3-loc-tests

Test case for locked and "marked-deleted" object version removal

Merge pull request #464 from shriya-deshmukh/delete-bucket-tagging-test-case

rgw/s3_boto3: Added http status code verification for DeleteBucketTagging case.

rgw/s3_boto3: Added http status code verification for DeleteBucketTagging
case.

Updated test_set_bucket_tagging test for verifying the http status code
for DeleteBucketTagging case.

Related CEPH PR: https://github.com/ceph/ceph/pull/47262

Signed-off-by: Shriya Deshmukh <shriya.deshmukh@seagate.com>

Merge pull request #460 from soumyakoduri/user_policy_tests

Fix User Policy test failures on dbstore

Fix User Policy test failures on dbstore

Tag User policy tests failing on dbstore as 'fails_on_dbstore'

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Test case for locked and "marked-deleted" object version removal.

Reproduces: https://tracker.ceph.com/issues/55766
Signed-off by: Igor Fedotov <igor.fedotov@croit.io>

Merge pull request #453 from Seagate/master

Contributing User Policy tests

Added put/get/list/delete User Policy Tests

c4d30d7 Ravindra Choudhari Mon, 27 Jun 2022 removing region name
4a13f58 Ravindra Choudhari Thu, 16 Jun 2022 Updating readme file (#15)
18bc152 Ravindra Choudhari Tue, 14 Jun 2022 Adding attr test_of_iam to all user policy tests (#13)
03f520a Ravindra Choudhari Tue, 14 Jun 2022 resolving review comments (#12)
7cf2823 Ravindra Choudhari Mon, 13 Jun 2022 added IAM policy test section in README.rst (#11)
563f3ea Ravindra Choudhari Fri, 10 Jun 2022 adding failing three tests back with attr @fails_on_rgw (#10)
696dd2e Ravindra Choudhari  Mon, 6 Jun 2022 changes as per review comments
3d63dfd Ravindra Choudhari  Mon, 6 Jun 2022 Fixed review comments (#8)
9492f69 Ravindra Choudhari Fri, 3 Jun 2022 Fixed review comments (#7)
74095dc Ketan Arlulkar      Wed, 1 Jun 2022 Fixed review comments (#6)
942fb4f Ketan Arlulkar      Wed, 1 Jun 2022 Added Tests for conflicting policies and IAM actions (#4)
ad5b5ae Ravindra Choudhari  Tue, 31 May 2022 IAM policies s3 actions (#5)
6515ec6 Ketan Arlulkar      Fri, 27 May 2022 Corrected eq import
40a2841 Ravindra Choudhari  Tue, 17 May 2022 resolving conflicts
f53a5c1 Ravindra Choudhari  Tue, 17 May 2022 added cleanup
747d563 Ketan Arlulkar      Tue, 17 May 2022 Added cleanup/Delete Policy
d1cc1d8 Ketan Arlulkar      Mon, 16 May 2022 Fixed review comments
1ec43a2 Ravindra Choudhari  Mon, 16 May 2022 delete user policy tests
a01722e Ravindra Choudhari  Mon, 16 May 2022 get user policy tests
ff9d676 Ketan Arlulkar      Fri, 13 May 2022 Removed TEST IDs
d261400 Ketan Arlulkar      Tue, 10 May 2022 Put User Policy & List User Policy Tests

Signed-off-by: Ravindra Choudhari <ravindra.choudhari@seagate.com>

Merge pull request #457 from cbodley/wip-bad-tests

remove tests that fail on boto3's parameter validation

remove tests that fail on boto3's parameter validation

Fixes: https://tracker.ceph.com/issues/55193
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #452 from cbodley/wip-no-such-tag-set

fix GetBucketTagging error code

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

fix GetBucketTagging error code

related to https://tracker.ceph.com/issues/55460

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Add support for rocky linux

Signed-off-by: Zuhair AlSader <zuhair.alsader@seagate.com>

Merge pull request #450 from soumyakoduri/dbstore-tests

Tag sse* tests with 'fails_on_dbstore' attr

Merge pull request #442 from soumyakoduri/cloudtier_tests

Adjust wait time for cloud-transition test failures

Tag sse* tests with 'fails_on_dbstore' attr

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #449 from cbodley/wip-cloud-config-sample

s3tests.conf.SAMPLE: comment out [s3 cloud] section

s3tests.conf.SAMPLE: comment out [s3 cloud] section

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Adjust wait time for cloud-transition test failures

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #440 from mdw-at-linuxbox/sse-s3-5

changes for sse s3.

Reviewed-by: Ali Maredia <amaredia@redhat.com>

sse s3 jumbo patch - all in one fixes for sse-s3 logic

original tests by Priya Sehgal <priya.sehgal@flipkart.com>:
rgw/s3_boto3: Tests added for SSE-S3 (GET, PUT, HEAD, MPU).

Additions by Casey Bodley <cbodley@redhat.com>:
add 'sse-s3' tag to test cases
sse: add _put_bucket_encryption() helper function
sse: document test cases with default bucket encryption
sse: expects encryption response header on put/get
sse: add 8MB default-encrypted upload
sse: test uploads that request x-amz-server-side-encryption=AES256

Lastly all my changes (Marcus Watts <mwatts@redhat.com>):

remove obsolete test - do it only in boto3 now.

Combine or rename duplicated function names.
Giving more than one test the same name is a Bad Thing(tm).

sse: expand test_bucket_policy_put_obj_enc, and _put_bucket_encryption

test_bucket_policy_put_obj_enc was testing too many things at once.
new tests:

* customer encryption and sse-s3: should fail
* customer encryption and sse-kms: should fail
* deny if not sse-s3: no-enc fails, sse-s3 succeeds.
* deny if not sse-s3: kms fails
  deny if not sse-ksm: no-enc fails, sse-kms succeeds.
  deny if not sse-ksm: s3 fails

_put_bucket_encryption was only testing sse-s3.
* test both these variations: sse-s3 and sse-kms

Note:
* these tests will fail on pre-sse-s3 ceph.

python3: comment out all boto3.set_stream_logger() calls
They made too much output.

Signed-off-by: Marcus Watts <mwatts@redhat.com>

Merge pull request #441 from soumyakoduri/dbstore-tests

Tag testcases failing on dbstore with 'fails_on_dbstore' attr

Tag testcases failing on dbstore with 'fails_on_dbstore' attr

To be able to successfully run s3tests on dbstore backend in teuthology,
mark all the s3-tests currently failing on it with 'fails_on_dbstore' attr

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #435 from soumyakoduri/lc_tests

lifecycle: Addressing lc spurious failures

lifecycle: Adjust lc wait time

Adjust wait time to fix spurious failures reported -
https://github.com/ceph/ceph/pull/40703#issuecomment-1060811704
http://qa-proxy.ceph.com/teuthology/mbenjamin-2022-02-23_15:42:19-rgw-wip-rgwlc-noreset-distro-basic-smithi/6703349/teuthology.log

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #429 from soumyakoduri/lc_tests

lifecycle/deletemarker_expiration: Increase timer window

lifecycle/deletemarker_expiration: Increase timer window

Increase wait time in test_lifecycle_deletemarker_expiration(..)
to avoid any spurious failure.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #421 from soumyakoduri/lc_tests

Enable Lifecycle tests

Enable lifecycle tests

Add an option to configure lc debug interval and adjust lifecycle
tests sleep as per the value set.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Add testcases for rgw cloudtransition feature

Feature PR: https://github.com/ceph/ceph/pull/35100

Also ported lc testcases from boto2 to boto3

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #424 from psathyan/fix_check_grants

Improving check_grants reliability

Merge pull request #428 from TRYTOBE8TME/wip-sts-error

s3tests_boto3/test_sts: Changing code for proper cleanup

test_sts: Changing code for proper cleanup

This solves: https://tracker.ceph.com/issues/53090

The solution is: We need to delete the role_policy and
user_policy attached user which was causing the failure.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>

Merge pull request #426 from galsalomon66/revert_install_arrow

revert the arrow installation(causing failure on some distro"s, such …

revert the arrow installation(causing failure on some distro"s, such as fedora)

Signed-off-by: gal salomon <gal.salomon@gmail.com>

Merge pull request #419 from galsalomon66/parquet_s3tests

parquet tests

fix output-serialization tests(upon comparing query results need to remove redundant columns)

skip output-serial test. the results from both queries are not equal, thus it raise an assert. the problem seems to be the formatting before the comparision

remove test_output_serial_expressions until fixing the test

experiment pyarrow for parquet testing, adding arrow/parquet to bootstrap, installing pyarrow,pandas for reading/writing parquet

Signed-off-by: gal salomon <gal.salomon@gmail.com>

Improving check_grants reliability

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>

merging master tests into parquet branch

Signed-off-by: gal salomon <gal.salomon@gmail.com>

fix for assert of error messages

Signed-off-by: gal salomon <gal.salomon@gmail.com>

remove redundant comma.  s3select-engine produced redundant result column before its last fix, s3tests should align with that

Signed-off-by: gal salomon <gal.salomon@gmail.com>

Merge pull request #402 from galsalomon66/progress-stats

s3select-tests:  new-s3select-responses, output-serialization, presto alignments