f; more review feedback from dmick

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

f; attempt to make comments better in defaults/main.yml

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

f; try to explain how packages and common_packages work

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: adds common_apt_repos and apt_repos to the docs and defaults

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

f; review feedback from dan

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: add documentation for this role

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: add common_packages to defaults/main.yml

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #81 from dmick/master

Fix warning in 'when' clause in 'Create the teuthology user.'

Fix warning in 'when' clause in 'Create the teuthology user.'

Warnings appeared each run:

[WARNING]: It is unnecessary to use '{{' in conditionals, leave variables in
loop expressions bare

Apparently 'when' clauses are already Jinja2 expressions, and so don't
need the normal variable quoting.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #80 from ceph/wip-remove-mandatory-secrets-path

common: |mandatory is not needed for secrets_path, it is always defined.

Reviewed-by: Dan Mick <dmick@redhat.com>

common: |mandatory is not needed for secrets_path, it is always defined.

secrets_path comes from the secrets role and it is always defined.  It
will default to /etc/ansible/secrets if the env var ANSIBLE_SECRETS_PATH
is not defined. You can also define secrets_path by passing a variable
to the playbook being used.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #79 from ceph/wip-cobbler-git

cobbler: install git

Merge pull request #77 from ceph/wip-cobbler-system-defaults

cobbler_systems: properly find defaults

Merge pull request #78 from ceph/wip-cobbler-rh-firewall

Cobbler: ignore firewalld if it's not running

cobbler: install git

Signed-off-by: Zack Cerza <zack@redhat.com>

Cobbler: ignore firewalld if it's not running

Signed-off-by: Zack Cerza <zack@redhat.com>

cobbler_systems: properly find defaults

For interface and kernel_options

Signed-off-by: Zack Cerza <zack@redhat.com>

Make firewall changes immediate

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #76 from ceph/wip-cobbler-rh-firewall

Manage the firewall on RHEL/CentOS 6/7

Manage the firewall on RHEL/CentOS 6/7

On EL7, poke holes for http and https. On EL6, just stop iptables.

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #74 from ceph/wip-fix-entitlements

Fix entitlements

Merge pull request #68 from ceph/wip-var-docs

docs: explain where to define variables for use in roles

Fix replace_repos logic

The issues were with quoting of booleans, and |success vs. .rc == 0

Signed-off-by: Zack Cerza <zack@redhat.com>

Fix logic of finding entitlements.yml

We were mistakenly checking for the existence of entitlements.yml on the
*remote* end.

Signed-off-by: Zack Cerza <zack@redhat.com>

docs: explain where to define variables for use in roles

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #73 from ceph/wip-12256

DNM: roles used by teuthology should not require a secrets repo

ansible-managed: skip adding pub_keys if vars is not defined

This lets this play gracefully skip if ansible_user and ansible_ssh_keys
is not defined.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

common: default the epel_mirror_baseurl var

Defaults to the value used in our sepia lab.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: default the gitbuilder_host var

Defaults to the value used in our sepia lab.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: set a default for the var ntp_servers

Defaults to the value used in our sepia lab.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: default git_mirror_host

Defaults to the value used in our sepia lab

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: default mirror_host var

This defaults to the value used in our sepia lab.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

creates a new sudo role that ensures all plays are ran with sudo

This should be added as a dependancy to any other roles that require
sudo. This commits adds it to ansible-managed, common and testnode.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

testnode: make lab_domain an optional var

lab_domain is used to strip the domain from the nodes hostname, this
allows that task to be skipped if lab_domain isn't provided.  I believe
we only do this because of some quirk in how cobbler images our rhel
nodes, we might not even need this functionality.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #72 from dachary/wip-fstab

implement modify_fstab to skip /etc/fstab modification

implement modify_fstab to persist mount options in /etc/fstab

http://tracker.ceph.com/issues/12250 Fixes: #12250

Signed-off-by: Loic Dachary <loic@dachary.org>

Merge pull request #69 from ceph/wip-cobbler-httpd

Help users locate cobbler's web UI

Help users locate cobbler's web UI

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #67 from ceph/wip-fix-defaults

Skip ansible_user creation if it is undefined

Merge pull request #70 from ceph/wip-no-ubuntu-resolvconf

testnode: do not modify resolv.conf on ubuntu

testnode: do not modify resolv.conf on ubuntu

There is no need to modify resolv.conf for ubuntu anymore.  When using
cobbler this is set by using the resolvconf var in the cobbler role. For
vms, like ones created by openstack, this allows ubuntu nodes to use the
resolv.conf already provided.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Skip ansible_user creation if it is undefined

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #66 from ceph/wip-puddle-updates

Puddle updates

puddle: add ceph 1.3 async

Add a configuration file to do Puddle generation for ceph 1.3 async.

puddle: update rh-common errata

Update Puddle's configuration for the latest RH-COMMON errata currently
in progress.

puddle: update URL variable conventions

1) Remove "_z" from the RHEL repository variables. There's no point in
distinguishing "RHEL 7 z" from "RHEL 7".

2) Add "_server" to distinguish the RHEL Server variant from the
Workstation/Client/ComputeNode variants.

Merge pull request #65 from ceph/wip-yum-tx

Remove saved yum transactions

Remove saved yum transactions

Signed-off-by: Zack Cerza <zack@redhat.com>

Don't try to remove a missing package

My previous commit had a bug. First, check if ceph-debuginfo is present.
If it's not, don't try to remove it.

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #64 from ceph/wip-bz-1234967

Work around BZ#1234967

Work around BZ#1234967

We have some corrupt ceph-debuginfo packages that are causing yum to die
with a UnicodeDecodeError. Use rpm to remove them for now.

https://bugzilla.redhat.com/show_bug.cgi?id=1234967

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #63 from ceph/wip-skip-entitlements

Gracefully skip registration

Merge pull request #62 from ceph/wip-usermod

Don't modify the teuthology_user if it is in use

Gracefully skip registration

If entitlements.yml is not found, don't attempt to register

Signed-off-by: Zack Cerza <zack@redhat.com>

Don't modify the teuthology_user if it is in use

This is to work around cases where the user exists, with a different
uid, and we are currently logged in as that user:

msg: usermod: user ubuntu is currently logged in

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #61 from ceph/wip-user-filter

users: add a 'users' var to act as a filter

users: add a 'users' var to act as a filter

If 'users' is provided it will filter 'managed_users'
and 'managed_admin_users' by the usernames provided in 'users'.

'users' must be a list of usernames as strings.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #59 from ceph/wip-readme-updates

readme updates explaining the use of a separate secrets repo

Merge pull request #58 from ceph/wip-user-docs

users: add documentation for the users role

Merge pull request #56 from ceph/wip-cobbler-complete

Fully deploy a cobbler node

Format multiline tasks more nicely

Signed-off-by: Zack Cerza <zack@redhat.com>

Format multiline tasks more nicely

Signed-off-by: Zack Cerza <zack@redhat.com>

Format multiline tasks more nicely

Signed-off-by: Zack Cerza <zack@redhat.com>

Run cobbler sync at the end of cobbler_systems

Signed-off-by: Zack Cerza <zack@redhat.com>

Create /root/.ssh before putting keys there

Signed-off-by: Zack Cerza <zack@redhat.com>

Move cobbler system population to new role

This creates the new cobbler_systems role, which is run after the
cobbler and cobbler_profile roles

Signed-off-by: Zack Cerza <zack@redhat.com>

Set the server by editing /etc/cobbler/settings

Otherwise, using 'cobbler setting edit' might not work

Signed-off-by: Zack Cerza <zack@redhat.com>

Always include package-type vars

Signed-off-by: Zack Cerza <zack@redhat.com>

Set pxe_just_once to 1

Otherwise we re-provision on every boot

Signed-off-by: Zack Cerza <zack@redhat.com>

Tell ansible to ignore host keys

Signed-off-by: Zack Cerza <zack@redhat.com>

Symlink /etc/ansible/{hosts,secrets}

Signed-off-by: Zack Cerza <zack@redhat.com>

cephlab_preseed_late: exit with status 0

Signed-off-by: Zack Cerza <zack@redhat.com>

Install gawk

For snippets/cephlab_post_install_kernel_options

Signed-off-by: Zack Cerza <zack@redhat.com>

After restarting cobbler, wait for it to start

Signed-off-by: Zack Cerza <zack@redhat.com>

Add virtualenv to .gitignore

Signed-off-by: Zack Cerza <zack@redhat.com>

Add a 'settings' tag

Signed-off-by: Zack Cerza <zack@redhat.com>

Use nmap instead of ncat for port scanning

netcat is apparently unavailable on RHEL7

Signed-off-by: Zack Cerza <zack@redhat.com>

Install extra cobbler packages for yum/apt systems

syslinux is for bootloaders; pykickstart is for kickstart file
generation; fence-agents is for IPMI etc. support; nmap is for port
scanning.

Signed-off-by: Zack Cerza <zack@redhat.com>

Make the cobbler role pull in the secrets role

Signed-off-by: Zack Cerza <zack@redhat.com>

Run cobbler sync and cobbler check

Signed-off-by: Zack Cerza <zack@redhat.com>

Enable tftpd

Signed-off-by: Zack Cerza <zack@redhat.com>

Set server, next_server and signature_url

Signed-off-by: Zack Cerza <zack@redhat.com>

Ensure cobbler and httpd are started *and* enabled

Signed-off-by: Zack Cerza <zack@redhat.com>

Deep-merge distros and extra_distros

So that we can override e.g. a mirror URL and keep all the other key/value
pairs

Signed-off-by: Zack Cerza <zack@redhat.com>

Add and use SHA256 when downloading ISOs

Signed-off-by: Zack Cerza <zack@redhat.com>

Populate systems

Disable netboot by default, so we don't accidentally reimage systems
unintentionally

Signed-off-by: Zack Cerza <zack@redhat.com>

Add cobbler SSH keys from secrets repo

Signed-off-by: Zack Cerza <zack@redhat.com>

Add tasks for yum and apt systems

Signed-off-by: Zack Cerza <zack@redhat.com>

Add vars for yum and apt systems

Signed-off-by: Zack Cerza <zack@redhat.com>

Upload etc_files

Signed-off-by: Zack Cerza <zack@redhat.com>

Add tasks to update settings

Signed-off-by: Zack Cerza <zack@redhat.com>

Add .gitignore

Signed-off-by: Zack Cerza <zack@redhat.com>

Add etc_files and settings

Signed-off-by: Zack Cerza <zack@redhat.com>

Add /etc/cobbler/users.digest

This sets the cobbler password

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #60 from ceph/wip-ansible-user-ssh-keys

Change 'ssh_keys' to 'ansible_user_ssh_keys' to clarify usage

Change 'ssh_keys' to 'ansible_user_ssh_keys' to clarify usage

Signed-off-by: Dan Mick <dan.mick@redhat.com>

users: add documentation for the users role

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

readme updates explaining the use of a separate secrets repo

We store everything related to our inventory in a repo separate from
this one. This commit explains that a bit better and the reasoning
behind it.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Use |sort instead of .sort()

The latter does an in-place sort, which meant we were comparing '' to
''. Whoops.

Signed-off-by: Zack Cerza <zack@redhat.com>

Merge pull request #57 from ceph/wip-fix-ubuntu-repos

testnode: fixes a bug keeping apt repos from being added