s3website: Refactor strings & aid debugging

Refactor duplicated static sites template content, and include a debug copy of
the WebsiteConf XML in every bucket for ease of debug with the test generator.

Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

functional._make_request: go back to simple version of httplib.request.

The httplib.request function automatically constructs the following
headers:
content-length, host, accept-encoding

Until such time as we need to override those values in incompatible
ways, simply use it.

Fixes: https://github.com/ceph/s3-tests/pull/92#issuecomment-185970260
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

Refactor _make_bucket_request.

s3tests.functional._make_bucket_request is now a special case of
_make_request, as requested by
https://github.com/ceph/s3-tests/pull/92#commitcomment-15775972

Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

website: include Forbidden in 403 test per https://github.com/dreamhost/s3-tests/commit/802c8a3ee985a90e35b21ffab5f670c2eeecf8a9#commitcomment-15776266.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: RGW does not have custom 404 message descriptions per s3 error codes yet.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: Use better test annotation for routingrules tests.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: Support both NoSuchWebsiteConfiguration and NoSuchKey for fetching the website config subresource.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

s3website: Allow tests to be skipped if website support disabled in RGW.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Fix whitespace.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Annotate many tests that fail on AWS (tested on EU region)

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: Improve XML handling and x-amz-website-redirect-location tests

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Lots of tests, that pass on AmazonS3 unless the phase of the moon is wrong. There is a non-trivial degree of lag in S3 applying WebsiteConfiguration changes sometimes, eu-west-1 was taking 20+ seconds during part of the last day. Compounded by the Amazon eventual-consistency made developing these tests difficult at times.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Work on tests.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Update redirect checks for x-amz-website-redirect-location

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Use new XML checks.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Add XML improvements.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Improve test attribute.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Add tests for x-amz-website-redirect-location, code still pending.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: refactor and add redirect testcases, so far 3 failures out of 27 new tests.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Fixup path stuff for redirect test.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Prepare for better testcases, with fixture functions.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: Clean up imports.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: Start redirect tests.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: improve test structure.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

website: bucket-level tests (indexdoc, errordoc)

This adds tests for the new S3 Website code under development at on the
wip-static-website-robbat2-master branch (see the robbat2 fork).

The ErrorDoc tests with a valid uploaded ErrorDoc show that my existing
code fails as expected :-). All other IndexDoc cases pass already.

It would be nice to refactor some of this set of tests and extract
common code, because the only variation in some of them is the ACLs on a
single file.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

refactor out _make_request and _make_bucket_request, with a common _make_raw_request; ready for s3website testing.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Use py3 print.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Merge pull request #104 from zhouyuan/update_gevent_1

gevent: bump to >=1.0

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Robin H. Johnson <robin.johnson@dreamhost.com>

gevent: bump to >=1.0

There are some DNS resolving issue on 0.13.6.
Bumping to >=1.0 fixes the issues for me.

Fixes: #13885
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

Merge pull request #99 from jmunhoz/wip-mp-cp-fails-on-rgw

Add fails_on_rgw on multipart copy part tests

Add fails_on_rgw on multipart copy part tests

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Merge pull request #97 from ceph/wip-15243

rgw: add a few tests that check for null object versioning behavior

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

rgw: add a few tests that check for null object versioning behavior

Deals with ceph issue #15243

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #91 from jmunhoz/wip-x-amz-expires-tc

rgw: add X-Amz-Expires test cases

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: add X-Amz-Expires test cases

Test X-Amz-Expires under AWS4 auth.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Merge pull request #89 from andrewgaul/atomic-multipart-upload

Test begin to overwrite file with MPU then abort

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Test begin to overwrite file with MPU then abort

Signed-off-by: Andrew Gaul <andrew@gaul.org>

Merge pull request #79 from dreamhost/wip-proxy

Improve proxy error support: "Bad Request" case

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Improve proxy error support: "Bad Request" case

If you are run the S3 testsuite against a reverse proxy (eg haproxy)
rather than RGW directly, some of the tests will return errors from the
proxy, rather than haproxy itself.

Some proxies differ from RGW in the exact case of 'Bad Request', so do
the match in a case-insensitive manner. Haproxy for example returns 'Bad
request'.

This removes the need for some of the prior fails_on_dho test tags, as
the failure was due to haproxy.

Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

Merge pull request #88 from andrewgaul/head-zero-bytes

Add test for HEAD of a zero-byte object

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #87 from dreamhost/wip-cleanup-buckets

s3tests: do not exit cleanup after first bucket!

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #85 from dreamhost/wip-test-issue11563

Add test for COPY Content-Type header

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #83 from andrewgaul/list-objects-public-read-bucket

Anonymously list private and public-read buckets

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #77 from andrewgaul/special-key-names

Consolidate test_object_create_special_characters

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #73 from andrewgaul/ends-with-delimiter

Test listing a blob which ends with delimiter

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #49 from andrewgaul/copy-bucket-key-not-found

Copy tests for non-existent buckets and keys

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #30 from andrewgaul/bucket-create-exists

Handle idempotent and BucketAlreadyOwnedByYou

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #84 from jmunhoz/wip-aws4-support

rgw: add AWS4 auth testing support

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: add AWS4 auth testing support

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Add test for HEAD of a zero-byte object

Signed-off-by: Andrew Gaul <andrew@gaul.org>

Merge pull request #86 from jmunhoz/wip-copy-mp-cc

s3tests: Check content is correct on copy multipart

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

s3tests: do not exit cleanup after first bucket!

Bucket cleanup code was exiting after the first succesful bucket
removed, instead of cleaning up all buckets. This left many buckets
behind over time, causing large slowdowns of the test suite.

This was introduced in commit c41ebab9cf93617f06084cf88c297188b4aa9f67,
when changes for versioned files were added.

Signed-off-by: Kobi Laredo <kobi.laredo@dreamhost.com>
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
Backport: hammer

s3tests: Check content is correct on copy multipart

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Add test for COPY Content-Type header

Issue #11563 deals with the COPY command breaking the Content-Type
header. Add a test case for this to ensure it remains fixed.

Reference: http://tracker.ceph.com/issues/11563
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

Merge pull request #76 from jmunhoz/test-requestid-on-error

Test RequestId on error

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

s3tests: Add test_object_requestid_matchs_header_on_error

Error responses' RequestId must match header's x-amz-request-id value.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

s3tests: Add test_object_requestid_on_error

Error responses must contains a RequestId tag. This is the ID of the
request associated with the error.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Merge pull request #75 from jmunhoz/test-multipart-cp

Test multipart copy part feature

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Anonymously list private and public-read buckets

Signed-off-by: Andrew Gaul <andrew@gaul.org>

check if setting acls modifies etag in bucket listing

This checks for ceph issue #12955

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Consolidate test_object_create_special_characters

test_bucket_create_special_key_names duplicates this test.  Add
missing cases and reformat for clarity.

Signed-off-by: Andrew Gaul <andrew@gaul.org>

rgw: test versioned objects with special names

E.g., objects that start with undescore

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

s3tests: Add test_multipart_copy_multiple_sizes

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

s3tests: Add test_multipart_copy_small

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Test listing a blob which ends with delimiter

This has a different behavior than when the blob does not end with the
delimiter.

Signed-off-by: Andrew Gaul <andrew@gaul.org>

Merge pull request #70 from tobegit3hub/fix_example_in_readme

Fix the example which is deprecated in README.rst

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #53 from andrewgaul/mpu-invalid-parts

Add multipart tests with invalid parts

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #64 from andrewgaul/cache-control-expires-headers

Add tests for Cache-Control and Expires headers

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #59 from robbat2/wip-website-fuzzy

fuzz: Write fuzzer rules for WebsiteConfiguration.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Use test_bucket_list_empty as example in README

Fix the example which is deprecated in README.rst

Signed-off-by: tobe <tobeg3oogle@gmail.com>

Merge pull request #66 from ceph/wip-12302

Remove "--allow-hosts None" because it magically makes things work

Remove "--allow-hosts None" because it magically makes things work

Fixes: 12302
Signed-off-by: Dan Mick <dan.mick@redhat.com>

Add tests for Cache-Control and Expires headers

Signed-off-by: Andrew Gaul <andrew@gaul.org>

s3tests: fix for python 2.6

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #63 from andrewgaul/unneeded_head_bucket

Remove unneeded called to _head_bucket

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Remove unneeded called to _head_bucket

Test does not consume obj_count or bytes_used and this function now
returns a dict of optional headers.

Signed-off-by: Andrew Gaul <andrew@gaul.org>

s3tests: adjust copy tests to test copy of larger objects

rgw has different code paths for objects > 512k

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #58 from robbat2/wip-unique-testname

tests must have unique names, otherwise they override existing tests.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #61 from andrewgaul/range-get-content-range

Test Content-Range header in range requests

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #60 from andrewgaul/range-get-invalid-range

Test range get with invalid range

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Test range get with invalid range

Signed-off-by: Andrew Gaul <andrew@gaul.org>

Test Content-Range header in range requests

Signed-off-by: Andrew Gaul <andrew@gaul.org>

s3tests: fix multipart test

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

fuzz: Write fuzzer rules for WebsiteConfiguration.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

tests must have unique names, otherwise they override existing tests.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

Merge pull request #56 from jmunhoz/bug-11753

s3tests: Test copying foreign object in foreign bucket

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

s3tests: Test copying foreign object in foreign bucket

User should be able to copy non-owned objects inside non-owned buckets when
they have full permissions to both bucket and object.

Test for issue #11639

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>

Merge pull request #55 from ceph/wip-bootstrap-pkg-install

bootstrap: apt/yum install the list of dependencies

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

bootstrap: apt/yum install the list of dependencies

If RPM or DEB packages are missing, don't print to STDERR and bail.
Instead, assume that the user has sudo rights, and attempt to install
the missing packages for the user automatically.

s3tests: more thorough multipart resend tests

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

radosgw-admin: test resend of a multipart upload part

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Add multipart tests with invalid parts

Signed-off-by: Andrew Gaul <andrew@gaul.org>

Merge pull request #52 from andrewgaul/nuke-empty-bucket

Handle empty bucket while nuking

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Handle empty bucket while nuking

Signed-off-by: Andrew Gaul <andrew@gaul.org>

Merge pull request #51 from andrewgaul/nuke-bucket-without-versions

Fall back when nuking buckets

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Fall back when nuking buckets

Some S3 implementations do not support object versioning - fall back
to listing without versions.

Signed-off-by: Andrew Gaul <andrew@gaul.org>

s3tests: cleanup, set bucket acls if permission denied

retry bucket removal after setting the bucket permissions if we're
getting pemission denied. This will make sure the bucket gets removed.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #50 from andrewgaul/test-object-acl-canned-during-create

Add test_object_acl_canned_during_create

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Add test_object_acl_canned_during_create

This mirrors test_bucket_acl_canned_during_create.

Signed-off-by: Andrew Gaul <andrew@gaul.org>