From 00a0f78d3e6fce1f01ce44432fb970af4ba53561 Mon Sep 17 00:00:00 2001 From: Paul Cuzner Date: Fri, 19 Feb 2021 12:24:07 +1300 Subject: [PATCH] mgr/cephadm:Add unit test for hosts without public network NIC Signed-off-by: Paul Cuzner (cherry picked from commit d271987a4dc8727f2d90ebcce16bdb3f8c56b6ca) --- src/pybind/mgr/cephadm/tests/test_configchecks.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/pybind/mgr/cephadm/tests/test_configchecks.py b/src/pybind/mgr/cephadm/tests/test_configchecks.py index c889b1ffde3f..534670d829d3 100644 --- a/src/pybind/mgr/cephadm/tests/test_configchecks.py +++ b/src/pybind/mgr/cephadm/tests/test_configchecks.py @@ -343,6 +343,19 @@ class TestConfigCheck: assert not mgr.health_checks + def test_no_public_network(self, mgr): + bad_node = mgr.cache.facts['node-1.ceph.com'] + bad_node['interfaces']['eth0']['ipv4_address'] = "192.168.1.20/24" + checker = CephadmConfigChecks(mgr) + checker.cluster_network_list = [] + checker.public_network_list = ['10.9.64.0/24'] + checker.run_checks() + logger.debug(mgr.health_checks) + assert len(mgr.health_checks) == 1 + assert 'CEPHADM_CHECK_PUBLIC_MEMBERSHIP' in mgr.health_checks + assert mgr.health_checks['CEPHADM_CHECK_PUBLIC_MEMBERSHIP']['detail'][0] == \ + 'node-1.ceph.com does not have an interface on any public network' + def test_missing_networks(self, mgr): checker = CephadmConfigChecks(mgr) -- 2.47.3