From 02f6b7b623235d60e37d5c8889bafdeb4eca31f8 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Mon, 14 Jan 2019 20:48:36 -0600 Subject: [PATCH] msg/msg_types: make set_sockaddr() a bit more robust We should keep the unused parts of u zeroed. Signed-off-by: Sage Weil --- src/msg/msg_types.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/msg/msg_types.h b/src/msg/msg_types.h index 1049ad540a0..63d64ce8c60 100644 --- a/src/msg/msg_types.h +++ b/src/msg/msg_types.h @@ -313,9 +313,13 @@ struct entity_addr_t { { switch (sa->sa_family) { case AF_INET: + // pre-zero, since we're only copying a portion of the source + memset(&u, 0, sizeof(u)); memcpy(&u.sin, sa, sizeof(u.sin)); break; case AF_INET6: + // pre-zero, since we're only copying a portion of the source + memset(&u, 0, sizeof(u)); memcpy(&u.sin6, sa, sizeof(u.sin6)); break; default: -- 2.39.5