From 03d39641bbc0d755382d1587c9066c3b68c4466a Mon Sep 17 00:00:00 2001 From: Vasu Kulkarni Date: Fri, 15 Feb 2019 09:08:35 -0800 Subject: [PATCH] fix couple flake8 issues Signed-off-by: Vasu Kulkarni --- teuthology/coverage_report_standalone.py | 10 +++------- teuthology/misc.py | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/teuthology/coverage_report_standalone.py b/teuthology/coverage_report_standalone.py index c04459cd7a..bfeedf1f7f 100644 --- a/teuthology/coverage_report_standalone.py +++ b/teuthology/coverage_report_standalone.py @@ -29,8 +29,7 @@ def gen_results(data_src, outdir): cmd = "{cmd} -o {merg_info}".format(cmd=cmd, merg_info=merged_info) print cmd - proc = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE) - proc_stdout = proc.communicate()[0] + subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE) assert(os.path.exists(merged_info)) ''' remove unncessary includes ''' @@ -38,8 +37,7 @@ def gen_results(data_src, outdir): format( merge_file=merged_info, fltr=merged_filterd) print cmd - proc = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE) - proc_stdout = proc.communicate()[0] + subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE) assert(os.path.exists(merged_filterd)) '''genhtml report and put it in outdir''' @@ -47,8 +45,7 @@ def gen_results(data_src, outdir): merged_filterd=merged_filterd, outdir=outdir) print cmd - proc = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE) - proc_stdout = proc.communicate()[0] + subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE) assert(os.path.exists(outdir+ "/index.html")) @@ -150,7 +147,6 @@ def do_coverage(args): /run_name_dir/job/ceph/remote/remote_name/coverage/. follows convention /builddir/build/BUILD// ''' - rundir = args.rundir if args.src: srcdir = args.src else: diff --git a/teuthology/misc.py b/teuthology/misc.py index f46e387215..ecbacde934 100644 --- a/teuthology/misc.py +++ b/teuthology/misc.py @@ -20,7 +20,6 @@ import yaml import json import re import pprint -import parallel from netaddr.strategy.ipv4 import valid_str as _is_ipv4 -- 2.39.5