From 049afe3a1e29cbe9919ffd024c2431c2ad01a9a8 Mon Sep 17 00:00:00 2001 From: Paul Cuzner Date: Fri, 19 Feb 2021 12:50:22 +1300 Subject: [PATCH] mgr/cephadm:skip an alert if the linkspeed is better than most The logic was issuing a healthcheck if the linkspeed was different to the majority. But if the difference is good (i.e. better!) we should not be raising a healthcheck Signed-off-by: Paul Cuzner (cherry picked from commit 74a3599a83b5b1dde094721f7754d284e8acf8fa) --- src/pybind/mgr/cephadm/configchecks.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pybind/mgr/cephadm/configchecks.py b/src/pybind/mgr/cephadm/configchecks.py index 0d855b10000c..36d29c6e723f 100644 --- a/src/pybind/mgr/cephadm/configchecks.py +++ b/src/pybind/mgr/cephadm/configchecks.py @@ -511,6 +511,9 @@ class CephadmConfigChecks: speed_copy = subnet_data.speed_map.copy() del speed_copy[speed_ptr] for bad_speed in speed_copy: + if bad_speed > speed_ptr: + # skip speed is better than most...it can stay! + continue for h in speed_copy[bad_speed]: host = HostFacts() host.load_facts(self.mgr.cache.facts[h]) -- 2.47.3