From 04b405fa1f8d0cacde489f3d1c8771dfe7a34dc0 Mon Sep 17 00:00:00 2001 From: Zorro Lang Date: Wed, 23 Jan 2019 15:34:55 +0800 Subject: [PATCH] common/dump: disable splice from FSSTRESS_AVOID New fsstress operation breaks fs dump/restore testing which use fsstress, e.g xfs/068. In _create_dumpdir_stress_num, disable splice in fsstress so that we dump exactly the same set of files and directories. Quote Dave's comments for future reference " fsstress is just creating regular files differently. It has no impact on xfsdump does except to change the number of files created and the directory layout. If this new functionality were creating a new type of file that xfsdump has to handle, or adding new attributes or changing the metadata of the existing files, then we want to make sure xfsdump is tested against that, and so we'd be changing the golden output after careful checking that both xfsdump and xfs_restore are working correctly and the file count is correct. But when all we are doing is creating normal, regular files just with a different syscall, it makes no sense to perturb the existing test then we have to go and validate that the new set of files being tested is actually scanned correctly, is complete and correct. Using a blacklist to avoid unnecessary perturbation such as in cases like this is the right thing to do because we've had to determine if the new functionality is a useful addition to xfsdump/restore test coverage or not. " [Eryu: add Dave's comments in commit log for future reference] Signed-off-by: Zorro Lang Suggested-by: Dave Chinner Signed-off-by: Eryu Guan --- common/dump | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/dump b/common/dump index 4d1a1607..b17771b9 100644 --- a/common/dump +++ b/common/dump @@ -310,6 +310,9 @@ _create_dumpdir_stress_num() if $FSSTRESS_PROG | grep -q copyrange; then FSSTRESS_AVOID="-f copyrange=0 $FSSTRESS_AVOID" fi + if $FSSTRESS_PROG | grep -q splice; then + FSSTRESS_AVOID="-f splice=0 $FSSTRESS_AVOID" + fi echo "" echo "-----------------------------------------------" -- 2.39.5