From 04d92eec5b0361803719231f00190415d76d6603 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Wed, 4 Mar 2020 11:47:01 -0600 Subject: [PATCH] mgr/cephadm: avoid racing updates to spec dict Signed-off-by: Sage Weil --- src/pybind/mgr/cephadm/module.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py index 35b7fbaacd284..1c6ed178cae98 100644 --- a/src/pybind/mgr/cephadm/module.py +++ b/src/pybind/mgr/cephadm/module.py @@ -2185,7 +2185,10 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule): def _apply_all_services(self): r = False + specs = [] # type: List[orchestrator.ServiceSpec] for sn, spec in self.spec_store.specs.items(): + specs.append(spec) + for spec in specs: try: if self._apply_service(spec): r = True -- 2.39.5