From 05574f3cfc49df09af8d98b68db5e44a4cf9c0ee Mon Sep 17 00:00:00 2001 From: =?utf8?q?Lu=C3=ADs=20Henriques?= Date: Thu, 13 Jul 2023 09:26:31 +0100 Subject: [PATCH] common/rc: cleanup old .kmemleak files MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit I've spent a non-negligible amount of time looking into a kmemleak that didn't exist in the code I was testing because there was an old .kmemleak file in the results directory. I don't think this is an intended behaviour, so I'm proposing to remove these files everytime we capture the result of a new scan. Signed-off-by: Luís Henriques Reviewed-by: Darrick J. Wong Signed-off-by: Zorro Lang --- common/rc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/common/rc b/common/rc index 741579af..5c4429ed 100644 --- a/common/rc +++ b/common/rc @@ -4433,6 +4433,10 @@ _capture_kmemleak() local kern_knob="$DEBUGFS_MNT/kmemleak" local leak_file="$1" + # Some callers pass in /dev/null when they want to clear the + # kernel's leak report file and do not care what was in that. + [ -f "$leak_file" ] && rm -f "$leak_file" + # Tell the kernel to scan for memory leaks. Apparently the write # returns before the scan is complete, so do it twice in the hopes # that twice is enough to capture all the leaks. -- 2.39.5