From 05682f3c01d0276cebe7256177017267de1cac00 Mon Sep 17 00:00:00 2001 From: Radoslaw Zarzynski Date: Thu, 28 Nov 2024 19:02:30 +0000 Subject: [PATCH] tools/cot: don't print tail_key during list-slow-omap `tail_key`, and even presence of some key designated to be a gaaurd, seems to an impementation detail of particular `ObjectStore`. I doubt this piece of information is useful enough to introduce a getter for it to the `ObjectStore` interface. Signed-off-by: Radoslaw Zarzynski --- src/tools/ceph_objectstore_tool.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/tools/ceph_objectstore_tool.cc b/src/tools/ceph_objectstore_tool.cc index 9b880c4d360..72197efc86f 100644 --- a/src/tools/ceph_objectstore_tool.cc +++ b/src/tools/ceph_objectstore_tool.cc @@ -304,8 +304,7 @@ struct lookup_slow_ghobject : public action_on_object_t { ghobject_t, ceph::signedspan, ceph::signedspan, - ceph::signedspan, - string> > _objects; + ceph::signedspan> > _objects; const string _name; double threshold; @@ -348,8 +347,7 @@ struct lookup_slow_ghobject : public action_on_object_t { total_time = mono_clock::now() - start1; if ( total_time >= make_timespan(threshold)) { _objects.emplace_back(coll, ghobj, - first_seek_time, last_seek_time, total_time, - url_escape(iter->tail_key())); + first_seek_time, last_seek_time, total_time); cerr << ">>>>> found obj " << ghobj << " first_seek_time " << std::chrono::duration_cast(first_seek_time).count() @@ -357,7 +355,6 @@ struct lookup_slow_ghobject : public action_on_object_t { << std::chrono::duration_cast(last_seek_time).count() << " total_time " << std::chrono::duration_cast(total_time).count() - << " tail key: " << url_escape(iter->tail_key()) << std::endl; } return; @@ -379,8 +376,7 @@ struct lookup_slow_ghobject : public action_on_object_t { ceph::signedspan first_seek_time; ceph::signedspan last_seek_time; ceph::signedspan total_time; - string tail_key; - std::tie(coll, ghobj, first_seek_time, last_seek_time, total_time, tail_key) = *i; + std::tie(coll, ghobj, first_seek_time, last_seek_time, total_time) = *i; spg_t pgid; bool is_pg = coll.is_pg(&pgid); @@ -397,7 +393,6 @@ struct lookup_slow_ghobject : public action_on_object_t { (last_seek_time).count()); f->dump_int("total_time", std::chrono::duration_cast(total_time).count()); - f->dump_string("tail_key", tail_key); f->close_section(); f->close_section(); -- 2.39.5