From 059a730940fec16fb6ab0ebcb197401d5b50e8c5 Mon Sep 17 00:00:00 2001 From: Afreen Misbah Date: Thu, 24 Jul 2025 22:11:31 +0530 Subject: [PATCH] mgr/dashboard: cypress tests do not fail on failures - the on 'fail' requires errors to be thrown explicitly - this is causing all tests to pass as of now irrescpective fo failures Fixes https://tracker.ceph.com/issues/72292 Signed-off-by: Afreen Misbah --- .../cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts | 2 -- src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts index 03d4a878518..88b8ab4c9ea 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts @@ -98,7 +98,6 @@ describe('Services page', () => { cy.get('cd-service-details').within(() => { services.checkServiceStatus('snmp-gateway'); }); - services.clickServiceTab('snmp-gateway', 'Daemons'); services.deleteService('snmp-gateway'); }); @@ -112,7 +111,6 @@ describe('Services page', () => { cy.get('cd-service-details').within(() => { services.checkServiceStatus('snmp-gateway'); }); - services.clickServiceTab('snmp-gateway', 'Daemons'); services.deleteService('snmp-gateway'); }); diff --git a/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts b/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts index 8b55b576589..bfcdd775dcc 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts @@ -22,5 +22,5 @@ Cypress.on('fail', (err: Error) => { if (err.message.includes('xhr') && err.message.includes('canceled')) { return false; // Ignore canceled XHR requests } - return true; + throw err; }); -- 2.39.5