From 06c74cccca10ce723ad97ea81bbae6770af9c565 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 14 Aug 2025 20:31:41 +0200 Subject: [PATCH] mds/SnapClient: un-inline encoding methods reduce header dependencies Signed-off-by: Max Kellermann --- src/mds/SnapClient.cc | 40 ++++++++++++++++++++++++++++++++++++++++ src/mds/SnapClient.h | 38 ++++---------------------------------- 2 files changed, 44 insertions(+), 34 deletions(-) diff --git a/src/mds/SnapClient.cc b/src/mds/SnapClient.cc index 8abce82b9a0a5..db40e2841893b 100644 --- a/src/mds/SnapClient.cc +++ b/src/mds/SnapClient.cc @@ -145,6 +145,46 @@ void SnapClient::notify_commit(version_t tid) } } +void SnapClient::prepare_create(inodeno_t dirino, std::string_view name, utime_t stamp, + version_t *pstid, bufferlist *pbl, MDSContext *onfinish) { + bufferlist bl; + __u32 op = TABLE_OP_CREATE; + encode(op, bl); + encode(dirino, bl); + encode(name, bl); + encode(stamp, bl); + _prepare(bl, pstid, pbl, onfinish); +} + +void SnapClient::prepare_create_realm(inodeno_t ino, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) { + bufferlist bl; + __u32 op = TABLE_OP_CREATE; + encode(op, bl); + encode(ino, bl); + _prepare(bl, pstid, pbl, onfinish); +} + +void SnapClient::prepare_destroy(inodeno_t ino, snapid_t snapid, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) { + bufferlist bl; + __u32 op = TABLE_OP_DESTROY; + encode(op, bl); + encode(ino, bl); + encode(snapid, bl); + _prepare(bl, pstid, pbl, onfinish); +} + +void SnapClient::prepare_update(inodeno_t ino, snapid_t snapid, std::string_view name, utime_t stamp, + version_t *pstid, MDSContext *onfinish) { + bufferlist bl; + __u32 op = TABLE_OP_UPDATE; + encode(op, bl); + encode(ino, bl); + encode(snapid, bl); + encode(name, bl); + encode(stamp, bl); + _prepare(bl, pstid, NULL, onfinish); +} + void SnapClient::refresh(version_t want, MDSContext *onfinish) { dout(10) << __func__ << " want " << want << dendl; diff --git a/src/mds/SnapClient.h b/src/mds/SnapClient.h index 7e891dbc1a178..970f078421d37 100644 --- a/src/mds/SnapClient.h +++ b/src/mds/SnapClient.h @@ -39,44 +39,14 @@ public: void notify_commit(version_t tid) override; void prepare_create(inodeno_t dirino, std::string_view name, utime_t stamp, - version_t *pstid, bufferlist *pbl, MDSContext *onfinish) { - bufferlist bl; - __u32 op = TABLE_OP_CREATE; - encode(op, bl); - encode(dirino, bl); - encode(name, bl); - encode(stamp, bl); - _prepare(bl, pstid, pbl, onfinish); - } + version_t *pstid, bufferlist *pbl, MDSContext *onfinish); - void prepare_create_realm(inodeno_t ino, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) { - bufferlist bl; - __u32 op = TABLE_OP_CREATE; - encode(op, bl); - encode(ino, bl); - _prepare(bl, pstid, pbl, onfinish); - } + void prepare_create_realm(inodeno_t ino, version_t *pstid, bufferlist *pbl, MDSContext *onfinish); - void prepare_destroy(inodeno_t ino, snapid_t snapid, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) { - bufferlist bl; - __u32 op = TABLE_OP_DESTROY; - encode(op, bl); - encode(ino, bl); - encode(snapid, bl); - _prepare(bl, pstid, pbl, onfinish); - } + void prepare_destroy(inodeno_t ino, snapid_t snapid, version_t *pstid, bufferlist *pbl, MDSContext *onfinish); void prepare_update(inodeno_t ino, snapid_t snapid, std::string_view name, utime_t stamp, - version_t *pstid, MDSContext *onfinish) { - bufferlist bl; - __u32 op = TABLE_OP_UPDATE; - encode(op, bl); - encode(ino, bl); - encode(snapid, bl); - encode(name, bl); - encode(stamp, bl); - _prepare(bl, pstid, NULL, onfinish); - } + version_t *pstid, MDSContext *onfinish); version_t get_cached_version() const { return cached_version; } void refresh(version_t want, MDSContext *onfinish); -- 2.39.5