From 072e659bbf8cfaa03a8d48df7d084d96ad50dc68 Mon Sep 17 00:00:00 2001 From: Xuehan Xu Date: Fri, 24 May 2024 17:35:47 +0800 Subject: [PATCH] crimson/osd/pg_shard_manager: remove the unnecessary "std::move" call MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixing the following compilation issue: /home/xuxuehan/src/ceph/src/crimson/osd/pg_shard_manager.h:236:7: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] 236 | ); | ^ /home/xuxuehan/src/ceph/src/crimson/osd/pg_shard_manager.h:236:7: note: remove ‘std::move’ call Signed-off-by: Xuehan Xu (cherry picked from commit 3d77b5c7e2ed95d424cdc9b97f9b41cea1a2648a) --- src/crimson/osd/pg_shard_manager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crimson/osd/pg_shard_manager.h b/src/crimson/osd/pg_shard_manager.h index 965d6ab0e16ba..b9879c8c9ddde 100644 --- a/src/crimson/osd/pg_shard_manager.h +++ b/src/crimson/osd/pg_shard_manager.h @@ -232,7 +232,7 @@ public: return target_shard_services.get_or_create_pg( std::move(trigger), opref.get_pgid(), - std::move(opref.get_create_info()) + opref.get_create_info() ); }).safe_then([&logger, &target_shard_services, &opref](Ref pgref) { logger.debug("{}: have_pg", opref); -- 2.39.5