From 07c6695d16bc3e8f6d8d5fdc17bd9830b1d94619 Mon Sep 17 00:00:00 2001 From: Dimitri Savineau Date: Thu, 18 Jul 2019 14:57:46 -0400 Subject: [PATCH] Remove NBSP characters Some NBSP are still present in the yaml files. Adding a test in travis CI. Signed-off-by: Dimitri Savineau --- .travis.yml | 1 + infrastructure-playbooks/purge-cluster.yml | 2 +- roles/ceph-validate/tasks/check_ipaddr_mon.yml | 2 +- tests/functional/setup.yml | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 157ba0233..8dfe11167 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,5 +8,6 @@ install: - pip install -r requirements.txt - pip install ansible-lint pytest script: + - if [[ -n $(grep --exclude-dir=.git -P "\xa0" -r .) ]]; then echo 'NBSP characters found'; exit 1; fi - pytest -vvvv library/ - for i in $(ls -1 roles/); do ansible-lint -x 204 -v roles/$i/ ; done diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml index 5904ba73a..ac9110faf 100644 --- a/infrastructure-playbooks/purge-cluster.yml +++ b/infrastructure-playbooks/purge-cluster.yml @@ -125,7 +125,7 @@ - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - "{{ client_group_name|default('clients') }}" - - "{{ mgr_group_name|default('mgrs') }}" + - "{{ mgr_group_name|default('mgrs') }}" - grafana-server - clients - iscsigws diff --git a/roles/ceph-validate/tasks/check_ipaddr_mon.yml b/roles/ceph-validate/tasks/check_ipaddr_mon.yml index 59f7426aa..1fab8ea82 100644 --- a/roles/ceph-validate/tasks/check_ipaddr_mon.yml +++ b/roles/ceph-validate/tasks/check_ipaddr_mon.yml @@ -2,4 +2,4 @@ - name: "fail if {{ inventory_hostname }} does not have any {{ ip_version }} address on {{ monitor_address_block }}" fail: msg: "{{ inventory_hostname }} does not have any {{ ip_version }} address on {{ monitor_address_block }}" - when: hostvars[inventory_hostname]['ansible_all_' + ip_version + '_addresses'] | ipaddr(hostvars[inventory_hostname]['monitor_address_block']) | length == 0 + when: hostvars[inventory_hostname]['ansible_all_' + ip_version + '_addresses'] | ipaddr(hostvars[inventory_hostname]['monitor_address_block']) | length == 0 diff --git a/tests/functional/setup.yml b/tests/functional/setup.yml index 8de4fbed3..3fb644454 100644 --- a/tests/functional/setup.yml +++ b/tests/functional/setup.yml @@ -17,7 +17,7 @@ set_fact: rootmount: "{{ ansible_mounts|json_query('[?mount==`/`]|[0]') }}" - # mount -o remount doesn't work on RHEL 8 for now + # mount -o remount doesn't work on RHEL 8 for now - name: add mount options to / mount: path: '{{ rootmount.mount }}' -- 2.39.5